Details

Applies to
Moin 1.9.
Purpose
provide more look coherence and beauty for Moin.
Description
This patch will make the options in info action to be displayed as a list, in the same style of user preferences, for example. The look will change from this:

current.png

To this:

implementation.png

Another idea is to change the look to at least this:

vbar.png

Patch

This patch is for using a list: 

   1 --- info_.py	2009-12-21 13:52:44 -0200
   2 +++ info.py	2009-12-21 14:27:11 -0200
   3 @@ -200,18 +200,20 @@
   4  
   5      request.theme.send_title(_('Info for "%s"') % (title, ), page=page)
   6      menu_items = [
   7 -        (_('Show "%(title)s"') % {'title': _('Revision History')},
   8 -         {'action': 'info'}),
   9 -        (_('Show "%(title)s"') % {'title': _('General Page Infos')},
  10 -         {'action': 'info', 'general': '1'}),
  11 -        (_('Show "%(title)s"') % {'title': _('Page hits and edits')},
  12 -         {'action': 'info', 'hitcounts': '1'}),
  13 +        (_('Revision History'),    {'action': 'info'}),
  14 +        (_('General Page Infos'),  {'action': 'info', 'general': '1'}),
  15 +        (_('Page hits and edits'), {'action': 'info', 'hitcounts': '1'}),
  16      ]
  17      request.write(f.div(1, id="content")) # start content div
  18      request.write(f.paragraph(1))
  19 -    for text, querystr in menu_items:
  20 -        request.write("[%s] " % page.link_to(request, text=text, querystr=querystr, rel='nofollow'))
  21 +    request.write(_("Please choose:"))
  22      request.write(f.paragraph(0))
  23 +    request.write(f.bullet_list(1))
  24 +    for text, querystr in menu_items:
  25 +        request.write(f.listitem(1))
  26 +        request.write(page.link_to(request, text=text, querystr=querystr, rel='nofollow'))
  27 +        request.write(f.listitem(0))
  28 +    request.write(f.bullet_list(0))
  29  
  30      show_hitcounts = int(request.values.get('hitcounts', 0)) != 0
  31      show_general = int(request.values.get('general', 0)) != 0
MoinMoin.action.info.patch

Discussion

There reason it looks like it looks now is to save screen space (height in this case).

I think such things (those lists not only in info action, but in SystemAdmin and other places) should be defined as lists with custom class and appearance (horizontal or vertical, this is no important) should be defined via css. -- EugeneSyromyatnikov 2010-01-24 03:44:03

Plan

CategoryMoinMoinPatch

MoinMoin: MoinMoinPatch/RearrangeInfoOptions (last edited 2010-09-21 12:41:37 by ThomasWaldmann)