1 2015-08-25T00:30:30 *** yask
2 2015-08-25T06:12:55 *** jek
3 2015-08-25T06:16:28 *** jek
4 2015-08-25T07:59:23 *** greg_f
5 2015-08-25T08:18:56 *** vipul20
6 2015-08-25T08:44:16 <ThomasWaldmann> moin
7 2015-08-25T10:34:55 *** yask
8 2015-08-25T11:58:41 *** vipul20
9 2015-08-25T12:20:19 *** dave_largo
10 2015-08-25T12:40:30 *** yask
11 2015-08-25T13:13:52 * ThomasWaldmann looks at gsoc code
12 2015-08-25T14:02:52 *** RogerHaase
13 2015-08-25T14:05:43 *** yask
14 2015-08-25T15:15:21 *** skathpalia
15 2015-08-25T15:16:27 <skathpalia> moin
16 2015-08-25T15:18:55 <ThomasWaldmann> hi skathpalia
17 2015-08-25T15:19:03 <skathpalia> hi ThomasWaldmann
18 2015-08-25T15:42:46 *** randomax_
19 2015-08-25T15:55:58 <ThomasWaldmann> btw, last tuesday I said it is last (coding phase) meeting, so not sure whether people are prepared for a mentor/student meeting today.
20 2015-08-25T15:56:28 <ThomasWaldmann> (or whether it is desired)
21 2015-08-25T15:57:55 <ThomasWaldmann> we ofc can't tell (are not allowed to tell) about student's final review outcome
22 2015-08-25T15:59:05 <ThomasWaldmann> so we'll do it in a less formal way today with everybody who's here.
23 2015-08-25T16:00:38 <ThomasWaldmann> first, thanks to everybody who participated with us in GSOC!
24 2015-08-25T16:02:50 <ThomasWaldmann> we also invite you to stay with the MoinMoin project and help us to bring it into a releasable state
25 2015-08-25T16:03:15 <ThomasWaldmann> (guess you have noticed that there are a lot of rough edges that should be rounded before release)
26 2015-08-25T16:04:20 <ThomasWaldmann> also, guess there are some rough edges in your new code also, so we would appreciate if you continue on it even after GSOC
27 2015-08-25T16:05:19 <ThomasWaldmann> ok, any comments from other mentors/students?
28 2015-08-25T16:06:38 <randomax_> well it was a nice experience for us new mentors i guess :)
29 2015-08-25T16:07:17 <skathpalia> Yeah great experience for me as well
30 2015-08-25T16:08:02 <ThomasWaldmann> so you now know both sides :)
31 2015-08-25T16:08:07 <yask> I would also like to thank all the mentors for their support and this organisation for giving me this opportunity. Special thanks to RogerHaase who wasn't my mentor but still supported me throughout this journey!
32 2015-08-25T16:08:16 <skathpalia> :)
33 2015-08-25T16:08:43 <ThomasWaldmann> yeah, many thanks to RogerHaase for helping!
34 2015-08-25T16:10:15 * ThomasWaldmann has some tech nical feedback for vipul, but guess that has to wait until he joins again
35 2015-08-25T16:14:41 *** foobarbaz
36 2015-08-25T16:15:04 * ThomasWaldmann tries to do a fresh clone of yask's repo, but somehow didn't work yet
37 2015-08-25T16:15:15 <foobarbaz> moin I am vipul, sorry I was travelling
38 2015-08-25T16:15:24 <foobarbaz> just returned
39 2015-08-25T16:15:35 <ThomasWaldmann> foobarbaz: /nick vipul
40 2015-08-25T16:15:36 *** vipul20
41 2015-08-25T16:15:45 <ThomasWaldmann> ah, now we have 2 :D
42 2015-08-25T16:15:52 *** foobarbaz
43 2015-08-25T16:16:03 <vipul20> now its fine
44 2015-08-25T16:17:35 <yask> ThomasWaldmann: was there an error?, did you run `hg update improvethemes` ?
45 2015-08-25T16:18:50 <ThomasWaldmann> abort: connection ended unexpectedly
46 2015-08-25T16:19:22 <ThomasWaldmann> maybe it's better from home, later. at least i could clone vipul's repo and review overall work.
47 2015-08-25T16:20:02 <ThomasWaldmann> vipul20: i have some notes from stuff i noticed while doing that:
48 2015-08-25T16:20:34 <ThomasWaldmann> adv. search: small search input field
49 2015-08-25T16:20:55 <ThomasWaldmann> code: the diff shows 2x macro subscribe definition
50 2015-08-25T16:21:32 <ThomasWaldmann> in tickets.js, there is an extremely long line (>200?)
51 2015-08-25T16:22:12 <ThomasWaldmann> ticket: if one posts a new comment, it does not update the view with it (manual refresh helps)
52 2015-08-25T16:22:47 <vipul20> ah! yes that has two subscribe macros
53 2015-08-25T16:23:04 <vipul20> yes I will update the long lines
54 2015-08-25T16:23:13 <ThomasWaldmann> indentation is still unequal. also it hangs out of the windows at the right
55 2015-08-25T16:23:16 <vipul20> when I checked the comments were working fine
56 2015-08-25T16:23:43 <ThomasWaldmann> i did a fresh clone and install, used current firefox
57 2015-08-25T16:24:19 <ThomasWaldmann> subscribe: toggles subscribe button, but makes user not appear on subscribers list
58 2015-08-25T16:24:55 <ThomasWaldmann> also: run ./m tests - some style related checks are failing
59 2015-08-25T16:25:29 <ThomasWaldmann> (I can help if it is unclear how to fix them)
60 2015-08-25T16:25:56 <vipul20> Ok i'll try fixing it first
61 2015-08-25T16:26:00 <ThomasWaldmann> hg heads shows multiple heads, check if that is desired / the correct state
62 2015-08-25T16:26:33 <vipul20> I don't know when does it show multiple heads
63 2015-08-25T16:27:26 <ThomasWaldmann> yask: vipul20: also note the update of the wiki page about gsoc on our wiki, you'll need that command line soon to submit your code to google
64 2015-08-25T16:27:55 <yask> okkey!
65 2015-08-25T16:28:00 <ThomasWaldmann> vipul20: if there are multiple branches or otherwise multiple heads
66 2015-08-25T16:28:16 <ThomasWaldmann> vipul20: one is "tip" (normal), other is "tags"
67 2015-08-25T16:29:19 <vipul20> oh ! yes I created that tags branch earlier. It has few lines of code can this be merged with default branch ?
68 2015-08-25T16:29:55 <ThomasWaldmann> is it non-gsoc code?
69 2015-08-25T16:30:26 <vipul20> it is for gsoc
70 2015-08-25T16:31:02 <ThomasWaldmann> ok, then carefully merge it into main branch, if the changes are useful/still apply.
71 2015-08-25T16:31:11 <vipul20> ok
72 2015-08-25T16:31:14 <vipul20> how can I see if a user has been added in the subscribers list or not ?
73 2015-08-25T16:32:04 <ThomasWaldmann> the ticket view lists "subcribers:" in the middle of the page, below the metadata
74 2015-08-25T16:32:51 <ThomasWaldmann> just wondered why i don't show up there after clicking subscribe.
75 2015-08-25T16:34:42 <vipul20> It don't even show up in previous code
76 2015-08-25T16:35:00 <ThomasWaldmann> oh :D
77 2015-08-25T16:35:04 <vipul20> I tried older code I had just now
78 2015-08-25T16:35:22 <vipul20> I will look at it
79 2015-08-25T16:35:50 <ThomasWaldmann> yask: i got your repo now (5th try or so).
80 2015-08-25T16:36:26 <vipul20> regarding comments thing: I just tried it now, it is working fine but still I will clone it again and try
81 2015-08-25T16:36:55 <vipul20> I will fix the indentation and should I follow strict 80 column rule ?
82 2015-08-25T16:37:19 <ThomasWaldmann> hmm, maybe i need to kill the browser cache
83 2015-08-25T16:37:53 <ThomasWaldmann> vipul20: no, 80 is not required, but it should be > 120 usually either
84 2015-08-25T16:38:03 <ThomasWaldmann> should NOT :)
85 2015-08-25T16:38:20 <vipul20> ok :)
86 2015-08-25T16:40:17 <ThomasWaldmann> pep8 recommends 80 for python, but i chose to ignore that rule (same for introducing ^L into source for printer pagination :D ).
87 2015-08-25T16:41:10 * ThomasWaldmann runs tests on yask's branch
88 2015-08-25T16:46:21 <ThomasWaldmann> -> all pass \o/
89 2015-08-25T16:55:04 <yask> :) , the next version of bootstrap announcement came recently, major change->(Moved from Less to Sass) http://blog.getbootstrap.com/2015/08/19/bootstrap-4-alpha/
90 2015-08-25T16:58:55 <ThomasWaldmann> uuh, big changes
91 2015-08-25T17:16:39 *** greg_f
92 2015-08-25T17:29:00 * ThomasWaldmann drives home
93 2015-08-25T17:29:38 *** skathpalia
94 2015-08-25T17:37:22 *** randomax_
95 2015-08-25T21:19:59 *** dave_largo
96 2015-08-25T21:20:30 *** yask
97 2015-08-25T21:44:35 *** RogerHaase
98
