1 2015-08-04T07:59:21 *** greg_f
2 2015-08-04T08:35:33 *** sunu
3 2015-08-04T08:35:35 *** waldi
4 2015-08-04T08:35:36 *** ronny
5 2015-08-04T08:35:37 *** SteveMcIntyre
6 2015-08-04T08:35:38 *** Cthulhux`
7 2015-08-04T08:35:40 *** xorAxAx
8 2015-08-04T08:35:40 *** sharky93_
9 2015-08-04T08:35:40 *** ThomasAH
10 2015-08-04T08:35:40 *** vpv
11 2015-08-04T08:35:43 *** jek
12 2015-08-04T08:35:44 *** eSyr-ng_
13 2015-08-04T08:35:44 *** xjjk
14 2015-08-04T08:35:44 *** ReimarBauer
15 2015-08-04T08:35:45 *** ananasov1
16 2015-08-04T08:35:49 *** xiaq
17 2015-08-04T08:35:52 *** eSyr
18 2015-08-04T08:35:52 *** ThomasWaldmann
19 2015-08-04T08:35:53 *** willingc
20 2015-08-04T08:35:54 *** ChanServ
21 2015-08-04T08:38:52 *** sunu
22 2015-08-04T08:38:52 *** willingc
23 2015-08-04T08:38:52 *** xiaq
24 2015-08-04T08:38:52 *** SteveMcIntyre
25 2015-08-04T08:38:52 *** ronny
26 2015-08-04T08:38:52 *** jek
27 2015-08-04T08:38:52 *** eSyr
28 2015-08-04T08:38:52 *** ThomasWaldmann
29 2015-08-04T08:38:52 *** xorAxAx
30 2015-08-04T08:38:52 *** waldi
31 2015-08-04T08:38:52 *** Cthulhux`
32 2015-08-04T08:38:52 *** eSyr-ng_
33 2015-08-04T08:38:52 *** xjjk
34 2015-08-04T08:38:52 *** sharky93_
35 2015-08-04T08:38:52 *** ThomasAH
36 2015-08-04T08:38:52 *** vpv
37 2015-08-04T08:38:52 *** ReimarBauer
38 2015-08-04T08:38:52 *** ananasov1
39 2015-08-04T08:38:52 *** ChanServ
40 2015-08-04T08:38:52 *** weber.freenode.net
41 2015-08-04T10:35:21 *** greg_f
42 2015-08-04T10:48:03 *** greg_f
43 2015-08-04T11:49:41 *** yask
44 2015-08-04T12:37:08 *** dave_largo
45 2015-08-04T12:37:34 *** vipul20
46 2015-08-04T13:31:03 *** skathpalia
47 2015-08-04T13:40:34 *** RogerHaase
48 2015-08-04T14:36:43 *** skathpalia
49 2015-08-04T15:46:29 *** dave_largo
50 2015-08-04T15:51:08 *** skathpalia
51 2015-08-04T15:55:08 <ThomasWaldmann> moin
52 2015-08-04T15:55:21 <skathpalia> moin
53 2015-08-04T15:56:14 <vipul20> moin
54 2015-08-04T15:56:27 <waldi> moin
55 2015-08-04T15:56:45 <skathpalia> Ajitesh won't able to attend meeting as he is busy somewhere else
56 2015-08-04T15:56:54 <ThomasWaldmann> oh, pity
57 2015-08-04T15:57:21 <ThomasWaldmann> apropos busy: i was busy 2w ago and ill 1w ago (hit me directly after my return from EP)
58 2015-08-04T15:58:15 <yask> moin
59 2015-08-04T15:59:43 <ThomasWaldmann> yask: vipul20: you keep the timeline / deadline in mind, 17. august most stuff should be finished and 21. august is firm pencils down.
60 2015-08-04T15:59:59 <ThomasWaldmann> so about 2w left
61 2015-08-04T16:00:26 <ThomasWaldmann> RogerHaase: btw, if you are interested, feel free to join us in the gsoc meeting
62 2015-08-04T16:01:12 <ThomasWaldmann> ok, gsoc meeting now. vipul20 can you start?
63 2015-08-04T16:01:26 <vipul20> yes
64 2015-08-04T16:01:44 <vipul20> #DONE:
65 2015-08-04T16:01:44 <vipul20> advanced search: CR: https://codereview.appspot.com/256230043
66 2015-08-04T16:01:44 <vipul20> comments now supports markdown formatting syntax, post comments on updating ticket metadata fields CR: https://codereview.appspot.com/256840043/
67 2015-08-04T16:01:44 <vipul20> #TODO:
68 2015-08-04T16:01:44 <vipul20> UI improvements of advanced search view like search options in /+search view
69 2015-08-04T16:01:44 <vipul20> ThomasWaldmann is it ok to commit this CR: https://codereview.appspot.com/246020043/ ?
70 2015-08-04T16:03:02 <ThomasWaldmann> have to look at that in detail first
71 2015-08-04T16:04:17 <skathpalia> vipul20, I am afraid your codereview https://codereview.appspot.com/256840043/ is still not working
72 2015-08-04T16:04:31 <ThomasWaldmann> btw, a bit more description than "advanced search for tickets" would be good
73 2015-08-04T16:04:49 <vipul20> skathpalia: it works fine at my system
74 2015-08-04T16:04:58 <skathpalia> It is rendering the comments but I am not able to relpy
75 2015-08-04T16:05:02 <skathpalia> to comments
76 2015-08-04T16:05:09 <vipul20> what is the error ?
77 2015-08-04T16:05:35 <skathpalia> it is not showing any error
78 2015-08-04T16:07:01 <skathpalia> Oh I forgot to create virtual env
79 2015-08-04T16:07:17 <skathpalia> It is working but the rendering is not good
80 2015-08-04T16:07:21 <ThomasWaldmann> vipul20: you added a key "author" for tickets, why?
81 2015-08-04T16:08:14 <vipul20> to store author of a ticket
82 2015-08-04T16:08:27 <vipul20> and use it to filter in advanced seardch
83 2015-08-04T16:08:55 <vipul20> skathpalia any suggestions on how to render ?
84 2015-08-04T16:08:58 <ThomasWaldmann> iirc we already have an "author" (or editor) for any type of item, why not use that?
85 2015-08-04T16:09:25 <skathpalia> similar to that of facebook you can say
86 2015-08-04T16:09:39 <vipul20> ThomasWaldmann: when I looked at the metadata of ticket item I didn't see any author, maybe I should see it again
87 2015-08-04T16:09:45 <skathpalia> on a comment you render the replies
88 2015-08-04T16:09:53 <skathpalia> like this
89 2015-08-04T16:09:56 <skathpalia> comment
90 2015-08-04T16:10:00 <skathpalia> reply1
91 2015-08-04T16:10:05 <skathpalia> reply2
92 2015-08-04T16:10:48 <vipul20> ok understood
93 2015-08-04T16:10:50 *** dave_largo
94 2015-08-04T16:12:28 <vipul20> skathpalia: do we store author of ticket item because I can't see whether it is done or not
95 2015-08-04T16:12:52 <skathpalia> see the metadata of other items
96 2015-08-04T16:13:53 <vipul20> It does not show any author key that's why I've added now
97 2015-08-04T16:14:07 <ThomasWaldmann> vipul20: the pending code reviews section on the wiki page is complete?
98 2015-08-04T16:16:08 <vipul20> Yes I've listed 3 CRs there and the file upload one has been long pending. It needs your review
99 2015-08-04T16:16:49 <ThomasWaldmann> ok, one less
100 2015-08-04T16:19:24 <ThomasWaldmann> in these comments view screenshot, i see xxx posted by name on date
101 2015-08-04T16:19:39 <ThomasWaldmann> xxx id itemid of comment?
102 2015-08-04T16:19:46 <ThomasWaldmann> xxx is itemid of comment?
103 2015-08-04T16:20:13 <vipul20> I've corrected it in my new CR
104 2015-08-04T16:20:32 <ThomasWaldmann> ah, is there a newer screenshot?
105 2015-08-04T16:21:32 <vipul20> I've included it in my blog post : http://vipulsharma20.blogspot.in/2015/08/gsoc-2015-coding-period.html
106 2015-08-04T16:22:14 <ThomasWaldmann> yes, that was the blogpost and image i was referring to
107 2015-08-04T16:22:28 <vipul20> oh sorry didnt get it first time
108 2015-08-04T16:22:34 <vipul20> yes they are item id of the comments
109 2015-08-04T16:22:52 <vipul20> when you click it, it takes you to that comment
110 2015-08-04T16:23:05 <ThomasWaldmann> additionally you always print "Comment 1", "Comment 2", ...?
111 2015-08-04T16:23:42 <ThomasWaldmann> that seems somehow not needed (except for debugging maybe)
112 2015-08-04T16:23:47 <vipul20> initially I thought I would use those comment 1 comment 2 ... instead of itemids as links to move to comments
113 2015-08-04T16:24:18 <ThomasWaldmann> always use unique ids, numbers will just get you into troubles
114 2015-08-04T16:24:27 <vipul20> bugzilla does like that so I thought maybe try here
115 2015-08-04T16:24:41 <vipul20> but yes I was adviced not be more like bugzilla earlier
116 2015-08-04T16:24:52 <ThomasWaldmann> i just think that comments stuff on the screen shot looks confusing
117 2015-08-04T16:25:45 <vipul20> can you please suggest me what can I improve on ?
118 2015-08-04T16:25:47 <ThomasWaldmann> maybe you should get rid of that "Comment N:" completely
119 2015-08-04T16:26:01 <vipul20> yes sure
120 2015-08-04T16:26:26 <ThomasWaldmann> and arrange "reply" and "xxxx posted by ..." more nicely
121 2015-08-04T16:26:40 <ThomasWaldmann> just look at other nice issue trackers/comment systems
122 2015-08-04T16:27:06 <ThomasWaldmann> indentation so it looks threaded?
123 2015-08-04T16:28:01 <ThomasWaldmann> reply link and posted by could be in one line, if reply is a bit more visible
124 2015-08-04T16:28:26 <vipul20> yes I'll try for threaded. I tried it earlier but I was not able to make it threaded.
125 2015-08-04T16:28:33 <ThomasWaldmann> and maybe slight frames around the comment text?
126 2015-08-04T16:28:53 <vipul20> yes agree with that
127 2015-08-04T16:29:05 <ThomasWaldmann> what was the problem with threaded?
128 2015-08-04T16:30:13 <vipul20> I built the comment tree, but I was not able to render it with comments and their replies and their replies.... I had issues in writing the parsing code
129 2015-08-04T16:30:36 <ThomasWaldmann> what parsing code?
130 2015-08-04T16:31:02 <vipul20> comment tree was like {parent comment id: reply comment id}
131 2015-08-04T16:31:45 <vipul20> for rendering the comments in the template
132 2015-08-04T16:32:24 <ThomasWaldmann> if that doesn't work you can also do it in python
133 2015-08-04T16:32:54 <vipul20> ok I'll do it
134 2015-08-04T16:33:21 <ThomasWaldmann> ok, any more questions to vipul20 ? skathpalia ?
135 2015-08-04T16:33:25 <skathpalia> no
136 2015-08-04T16:33:37 <waldi> no
137 2015-08-04T16:33:44 <ThomasWaldmann> ok, thanks vipul20. yask, your stage.
138 2015-08-04T16:34:35 <yask> Done: Wrote toolbar settings for various wiki syntax (creole,moin wiki,markdown,mediawiki) and worked on quick links for basic and modernised theme.
139 2015-08-04T16:34:36 <yask> CRs (Pending).
140 2015-08-04T16:34:36 <yask> https://codereview.appspot.com/259900043 Navbar fixed in basic theme ticket view
141 2015-08-04T16:34:36 <yask> fixed a minor bug in navbar of basic theme: https://codereview.appspot.com/256330043
142 2015-08-04T16:34:36 <yask> added toolbar settings for moin wiki,creole,mediawiki and markdown. Using http://markitup.jaysalvat.com/ javascript plugin.
143 2015-08-04T16:34:36 <yask> cumulative CR: https://codereview.appspot.com/259880043
144 2015-08-04T16:34:37 <yask> Quicklinks improvements:
145 2015-08-04T16:34:37 <yask> CR: https://codereview.appspot.com/252640043
146 2015-08-04T16:36:06 <yask> Screenshots:
147 2015-08-04T16:36:06 <yask> https://fbcdn-sphotos-d-a.akamaihd.net/hphotos-ak-xtp1/v/t35.0-12/11821562_10204543703820816_1747782659_o.jpg?oh=45d6587ef210b4ff982187f086e7f7d5&oe=55C3BF0F&__gda__=1438831498_535d4012f6e0f733afb4e1c99eefd433
148 2015-08-04T16:36:06 <yask> https://scontent-hkg3-1.xx.fbcdn.net/hphotos-xaf1/v/t35.0-12/s2048x2048/11800981_10204546017318652_1712122133_o.jpg?oh=bdd4c467bf2cc0f5d197384d033acda7&oe=55C2D8AA
149 2015-08-04T16:36:06 <yask> http://g.recordit.co/NBCSSg6L5X.gif
150 2015-08-04T16:36:06 <yask> http://i.imgur.com/zTWr4Ei.png
151 2015-08-04T16:39:39 <ThomasWaldmann> navbar looks nice
152 2015-08-04T16:40:50 <ThomasWaldmann> so that is the trail in the 2nd screenshot at the upper right?
153 2015-08-04T16:41:49 <ThomasWaldmann> (yask gsoc newwiki ... test4 ... test8)
154 2015-08-04T16:43:06 <yask> those are quicklinks... if no of quicklinks exceed than what can be accommodated, dropdown appears with extra links
155 2015-08-04T16:43:51 <ThomasWaldmann> ah. seeing the animation now in 3rd. it will always just render 4 or how many?
156 2015-08-04T16:45:48 <yask> No , I didnt give fixed height to that box, currently it renders as many quicklinks the user has created.
157 2015-08-04T16:46:24 <ThomasWaldmann> ok, so this is todo (otherwise it would be pointless, right?)
158 2015-08-04T16:47:01 <skathpalia> Yeah we can have a max-height property set so that user can scroll also
159 2015-08-04T16:47:16 <ThomasWaldmann> ok, sounds good
160 2015-08-04T16:47:20 <yask> Yea!.
161 2015-08-04T16:47:35 <ThomasWaldmann> https://scontent-hkg3-1.xx.fbcdn.net/hphotos-xaf1/v/t35.0-12/s2048x2048/11800981_10204546017318652_1712122133_o.jpg?oh=bdd4c467bf2cc0f5d197384d033acda7&oe=55C2D8AA
162 2015-08-04T16:47:48 <ThomasWaldmann> why is Home, Show and Modify underlined there ^
163 2015-08-04T16:49:12 <ThomasWaldmann> (btw, everybody else feel free to ask questions, I am not even his mentor :)
164 2015-08-04T16:49:46 <yask> Home and show should be highlighted , modify is underlined because my mouse cursor was there while taking screenshot
165 2015-08-04T16:50:04 <ThomasWaldmann> ah
166 2015-08-04T16:50:31 <yask> http://i.imgur.com/N95ksmU.png
167 2015-08-04T16:51:12 <ThomasWaldmann> ok
168 2015-08-04T16:51:47 <ThomasWaldmann> ok, that much from me, any questions?
169 2015-08-04T16:52:10 <waldi> not really
170 2015-08-04T16:53:39 <ThomasWaldmann> there are 3 codereviews open by YS and not a single feedback comment on them. since a week. :|
171 2015-08-04T16:54:40 <yask> Ajitesh was reviewing it and was giving feedback on chat.., he got busy for a few days last week.
172 2015-08-04T16:55:29 <ThomasWaldmann> ah, at least.
173 2015-08-04T16:55:49 <skathpalia> I will try to have a look at them by today
174 2015-08-04T16:56:30 <ThomasWaldmann> ok, so does anybody have questions / comments left?
175 2015-08-04T16:57:54 <skathpalia> no
176 2015-08-04T16:58:46 <ThomasWaldmann> ok, end of meeting then. have a nice evening / night. :)
177 2015-08-04T17:53:30 *** skathpalia
178 2015-08-04T17:58:20 *** greg_f
179 2015-08-04T18:01:32 *** skathpalia
180 2015-08-04T18:21:53 *** skathpalia
181 2015-08-04T18:46:19 *** skathpalia
182 2015-08-04T19:40:24 *** yask
183 2015-08-04T20:02:44 *** skathpalia
184 2015-08-04T21:20:50 *** dave_largo
185 2015-08-04T21:38:59 *** yask
186 2015-08-04T21:47:23 *** RogerHaase
187 2015-08-04T23:50:24 *** yask
188
