MoinMoin: MoinMoinChat/Logs/moin-dev/2015-07-04

   1 2015-07-04T00:35:26  *** eSyr-ng has quit IRC
   2 2015-07-04T00:36:11  *** eSyr-ng has joined #moin-dev
   3 2015-07-04T08:15:09  *** yask has joined #moin-dev
   4 2015-07-04T14:45:20  *** saurabhkathpalia has joined #moin-dev
   5 2015-07-04T14:45:26  <saurabhkathpalia> moin
   6 2015-07-04T14:45:28  <saurabhkathpalia> hi yask
   7 2015-07-04T14:45:39  <yask> moin saurabhkathpalia
   8 2015-07-04T14:45:42  <saurabhkathpalia> There are some bugs in your patch
   9 2015-07-04T14:46:03  <yask> Yea , the reason is that I haven't worked on ticket view as yet
  10 2015-07-04T14:46:08  <saurabhkathpalia> The homepage content is not properly aligned
  11 2015-07-04T14:46:20  <yask> image ?
  12 2015-07-04T14:47:19  <saurabhkathpalia> http://imgur.com/PT0ycOY
  13 2015-07-04T14:47:46  <saurabhkathpalia> Also the css of ticket is not proper now
  14 2015-07-04T14:48:30  <saurabhkathpalia> I know you haven't worked on it, but you have made some global css changes so these changes should be consistent for each view
  15 2015-07-04T14:49:48  <saurabhkathpalia> Also the modify view is not proper
  16 2015-07-04T14:49:49  <yask> yea! I am still in the process of writing css rules for other views
  17 2015-07-04T14:50:36  <saurabhkathpalia> So for now you have just changed the history view right?
  18 2015-07-04T14:50:44  <saurabhkathpalia> http://imgur.com/LRrK05b
  19 2015-07-04T14:50:47  <yask> for modify I have proposed a different view ( which is a separate task) according to my soc proposal
  20 2015-07-04T14:51:37  <yask> for now I have worked on layout , global view template , and user setting template
  21 2015-07-04T14:52:08  <yask> user setting is in the next cr (whose patch failed)
  22 2015-07-04T14:52:19  <saurabhkathpalia> Ok these looks good
  23 2015-07-04T14:52:48  <saurabhkathpalia> Just make a small change to global view template
  24 2015-07-04T14:53:02  <saurabhkathpalia> align it properly with the header
  25 2015-07-04T14:53:12  <yask> Ah! there was a fix for the alignement , maybe I forgot to put that in this cr : http://imgur.com/OmVHvnL
  26 2015-07-04T14:53:48  <saurabhkathpalia> Ok update the CR
  27 2015-07-04T14:53:58  <yask> sure!
  28 2015-07-04T14:58:02  *** saurabhkathpalia has quit IRC
  29 2015-07-04T15:00:00  <yask> https://codereview.appspot.com/252920043
  30 2015-07-04T15:01:24  *** skathpalia has joined #moin-dev
  31 2015-07-04T15:01:39  <yask> skathpalia:  https://codereview.appspot.com/252920043
  32 2015-07-04T15:02:19  <skathpalia> ??
  33 2015-07-04T15:02:19  <skathpalia> ??
  34 2015-07-04T15:02:48  <yask> the alignment fix cr: https://codereview.appspot.com/252920043
  35 2015-07-04T15:03:53  <skathpalia> Give the appropriate description in the CR
  36 2015-07-04T15:03:57  <yask> updated the patch: https://codereview.appspot.com/253770043
  37 2015-07-04T15:04:03  <yask> sorry!
  38 2015-07-04T15:07:11  <yask> did you run ./m css after applying the patch ?
  39 2015-07-04T15:07:11  *** skathpalia has quit IRC
  40 2015-07-04T18:21:49  *** yask has quit IRC
  41