1 2015-07-01T00:11:53  *** yask has quit IRC
   2 2015-07-01T00:53:20  *** vipul20 has quit IRC
   3 2015-07-01T04:38:34  *** aviraldg has joined #moin-dev
   4 2015-07-01T06:06:14  *** skathpalia has joined #moin-dev
   5 2015-07-01T06:06:16  <skathpalia> moin
   6 2015-07-01T06:06:40  <skathpalia> vipul20: your file upload code is not working
   7 2015-07-01T06:06:52  <skathpalia> Just try out this
   8 2015-07-01T06:07:33  <skathpalia> Make a ticket with uploading a file and then click submit
   9 2015-07-01T06:07:47  <skathpalia> Now go back to Tickets tab in the left
  10 2015-07-01T06:07:58  <skathpalia> and then click on the ticket just created
  11 2015-07-01T06:08:09  <skathpalia> You will get the ticket but the file won't be there
  12 2015-07-01T06:17:01  *** skathpalia has quit IRC
  13 2015-07-01T06:30:04  *** skathpalia has joined #moin-dev
  14 2015-07-01T06:30:39  <skathpalia> yask: In order to split your CR in the following manner
  15 2015-07-01T06:31:07  <skathpalia> you have done multiple things in one CR so you can made new CR for each improvement
  16 2015-07-01T06:31:34  <skathpalia> for example footer jump problem can be solved in different CR
  17 2015-07-01T06:32:12  <skathpalia> changing of bootstrap version can be done in a different CR
  18 2015-07-01T06:32:44  <skathpalia> and you can take this method to other changes also :)
  19 2015-07-01T07:46:32  *** skathpalia has quit IRC
  20 2015-07-01T07:53:14  *** skathpalia has joined #moin-dev
  21 2015-07-01T07:53:40  *** greg_f has joined #moin-dev
  22 2015-07-01T08:37:46  <ThomasWaldmann> moin
  23 2015-07-01T08:46:51  *** skathpalia has quit IRC
  24 2015-07-01T09:03:04  <magu|_> moin
  25 2015-07-01T09:04:21  *** yask has joined #moin-dev
  26 2015-07-01T10:24:24  *** vipul20 has joined #moin-dev
  27 2015-07-01T10:26:04  <vipul20> skathpalia: fixed the issue please try new patch: https://codereview.appspot.com/246020043/
  28 2015-07-01T11:16:33  *** skathpalia has joined #moin-dev
  29 2015-07-01T11:20:22  <skathpalia> vipul20:just checked your updated CR, its working now
  30 2015-07-01T11:21:40  <vipul20> nice :)
  31 2015-07-01T11:21:56  <skathpalia> Can you explain what exactly are you doing in order to associate files with ticket
  32 2015-07-01T11:21:58  <skathpalia> vipul20:^^
  33 2015-07-01T11:22:07  <skathpalia> so that I get better understanding of CR
  34 2015-07-01T11:22:43  <vipul20> I am creating file items as <item_id>/<file_name>
  35 2015-07-01T11:23:07  <vipul20> in create view it has name so initially file name is <ticket_name>/<file_name>
  36 2015-07-01T11:23:36  <vipul20> but once itemid is generated i've changed previosuly uploaded files to <item_id>/<filename>
  37 2015-07-01T11:24:15  <skathpalia> Ok so basically you remove the name of the associated file once ticket is updated
  38 2015-07-01T11:24:18  <skathpalia> right?
  39 2015-07-01T11:25:02  <skathpalia> vipul20:^^
  40 2015-07-01T11:25:20  <vipul20> yes
  41 2015-07-01T11:25:20  <vipul20> and changed refers_to field to refer the itemid of the ticket
  42 2015-07-01T11:25:49  <vipul20> so it is easy to query and index with whoosh
  43 2015-07-01T11:26:30  <skathpalia> your check_itemid function is removing the name of the associated files
  44 2015-07-01T11:26:32  <skathpalia> right?
  45 2015-07-01T11:26:47  <skathpalia> vipul20:^^
  46 2015-07-01T11:26:50  <vipul20> ye
  47 2015-07-01T11:26:51  <vipul20> yes
  48 2015-07-01T11:27:10  <vipul20> I just wrote it without thinking about an appropriate name
  49 2015-07-01T11:27:19  <vipul20> should I use something else
  50 2015-07-01T11:27:20  <vipul20> ?
  51 2015-07-01T11:27:32  <skathpalia> Looks Ok to me
  52 2015-07-01T11:28:20  <skathpalia> Added a comment
  53 2015-07-01T11:28:49  <skathpalia> ran this also looks ok to me
  54 2015-07-01T11:29:24  <vipul20> oh sorry :| didn't see that "print" I was just testing
  55 2015-07-01T11:29:30  <skathpalia> vipul20:  ask Thomas whether to commit or not after making the change described in the comment
  56 2015-07-01T11:29:49  <skathpalia> I mean ask ThomasWaldmann for review
  57 2015-07-01T11:30:01  <vipul20> yes sure I will update it now and ask for the review
  58 2015-07-01T11:40:42  <yask> skathpalia: https://codereview.appspot.com/253770043/ and https://codereview.appspot.com/251980043/
  59 2015-07-01T11:41:37  <skathpalia> I will look into these in some time
  60 2015-07-01T11:41:50  <yask> Okey !
  61 2015-07-01T11:44:10  <vipul20> updated CR
  62 2015-07-01T11:44:16  <vipul20> ThomasWaldmann: updated CR: https://codereview.appspot.com/246020043/
  63 2015-07-01T12:02:49  <yask> skathpalia:  Review and test the CRs in this order : https://codereview.appspot.com/251980043/ (Bootstrap update) -> https://codereview.appspot.com/253770043/  (Footer Fix) -> https://codereview.appspot.com/251990043/ (Usersettings bootstrapped) :)
  64 2015-07-01T12:32:30  *** skathpalia has quit IRC
  65 2015-07-01T12:47:47  *** skathpalia has joined #moin-dev
  66 2015-07-01T12:57:57  *** vpv_ is now known as vpv
  67 2015-07-01T13:30:17  *** skathpalia has quit IRC
  68 2015-07-01T13:31:58  *** skathpalia has joined #moin-dev
  69 2015-07-01T14:24:24  *** skathpalia has quit IRC
  70 2015-07-01T14:41:30  *** sharky93 has joined #moin-dev
  71 2015-07-01T14:41:46  *** ReimarBa1er has joined #moin-dev
  72 2015-07-01T14:41:56  *** eSyr-ng has joined #moin-dev
  73 2015-07-01T14:42:10  *** ananasov1 has joined #moin-dev
  74 2015-07-01T14:46:34  *** yask has quit IRC
  75 2015-07-01T14:46:39  *** eSyr-ng_ has quit IRC
  76 2015-07-01T14:46:40  *** sharky93_ has quit IRC
  77 2015-07-01T14:46:46  *** ananasova has quit IRC
  78 2015-07-01T14:46:47  *** ReimarBauer has quit IRC
  79 2015-07-01T14:46:48  *** waldi has quit IRC
  80 2015-07-01T14:52:57  *** waldi has joined #moin-dev
  81 2015-07-01T14:52:57  *** waldi has joined #moin-dev
  82 2015-07-01T14:59:58  *** yask has joined #moin-dev
  83 2015-07-01T15:23:21  *** vipul20 has quit IRC
  84 2015-07-01T15:41:42  *** vipul20 has joined #moin-dev
  85 2015-07-01T16:49:21  *** dave_largo has joined #moin-dev
  86 2015-07-01T17:33:11  *** greg_f has quit IRC
  87 2015-07-01T21:01:48  *** yask has quit IRC
  88 2015-07-01T21:03:33  *** dave_largo has quit IRC
  89 2015-07-01T22:03:21  *** vipul20 has quit IRC
  90

MoinMoin: MoinMoinChat/Logs/moin-dev/2015-07-01 (last edited 2015-07-01 00:15:03 by IrcLogImporter)