MoinMoin: MoinMoinChat/Logs/moin-dev/2015-06-27

   1 2015-06-27T00:33:19  *** vipul20 has quit IRC
   2 2015-06-27T00:51:46  *** yask has quit IRC
   3 2015-06-27T06:25:48  *** vipul20 has joined #moin-dev
   4 2015-06-27T09:15:30  *** yask has joined #moin-dev
   5 2015-06-27T11:03:19  *** vipul20 has quit IRC
   6 2015-06-27T11:47:08  *** greg_f has joined #moin-dev
   7 2015-06-27T15:20:06  *** RogerHaase has joined #moin-dev
   8 2015-06-27T15:25:45  <yask> RogerHaase: Moin
   9 2015-06-27T15:26:29  <RogerHaase> moin :)
  10 2015-06-27T15:27:29  <yask> RogerHaase: in common.css we have styling rules for .zebra (which interferes with bootstrap's .zebra) similar case with tables
  11 2015-06-27T15:27:50  <yask> I wish there was something to reset all properties of an element in css :P
  12 2015-06-27T15:28:46  <yask> RogerHaase: just saw your comment in bitbucket :)
  13 2015-06-27T15:30:50  <yask> "As theme.css gets loaded after common.css, there should be no interference.". Yes but I'll have to make changes in theme.css to override they styles written in common.css which is rather complex
  14 2015-06-27T15:30:55  <yask> RogerHaase: ^
  15 2015-06-27T15:31:18  <RogerHaase> that .zebra in common.css should probably be .moin-zebra
  16 2015-06-27T15:31:26  <yask> Yesss!!
  17 2015-06-27T15:34:11  <yask> RogerHaase: Also to implement bootstrap forms for user settings I had to make changes in macros (forms.html) as `forms.render(form['something'])` rendered html with <label> which I didn't want. So I made exclusive `forms.html` template for modernized theme. Hope it is okkey ?
  18 2015-06-27T15:35:11  <RogerHaase> dk, no time to look today
  19 2015-06-27T15:36:04  <yask> Ah! okkey!
  20 2015-06-27T15:36:53  <RogerHaase> did you notice you still have overlay issues afer reducing table width to ~900 pixels and clicking on the hamburger thing
  21 2015-06-27T15:37:42  <RogerHaase> table/window
  22 2015-06-27T15:39:23  <yask> Ah! I didn't notice that..! Fixing it right now. Thanks!
  23 2015-06-27T15:42:17  <RogerHaase> hmm, that .zebra class in common.css seems unused, wonder if it was meant to be defined in userstyles.css (but if we put it there, we should use a name other than .zebra)
  24 2015-06-27T15:43:16  <RogerHaase> ThomasWaldmann: issues 369,157, 522, 523, and 524 can be closed
  25 2015-06-27T15:43:28  <yask> Yea , I'll change it to moin-zebra . But If I make tables it inherits styling from common.css .
  26 2015-06-27T15:43:54  <yask> Trying this: http://stackoverflow.com/questions/13076227/css-reset-table-to-default-equivalent
  27 2015-06-27T15:45:04  <yask> At least in less we should have something like `element { reset; }` :\
  28 2015-06-27T15:52:10  <RogerHaase> you are speaking of the few lines ~186 /* moin default table styling */ - what is causing a problem?
  29 2015-06-27T16:05:58  <yask> Yes ! It has rules for borders , margin and stuff which I don't want.
  30 2015-06-27T16:08:14  <yask> Maybe change it to class `.moin-tables` ?
  31 2015-06-27T16:09:31  *** greg_f has quit IRC
  32 2015-06-27T16:14:28  <RogerHaase> yask: it says default table styling. If you have better default table styling, then change common.css so all themes benefit.
  33 2015-06-27T16:28:09  <RogerHaase> gtg
  34 2015-06-27T16:28:12  *** RogerHaase has left #moin-dev
  35 2015-06-27T17:18:30  <yask> CR  https://codereview.appspot.com/245670043/
  36 2015-06-27T17:25:50  <yask> New user settings screenshot: http://i.imgur.com/h0ch4tc.png
  37 2015-06-27T17:47:27  *** vipul20 has joined #moin-dev
  38 2015-06-27T20:11:05  <yask> RogerHaase: fixed " overlay issues afer reducing table width to ~900 pixels and clicking on the hamburger thing" Patch #2 of CR: https://codereview.appspot.com/245670043/
  39 2015-06-27T20:23:57  <vipul20> ThomasWaldmann: https://codereview.appspot.com/242340043/ (tags on click)  , https://codereview.appspot.com/246020043/ (added TODO in file upload)