1 2015-06-25T00:04:01  <yask> RogerHaase: Fixed unclosed div html validation errors in this CR : https://codereview.appspot.com/245560043
   2 2015-06-25T00:04:17  <yask> No more validation errrors! Phew! :)
   3 2015-06-25T01:13:18  *** vipul20 has quit IRC
   4 2015-06-25T02:31:49  *** yask has quit IRC
   5 2015-06-25T04:46:34  *** yask has joined #moin-dev
   6 2015-06-25T05:30:14  <yask> ThomasWaldmann: waldi: RogerHaase: Updated Bootstrap to version version 3.3.5 in my fork of repo xstatic-bootstrap: https://bitbucket.org/yask123/xstatic-bootstrap/commits/942330589c64df20f73f2c6b77ca4afee8a09f73
   7 2015-06-25T05:59:15  *** tah is now known as ThomasAH
   8 2015-06-25T06:23:31  *** vipul20 has joined #moin-dev
   9 2015-06-25T07:41:46  *** yask has quit IRC
  10 2015-06-25T08:15:04  *** yask has joined #moin-dev
  11 2015-06-25T09:07:42  *** greg_f has joined #moin-dev
  12 2015-06-25T11:43:19  *** vipul20 has quit IRC
  13 2015-06-25T12:31:46  *** yask has quit IRC
  14 2015-06-25T12:49:09  *** dave_largo has joined #moin-dev
  15 2015-06-25T14:20:55  *** yask has joined #moin-dev
  16 2015-06-25T14:26:15  <yask> blog post:  http://iyask.me/blog/2015/06/25/gsoc-update/
  17 2015-06-25T17:37:35  <ThomasWaldmann> yask: you please redo that bootstrap change and separate it into 2 commits:
  18 2015-06-25T17:37:44  <ThomasWaldmann> a) bootstrap updated files
  19 2015-06-25T17:38:00  <ThomasWaldmann> b) you changes to the xstatic file(s)
  20 2015-06-25T18:07:44  <yask> ThomasWaldmann: I just updated bootstrap files (completely removed old css/js/less files and put the fresh css/js/less files from https://github.com/twbs/bootstrap  and changed the version to 3.3.5 (in __init__.py file). I haven't made any custom changes. Should commit for "bootstrap update files" and "Change of version" be in separate commits?
  21 2015-06-25T18:24:47  <ThomasWaldmann> well, if you ask for review, you should make it easy for reviewer.
  22 2015-06-25T18:25:08  <ThomasWaldmann> did you make sure that you added / committed ALL bootstrap files?
  23 2015-06-25T18:25:12  <ThomasWaldmann> yask: ^
  24 2015-06-25T18:34:56  <yask> ThomasWaldmann: Yes! I added all the bootstrap files (less : https://github.com/twbs/bootstrap/tree/master/less ) and (css, fonts, js https://github.com/twbs/bootstrap/tree/master/dist)
  25 2015-06-25T18:39:06  <ThomasWaldmann> ok, sounds good, make a pull request
  26 2015-06-25T18:40:26  <ThomasWaldmann> yask: ^
  27 2015-06-25T18:44:33  <yask> ThomasWaldmann: Done https://bitbucket.org/thomaswaldmann/xstatic-bootstrap/pull-request/2/updated-bootstrap-to-version-version-335/
  28 2015-06-25T18:49:44  *** vipul20 has joined #moin-dev
  29 2015-06-25T18:51:18  *** greg_f has quit IRC
  30 2015-06-25T18:54:11  <ThomasWaldmann> ok, I'll merge it later, thanks!
  31 2015-06-25T19:07:30  <vipul20> ThomasWaldmann: can I issue a PR for the UI changes and ticket suggestion you reviewed earlier ?
  32 2015-06-25T19:14:41  <ThomasWaldmann> vipul20: did you resolve all feedback?
  33 2015-06-25T19:15:15  <ThomasWaldmann> (and please give urls)
  34 2015-06-25T19:17:55  <vipul20> ThomasWaldmann: https://codereview.appspot.com/236490043/  , https://codereview.appspot.com/247160044/
  35 2015-06-25T19:20:38  <ThomasWaldmann> 21:14  ThomasWaldmann$ vipul20: did you resolve all feedback?
  36 2015-06-25T19:20:47  <vipul20> yes
  37 2015-06-25T19:22:29  <vipul20> ThomasWaldmann: yes, the summary label was missing which is fixed now
  38 2015-06-25T19:24:44  <vipul20> ThomasWaldmann: also, can you please review https://codereview.appspot.com/242340043/ (add tags on click). fixed addition of tag in empty input field
  39 2015-06-25T19:26:16  <ThomasWaldmann> https://codereview.appspot.com/236490043/ for that one you first please fix the CR description, so it clearly describes what you have changed. you can the use that as a commit comment.
  40 2015-06-25T19:28:55  <ThomasWaldmann> vipul20: you know how a good commit comment is usually formatted?
  41 2015-06-25T19:30:19  <vipul20> ThomasWaldmann: sorry but I haven
  42 2015-06-25T19:30:31  <vipul20> haven't contributed much so I don't know
  43 2015-06-25T19:30:56  <ThomasWaldmann> like that:
  44 2015-06-25T19:31:13  <ThomasWaldmann> first line not too long, rough description
  45 2015-06-25T19:31:18  <ThomasWaldmann> (empty line)
  46 2015-06-25T19:31:21  <ThomasWaldmann> more
  47 2015-06-25T19:31:22  <ThomasWaldmann> more
  48 2015-06-25T19:31:23  <ThomasWaldmann> more
  49 2015-06-25T19:32:28  <yask> ThomasWaldmann: Does this commit message look good ? https://bitbucket.org/yask123/moin-2.0/commits/90961106254ee93a02f7d9ec1cc1b94a85457f7a
  50 2015-06-25T19:33:49  <ThomasWaldmann> the first line is a bit long, it might not look good on bitbucket or hg log output.
  51 2015-06-25T19:34:06  <ThomasWaldmann> also, try to write correct english.
  52 2015-06-25T19:35:25  <yask> Ah! I wish commit messages in mercurial could be edited.
  53 2015-06-25T19:35:43  <ThomasWaldmann> you just have to think first. :)
  54 2015-06-25T19:36:11  <ThomasWaldmann> editable history in git is also rather limited if you work in a team
  55 2015-06-25T19:39:49  <ThomasWaldmann> btw, please always use hg diff and hg status before you commit
  56 2015-06-25T19:40:08  <ThomasWaldmann> to make sure you do not commit unwanted stuff, but all wanted stuff
  57 2015-06-25T19:45:37  <yask> ThomasWaldmann: Okkey! But I won't be able to make a PR (to merge in main branch)[ before mid-term evaluations]  as I am still in intermediate stages of my project and it may break stuff. I hope thats fine.
  58 2015-06-25T19:47:40  <ThomasWaldmann> well, make sure that some finished stuff is committed
  59 2015-06-25T19:49:30  <yask> ThomasWaldmann: Yea , of course. Already made 4 commits (with all finished stuff yet).
  60 2015-06-25T19:54:09  <vipul20> ThomasWaldmann: how about this description: https://codereview.appspot.com/236490043/
  61 2015-06-25T20:18:11  <ThomasWaldmann> vipul20: that's a bit too verbose even
  62 2015-06-25T20:18:27  <ThomasWaldmann> the stuff with the reindented code section is good for code review
  63 2015-06-25T20:18:34  <ThomasWaldmann> but as that's already done...
  64 2015-06-25T20:18:59  <ThomasWaldmann> but other than that, it's ok
  65 2015-06-25T20:40:22  <ThomasWaldmann> vipul20: https://codereview.appspot.com/247160044/ updated
  66 2015-06-25T20:47:36  <vipul20> ThomasWaldmann: I've created a macro for "subscribe" and used it in the ticket view. So now, there is a subscribe button alongside other meta fields. Otherwise, it used to be under "User Action" option in the basic theme
  67 2015-06-25T20:52:26  <ThomasWaldmann> ah, so it just moved? removed from 2 places, added to 1 other place?
  68 2015-06-25T20:54:34  <ThomasWaldmann> that subscribe button has bad contrast btw
  69 2015-06-25T20:55:16  <vipul20> yes, one block deleted to remove from the side panel under "user action" ( in case of basic theme) and another to remove from the header and footer (in case of modernized theme)
  70 2015-06-25T20:55:32  <vipul20> I used just used "moin-button"
  71 2015-06-25T20:56:20  <ThomasWaldmann> ok, if that is globally used we can fix that later
  72 2015-06-25T20:57:48  <vipul20> yes it is defined in common.css
  73 2015-06-25T21:08:58  *** dave_largo has quit IRC
  74

MoinMoin: MoinMoinChat/Logs/moin-dev/2015-06-25 (last edited 2015-06-25 00:15:02 by IrcLogImporter)