1 2015-06-24T03:31:45 *** yask
2 2015-06-24T08:03:40 *** greg_f
3 2015-06-24T08:03:44 *** greg_f
4 2015-06-24T09:51:05 *** yask
5 2015-06-24T10:24:44 *** greg_f
6 2015-06-24T12:37:48 *** dave_largo
7 2015-06-24T12:47:48 *** greg_f
8 2015-06-24T12:55:53 *** krypten
9 2015-06-24T13:03:19 *** vipul20
10 2015-06-24T13:04:50 *** vipul20
11 2015-06-24T14:03:18 <yask> waldi: Code Review : https://codereview.appspot.com/245560043/
12 2015-06-24T15:13:17 *** RogerHaase
13 2015-06-24T15:13:18 *** vipul20
14 2015-06-24T15:14:31 <RogerHaase> yask: "hg heads" on a clone of your repo yields 8 heads
15 2015-06-24T15:18:35 <yask> whoops! I'll merge the heads
16 2015-06-24T15:19:23 <yask> could you please send me a screenshot where "Header looks odd at 1980 pixel width"
17 2015-06-24T15:19:33 <yask> RogerHaase:
18 2015-06-24T15:20:59 <yask> It looks fine in this resolution 2560 x 1600
19 2015-06-24T15:21:40 <RogerHaase> yask: those comments may be in error, now I am confused as to which branch I was running..
20 2015-06-24T15:23:01 <yask> ah! I made another branch called improvethemes and commited my changes there
21 2015-06-24T15:25:56 *** vipul20
22 2015-06-24T15:27:50 <RogerHaase> yask: https://paste.thinkmo.de/MbuPPGRW#yask.png
23 2015-06-24T15:29:45 <yask> Thank! I'll fix this.
24 2015-06-24T15:30:23 <yask> bdw did you apply this patch ? https://codereview.appspot.com/245560043/ . It contains few fixes for breadcrumb
25 2015-06-24T15:31:47 <yask> wait , yeah! I fixed this issue in this patch , please try it and let me know
26 2015-06-24T15:32:25 <yask> RogerHaase:
27 2015-06-24T15:33:05 <RogerHaase> yask: will try cloning again
28 2015-06-24T15:34:14 <yask> I havent committed this patch (https://codereview.appspot.com/245560043/) to my repo, so you'll manually have to patch it.
29 2015-06-24T15:36:17 <yask> RogerHaase: Do I also have to run any html validation tests? If yes , how? I only run ./m test and ./m coding-std
30 2015-06-24T15:38:57 <yask> Also we had `.panel` class for highlighting link in the current tab , this interfered with the `.panel` of Bootstrap so I changed `.panel` to `.moin-panel` https://codereview.appspot.com/245560043/diff/40001/MoinMoin/static/js/common.js
31 2015-06-24T15:42:18 <RogerHaase> yask: hmm, looks like html validation is not mentioned in our development docs. But yes, checking for HTML error is required. I use the HTML Validator add-on for firefox. I am not sure if there is a unix version (years ago there was not)
32 2015-06-24T15:43:26 <yask> Okkey! I'll download firefox for this addon :)
33 2015-06-24T15:49:13 <RogerHaase> gtg, back in ~3 hours
34 2015-06-24T15:49:16 *** RogerHaase
35 2015-06-24T16:01:30 <yask> :/
36 2015-06-24T16:01:30 <yask> Please note: This add-on is not compatible with your operating system.
37 2015-06-24T16:01:30 <yask> Install for Windows anyway
38 2015-06-24T16:49:35 *** greg_f
39 2015-06-24T17:34:49 <yask> New CR: RogerHaase waldi : https://codereview.appspot.com/245560043/
40 2015-06-24T17:37:02 <yask> RogerHaase: Text in footer is actually an image with black text http://i.imgur.com/W58Chsk.png , thus it doesnt look good in dark background. I'll edit the image with white text
41 2015-06-24T18:53:18 *** vipul20
42 2015-06-24T19:43:37 *** RogerHaase
43 2015-06-24T19:45:56 <yask> RogerHaase: moin
44 2015-06-24T19:46:07 <yask> did you read the mail I sent you ?
45 2015-06-24T19:47:59 <yask> this was the message : http://pastebin.com/HNXJTBkJ
46 2015-06-24T19:50:34 <RogerHaase> yask: Yes, I read it. One reason why you have all those heads is that you have not pull from the main repo in a while. On my clone from 4 hours ago. there are 4 incoming patches from April 27
47 2015-06-24T19:52:10 <yask> I synced my repo from an option in bitbucket website , I thought it would update my repo automatically ( And thus no need to do hg pull)
48 2015-06-24T19:54:01 <yask> Should I merge the heads ?
49 2015-06-24T19:54:40 <RogerHaase> try hg incoming against main repo first
50 2015-06-24T19:56:07 <yask> okkey
51 2015-06-24T19:58:51 <yask> hg incoming says: searching for changes
52 2015-06-24T19:58:51 <yask> no changes found
53 2015-06-24T20:02:16 <yask> should I do hg merge ? I am a little scared :P
54 2015-06-24T20:02:59 <yask> How did I get more than one head in any case ?
55 2015-06-24T20:07:29 <RogerHaase> hmmm, there used to be 3 heads: default, gae, and namespaces. Then there were more from student updates. How many heads do you see from "hg heads"
56 2015-06-24T20:11:56 <yask> 8
57 2015-06-24T20:12:37 <yask> I have created my own branch `improvethemes` for my project.
58 2015-06-24T20:12:54 <yask> Did you test the new patch ?
59 2015-06-24T20:18:23 <RogerHaase> I also had 8 heads. I saw 4 patches incoming from main repo; I did hg pull -u from main repo and now I have 4 heads: improvethemes, default, gae, and namespaces
60 2015-06-24T20:20:22 <RogerHaase> when you did hg incoming, did you do main repo, not your repo?
61 2015-06-24T20:28:11 <yask> I did hg incoming from my own repo but I was in my branch `improvethemes`
62 2015-06-24T20:29:48 <yask> I can't move to default branch without committing changes
63 2015-06-24T20:33:09 *** vipul20
64 2015-06-24T20:33:53 <RogerHaase> you can do manual way "hg diff > save.diff", "hg revert --all" "hg incoming <main repo>", "hg pull -u <main repo>", "hg import --no-commit save.diff" - insert branch changes where needed
65 2015-06-24T20:38:53 <yask> Ah! Or maybe just commit the changes? Ajitesh reviewed the CR and said it was okkkey. Could you have a look at it as well ? Else I'll do it manually.
66 2015-06-24T20:39:07 <yask> https://codereview.appspot.com/245560043/ CR
67 2015-06-24T20:40:57 <yask> oh! Its just one step (for saving commits). For a second I thought I had to enter all those commands just to save changes :P
68 2015-06-24T20:53:52 <yask> RogerHaase:
69 2015-06-24T21:02:57 <yask> RogerHaase: Regarding "Any template in theme/xxx/templates directory overrides the template in MoinMoin/templates." , I tested again by making `usersettings_forms.html` empty and putting this inside /themes/modernized/templates/ directory. It doesn't look like this template file is overriding as I can still see all the forms in user settings.
70 2015-06-24T21:07:54 <RogerHaase> yask: I tested the patch. There is still a HTML validation error - the search form is below a UL. Also, when I reduce window size to 1024 pixels, the header breaks: https://paste.thinkmo.de/6NDWat3X#yask.png
71 2015-06-24T21:10:31 <yask> RogerHaase: Yea , in small window size the design breaks! I'll fix this right now.
72 2015-06-24T21:11:16 <yask> Regarding validation error , I mailed you few details
73 2015-06-24T21:12:32 <yask> html validation error happens in basic theme as well , mostly because of empty spans and wiki contents
74 2015-06-24T21:14:13 <RogerHaase> line 77 column 79 - Error: Element form not allowed as child of element ul in this context. (Suppressing further errors from this subtree.) <== happens on all pages because <form> is under <ul>
75 2015-06-24T21:16:56 <yask> oops , I thought I fixed that! I'll make a new CR
76 2015-06-24T21:17:03 *** dave_largo
77 2015-06-24T21:18:01 <RogerHaase> above error does not happen on basic theme because <form> is under a bunch of <div>
78 2015-06-24T21:19:28 <yask> yea!
79 2015-06-24T21:34:25 <RogerHaase> Errors on Global History ==>
80 2015-06-24T21:34:31 <RogerHaase> line 80 column 79 - Error: Element form not allowed as child of element ul in this context. (Suppressing further errors from this subtree.)
81 2015-06-24T21:34:31 <RogerHaase> line 909 column 11 - Error: End tag for body seen, but there were unclosed elements.
82 2015-06-24T21:34:31 <RogerHaase> line 414 column 45 - Error: Unclosed element div.
83 2015-06-24T21:34:31 <RogerHaase> line 350 column 45 - Error: Unclosed element div.
84 2015-06-24T21:34:31 <RogerHaase> line 318 column 45 - Error: Unclosed element div.
85 2015-06-24T21:34:32 <RogerHaase> line 286 column 45 - Error: Unclosed element div.
86 2015-06-24T21:34:32 <RogerHaase> line 281 column 27 - Error: Unclosed element div.
87 2015-06-24T21:34:33 <RogerHaase> line 275 column 51 - Error: Unclosed element div.
88 2015-06-24T21:34:33 <RogerHaase> line 273 column 43 - Error: Unclosed element div.
89 2015-06-24T21:34:34 <RogerHaase> line 272 column 33 - Error: Unclosed element div.
90 2015-06-24T21:34:34 <RogerHaase> line 54 column 27 - Error: Unclosed element div.
91 2015-06-24T21:40:35 <RogerHaase> yask: gtg - I suggest you prioritize getting the modernized header and footer working. You are digging a hole by trying to do too much at once.
92 2015-06-24T21:40:40 *** RogerHaase
93 2015-06-24T22:08:19 <yask> Ah! but all my divs are closed in my template.
94 2015-06-24T22:16:17 <yask> RogerHaase: Fixed the design break from small resolutions and HTML validation error which occurred due to form inside <ul> tag https://codereview.appspot.com/245560043
95 2015-06-24T22:21:31 <yask> http://i.imgur.com/m78giDU.png Screenshot in smaller size
96 2015-06-24T22:29:47 <yask> I plan to use Responsive utilities http://getbootstrap.com/css/#responsive-utilities , to hide search form in smaller screens
