1 2015-06-18T00:33:15 *** vipul20
2 2015-06-18T00:51:43 *** yask
3 2015-06-18T07:19:19 *** vipul20
4 2015-06-18T08:00:59 *** greg_f
5 2015-06-18T09:34:12 *** skathpalia
6 2015-06-18T10:04:30 *** aviraldg
7 2015-06-18T10:11:01 *** yask
8 2015-06-18T10:30:20 *** skathpalia
9 2015-06-18T10:40:16 *** skathpalia
10 2015-06-18T10:51:05 <vipul20> skathpalia: http://pastebin.com/vZgMiCc3
11 2015-06-18T10:53:23 <skathpalia> I an not sure why this doesn't work
12 2015-06-18T10:53:44 <skathpalia> Ask Thomas or Roger regarding this
13 2015-06-18T10:54:08 <skathpalia> In the meantime I will also try to add a meta field
14 2015-06-18T11:58:38 *** skathpalia
15 2015-06-18T12:09:40 *** skathpalia
16 2015-06-18T12:39:54 *** dave_largo
17 2015-06-18T13:28:25 *** skathpalia
18 2015-06-18T13:41:59 <vipul20> ThomasWaldmann: CR: https://codereview.appspot.com/236490043/ , https://codereview.appspot.com/242340043/ and also I've a question here: http://pastebin.com/vZgMiCc3
19 2015-06-18T13:47:47 *** skathpalia
20 2015-06-18T14:37:55 *** skathpalia
21 2015-06-18T16:46:39 *** greg_f
22 2015-06-18T20:40:15 <ThomasWaldmann> vipul20: it does not patch into item.meta. if you want that, you have to do it yourself.
23 2015-06-18T20:41:56 <ThomasWaldmann> but it uses a copy of item.meta, updates it with all kwargs (which are collected in update_meta and usually not given via update_meta=...) and saves that to storage
24 2015-06-18T20:42:32 <ThomasWaldmann> if you reload it from storage, you ofc get the merged meta it saved.
25 2015-06-18T20:43:23 <ThomasWaldmann> (you could have easily found that yourself btw, by reading Item.modify docstring and src, it's quite clear)
26 2015-06-18T21:01:13 <vipul20> ThomasWaldmann: yes, it is very clear that it uses a copy of item.meta and update it with whatever is collected in update_meta on performing item.modify. But when we create and do this item.modify and then check item.meta it does not give the updated meta.
27 2015-06-18T21:04:39 *** dave_largo
28 2015-06-18T21:46:33 <ThomasWaldmann> vipul20: yes, because it worked on a copy. if you create the item after modify, you should see updated meta.
29 2015-06-18T22:55:23 *** ronny
30 2015-06-18T22:55:23 *** Cthulhux
31 2015-06-18T23:05:52 *** ronny
32 2015-06-18T23:05:52 *** Cthulhux
33
MoinMoin: MoinMoinChat/Logs/moin-dev/2015-06-18 (last edited 2015-06-18 00:45:03 by IrcLogImporter)