1 2015-06-16T02:47:37 *** ThomasAH
2 2015-06-16T06:33:15 *** vipul20
3 2015-06-16T08:01:21 *** greg_f
4 2015-06-16T09:04:23 *** aviraldg
5 2015-06-16T10:45:14 *** yask
6 2015-06-16T11:25:07 <yask> Code review waldi https://codereview.appspot.com/245270044/
7 2015-06-16T12:41:50 *** dave_largo
8 2015-06-16T12:43:15 *** vipul20
9 2015-06-16T14:44:12 *** RogerHaase
10 2015-06-16T14:47:40 <RogerHaase> yask: you should update xstatic bootstrap rather than add all those bootstrap 3.3.4 files to the repository
11 2015-06-16T14:51:00 <yask> RogerHaase: Yea , thats what i intend to do. At this moment I have temporarily added those files to the directory to just test the theme/template. (Thats why it resulted it such a huge CR mostly consisting of updated default bootstrap files )
12 2015-06-16T15:01:23 <RogerHaase> yask: seems rather time consuming to review. I would suggest either working with Bootstrap 3.1.1. or work on upgrading xstatic. If waldi or ThomasWaldmann said OK would you commit that?
13 2015-06-16T15:15:17 <yask> Yea! sure
14 2015-06-16T15:33:34 *** randomax
15 2015-06-16T15:42:33 *** vipul20
16 2015-06-16T15:58:41 <ThomasWaldmann> moin
17 2015-06-16T15:59:03 <randomax> moin
18 2015-06-16T15:59:06 <ThomasWaldmann> waldi: are you with us?
19 2015-06-16T15:59:10 <vipul20> moin
20 2015-06-16T16:01:17 <ThomasWaldmann> ok, time for the weekly gsoc meeting! :)
21 2015-06-16T16:01:28 <yask> moin :)
22 2015-06-16T16:01:45 <ThomasWaldmann> waldi and skathpalia seem absent still, hopefully they can manage to join us.
23 2015-06-16T16:02:34 <ThomasWaldmann> btw, we'll have this meeting every week from now on. same time, same weekday. please set a repeating calendar entry, so you don't miss it.
24 2015-06-16T16:04:19 <ThomasWaldmann> ok, vipul and yask, did you prepare some stuff for now as mentioned on the wiki page?
25 2015-06-16T16:05:25 <ThomasWaldmann> (and did you subscribe to https://moinmo.in/GoogleSoc2015 ?)
26 2015-06-16T16:05:57 *** skathpalia
27 2015-06-16T16:06:16 <ThomasWaldmann> hi skathpalia :)
28 2015-06-16T16:06:22 <skathpalia> Hi
29 2015-06-16T16:06:30 <skathpalia> Sorry for the delay
30 2015-06-16T16:07:05 <ThomasWaldmann> skathpalia: can you read the backlog since 16:00 utc later?
31 2015-06-16T16:07:45 <ThomasWaldmann> vipul20: yask: did you see my question?
32 2015-06-16T16:08:18 <yask> ThomasWaldmann: Yes!
33 2015-06-16T16:08:40 <yask> Sorry , i didn't prepare it... writing it all now :) . I have been working on `rewriting template files` and `modernized theme`. Ajitesh started reviewing my CR and gave some suggestions today.
34 2015-06-16T16:08:49 <skathpalia> Yeah np
35 2015-06-16T16:09:32 <ThomasWaldmann> yask: ok, write it now
36 2015-06-16T16:09:39 <ThomasWaldmann> (short :)
37 2015-06-16T16:09:47 <ThomasWaldmann> vipul20: how about you?
38 2015-06-16T16:10:27 <yask> Also I would like to work on latest version of bootstrap , I was thinking to work on 'upgrading xstatic' ?
39 2015-06-16T16:10:33 <ThomasWaldmann> btw, vipul20 and yask, you both noticed that PSF wants regular blog posts from you about your gsoc activities?
40 2015-06-16T16:11:51 <ThomasWaldmann> waldi: ping
41 2015-06-16T16:13:00 <yask> Yea! I am planning to write a blog post today! I did write introductory post before my exams.
42 2015-06-16T16:13:06 <vipul20> yes we got emails regarding the blog posts. We've to post at least once in every 2 weeks
43 2015-06-16T16:14:10 * ThomasWaldmann wrote an email to waldi, let's see if it helps
44 2015-06-16T16:14:27 <randomax> yask, also post screenshots of your design via imagebin
45 2015-06-16T16:14:50 <vipul20> last week I wrote code for file upload.. I've already taken a lot of time in this and still its not done https://codereview.appspot.com/246020043/ I hope I finish it up quickly
46 2015-06-16T16:16:27 <yask> randomax: You are referring to the designs I attached to my soc proposal ? or the current theme's screenshot?
47 2015-06-16T16:17:11 <randomax> current theme's screenshot
48 2015-06-16T16:17:25 <yask> just a sec
49 2015-06-16T16:17:36 <ThomasWaldmann> maybe we should keep the discussion about the projects separate, so maybe vipul could start with his DONE / BLOCKER / TODO + discussion and then yask afterwards.
50 2015-06-16T16:18:01 <ThomasWaldmann> (maybe waldi will be there until then)
51 2015-06-16T16:19:11 <ThomasWaldmann> and if you prepare and copy&paste stuff to IRC, use these prefixes: DONE: ... BLOCKER: ... TODO: ...
52 2015-06-16T16:21:12 <ThomasWaldmann> vipul20: btw, i added some comments on that CR 2d ago
53 2015-06-16T16:22:37 <vipul20> DONE: file upload: https://codereview.appspot.com/242340043/patch/1/10001, it is still not done completely (already I've taken a lot of time..need to do it quickly)
54 2015-06-16T16:22:37 <vipul20> add tags to field on click: https://codereview.appspot.com/246020043/
55 2015-06-16T16:22:37 <vipul20> pending review for ticket suggestion: https://codereview.appspot.com/236490043/
56 2015-06-16T16:24:52 <ThomasWaldmann> ok, i still have to look at the last one. skathpalia could you get a bit more involved in CR also?
57 2015-06-16T16:25:08 <vipul20> TODO: we do not have tests for ticket creation. So I think we should have test for it. Is it necessary ? last year I think skathpalia wrote but I cannot see in current code
58 2015-06-16T16:26:09 <ThomasWaldmann> UI stuff is a bit hard to test as long as the UI is not stable
59 2015-06-16T16:26:43 <skathpalia> Yeah i will look at the pending crs
60 2015-06-16T16:26:59 <vipul20> I've some issues regarding whoosh indexing. When I add a new field in indexing.py it still shows unknown field error. Do we need to update the index in a different way ?
61 2015-06-16T16:27:12 <ThomasWaldmann> i guess in general we need to speed up a bit. vipul20 did you compare your progress with your planned schedule?
62 2015-06-16T16:28:11 <ThomasWaldmann> i just had a look at both gsoc repos and no commit in there yet. there are some CRs open, so that's better than nothing, but for 3 weeks it feels not that much.
63 2015-06-16T16:28:44 <ThomasWaldmann> also community binding phase has been rather inactive. not the expected planning activity.
64 2015-06-16T16:29:21 <yask> Current modernized theme screenshot: http://i.imgur.com/1Nlpdln.png
65 2015-06-16T16:29:41 <ThomasWaldmann> yask: please wait until it's your stage.
66 2015-06-16T16:29:51 <yask> Okkey!
67 2015-06-16T16:30:40 <vipul20> yes ThomasWaldmann: I compared with my planned schedule, unfortunately I am lagging behind :/
68 2015-06-16T16:30:46 <ThomasWaldmann> yask: you could put some markers in there about what you changed
69 2015-06-16T16:31:18 <ThomasWaldmann> vipul20: can you identify the reasons?
70 2015-06-16T16:32:44 <vipul20> I realize that I had poor planning also I am slow in getting things right
71 2015-06-16T16:33:05 <ThomasWaldmann> btw, it's 10d left until midterm evals start.
72 2015-06-16T16:34:40 <skathpalia> Vipul if you are struck at some point the
73 2015-06-16T16:35:18 <ThomasWaldmann> well, iirc i told you some things multiple times. so either you didn't read it or didn't understand what i mean (then you should ask good questions).
74 2015-06-16T16:35:25 <skathpalia> Then you can do some ui improvements side by side
75 2015-06-16T16:35:48 <vipul20> I really need to speed up !
76 2015-06-16T16:36:18 <ThomasWaldmann> and as skathpalia mentions, doing some multitasking while waiting for "mentor I/O" is a good idea (see how operating systems do scheduling)
77 2015-06-16T16:37:22 <vipul20> I didn't expect this file upload thing to take much time as it had an existing implementation.. but I took a lot of time
78 2015-06-16T16:37:55 <ThomasWaldmann> vipul20: i'ld suggest that instead of writing new tests you try to get some CRs finished, tested (run unit tests + manual tests) and committed
79 2015-06-16T16:38:55 <vipul20> ok
80 2015-06-16T16:39:15 <ThomasWaldmann> also, look at your plans (etherpad) and check the stuff you finished
81 2015-06-16T16:39:57 <ThomasWaldmann> (and in case you had to do stuff additionally, keep a notice there)
82 2015-06-16T16:40:42 <ThomasWaldmann> ok, guess we need to finish with vipul's part of this meeting soon. anything left to / from vipul?
83 2015-06-16T16:40:54 <ThomasWaldmann> waldi: peng
84 2015-06-16T16:41:35 <vipul20> I've question regarding creating whoosh index
85 2015-06-16T16:42:13 <vipul20> when I am adding new field to index in indexing.py it still shows unknown field error. Do we have to update index in some other way ?
86 2015-06-16T16:42:20 <ThomasWaldmann> yes? (if it is much, we can also discuss after meeting)
87 2015-06-16T16:42:48 <ThomasWaldmann> did you rebuild the on-disk index afterwards?
88 2015-06-16T16:43:14 <vipul20> no
89 2015-06-16T16:43:23 <ThomasWaldmann> try :)
90 2015-06-16T16:43:40 <vipul20> ok I'll try that
91 2015-06-16T16:43:45 <ThomasWaldmann> moin's storage is a rather dumb pile of items
92 2015-06-16T16:43:54 <ThomasWaldmann> all intelligent behaviour comes from the index
93 2015-06-16T16:44:23 <ThomasWaldmann> index lives on disk and if you do schema changes, a rebuild might be necessary
94 2015-06-16T16:44:58 <ThomasWaldmann> ok, if there are more technical questions: please after meeting. time is limited in here.
95 2015-06-16T16:45:08 <ThomasWaldmann> yask: ok, now it's your stage
96 2015-06-16T16:46:05 <ThomasWaldmann> (next time we'll try to start a bit more in-time, so the planned 1h will be rather 2x 30mins for the 2 projects)
97 2015-06-16T16:46:14 <yask> DONE (what did you achieve last week)
98 2015-06-16T16:46:14 <yask> rewrite of the `layout.html` template to work on top of Bootstrap.
99 2015-06-16T16:46:14 <yask> It also replaces the old stylus theme by new modernized theme. The theme is written in `theme.less` and `modernized.less` file.
100 2015-06-16T16:46:14 <yask> https://codereview.appspot.com/245270044
101 2015-06-16T16:46:14 <yask> Code review is in process. Ajitesh is reviewing it.
102 2015-06-16T16:46:15 <yask> BLOCKERS (stuff you can not solve on your own in reasonable time)
103 2015-06-16T16:46:15 <yask> NEXT (stuff planned for next week)
104 2015-06-16T16:46:16 <yask> Make changes in `make.py` file to automate compiling of the modernized less file to css.
105 2015-06-16T16:46:16 <yask> Write css rules for other sections such as setting’s page , tags , index.. etc.
106 2015-06-16T16:46:17 <yask> Implement a design for displaying quicklinks, footer.. etc.
107 2015-06-16T16:46:17 <yask> Implementing the suggestions mentioned by mentors on the previous cr.
108 2015-06-16T16:46:18 <yask> If I get some extra time I’ll proceed to my next task " # Better error-notifications “(As mentioned in soc proposal).
109 2015-06-16T16:46:58 <ThomasWaldmann> good copy and pasting :)
110 2015-06-16T16:47:06 <yask> :)
111 2015-06-16T16:48:07 <ThomasWaldmann> that codereview is rather long
112 2015-06-16T16:49:28 <yask> Yea , because while working with latest version of bootstrap I temporarily added those files to the directory to just test the theme/template. (Thats why it resulted it such a huge CR mostly consisting of updated default bootstrap files )
113 2015-06-16T16:50:15 <yask> The work in done in `theme.less`
114 2015-06-16T16:50:15 <yask> `layout.html`
115 2015-06-16T16:50:15 <yask> `modernized.less` as mentioned in the description of the CR.
116 2015-06-16T16:50:41 <waldi> moin
117 2015-06-16T16:50:51 <ThomasWaldmann> ok, i read it in your description there
118 2015-06-16T16:50:58 <waldi> ThomasWaldmann: did anyone give a followup on the meeting time? never read one
119 2015-06-16T16:51:33 <ThomasWaldmann> waldi: it's on the main gsoc wiki page (to which you should subscribe)
120 2015-06-16T16:51:54 <ThomasWaldmann> (and also the result was rather clear on the doodle)
121 2015-06-16T16:52:10 <waldi> i thought i'm subscribed
122 2015-06-16T16:52:45 <ThomasWaldmann> but you're right in time for your student
123 2015-06-16T16:52:55 <ThomasWaldmann> see 18:46+
124 2015-06-16T16:54:33 <ThomasWaldmann> yask: if you want some material for blog posts, some before / after screenshots would be nice
125 2015-06-16T16:55:24 <yask> Yea! I'll add them.
126 2015-06-16T16:57:23 <waldi> yask: please don't add all the bootstrap stuff, but i think you already got the hint. changes of this size needs to be split up anyway
127 2015-06-16T16:58:26 <ThomasWaldmann> yask: the "bootstrap stuff" is what you'ld normally get from xstatic-bootstrap?
128 2015-06-16T16:58:27 <yask> Yea , I'll be trimming down the unwanted bootstrap next!
129 2015-06-16T16:59:38 <yask> Yes , but I thought to work on latest bootstrap.
130 2015-06-16T17:00:29 <yask> This was just added temporarily.
131 2015-06-16T17:02:20 <ThomasWaldmann> yask: so xstatic currently has x and you want y? what's x and y and why? :)
132 2015-06-16T17:05:16 <yask> Ah! Since I was rewriting a template I thought to use latest version of bootstrap as RogerHaase suggested( in my etherpad). There are couple of bug fixes in the latest version of bootstrap and I thought we'll be upgrading xstatic anyway soon :)
133 2015-06-16T17:06:15 <yask> Although there aren't any major changes between the two versions. We can still use the existing bootstrap from xstatic and it should work fine
134 2015-06-16T17:09:18 <waldi> please provide an update for xstatic first, then you don't need to resort to unmergeable changes
135 2015-06-16T17:10:34 <yask> Okkey!!
136 2015-06-16T17:10:35 <ThomasWaldmann> ok, if it's just a minor bs update, it shouldn't cause issues.
137 2015-06-16T17:10:42 <ThomasWaldmann> so, version numbers?
138 2015-06-16T17:11:39 <ThomasWaldmann> yask: don't waste too much time on xstatic-bootstrap package. if you aren't finished with it after 2h, talk to me.
139 2015-06-16T17:12:34 <yask> Current version of Bootstrap is 3.3.4, setup.py > 'XStatic-Bootstrap==3.1.1.2'
140 2015-06-16T17:12:53 <yask> Okkey!
141 2015-06-16T17:14:52 <ThomasWaldmann> ok, that seems a bit more than just fixes. but you don't expect compat problems?
142 2015-06-16T17:16:24 <yask> Haven't tested , but I don't expect compatibility problems.
143 2015-06-16T17:16:56 <ThomasWaldmann> ok
144 2015-06-16T17:17:11 <ThomasWaldmann> ok, time is over. anything left for/from yask?
145 2015-06-16T17:17:34 <waldi> no
146 2015-06-16T17:17:46 <ThomasWaldmann> skathpalia: ^
147 2015-06-16T17:17:54 <skathpalia> No
148 2015-06-16T17:18:29 <yask> no :)
149 2015-06-16T17:19:07 <ThomasWaldmann> ok, so thanks for attending. don't forget to subscribe to the wiki page and setup a gsoc meeting reminder.
150 2015-06-16T17:19:15 * ThomasWaldmann bbl
151 2015-06-16T17:19:22 *** randomax
152 2015-06-16T17:20:08 *** skathpalia
153 2015-06-16T17:49:08 *** greg_f
154 2015-06-16T17:51:45 *** aviraldg
155 2015-06-16T18:51:47 *** randomax
156 2015-06-16T18:54:33 *** randomax
157 2015-06-16T19:21:43 *** yask
158 2015-06-16T20:19:51 *** yask
159 2015-06-16T20:49:44 *** RogerHaase
160 2015-06-16T21:18:14 *** dave_largo
161 2015-06-16T23:23:15 *** vipul20
162
