1 2015-03-22T00:37:09  *** vipul20 has quit IRC
   2 2015-03-22T06:06:38  *** vipul20 has joined #moin-dev
   3 2015-03-22T07:53:30  *** reyha has joined #moin-dev
   4 2015-03-22T08:00:25  *** UnoPolak has quit IRC
   5 2015-03-22T08:00:41  *** UnoPolak has joined #moin-dev
   6 2015-03-22T08:09:43  <reyha> ThomasWaldmann:  please review this https://codereview.appspot.com/217140043/
   7 2015-03-22T10:44:10  *** reyha has quit IRC
   8 2015-03-22T11:57:09  *** vipul20 has quit IRC
   9 2015-03-22T12:07:40  <ThomasWaldmann> moin
  10 2015-03-22T12:55:49  *** vipul20 has joined #moin-dev
  11 2015-03-22T12:59:21  *** reyha has joined #moin-dev
  12 2015-03-22T13:01:40  <ThomasWaldmann> reyha: you have seen that aabs08 wrote into that ticket "i am working on it" and also made a pull request for it?
  13 2015-03-22T13:03:17  <ThomasWaldmann> reyha: see there for a better solution:
  14 2015-03-22T13:03:20  <ThomasWaldmann> https://bitbucket.org/aabs08/moin-2.0/commits/08007ac96dda40b42183f0a84174898293297179
  15 2015-03-22T13:03:41  * ThomasWaldmann needs to merge some PRs today...
  16 2015-03-22T13:08:42  <vipul20> moin ThomasWaldmann: can you please review https://codereview.appspot.com/213780043/
  17 2015-03-22T13:09:47  <reyha> ThomasWaldmann:  yes, thanks a lot!
  18 2015-03-22T13:21:44  <ThomasWaldmann> vipul20: done
  19 2015-03-22T13:22:36  <ThomasWaldmann> btw (for everybody): links(!) to issues in codereview headers would be much appreciated
  20 2015-03-22T13:22:55  <ThomasWaldmann> make life of your reviewers easier! ;)
  21 2015-03-22T13:46:52  <vipul20> thanks for the review ThomasWaldmann I will include the link of the issue from next time
  22 2015-03-22T13:47:05  <vipul20> ThomasWaldmann: we discussed about switching explicitly from name-based view to itemid-based view
  23 2015-03-22T13:47:28  <vipul20> should I provide link to the item-based view ?
  24 2015-03-22T13:47:59  <vipul20> rather than switching automagically ?
  25 2015-03-22T13:57:42  <ThomasWaldmann> yes. one link might not be enough btw.
  26 2015-03-22T14:00:15  <vipul20> should we give a message with the link that one should click the link to get itemid based view ? will it be sufficient ?
  27 2015-03-22T14:11:49  <ThomasWaldmann> i mean one (1) link might not be enough
  28 2015-03-22T14:12:10  <ThomasWaldmann> just think about the situation for a while
  29 2015-03-22T14:29:48  *** greg_f has joined #moin-dev
  30 2015-03-22T15:07:00  *** aabs08 has joined #moin-dev
  31 2015-03-22T15:10:55  *** bond007 has joined #moin-dev
  32 2015-03-22T15:16:48  <vipul20> ThomasWaldmann: I think there should be a link to itemid based view when a name based view  is displayed and vice versa i.e. link to both views should be available as a user may want to switch to any view. Am I right ?
  33 2015-03-22T15:26:30  <ThomasWaldmann> almost
  34 2015-03-22T16:38:58  *** aabs08 has quit IRC
  35 2015-03-22T16:54:16  *** reyha has quit IRC
  36 2015-03-22T17:22:12  *** aabs08 has joined #moin-dev
  37 2015-03-22T17:31:16  *** aabs08 has quit IRC
  38 2015-03-22T17:31:34  *** aabs08 has joined #moin-dev
  39 2015-03-22T17:40:06  *** reyha has joined #moin-dev
  40 2015-03-22T17:51:05  *** aabs08 has quit IRC
  41 2015-03-22T18:25:05  *** greg_f has quit IRC
  42 2015-03-22T18:42:18  *** aabs08 has joined #moin-dev
  43 2015-03-22T19:01:35  *** bond007_ has joined #moin-dev
  44 2015-03-22T19:02:24  *** bond007 has quit IRC
  45 2015-03-22T19:04:48  *** aabs08 has quit IRC
  46 2015-03-22T20:00:49  *** bond007_ has quit IRC
  47 2015-03-22T21:04:10  *** reyha has quit IRC
  48

MoinMoin: MoinMoinChat/Logs/moin-dev/2015-03-22 (last edited 2015-03-22 00:45:03 by IrcLogImporter)