1 2015-03-10T00:09:21 *** grvanm
2 2015-03-10T00:55:02 *** dumindux
3 2015-03-10T01:14:49 *** grvanm
4 2015-03-10T01:30:38 *** grvanm
5 2015-03-10T01:37:52 *** dumindux
6 2015-03-10T01:51:34 *** dumindux
7 2015-03-10T02:25:21 *** swills
8 2015-03-10T02:25:39 <swills> can anyone point me at an IRC bot that announces recent changes?
9 2015-03-10T02:51:53 *** dumindux
10 2015-03-10T03:18:53 *** grvanm
11 2015-03-10T03:38:13 *** vipul20
12 2015-03-10T04:41:33 *** AayushRanaut
13 2015-03-10T04:44:23 *** dumindux
14 2015-03-10T05:08:55 *** aviraldg
15 2015-03-10T06:00:02 *** vipul20
16 2015-03-10T07:06:09 *** reyha
17 2015-03-10T07:26:17 *** AayushRanaut
18 2015-03-10T07:33:19 *** AayushRanaut
19 2015-03-10T07:56:25 *** tonythomas
20 2015-03-10T07:57:40 *** UnoPolak
21 2015-03-10T08:21:11 *** aviraldg
22 2015-03-10T09:17:44 *** grvanm
23 2015-03-10T09:24:24 *** grvanm
24 2015-03-10T09:25:17 *** krisgan
25 2015-03-10T09:35:45 *** grvanm
26 2015-03-10T09:36:43 *** grvanm
27 2015-03-10T09:36:58 *** grvanm
28 2015-03-10T09:42:12 *** reyha
29 2015-03-10T09:44:45 *** AayushRanaut
30 2015-03-10T10:02:32 *** krisgan
31 2015-03-10T10:41:48 *** greg_f
32 2015-03-10T10:49:50 *** bond007
33 2015-03-10T10:50:47 <bond007> RogerHasse: https://codereview.appspot.com/207670043 Issue #508
34 2015-03-10T10:59:04 *** bond007
35 2015-03-10T12:01:56 *** reyha
36 2015-03-10T12:07:04 *** bond007
37 2015-03-10T12:09:57 <bond007> ThomasWaldmann: https://codereview.appspot.com/207670043/ Issue #508
38 2015-03-10T12:25:35 *** bond007_
39 2015-03-10T12:26:27 *** bond007
40 2015-03-10T12:29:02 *** dumindux
41 2015-03-10T12:50:03 *** bond007_
42 2015-03-10T12:58:30 *** AayushRanaut
43 2015-03-10T13:14:29 *** bond007
44 2015-03-10T13:52:23 *** Kallor
45 2015-03-10T13:53:21 *** Kallor
46 2015-03-10T14:00:45 *** aviraldg
47 2015-03-10T14:04:51 *** pjoshi
48 2015-03-10T14:07:23 <pjoshi> Moin!!
49 2015-03-10T14:13:18 <AayushRanaut> Moin!
50 2015-03-10T14:13:40 <aviraldg> Moin!
51 2015-03-10T14:35:28 *** pjoshi
52 2015-03-10T14:42:49 *** AayushRanaut
53 2015-03-10T14:47:03 *** etotientz
54 2015-03-10T14:48:25 *** etotientz
55 2015-03-10T14:53:23 *** ThomasAH
56 2015-03-10T15:12:03 *** RogerHaase
57 2015-03-10T15:25:10 *** dumindux
58 2015-03-10T15:56:10 <bond007> RogerHaase: #588 issue https://codereview.appspot.com/207670043
59 2015-03-10T15:56:23 <bond007> *#508
60 2015-03-10T16:08:04 *** dave_largo
61 2015-03-10T16:12:12 *** reyha
62 2015-03-10T16:14:40 *** aabs08
63 2015-03-10T16:21:27 <RogerHaase> bond007: done
64 2015-03-10T16:44:13 *** aabs08
65 2015-03-10T16:48:09 *** dumindux
66 2015-03-10T16:50:52 *** AayushRanaut
67 2015-03-10T16:52:56 *** dumindux
68 2015-03-10T17:00:45 *** dumindux
69 2015-03-10T17:02:41 *** dumindux
70 2015-03-10T17:04:33 *** aabs08
71 2015-03-10T17:06:59 *** dumindux
72 2015-03-10T17:07:14 *** bond007_
73 2015-03-10T17:07:34 *** bond007
74 2015-03-10T17:10:13 <bond007_> RogerHaase: https://codereview.appspot.com/207670043/
75 2015-03-10T17:24:50 *** reyha
76 2015-03-10T17:25:08 *** pjoshi
77 2015-03-10T17:25:52 <pjoshi> RogerHaase: Moin
78 2015-03-10T17:26:17 <pjoshi> ThomasAH:
79 2015-03-10T17:26:24 <pjoshi> ThomasWaldmann:
80 2015-03-10T17:26:32 <pjoshi> I want to ask you about tickets
81 2015-03-10T17:26:48 <pjoshi> I think we need to change the UI of tickets
82 2015-03-10T17:27:10 <RogerHaase> pjoshi: from yesterday, did you find "hg add ..."
83 2015-03-10T17:27:59 <RogerHaase> pjoshi: also to disable checkboxes, radiobuttons on forms, the usual route in to do it with javascript
84 2015-03-10T17:28:43 <pjoshi> RogerHaase: Okay then we need to add different js script to show on that history page
85 2015-03-10T17:29:43 <pjoshi> RogerHaase: And one more thing if we have to add a new template in Moin how to add it as I am still getting error in uploading it for code review
86 2015-03-10T17:30:33 <RogerHaase> hg add <new filename>
87 2015-03-10T17:32:12 <pjoshi> RogerHaase: So I have to add it before I sent it for code review ?
88 2015-03-10T17:33:25 <RogerHaase> yes, the add is not a commit, just makes the file known
89 2015-03-10T17:33:46 <pjoshi> RogerHaase: okay got it.
90 2015-03-10T17:33:56 <bond007_> RogerHaase: https://codereview.appspot.com/207670043/
91 2015-03-10T17:34:58 <pjoshi> RogerHaase: What I think is that we need to add a different template to render if the revid != CURRENT and for that we will apply different js, right ?
92 2015-03-10T17:35:26 <pjoshi> the js without radiobutton and dropdown
93 2015-03-10T17:38:35 *** AayushRanaut
94 2015-03-10T17:38:51 <RogerHaase> pjoshi: hmm, does that mean you have to add a new js file as well? It there a way to add a clue to existing template that view is not current revision and have that kick off js function?
95 2015-03-10T17:39:12 <RogerHaase> .. where new js function is in common.js
96 2015-03-10T17:40:32 <pjoshi> RogerHaase: emm, have to try that once.
97 2015-03-10T17:41:40 <pjoshi> RogerHaase: What I think is if in the tickets only while creating if we just use tags(like in github or bitbuckets) to put and not these radio buttons then it will be easy to render the previous versions too
98 2015-03-10T17:46:16 <RogerHaase> pjoshi: give it a try
99 2015-03-10T17:46:51 <pjoshi> RogerHaase: Sure :)
100 2015-03-10T17:49:08 <RogerHaase> bond007_: done
101 2015-03-10T17:52:10 <RogerHaase> bond007_: re-done
102 2015-03-10T17:52:37 <reyha> RogerHaase: I tried to work on issue 347. It seems like on clicking the logo and the sitename I get linked to the home page. However whenever i try to change it, item_not_found error comes up.
103 2015-03-10T17:52:47 <reyha> what do i exactly need to do?
104 2015-03-10T17:54:27 <RogerHaase> reyha: just create the alternate "home" page
105 2015-03-10T18:08:27 *** krisgan
106 2015-03-10T18:11:07 *** AayushRanaut
107 2015-03-10T18:25:27 *** bond007
108 2015-03-10T18:25:54 *** greg_f
109 2015-03-10T18:26:32 *** bond007_
110 2015-03-10T18:28:10 <ThomasWaldmann> moin
111 2015-03-10T18:31:14 <pjoshi> ThomasWaldmann: Moin
112 2015-03-10T18:31:39 *** UnoPolak
113 2015-03-10T18:31:52 <AayushRanaut> Moin!
114 2015-03-10T18:48:12 <bond007> RogerHaase: https://codereview.appspot.com/207670043
115 2015-03-10T18:48:55 <bond007> RogerHaase: I used this website `http://jshint.com`
116 2015-03-10T18:54:01 *** pjoshi
117 2015-03-10T18:54:40 *** pjoshi
118 2015-03-10T18:54:46 <pjoshi> RogerHaase: It is donw without any js/css addition
119 2015-03-10T18:55:11 <pjoshi> RogerHaase: Here is the code review https://codereview.appspot.com/211520043
120 2015-03-10T18:58:58 <pjoshi> ThomasWaldmann:
121 2015-03-10T18:59:08 <pjoshi> Please review this https://codereview.appspot.com/211520043
122 2015-03-10T19:01:38 *** AayushRanaut
123 2015-03-10T19:01:44 <ThomasWaldmann> pjoshi: ok, looking right now
124 2015-03-10T19:02:37 <pjoshi> ThomasWaldmann: :)
125 2015-03-10T19:02:45 *** AayushRanaut
126 2015-03-10T19:13:24 <bond007> RogerHaase: https://codereview.appspot.com/207670043
127 2015-03-10T19:19:19 <ThomasWaldmann> pjoshi: done
128 2015-03-10T19:20:01 <ThomasWaldmann> as a general comment for all students: do not request mentor review as long as you can easily spot stuff to improve yourself.
129 2015-03-10T19:20:34 <ThomasWaldmann> that means that you always do the first (first few) reviews yourself, before even uploading to codereview.
130 2015-03-10T19:20:52 <ThomasWaldmann> hg status and hg diff and just slowly read that and re-think your changes.
131 2015-03-10T19:21:58 *** pjoshi
132 2015-03-10T19:22:03 <ThomasWaldmann> mentoring time availability is limited and if you burn it for trivial stuff, there might be not enough left for not-so-trivial stuff
133 2015-03-10T19:25:16 *** pjoshi
134 2015-03-10T19:25:38 <sharky93> the ever so wise ThomasWaldmann :)
135 2015-03-10T19:25:43 <sharky93> moin
136 2015-03-10T19:25:49 <ThomasWaldmann> sharky93: :P
137 2015-03-10T19:27:09 <aviraldg> I assume you don't want to be bugged (other than the standard notification email) about reviewed but unmerged PRs?
138 2015-03-10T19:28:25 <ThomasWaldmann> I have a look now and then at PRs. It helps if you put a link to codereview in the PR. And to the ticket, if it is not in the codereview anyway.
139 2015-03-10T19:28:35 <aviraldg> ThomasWaldmann: What do you think about https://bitbucket.org/thomaswaldmann/moin-2.0/issue/504/logout-should-be-post-not-get?
140 2015-03-10T19:28:55 <aviraldg> Aha. Will keep that in mind.
141 2015-03-10T19:28:55 *** pjoshi
142 2015-03-10T19:29:15 *** pjoshi
143 2015-03-10T19:29:15 *** pjoshi
144 2015-03-10T19:30:03 <AayushRanaut> ThomasWaldmann: Could you please take a look at this trivial though UX improvement https://codereview.appspot.com/215140043
145 2015-03-10T19:30:03 <ThomasWaldmann> RogerHaase: not sure if that "Authentication" idea is ok with google (as it is now).
146 2015-03-10T19:30:53 <ThomasWaldmann> they have a rather limited requirement to writing *code* (that includes docs and testing for that code).
147 2015-03-10T19:31:28 <ThomasWaldmann> but docs-only, testing-only, ... tasks are not in scope.
148 2015-03-10T19:32:02 <ThomasWaldmann> so at least the focus there should be changed to coding, if possible.
149 2015-03-10T19:32:14 <RogerHaase> ThomasWaldmann: OK, will try rephrasing or do you want it removed
150 2015-03-10T19:32:36 <ThomasWaldmann> if it can be upheld and made in scope, it would be great.
151 2015-03-10T19:33:16 * ThomasWaldmann just remembers some ML discussions with google and their standpoint there.
152 2015-03-10T19:34:30 <ThomasWaldmann> AayushRanaut: looking now
153 2015-03-10T19:34:35 *** tonythomas
154 2015-03-10T19:34:43 <AayushRanaut> Thanks
155 2015-03-10T19:35:45 <ThomasWaldmann> AayushRanaut: wasn't that already fixed recently? by using some next=... param?
156 2015-03-10T19:35:56 <bond007> https://codereview.appspot.com/207670043 Issue #508
157 2015-03-10T19:36:47 <ThomasWaldmann> for all students: if you work on something, put a remark on the ticket and update with links to codereviews / PR later.
158 2015-03-10T19:37:11 <AayushRanaut> ThomasWaldmann: It was still showing me the same screen when I accesed the login URL.
159 2015-03-10T19:38:28 <ThomasWaldmann> yes, but there is even a remark by aabs08
160 2015-03-10T19:38:53 <ThomasWaldmann> don't expect all changes to make it into main repo immediately.
161 2015-03-10T19:40:10 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-requests
162 2015-03-10T19:40:31 <ThomasWaldmann> maybe having a look there is also useful ^
163 2015-03-10T19:40:54 * ThomasWaldmann will merge some stuff from there later
164 2015-03-10T19:41:01 <AayushRanaut> Ah sorry
165 2015-03-10T19:41:08 <pjoshi_> ThomasWaldmann: I answered the questions asked here https://codereview.appspot.com/211520043
166 2015-03-10T19:41:27 <pjoshi_> and I will clean the code and will update the CR
167 2015-03-10T19:43:28 <ThomasWaldmann> pjoshi_: i don't see your answer, did you submit?
168 2015-03-10T19:43:56 <ThomasWaldmann> publish+mail = "m" key
169 2015-03-10T19:44:40 <ThomasWaldmann> ok, now I have 7 PRs and none has a link to codereview.
170 2015-03-10T19:45:30 <pjoshi_> ThomasWaldmann: Sorry was just drafted that time
171 2015-03-10T19:45:44 <pjoshi_> its updated now
172 2015-03-10T19:48:07 <ThomasWaldmann> ok
173 2015-03-10T19:51:09 <ThomasWaldmann> pjoshi_: if you use that "show" method for showing name and value, will it still look as pretty as the form fields? is there css for the form fields?
174 2015-03-10T19:51:11 <aviraldg> Do minor fixes need a full review as well?
175 2015-03-10T19:51:52 <ThomasWaldmann> if you're just fixing obvious typos, then not.
176 2015-03-10T19:52:53 <ThomasWaldmann> you can also state "no codereview" than I at least know i do not have to search for it
177 2015-03-10T19:53:01 <aviraldg> PR#256 is pretty minor and RogerHaase said he's had a look at it
178 2015-03-10T19:54:36 *** pjoshi_
179 2015-03-10T19:55:14 *** pjoshi_
180 2015-03-10T19:55:35 <ThomasWaldmann> aviraldg: that encode/decode doesn't look too trivial.
181 2015-03-10T19:55:46 *** aabs08
182 2015-03-10T19:55:54 <pjoshi_> ThomasWaldmann: But I guess it suits the normal template
183 2015-03-10T19:56:16 <ThomasWaldmann> aviraldg: i think there should be a comment above that, why you are doing it like this
184 2015-03-10T19:56:30 <pjoshi_> ThomasWaldmann: We need to improve tickets anyways so we will do it anyways
185 2015-03-10T19:56:33 <aviraldg> sure, I'll update with that
186 2015-03-10T19:57:05 <ThomasWaldmann> pjoshi_: the question is whether you have to it twice now rather than once.
187 2015-03-10T19:59:14 <pjoshi_> ThomasWaldmann: Its better to do it together with the whole ticket improvement and as far as bug is concern I guess we are able to show a not editable view
188 2015-03-10T20:00:07 <pjoshi_> and ThomasWaldmann If you want me to do it now the will start adding UI to it too.
189 2015-03-10T20:00:18 *** aabs08
190 2015-03-10T20:01:17 *** AayushRanaut
191 2015-03-10T20:05:28 <ThomasWaldmann> pjoshi_: you're right, styling has nothing to do with the ticket. but has to be made consistent later.
192 2015-03-10T20:06:12 <pjoshi_> ThomasWaldmann: yeah that will be done under ticket improvements anyways.
193 2015-03-10T20:08:19 <ThomasWaldmann> aviraldg: how about adding a test that reproduces the failure (without your fix) and succeeds with your fix?
194 2015-03-10T20:08:52 <aviraldg> will do
195 2015-03-10T20:10:20 <bond007> ThomasWaldmann: RogerHaase: https://codereview.appspot.com/207670043 issue #508
196 2015-03-10T20:12:05 <ThomasWaldmann> aviraldg: and maybe also consider the opposite direction, unparse()
197 2015-03-10T20:12:43 <ThomasWaldmann> aviraldg: you can also ask waldi for review, who already gave feedback for the first try a year ago
198 2015-03-10T20:13:34 <aviraldg> unparse already works fine (afaik)
199 2015-03-10T20:14:01 <aviraldg> already did ping him a while back, think he wasn't available then
200 2015-03-10T20:14:51 <ThomasWaldmann> i just mean, if you do non-ascii tests for one, also do them for the other
201 2015-03-10T20:15:27 <aviraldg> right
202 2015-03-10T20:20:50 <ThomasWaldmann> bond007: done
203 2015-03-10T20:24:19 <pjoshi_> ThomasWaldmann: Instead of showTicket what should be the name of the template that you suggest ?
204 2015-03-10T20:25:12 *** bond007
205 2015-03-10T20:27:05 <ThomasWaldmann> pjoshi_: how are the other names made?
206 2015-03-10T20:27:45 <ThomasWaldmann> (this is about avoiding redundancy and having consistency)
207 2015-03-10T20:27:51 <pjoshi_> ThomasWaldmann: So only show,html will work I guess
208 2015-03-10T20:27:56 *** bond007
209 2015-03-10T20:28:01 <pjoshi_> ThomasWaldmann: Yeah I got it
210 2015-03-10T20:28:13 <ThomasWaldmann> don't we already have show.html?
211 2015-03-10T20:28:40 <pjoshi_> ThomasWaldmann: Not in tickets mdule
212 2015-03-10T20:28:43 <pjoshi_> *module
213 2015-03-10T20:28:51 <ThomasWaldmann> ok then
214 2015-03-10T20:29:00 <pjoshi_> Great :)
215 2015-03-10T20:34:45 <pjoshi_> ThomasWaldmann: Thanks for reviews. Good Night :)
216 2015-03-10T20:34:58 <bond007> ThomasWaldmann: I added css verification in python , so that maybe in the future we could build a proper css verification system , I was worried about this: http://stackoverflow.com/questions/7153488/is-including-an-external-css-file-safe-or-could-it-lead-to-code-injection?rq=1
217 2015-03-10T20:35:44 <ThomasWaldmann> bond007: it is the user himself who adds this css. and it is only presented to him.
218 2015-03-10T20:36:02 *** pjoshi_
219 2015-03-10T20:36:10 <ThomasWaldmann> so if you want to hack yourself, that's the way to go! :D
220 2015-03-10T20:38:42 <bond007> alright! it does seems an overkill .
221 2015-03-10T20:40:08 <bond007> ThomasWaldmann: edited my pr with code reviews: https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/253/fixes-issues-488-494-496-489/diff
222 2015-03-10T20:41:21 <ThomasWaldmann> great, thanks!
223 2015-03-10T20:42:01 *** bond007
224 2015-03-10T20:42:17 <aabs08> ThomasWaldmann, I also added but in reply to your comment https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/252/fixes-issue-483-482-499-and-503/diff#comment-5582589
225 2015-03-10T20:43:43 <ThomasWaldmann> ok, great
226 2015-03-10T21:03:11 *** dave_largo
227 2015-03-10T21:45:44 *** pjoshi
228 2015-03-10T21:46:46 <pjoshi> ThomasWaldmann: please review this https://codereview.appspot.com/211520043/#ps20001
229 2015-03-10T21:58:08 *** RogerHaase
230 2015-03-10T22:13:03 *** aabs08
231 2015-03-10T23:11:30 <pjoshi> ThomasWaldmann: Please review this https://codereview.appspot.com/215160043
232 2015-03-10T23:27:17 *** pjoshi
233 2015-03-10T23:32:17 *** reyha
234
