MoinMoin: MoinMoinChat/Logs/moin-dev/2015-02-17

   1 2015-02-17T05:10:01  *** yask007 has joined #moin-dev
   2 2015-02-17T07:01:22  *** yask007 has quit IRC
   3 2015-02-17T07:45:07  *** yask007 has joined #moin-dev
   4 2015-02-17T08:53:04  *** yask007 has quit IRC
   5 2015-02-17T09:13:28  *** greg_f has joined #moin-dev
   6 2015-02-17T14:00:35  *** dave_largo has joined #moin-dev
   7 2015-02-17T17:13:18  *** aabs08 has joined #moin-dev
   8 2015-02-17T17:13:53  <aabs08> ThomasWaldmann,  codereview issue #483 and #482 https://codereview.appspot.com/194330043/
   9 2015-02-17T17:29:49  *** aabs08 has quit IRC
  10 2015-02-17T17:35:44  *** ayushjjwala has joined #moin-dev
  11 2015-02-17T17:39:54  <ThomasWaldmann> ayushjjwala: ah, already here
  12 2015-02-17T17:40:17  <ThomasWaldmann> ayushjjwala: do you know aabs08?
  13 2015-02-17T17:40:36  <ayushjjwala> no
  14 2015-02-17T17:40:47  <ThomasWaldmann> Aabhas
  15 2015-02-17T17:42:06  <ThomasWaldmann> you both come from same ip
  16 2015-02-17T17:42:37  <ayushjjwala> ooh..he isnt online i guess
  17 2015-02-17T17:44:21  <vipul20> ThomanWaldmann: Hi I am new to moin and I am working on some issues. I have a question: whom should I ask to review my code before issuing a PR ?
  18 2015-02-17T17:44:50  <vipul20> oh! sorry for writing your name wrong
  19 2015-02-17T17:44:58  <ayushjjwala> @ThomasWaldmann can u guide me as i am new..
  20 2015-02-17T17:44:58  <moinBot`> ayushjjwala: Error: "ThomasWaldmann" is not a valid command.
  21 2015-02-17T17:53:31  <ThomasWaldmann> vipul20: use tab completion :)
  22 2015-02-17T17:54:41  <ThomasWaldmann> i or rogerhaase or waldi or ajitesh can review code
  23 2015-02-17T17:55:20  <ThomasWaldmann> for beginners, there is a lot of information linked from https://moinmo.in/MoinMoin2.0
  24 2015-02-17T17:56:05  <ThomasWaldmann> (page itself, docs, issue tracker, repo, ...)
  25 2015-02-17T17:57:45  <vipul20> thanks :) yes I read that earlier and the docs are pretty good everything is so nicely explained. For a beginner like me, it is very helpful :)
  26 2015-02-17T17:59:43  <ThomasWaldmann> great to hear that :)
  27 2015-02-17T18:03:45  *** ayushjjwala has quit IRC
  28 2015-02-17T18:23:13  *** RogerHaase has joined #moin-dev
  29 2015-02-17T18:59:19  *** greg_f has quit IRC
  30 2015-02-17T19:27:19  *** RogerHaase has left #moin-dev
  31 2015-02-17T20:32:40  *** aabs08 has joined #moin-dev
  32 2015-02-17T20:34:17  *** aabs08 has quit IRC
  33 2015-02-17T20:34:50  *** aabs08 has joined #moin-dev
  34 2015-02-17T20:38:48  <aabs08> ThomasWaldmann,  ping
  35 2015-02-17T20:50:09  <ThomasWaldmann> aabs08: rather than ping, how about just saying what you want to say?
  36 2015-02-17T20:50:40  <aabs08> ThomasWaldmann,  okay will keep that in mind
  37 2015-02-17T20:51:31  <ThomasWaldmann> works much better. esp if async.
  38 2015-02-17T20:52:01  <aabs08> you asked  "is theme_supp.login_url still used somewhere?"  , by somewhere you meant only layout.html  or all files ?
  39 2015-02-17T20:52:17  <ThomasWaldmann> all
  40 2015-02-17T20:52:42  <aabs08> all files in MoinMoin/themes/basic/templates folder ?
  41 2015-02-17T20:53:00  <ThomasWaldmann> *all*
  42 2015-02-17T20:54:12  <aabs08> btw there is no logout_url method
  43 2015-02-17T20:54:22  <ThomasWaldmann> ok
  44 2015-02-17T20:56:13  <aabs08> I searched for all files and theme_supp.login_url() and variable login_url was only used in layout.html .
  45 2015-02-17T20:56:42  <ThomasWaldmann> ok, so if it is not used any more, you could remove the method also
  46 2015-02-17T20:57:01  <ThomasWaldmann> maybe first check what it does and afterwards try both basic and modernized.
  47 2015-02-17T21:00:53  <aabs08> there are two if conditions in login_url methods http://pastebin.com/w5mESgUe
  48 2015-02-17T21:02:26  <aabs08> which I am unable to understand
  49 2015-02-17T21:11:24  <ThomasWaldmann> well, obviously it results in different urls, not just the one you hardcoded in the template.
  50 2015-02-17T21:11:59  <ThomasWaldmann> and it depends on the login method used.
  51 2015-02-17T21:12:17  <ThomasWaldmann> there might be a normal username/password login,
  52 2015-02-17T21:13:07  <ThomasWaldmann> or a login that is handled by the web server (e.g. http basic auth with htpasswd) that does not require any form inputs from moin
  53 2015-02-17T21:14:54  <aabs08> okay , so in the other case we need to redirect?
  54 2015-02-17T21:15:05  <ThomasWaldmann> so, as it looks, you need that method and move the next=xxx logic to that method
  55 2015-02-17T21:16:38  <aabs08> ok got it :)
  56 2015-02-17T21:18:00  *** dave_largo has quit IRC
  57 2015-02-17T21:26:06  *** randomax has joined #moin-dev
  58 2015-02-17T22:58:07  <aabs08> ThomasWaldmann, codereview issue #483 and #482 https://codereview.appspot.com/194330043/
  59 2015-02-17T23:14:18  *** aabs08 has quit IRC
  60