1 2015-01-26T00:45:58 *** yogicxl
2 2015-01-26T00:58:23 <yogicxl> RogerHaase, I have removed the empty code block. Please review now https://codereview.appspot.com/195380043/
3 2015-01-26T05:54:50 *** randomax
4 2015-01-26T06:34:49 *** yogicxl
5 2015-01-26T07:50:24 *** Kallor
6 2015-01-26T09:11:02 *** yogicxl
7 2015-01-26T10:17:23 *** randomax
8 2015-01-26T10:23:41 *** greg_f
9 2015-01-26T10:29:34 *** randomax
10 2015-01-26T10:31:15 *** yogicxl
11 2015-01-26T10:49:19 *** greg_f
12 2015-01-26T10:51:38 *** pjoshi_
13 2015-01-26T10:59:02 *** greg_f
14 2015-01-26T11:04:52 *** Kallor
15 2015-01-26T11:22:21 *** pjoshi_
16 2015-01-26T12:44:42 *** dave_largo
17 2015-01-26T12:51:42 *** sunu
18 2015-01-26T12:51:58 *** sunu
19 2015-01-26T12:52:22 *** sunu
20 2015-01-26T12:52:51 *** yogicxl
21 2015-01-26T12:53:41 <yogicxl> ThomasWaldmann, could you please review my code for issue #463. Here is the link http://codereview.appspot.com/195380043
22 2015-01-26T13:39:50 *** grvanm
23 2015-01-26T14:57:30 <ThomasWaldmann> yogicxl: done
24 2015-01-26T15:51:07 *** Kallor
25 2015-01-26T15:57:36 *** Kallor
26 2015-01-26T16:49:11 *** randomax
27 2015-01-26T17:11:09 *** yogicxl
28 2015-01-26T17:12:25 *** yogicxl
29 2015-01-26T17:52:14 <yogicxl> ThomasWaldmann, could you please guide me on how to disable the forms and submission?
30 2015-01-26T17:56:00 *** grvanm
31 2015-01-26T17:56:33 *** bluebuck
32 2015-01-26T18:04:48 *** tanya_chuddhari
33 2015-01-26T18:11:05 *** SteveMcI1tyre
34 2015-01-26T18:11:56 *** tanya
35 2015-01-26T18:36:20 *** daredevil
36 2015-01-26T18:38:15 <ThomasWaldmann> yogicxl: in html, there is usually a disabled attribute for input fields
37 2015-01-26T18:39:51 <yogicxl> ThomasWaldmann, yes I know , my question is should i write it in naive html lines or create new macro in forms.html?
38 2015-01-26T18:40:56 <yogicxl> ThomasWaldmann, Because I am unable find any disabled attribute in these functions which are defined
39 2015-01-26T18:42:31 <ThomasWaldmann> guess you have to look that up
40 2015-01-26T18:46:38 <ThomasWaldmann> maybe there is some way with flatland, not sure
41 2015-01-26T18:46:58 <yogicxl> ThomasWaldmann, Is it ok if i define read-only in its css
42 2015-01-26T18:47:27 *** greg_f
43 2015-01-26T18:47:32 <yogicxl> ThomasWaldmann, Because that works.
44 2015-01-26T18:47:57 <ThomasWaldmann> hmm, not sure. better ask roger about css.
45 2015-01-26T18:49:02 <ThomasWaldmann> http://i.imgur.com/Q3cUg29.gif < me and css
46 2015-01-26T18:49:22 <yogicxl> ThomasWaldmann, ok, and about passing revision_id as argument in do_modify.. I ll need to change that in other files as well. Should i do that?
47 2015-01-26T18:49:43 <ThomasWaldmann> other files?
48 2015-01-26T18:49:47 <yogicxl> ThomasWaldmann, lol thats actually true
49 2015-01-26T18:50:24 <yogicxl> ThomasWaldmann, I mean in views.py, item/__init__.py
50 2015-01-26T18:50:57 <yogicxl> ThomasWaldmann, sry only views.py
51 2015-01-26T18:51:20 <ThomasWaldmann> in the CR, i just saw 1 place, but you maybe could use revid=CURRENT if the default was current up to now
52 2015-01-26T18:52:53 <yogicxl> ThomasWaldmann, ok
53 2015-01-26T18:59:49 <yogicxl> ThomasWaldmann, I think I have made the required changes, could you please review? http://codereview.appspot.com/195380043
54 2015-01-26T19:00:17 <ThomasWaldmann> did you run tests and review it yourself first?
55 2015-01-26T19:03:46 <yogicxl> ThomasWaldmann, yes
56 2015-01-26T19:07:35 * ThomasWaldmann looks ...
57 2015-01-26T19:09:32 *** pjoshi_
58 2015-01-26T19:11:04 <pjoshi_> ThomasWaldmann: Moin
59 2015-01-26T19:11:24 <pjoshi_> I pushed a request related to issue #455
60 2015-01-26T19:14:27 <ThomasWaldmann> codereview for that?
61 2015-01-26T19:14:52 <pjoshi_> https://codereview.appspot.com/139660043
62 2015-01-26T19:16:12 <ThomasWaldmann> oh, long going one :D
63 2015-01-26T19:16:28 <pjoshi_> haha.. yeah.
64 2015-01-26T19:16:55 <pjoshi_> I guess Finally its done
65 2015-01-26T19:18:26 <ThomasWaldmann> so, e.fullname is the full name of an item?
66 2015-01-26T19:20:30 <pjoshi_> fullname is the name of items with '\'
67 2015-01-26T19:21:25 *** yogicxl
68 2015-01-26T19:21:37 *** yogicxl
69 2015-01-26T19:22:41 <ThomasWaldmann> pjoshi_: you can't just use an itemname as href
70 2015-01-26T19:23:10 <ThomasWaldmann> href is ascii, item name is potentially arbitrary unicode
71 2015-01-26T19:23:18 <ThomasWaldmann> and that is just one of the problems
72 2015-01-26T19:25:37 <ThomasWaldmann> also, if you remove the #, it is not an anchor any more.
73 2015-01-26T19:25:54 * ThomasWaldmann didn't work with that part of the code recently
74 2015-01-26T19:26:09 <ThomasWaldmann> but my impression is that goals of that are rather unclear
75 2015-01-26T19:26:31 <yogicxl> ThomasWaldmann, yes style="input:read-only;" works
76 2015-01-26T19:27:07 <pjoshi_> ThomasWaldmann: Yeah I was not aware about the ascii and unicode part
77 2015-01-26T19:27:17 <pjoshi_> Still little bit confussed
78 2015-01-26T19:28:09 <ThomasWaldmann> pjoshi_: you need url_for for making urls from names
79 2015-01-26T19:28:33 <ThomasWaldmann> but maybe first find out what that part of the code should do before you fix it :)
80 2015-01-26T19:29:06 <ThomasWaldmann> yogicxl: it's a little dirty, though
81 2015-01-26T19:29:31 <ThomasWaldmann> imagine if you have a browser with disabled css (or which does not implement css)
82 2015-01-26T19:30:20 <yogicxl> ThomasWaldmann, Ok, Could you please guide me how to proceed?
83 2015-01-26T19:31:01 <pjoshi_> ThomasWaldmann: So you are telling that I have to use url_for for correcting the url, right ?
84 2015-01-26T19:31:20 <pjoshi_> As direct refering names to the url is not appropriate
85 2015-01-26T19:32:33 <ThomasWaldmann> can you explain what the goal of your change is?
86 2015-01-26T19:34:08 <yogicxl> ThomasWaldmann, are you asking me?
87 2015-01-26T19:34:31 <ThomasWaldmann> no, that was for pjoshi_
88 2015-01-26T19:35:02 <pjoshi_> ThomasWaldmann: I just did what is required for the bug
89 2015-01-26T19:35:07 <yogicxl> ThomasWaldmann, ok
90 2015-01-26T19:35:24 <pjoshi_> as to get correct url for the click on the sign
91 2015-01-26T19:35:42 <ThomasWaldmann> so what is the correct url?
92 2015-01-26T19:35:52 <ThomasWaldmann> yogicxl: i gave some feedback on CR
93 2015-01-26T19:36:23 <pjoshi_> ThomasWaldmann: something like that "http://localhost:8080/+index/OtherTextItems"
94 2015-01-26T19:36:39 <pjoshi_> as the global index url is "http://localhost:8080/+index"
95 2015-01-26T19:36:54 <ThomasWaldmann> pjoshi_: ok, if you want that, use url_for()
96 2015-01-26T19:37:06 <pjoshi_> and when we click on the sign we should get http://localhost:8080/+index/OtherTextItems
97 2015-01-26T19:37:37 <ThomasWaldmann> (and remove the stuff that talk about anchor as it is none)
98 2015-01-26T19:38:06 <ThomasWaldmann> (obviously this code had other goals before)
99 2015-01-26T19:38:22 <pjoshi_> oh.. Will you tell me those
100 2015-01-26T19:38:28 <yogicxl> ThomasWaldmann, What should i name the variable carry the template?
101 2015-01-26T19:38:36 <yogicxl> carrying*
102 2015-01-26T19:39:04 <pjoshi_> as I was just working according to the issue tracker
103 2015-01-26T19:40:30 <pjoshi_> ThomasWaldmann: I guess I am not sure about the other goals of the code ?
104 2015-01-26T19:40:57 <pjoshi_> and previously we had two signs one for up and one for down so we had code according to that
105 2015-01-26T19:41:30 <pjoshi_> But when I just start working again after a break I saw a lot of changes in code also
106 2015-01-26T19:42:21 <ThomasWaldmann> pjoshi_: i didn't say that old goals were new goals, so just use url_for but with correct target and remove stuff there that talks about anchor if it is not an anchor.
107 2015-01-26T19:43:12 <ThomasWaldmann> yogicxl: is it named pass_template because you pass the template into render?
108 2015-01-26T19:43:29 <yogicxl> ThomasWaldmann, yup.
109 2015-01-26T19:43:48 <ThomasWaldmann> how about just template? variables use to get passed, somewhere. :)
110 2015-01-26T19:44:07 <pjoshi_> ThomasWaldmann: Okay.. Will do that
111 2015-01-26T19:44:15 <yogicxl> ThomasWaldmann, ok, making the change.
112 2015-01-26T19:46:53 <yogicxl> ThomasWaldmann, what should i do about the style="input:read-only;"
113 2015-01-26T19:49:03 <ThomasWaldmann> yogicxl: well, keep it for now and let roger have a look.
114 2015-01-26T19:49:22 <ThomasWaldmann> i am not sure if there is an easy way involving flatland/form rendering.
115 2015-01-26T19:49:33 <ThomasWaldmann> jek__: ^^
116 2015-01-26T19:50:11 <yogicxl> ThomasWaldmann, ok then.. I ll put it for review.
117 2015-01-26T19:52:07 <yogicxl> ThomasWaldmann, could you please review the other changes? http://codereview.appspot.com/195380043
118 2015-01-26T20:09:21 <ThomasWaldmann> yogicxl: done
119 2015-01-26T20:15:27 *** pjoshi_
120 2015-01-26T20:33:48 <yogicxl> ThomasWaldmann, I dont think any other code is calling do_modify. I checked for this using grep -rn... Could you provide a better way
121 2015-01-26T20:33:49 <yogicxl> ?
122 2015-01-26T20:35:30 <ThomasWaldmann> i am pretty sure do_modify is not only called by do_show
123 2015-01-26T20:35:46 <ThomasWaldmann> because they are usually rather different
124 2015-01-26T20:36:15 <ThomasWaldmann> i usually use pycharm, it has nice indexed search
125 2015-01-26T20:38:23 <yogicxl> ThomasWaldmann, ok i ll look into it.
126 2015-01-26T20:41:40 <yogicxl> ThomasWaldmann, do_modify is only called in apps/frontend/views.py with line items.do_modify
127 2015-01-26T20:43:32 *** dave_largo
128 2015-01-26T20:53:08 <yogicxl> ThomasWaldmann, I think it will be easier if revid is kept as ticket class variable, else it will require many changes.
129 2015-01-26T21:05:43 <yogicxl> ThomasWaldmann, How much time does it usually take to run ./m tests ?
130 2015-01-26T21:21:07 <yogicxl> ThomasWaldmann, please review https://codereview.appspot.com/195380043/
131 2015-01-26T21:21:27 <yogicxl> RogerHaase, please review
132 2015-01-26T21:21:50 <yogicxl> RogerHaase, https://codereview.appspot.com/195380043/
133 2015-01-26T21:31:33 *** yogicxl
134
