1 2014-10-18T10:44:39 *** greg_f
2 2014-10-18T14:53:31 *** RogerHaase
3 2014-10-18T14:59:13 *** RogerHaase
4 2014-10-18T15:32:59 *** RogerHaase
5 2014-10-18T17:35:46 *** greg_f
6 2014-10-18T19:54:05 <RogerHaase> ThomasWaldmann: replace broken, inconsistent Global History theme icons with font awesome https://codereview.appspot.com/158860049/
7 2014-10-18T19:57:52 * ThomasWaldmann just added a Python "assembly" for 31c3 (CCC congress) + MoinMoin as project
8 2014-10-18T20:05:33 <ThomasWaldmann> RogerHaase: review done
9 2014-10-18T20:19:54 <RogerHaase> ThomasWaldmann: you want a new issue saying modernized theme has no revert icon?
10 2014-10-18T20:20:52 <RogerHaase> the removed icons are not used anywhere else
11 2014-10-18T20:21:27 <ThomasWaldmann> RogerHaase: would be good, noone will read codereview comments later...
12 2014-10-18T20:21:46 <RogerHaase> ok
13 2014-10-18T20:22:15 * ThomasWaldmann runs unit tests on current code
14 2014-10-18T20:27:57 <ThomasWaldmann> RogerHaase: do you have lxml installed and if yes, how many test fails do you get?
15 2014-10-18T20:31:12 <RogerHaase> I do not have lxml installed, iirc it does not install easily on windows, will try to install
16 2014-10-18T20:33:52 <ThomasWaldmann> yeah, it is a pita :|
17 2014-10-18T20:39:30 <ThomasWaldmann> ok, no fails without lxml (as it skips these tests then)
18 2014-10-18T20:57:57 <RogerHaase> ThomasWaldmann: lxml installs in main python directory, but fails in virtualenv https://paste.thinkmo.de/rvm9FpuX so I copied over the site-packages lxml directory from the main python to my venv, end result is ====== 22 failed, 1537 passed, 337 skipped, 1 xfailed in 376.96 seconds =======
19 2014-10-18T21:00:21 <RogerHaase> without lxml ================== 1590 passed, 57 skipped in 351.07 seconds ==================
20 2014-10-18T21:23:34 *** RogerHaase
21
MoinMoin: MoinMoinChat/Logs/moin-dev/2014-10-18 (last edited 2014-10-18 10:45:02 by IrcLogImporter)