MoinMoin: MoinMoinChat/Logs/moin-dev/2014-09-09

   1 2014-09-09T03:33:13  *** dimazest_ has joined #moin-dev
   2 2014-09-09T03:35:34  *** ananasov1 has joined #moin-dev
   3 2014-09-09T03:35:46  *** eSyr-ng_ has joined #moin-dev
   4 2014-09-09T03:40:44  *** ananasova has quit IRC
   5 2014-09-09T03:40:45  *** eSyr-ng has quit IRC
   6 2014-09-09T03:40:55  *** jhermann has quit IRC
   7 2014-09-09T03:41:12  *** dimazest has quit IRC
   8 2014-09-09T03:41:28  *** dimazest_ is now known as dimazest
   9 2014-09-09T03:45:52  *** jhermann has joined #moin-dev
  10 2014-09-09T08:07:33  *** sharky93 has joined #moin-dev
  11 2014-09-09T08:34:18  *** greg_f has joined #moin-dev
  12 2014-09-09T08:40:29  *** moinBot has joined #moin-dev
  13 2014-09-09T08:48:23  *** xorAxAx has quit IRC
  14 2014-09-09T08:48:36  *** ThomasWaldmann has quit IRC
  15 2014-09-09T08:54:11  *** xorAxAx has joined #moin-dev
  16 2014-09-09T09:01:11  *** ThomasWaldmann has joined #moin-dev
  17 2014-09-09T11:30:48  *** eSyr has quit IRC
  18 2014-09-09T11:31:46  *** eSyr has joined #moin-dev
  19 2014-09-09T12:12:49  <ThomasWaldmann> moin
  20 2014-09-09T12:50:39  *** ananasova has joined #moin-dev
  21 2014-09-09T15:01:52  *** RogerHaase has joined #moin-dev
  22 2014-09-09T16:22:20  <RogerHaase> ThomasWaldmann: reverting deleted item, added prior name to view https://codereview.appspot.com/133810044/
  23 2014-09-09T16:32:03  <ThomasWaldmann> moin RogerHaase
  24 2014-09-09T16:35:41  <RogerHaase> moin
  25 2014-09-09T16:38:04  <ThomasWaldmann> RogerHaase: hmm, does this link using the name work if the name is not there in current rev?
  26 2014-09-09T16:38:21  <ThomasWaldmann> iirc the usual lookup is just using the latest item revs
  27 2014-09-09T16:41:11  <RogerHaase> fixing the Name_Exact bug opened a problem when viewing the history of deleted items - only Item ID was shown, So there was no way to revert the item. (There is yet another bug not being fixed here, if you revert an Item ID the ID is converted to a name.)
  28 2014-09-09T16:42:46  <RogerHaase> Currently, if you delete an item, you get a new nameless revision that cannot be reverted, only the prior named item can be reverted.
  29 2014-09-09T16:43:32  <RogerHaase> actually any prior version that has a name can be reverted
  30 2014-09-09T16:46:21  <ThomasWaldmann> url_for_item(name, n amespace=fqname.namespace, endpoint='frontend.history')
  31 2014-09-09T16:46:48  <ThomasWaldmann> so you think that works if name is not in the latest rev?
  32 2014-09-09T16:48:14  <RogerHaase> yes
  33 2014-09-09T16:49:20  <ThomasWaldmann> ah, i guess it likely looks up all revs of that name in all_revs index
  34 2014-09-09T16:51:42  <RogerHaase> here I deleted and reverted several times https://paste.thinkmo.de/iib73k3n#ScreenShot.png
  35 2014-09-09T16:55:26  <ThomasWaldmann> ok
  36 2014-09-09T16:55:36  <ThomasWaldmann> changeset looks valid
  37 2014-09-09T16:56:05  <ThomasWaldmann> the visuals seen on the screenshot need fine tweaking still
  38 2014-09-09T16:58:43  <RogerHaase> yes, I was thinking the history view needs several changes and we could use the current basic view for both themes after a few changes.  Will open an issue with some ideas so you can comment on them later today
  39 2014-09-09T17:16:16  *** sunu has joined #moin-dev
  40 2014-09-09T17:54:09  *** greg_f has quit IRC
  41 2014-09-09T20:44:16  *** sharky93_ has joined #moin-dev
  42 2014-09-09T22:07:31  *** RogerHaase has left #moin-dev
  43