1 2014-08-18T11:28:37 *** skathpalia
2 2014-08-18T11:33:22 *** randomax
3 2014-08-18T11:42:26 *** greg_f
4 2014-08-18T11:45:28 *** magu_cic_
5 2014-08-18T11:48:25 *** magu_cic
6 2014-08-18T11:51:54 <ThomasWaldmann> moin
7 2014-08-18T11:55:23 <skathpalia> moin
8 2014-08-18T11:58:36 <randomax> moin
9 2014-08-18T12:00:02 <ThomasWaldmann> skathpalia: randomax: please pull/merge from main repo
10 2014-08-18T12:01:12 <randomax> ok
11 2014-08-18T12:18:19 <ThomasWaldmann> http://localhost:8080/+meta/Home - some lists there are comma separated, some not. the comma separated ones have space on the left side of the comma and a comma at the end of the list, which is both incorrect.
12 2014-08-18T12:23:17 <ThomasWaldmann> if one is on "Home" item and just clicks through the action bar (show, history, modify, ...), one sees that the views use different sizes for their content-area main headlines
13 2014-08-18T12:24:22 <ThomasWaldmann> index, sitemap, similar items use bigger headlines than the others
14 2014-08-18T12:25:31 <ThomasWaldmann> (this is all on basic theme, in case it matters)
15 2014-08-18T12:26:01 <ThomasWaldmann> modify view still have the login link not right-aligned
16 2014-08-18T12:26:06 <ThomasWaldmann> has*
17 2014-08-18T12:26:55 <ThomasWaldmann> randomax: ^
18 2014-08-18T12:28:01 <randomax> ok i'll look into it
19 2014-08-18T12:30:21 <ThomasWaldmann> randomax: if one uses the jinja2 join filter, the trailing comma shouldn't happen
20 2014-08-18T12:31:05 <ThomasWaldmann> and if you put the </a> directly after the text, the space vanishes I guess
21 2014-08-18T12:31:31 <ThomasWaldmann> or use that space eating modifier of jinja2
22 2014-08-18T12:31:52 <ThomasWaldmann> skathpalia: meta on right looks better
23 2014-08-18T12:32:10 <randomax> ThomasWaldmann, yes i'll do that
24 2014-08-18T12:33:54 <ThomasWaldmann> skathpalia: the textarea below "Message" on the ticket creation view, can it fill 100% (or near 100%) of the width of the left part?
25 2014-08-18T12:34:05 <randomax> ThomasWaldmann, fixed the floating of footer onto content at small resolutions in basic theme - https://codereview.appspot.com/127450043
26 2014-08-18T12:35:13 <ThomasWaldmann> skathpalia: and the submit button, can it be either right below the textarea (with the textarea height being as it is now) or can the textarea height extend so it fills the space up to the button?
27 2014-08-18T12:38:46 <ThomasWaldmann> skathpalia: if there would be some visual difference between "... wrote on ..." and the text written, it would look better. on the search results, there is iirc some nice style that differentiates metadata from highlighted results, maybe it can be re-used.
28 2014-08-18T12:42:53 <ThomasWaldmann> with "right below" I meant "directly below" (not necessarily on the righthand side)
29 2014-08-18T12:44:20 <ThomasWaldmann> skathpalia: the ticket list header looks much better now. except for the tags column, which still has the space reserved for the sort-updown-control although it is not used there
30 2014-08-18T12:47:02 <ThomasWaldmann> randomax: not sure what you are fixing there
31 2014-08-18T12:47:33 <randomax> the footer comes up to the top when the viewport is small
32 2014-08-18T12:47:54 <randomax> top meaning top of the page
33 2014-08-18T12:48:01 <randomax> the cr fixes that
34 2014-08-18T12:48:56 <ThomasWaldmann> ok. for css feedback rather ask roger, I am bad at reviewing such stuff.
35 2014-08-18T12:49:06 <ThomasWaldmann> skathpalia: Tip: Sort multiple columns simultaneously by holding down the Shift key and clicking a second, third or even fourth column header!
36 2014-08-18T12:49:53 <ThomasWaldmann> maybe "... and clicking on additional column headers!"
37 2014-08-18T12:52:01 <randomax> ok
38 2014-08-18T12:55:24 <ThomasWaldmann> skathpalia: can the vspacing of the metadata on ticket view be made a bit more consistent? sometimes there is different amount of vspace between items. sometimes there is more vspace between stuff that belongs together (label+field) than between stuff that does not belong together (field + next label).
39 2014-08-18T12:55:35 <randomax> Also regarding "if one is on "Home" item and just clicks through the action bar (show, history, modify, ...), one sees that the views use different sizes for their content-area main headlines"
40 2014-08-18T12:55:56 <randomax> i do not see them using different sizes of content or headings
41 2014-08-18T12:56:23 <randomax> *sorry different sizes of content
42 2014-08-18T12:57:34 <ThomasWaldmann> well, it's quite clearly visible here
43 2014-08-18T12:57:55 <ThomasWaldmann> and i mean the topmost heading of content area
44 2014-08-18T12:58:25 <randomax> Yeah heading i agree
45 2014-08-18T12:58:47 <randomax> but the content area is the same
46 2014-08-18T12:58:59 <ThomasWaldmann> h1 vs h2
47 2014-08-18T12:59:09 <randomax> yeah i'll fix the heading
48 2014-08-18T13:00:00 <ThomasWaldmann> (make sure the other headings, if any, are adjusted too, if needed)
49 2014-08-18T13:04:27 <ThomasWaldmann> about the wrong position of "login" link on modify view: the same issue was already solved on +tickets view
50 2014-08-18T13:07:43 *** dave_largo
51 2014-08-18T13:07:47 <ThomasWaldmann> randomax: that disk icon with (./) and (x) look somehow too similar. aside from that, younger people might not know diskettes any more.
52 2014-08-18T13:08:13 <ThomasWaldmann> (on +history view) - also there is no mouseover title that explains the icon
53 2014-08-18T13:15:08 <randomax> ThomasWaldmann, ok so should i change the icons or add a tooltip ?
54 2014-08-18T13:31:37 *** magu_cic_
55 2014-08-18T13:43:37 <skathpalia> ThomasWaldmann, sorry was offline, looking at your comments
56 2014-08-18T14:06:59 *** vpv_
57 2014-08-18T14:11:33 *** penguinRaider
58 2014-08-18T14:11:41 *** randomax
59 2014-08-18T14:11:59 *** vpv
60 2014-08-18T14:12:21 *** skathpalia
61 2014-08-18T14:16:09 *** penguinRaider
62 2014-08-18T14:16:10 *** skathpalia
63 2014-08-18T14:17:34 *** randomax
64 2014-08-18T14:18:47 *** RogerHaase
65 2014-08-18T14:34:14 *** randomax_
66 2014-08-18T14:34:21 <randomax_> RogerHaase, fixed floating footer - https://codereview.appspot.com/127450043
67 2014-08-18T14:34:30 *** randomax
68 2014-08-18T14:35:24 *** randomax_
69 2014-08-18T14:42:54 <RogerHaase> randomax: looks ok, commit
70 2014-08-18T14:43:11 <skathpalia> ThomasWaldmann, updated the cr https://codereview.appspot.com/128030043/
71 2014-08-18T14:43:33 <skathpalia> Removed the unnecessary line-height
72 2014-08-18T14:45:26 <randomax> ok
73 2014-08-18T15:01:40 <RogerHaase> skathpalia: I would call that a trivial change, per last meeting commit it
74 2014-08-18T15:02:01 <skathpalia> Ok committing it :)
75 2014-08-18T16:02:50 <randomax> RogerHaase, updated blog http://ajiteshg.blogspot.in/
76 2014-08-18T16:15:04 <skathpalia> RogerHaase, added a blog post http://sksaurabhkathpalia.blogspot.in/
77 2014-08-18T16:21:23 <skathpalia> dimazest ^^
78 2014-08-18T16:23:16 <dimazest> cool, great work
79 2014-08-18T16:24:58 <skathpalia> thanks :)
80 2014-08-18T16:43:35 <RogerHaase> randomax: nice blog (fix duplicated paragraph at end)
81 2014-08-18T16:44:12 <randomax> ok :)
82 2014-08-18T16:55:37 *** randomax
83 2014-08-18T16:58:12 *** randomax
84 2014-08-18T18:02:56 *** greg_f
85 2014-08-18T18:47:51 <ThomasWaldmann> final minutes of gsoc coding...
86 2014-08-18T18:50:44 <ThomasWaldmann> randomax: skathpalia: if you like, you can do a final pull/merge from main repo (as far as gsoc is concerned)
87 2014-08-18T18:51:39 <skathpalia> done :)
88 2014-08-18T19:41:23 <randomax> done
89 2014-08-18T19:58:23 *** penguinRaider
90 2014-08-18T19:59:10 *** penguinRaider
91 2014-08-18T20:25:08 <ThomasWaldmann> skathpalia: randomax: see the GoogleSoc2014 wiki page
92 2014-08-18T20:25:35 <ThomasWaldmann> please check if the changeset i have identified as "start-of-summer-of-code" is the right one
93 2014-08-18T20:26:42 <ThomasWaldmann> (check what is the parent-changeset of your first gsoc-coding-phase change)
94 2014-08-18T20:27:28 <randomax> ok
95 2014-08-18T20:29:49 <randomax> yes i guess its correct
96 2014-08-18T20:48:50 *** randomax
97 2014-08-18T21:03:13 <skathpalia> yeah
98 2014-08-18T21:07:46 *** dave_largo
99 2014-08-18T21:15:19 *** skathpalia
100 2014-08-18T21:50:08 *** RogerHaase
101
