1 2014-08-16T02:44:14 *** penguinRaider
2 2014-08-16T03:13:41 *** penguinRaider
3 2014-08-16T08:11:18 *** randomax
4 2014-08-16T08:43:54 *** penguinRaider
5 2014-08-16T08:44:32 *** penguinRaider
6 2014-08-16T09:27:26 *** skathpalia
7 2014-08-16T09:51:23 *** greg_f
8 2014-08-16T09:51:54 *** greg_f
9 2014-08-16T09:56:22 *** skathpalia
10 2014-08-16T10:44:08 *** randomax
11 2014-08-16T11:04:21 *** skathpalia
12 2014-08-16T11:50:02 *** randomax
13 2014-08-16T12:00:14 *** greg_f
14 2014-08-16T12:24:01 *** sl33k_
15 2014-08-16T13:56:07 *** sl33k_
16 2014-08-16T14:32:08 *** RogerHaase
17 2014-08-16T14:35:32 <skathpalia> RogerHaase, Made ticket-create button working with a workaround https://codereview.appspot.com/129250043/
18 2014-08-16T14:44:18 <RogerHaase> skathpalia: works OK
19 2014-08-16T14:45:49 <skathpalia> RogerHaase, Can I commit it?
20 2014-08-16T14:46:25 <RogerHaase> ok by me; dimazest and ThomasWaldmann are not around?
21 2014-08-16T14:46:58 <dimazest> i'm not sure whether using a timestamp is a good solution
22 2014-08-16T14:47:03 <dimazest> but i'm not sure
23 2014-08-16T14:47:16 <dimazest> uuid looks more appropriate
24 2014-08-16T14:48:06 * ThomasWaldmann just merged the PRs. skathpalia and randomax please pull/merge from main repo.
25 2014-08-16T14:49:24 <randomax> ok
26 2014-08-16T14:49:32 <RogerHaase> dimazest: we need a Create Ticket button to make the ticket UI usable. The code change is marked workaround. Whenever a nameless item can be created, the code should be changed
27 2014-08-16T14:49:57 <dimazest> then it's fine, i guess
28 2014-08-16T14:51:04 <skathpalia> RogerHaase, dimazest Can I commit it then?
29 2014-08-16T14:51:17 <dimazest> yeap
30 2014-08-16T14:51:40 <skathpalia> Ok committing it :)
31 2014-08-16T14:54:45 * ThomasWaldmann needs to look at committed code to prepare meeting, so CRs from me after meeting please.
32 2014-08-16T14:56:20 <randomax> RogerHaase, i think issue 444 - https://bitbucket.org/thomaswaldmann/moin-2.0/issue/444/traceback-on-trying-to-access-item-which
33 2014-08-16T14:56:28 <randomax> got fixed mysteriously
34 2014-08-16T14:56:35 <randomax> cant seem to recreate it now
35 2014-08-16T15:00:48 <RogerHaase> randomax: I also cannot recreate the problem; so just close the issue
36 2014-08-16T15:01:02 <randomax> ok
37 2014-08-16T15:05:29 <skathpalia> ThomasWaldmann, Now #326 and #321 can be closed
38 2014-08-16T15:05:33 <ThomasWaldmann> skathpalia: https://codereview.appspot.com/122940043/
39 2014-08-16T15:08:02 <ThomasWaldmann> randomax: skathpalia: RogerHaase: dimazest: if issues need to be closed (and you can't do it by yourself), can you just link to them on https://moinmo.in/ThomasWaldmann/IssuesToBeClosed (and if you have the cs URL of the fix at hand, please give it there also)
40 2014-08-16T15:09:33 <skathpalia> Ok
41 2014-08-16T15:10:50 <ThomasWaldmann> btw, aside from the CR 122940043, cr site doesn't show me any open ones, so I guess they were resolved by dimazest and roger meanwhile.
42 2014-08-16T15:11:18 <skathpalia> yeah
43 2014-08-16T15:11:19 <randomax> yeah all of mine were resolved
44 2014-08-16T15:13:01 <ThomasWaldmann> great :)
45 2014-08-16T15:13:26 <ThomasWaldmann> RogerHaase: see query
46 2014-08-16T15:22:22 <skathpalia> RogerHaase, Now clicking on open, closed, all buttons clears search field and selected tags https://codereview.appspot.com/130150043
47 2014-08-16T15:26:19 <skathpalia> dimazest, updated the above cr
48 2014-08-16T15:35:34 <dimazest> ok
49 2014-08-16T15:36:18 <skathpalia> Can I commit it?
50 2014-08-16T15:38:30 <skathpalia> dimazest, ^^
51 2014-08-16T15:38:43 <dimazest> yes
52 2014-08-16T15:41:21 <skathpalia> ThomasWaldmann, I also have one more pending cr https://codereview.appspot.com/128030043/
53 2014-08-16T15:42:26 <ThomasWaldmann> did you add me as reviewer there, cr does not show it as open
54 2014-08-16T15:43:54 <skathpalia> Actually only there is reviewed only by RogerHaase it doesn't come up in your list of crs
55 2014-08-16T15:46:29 <ThomasWaldmann> it does not even show up in that list after i added a comment, although it added me as a reviewer then.
56 2014-08-16T15:46:55 <ThomasWaldmann> skathpalia: randomax: so if you have open reviews, add them to the same wiki page as the issues to be closed
57 2014-08-16T15:49:20 <RogerHaase> skathpalia: after you create the cr, you can add reviewers by clicking on the Publish & Mail Comments link and adding reviewers - thomas.j.<tab>
58 2014-08-16T16:01:48 <ThomasWaldmann> ok, meeting time
59 2014-08-16T16:02:02 <ThomasWaldmann> randomax: can you begin?
60 2014-08-16T16:02:10 <RogerHaase> randomax: by clicking on your user name link, I show 7 open crs https://codereview.appspot.com/user/sksaurabhkathpalia
61 2014-08-16T16:03:20 <randomax> yes
62 2014-08-16T16:03:52 <randomax> RogerHaase, didnt get you
63 2014-08-16T16:04:15 <randomax> Done
64 2014-08-16T16:04:26 <randomax> Committed the cr for - Added capability to edit acl string in item acl report view itself
65 2014-08-16T16:04:30 <skathpalia> randomax, RogerHaase thats my list of crs
66 2014-08-16T16:04:31 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/63267bfa90997342601cfe490637781af7bd78d9
67 2014-08-16T16:04:51 <randomax> Fixed the invisible links in meta view in basic theme
68 2014-08-16T16:04:55 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/3cf58438633e081b43acea0fc3edff633269eeb5
69 2014-08-16T16:05:00 <randomax> Replaced important hex color values with variables in basic theme's theme.less
70 2014-08-16T16:05:04 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/32ab08637a4e2c4c3924effddbd0ee4aa0e60543
71 2014-08-16T16:05:12 <randomax> Added css for smileys in basic theme
72 2014-08-16T16:05:23 <randomax> Fixed quicklinks and their tooltips
73 2014-08-16T16:05:31 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/b8680cd6cf9195643329f7a3d65eb3c734d012d0
74 2014-08-16T16:05:44 <randomax> Fixed issue #454
75 2014-08-16T16:05:48 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/a6c76ccde0111dd5b959bfe29fe839fb8548b31e
76 2014-08-16T16:05:57 <randomax> Fixes issue #451
77 2014-08-16T16:06:08 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/c7fe669a6c5c45b3e7a46637bd6287c5216048fa
78 2014-08-16T16:06:38 <randomax> Fixed failing modify view
79 2014-08-16T16:06:43 <randomax> https://bitbucket.org/thomaswaldmann/moin-2.0/commits/ebc41545962add2f3ca3c0156f5bda38f6de2914
80 2014-08-16T16:07:15 <ThomasWaldmann> quite a lot of activity :)
81 2014-08-16T16:07:28 <randomax> :)
82 2014-08-16T16:08:11 <randomax> my work on custom css was cancelled so thought i should compensate by doing some other work
83 2014-08-16T16:08:28 <ThomasWaldmann> i have prepared some click-through feedback for both projects
84 2014-08-16T16:09:05 <ThomasWaldmann> will post it to a pastebin soon, so you can check overlap with your project plans
85 2014-08-16T16:09:46 <randomax> ok
86 2014-08-16T16:11:47 <RogerHaase> anything left to do for your project?
87 2014-08-16T16:12:11 <randomax> No
88 2014-08-16T16:12:14 <ThomasWaldmann> https://paste.thinkmo.de/7d90a912-790b-4cfb-8447-dd4b7bc3e6f2
89 2014-08-16T16:12:46 <ThomasWaldmann> these are my notes from last hour, I just did a click-through and noted all stuff i noted :)
90 2014-08-16T16:13:24 <ThomasWaldmann> i didn't check the overlap with both project plans, but most stuff is about UI issues, so it might apply
91 2014-08-16T16:14:29 <ThomasWaldmann> and I only had time for modernized theme yet, basic theme is TODO still
92 2014-08-16T16:15:55 <ThomasWaldmann> randomax: skathpalia: so maybe if you run out of other todo, you could pick the easy-to-fix stuff from there
93 2014-08-16T16:16:03 <randomax> Ok.. i'll work on those issues
94 2014-08-16T16:16:05 <skathpalia> Ok
95 2014-08-16T16:19:17 <ThomasWaldmann> ok, any questions/comments for/from randomax ?
96 2014-08-16T16:19:24 <randomax> nope
97 2014-08-16T16:19:29 <RogerHaase> btw, that custom css works now if you create a text item with css, then modify content type to test/css, then add ~http://localhost:8080/+get/MyCss to User CSS URL in Settings > Appearance
98 2014-08-16T16:19:48 <RogerHaase> test/css s/b text/css
99 2014-08-16T16:20:52 <randomax> ohh
100 2014-08-16T16:20:59 <ThomasWaldmann> hopefully noone will trick users into using that "great new css" for themselves that might have some evil js inside X)
101 2014-08-16T16:21:01 <RogerHaase> no other questions here
102 2014-08-16T16:22:11 <ThomasWaldmann> randomax: maybe c&p the stuff from pastebin to your etherpad and remove everything that is not in scope
103 2014-08-16T16:22:32 <randomax> ok
104 2014-08-16T16:23:00 <ThomasWaldmann> ok, thanks randomax, skathpalia is next
105 2014-08-16T16:23:09 <skathpalia> Ok
106 2014-08-16T16:23:14 <skathpalia> Done:
107 2014-08-16T16:23:20 <skathpalia> Now user is redirected to updated ticket on clicking ticket update button in ticket modify view.
108 2014-08-16T16:23:34 <skathpalia> https://codereview.appspot.com/126300043/
109 2014-08-16T16:23:38 <skathpalia> https://codereview.appspot.com/123340043/
110 2014-08-16T16:23:43 <skathpalia> Added link to depends_on and superseded_by in ticket modify view
111 2014-08-16T16:23:47 <skathpalia> https://codereview.appspot.com/129060043/
112 2014-08-16T16:23:55 <skathpalia> Now user can check issues assigned to a particular user by http://127.0.0.1:8080/+tickets?assigned_to=NAME
113 2014-08-16T16:24:00 <skathpalia> https://codereview.appspot.com/127240043/
114 2014-08-16T16:24:06 <skathpalia> Now user sees unscubscribe link in blog view if he is subscribed to that blog in modernized theme
115 2014-08-16T16:24:11 <skathpalia> https://codereview.appspot.com/127900043/
116 2014-08-16T16:24:17 <skathpalia> Fixed https://bitbucket.org/saurabh_k/moin-2.0/issue/3/ticket-sort-only-displays-only-open Now on clicking on sort button in +tickets view only tickets relevant to the filters are shown
117 2014-08-16T16:24:21 <skathpalia> https://codereview.appspot.com/125180043/
118 2014-08-16T16:24:28 <skathpalia> Moved login link to right in +tickets view, increased spacing in EDSP, removed extra padding in the table headers
119 2014-08-16T16:24:34 <skathpalia> https://codereview.appspot.com/127850043/
120 2014-08-16T16:24:42 <skathpalia> Made ticket-create button working with a workaround
121 2014-08-16T16:24:42 <ThomasWaldmann> (one last general comment maybe for both projects: if an issue is identified for one theme, it is always a good idea to check/fix it also in the other theme. modernized/basic, foobar can be ignored i guess)
122 2014-08-16T16:24:51 <skathpalia> https://codereview.appspot.com/129250043/
123 2014-08-16T16:25:13 <skathpalia> Ok
124 2014-08-16T16:25:15 <skathpalia> Now clicking on open, closed and all buttons clears search field and selected tags
125 2014-08-16T16:25:20 <skathpalia> https://codereview.appspot.com/130150043/
126 2014-08-16T16:25:25 <skathpalia> All the above stuff is committed
127 2014-08-16T16:25:30 <skathpalia> Removed ticket.styl and improved format of ticket.css
128 2014-08-16T16:25:35 <skathpalia> https://codereview.appspot.com/128030043/
129 2014-08-16T16:25:40 <skathpalia> BLocked: None
130 2014-08-16T16:25:57 <skathpalia> TODO:
131 2014-08-16T16:26:17 <skathpalia> Define UI for checking tickets assigned to a particular user
132 2014-08-16T16:26:22 <skathpalia> Try to fix issues mentioned in the feedback
133 2014-08-16T16:27:25 <ThomasWaldmann> maybe one thing that is also on my pastebin: what do you all think about this layout for tickets:
134 2014-08-16T16:28:03 <ThomasWaldmann> left: ticket text / comments (60..75%) right: metadata (remaining space)
135 2014-08-16T16:28:20 <ThomasWaldmann> currently it is the opposite way and rather 50/50 which looks a bit strange
136 2014-08-16T16:28:38 <skathpalia> I feel the current one is good, but I will try to change as mentioned above and create screenshots for bot so that it is easy to judge which one is better
137 2014-08-16T16:29:09 <ThomasWaldmann> rationale is that the ticket text is most important and should come first (left for ltr languages)
138 2014-08-16T16:30:35 <RogerHaase> there was brief discussion of adding Assigned User column to ticket table
139 2014-08-16T16:30:47 <ThomasWaldmann> https://github.com/bepasty/bepasty-server/issues/107 see there also: text left, other stuff: smaller column at right
140 2014-08-16T16:31:36 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/450/changes-to-user-settings-easily-lost-when same there :)
141 2014-08-16T16:31:43 *** sl33k_
142 2014-08-16T16:31:49 <ThomasWaldmann> so maybe it is just what I am used to :D
143 2014-08-16T16:31:57 <skathpalia> ThomasWaldmann, will make it that way :)
144 2014-08-16T16:32:34 <skathpalia> RogerHaase, I got an idea regarding showing assigned_to users in the ticket list
145 2014-08-16T16:33:35 <ThomasWaldmann> i also found an issue for that sort button rendering, see pastebin
146 2014-08-16T16:33:50 <skathpalia> First we can fetch all the users and then we can match the itemid of fetched users and the itemids given in assigned_to of all tickets
147 2014-08-16T16:34:16 <skathpalia> This way we will have to run only one extra query for adding assigned_to field in table
148 2014-08-16T16:35:02 <ThomasWaldmann> be a little careful with "fetch all users". there are sites that have 10000.
149 2014-08-16T16:35:22 <dimazest> it worth doing this on the server side
150 2014-08-16T16:35:33 <ThomasWaldmann> it's not as bad as with moin 1.x any more as we have an index now, but still: think first :)
151 2014-08-16T16:35:50 <RogerHaase> I think the assigned_to is an important column to have in the ticket table
152 2014-08-16T16:37:46 <ThomasWaldmann> but yes, for rendering a long ticket list it might be more efficient that way.
153 2014-08-16T16:38:22 <ThomasWaldmann> alternative would be to build a set of all used uids first and then do one OR(uids) queries to just look these up
154 2014-08-16T16:38:58 <ThomasWaldmann> query*
155 2014-08-16T16:39:21 <skathpalia> Yeah this can also be done
156 2014-08-16T16:39:30 <skathpalia> will try this :)
157 2014-08-16T16:41:13 <ThomasWaldmann> which one is faster depends on whoosh optimising the OR query, but the one with the OR query likely will use less memory.
158 2014-08-16T16:42:36 <RogerHaase> I also wish for a ticket table column that indicates either creation date or last update
159 2014-08-16T16:43:46 <ThomasWaldmann> RogerHaase: is the specific date important? we already have sorting by last upd
160 2014-08-16T16:44:35 <ThomasWaldmann> i am not sure about the use case for creation date
161 2014-08-16T16:45:34 <RogerHaase> last update is probably better, but seeing if an item has bee updated in last few hours or 2 years ago is sometimes of interest
162 2014-08-16T16:45:36 *** penguinRaider
163 2014-08-16T16:47:37 <skathpalia> May be the table would become a bit congested then
164 2014-08-16T16:47:44 <ThomasWaldmann> RogerHaase: yeah, update* not create
165 2014-08-16T16:48:16 <skathpalia> But still will try that and check if it looks Ok
166 2014-08-16T16:48:23 <ThomasWaldmann> one issue i encounter all the time on web systems is that they put a datetime somewhere, but not have hspace for it
167 2014-08-16T16:48:40 <RogerHaase> if space is needed, I would remove item ID column as Summarry column mouseover shows item ID and has same link if clicked
168 2014-08-16T16:48:43 <ThomasWaldmann> and then, they abbreviate in the "x days ago" style
169 2014-08-16T16:48:57 <ThomasWaldmann> which is not that helpful if one wants to know the exact time
170 2014-08-16T16:49:28 <ThomasWaldmann> RogerHaase: itemid is our "bug number"
171 2014-08-16T16:49:29 <RogerHaase> that x-days ago is worst design ever
172 2014-08-16T16:49:44 <skathpalia> RogerHaase, Ok will do that :
173 2014-08-16T16:52:00 <RogerHaase> as I said, mouseover summary or click summary column to see bug number (a random string of hex digits is not information of use)
174 2014-08-16T16:54:49 <ThomasWaldmann> RogerHaase: i disagree
175 2014-08-16T16:55:12 <ThomasWaldmann> all issue trackers have some short id, usually a 1+ decimal number
176 2014-08-16T16:55:49 <ThomasWaldmann> but as this is not globally unique, we have that uuid and the id displayed is just an abbreviation of it
177 2014-08-16T16:56:13 <ThomasWaldmann> but it can be used to shortly identify an item in same way as a decimal number
178 2014-08-16T16:56:47 <ThomasWaldmann> (whether 8 hex digits is the best amount is TBD, maybe we can use less)
179 2014-08-16T16:57:31 *** penguinRaider
180 2014-08-16T16:57:33 <ThomasWaldmann> see also commit comments like "..., closes #1234), we need such a short id and it should be visible
181 2014-08-16T16:59:17 <RogerHaase> if you sort on the column ID, there is no useful information generated. If you need the ID, it could be put on the ticket view (or can be copied from url)
182 2014-08-16T16:59:51 <ThomasWaldmann> yeah, sorting doesn't make sense, except for manually finding an id in the list
183 2014-08-16T17:01:36 <ThomasWaldmann> btw, about the "recently updated" thing: don't we show ticket updates on global history? do we need a "rc bookmark" like thing on issue tracker?
184 2014-08-16T17:02:09 <skathpalia> yeah tickets are shown on global history
185 2014-08-16T17:03:13 <ThomasWaldmann> ok, so one could just use that existing functionality to see what's new, then read it, then set bookmark
186 2014-08-16T17:03:18 <ThomasWaldmann> wiki style :)
187 2014-08-16T17:03:58 <RogerHaase> to be useful, then global history will need that Summary column
188 2014-08-16T17:04:13 <ThomasWaldmann> it shows the summary
189 2014-08-16T17:04:16 <ThomasWaldmann> just tried it
190 2014-08-16T17:04:17 <skathpalia> yeah
191 2014-08-16T17:04:42 <skathpalia> and for other nameless items it shows shortened fqname
192 2014-08-16T17:05:29 <RogerHaase> ? I am only seeing item ID
193 2014-08-16T17:05:43 <ThomasWaldmann> a cool feature we maybe can add later is that while we render blog or ticket items, it checks against the rc bookmark and highlights all newer entries on tickets/blog view
194 2014-08-16T17:06:05 <ThomasWaldmann> i see "this is the summary" (modernized)
195 2014-08-16T17:06:16 <skathpalia> for nameless items shortened fqname returns shortened itemid
196 2014-08-16T17:06:25 <skathpalia> for ticket it shows summary in all themes
197 2014-08-16T17:07:48 <ThomasWaldmann> btw, was there a special reason for centering the THs and left-aligning the TDs?
198 2014-08-16T17:08:53 <skathpalia> in +tickets view ?
199 2014-08-16T17:09:01 <ThomasWaldmann> yes
200 2014-08-16T17:09:51 <skathpalia> Both are left aligned
201 2014-08-16T17:10:15 <ThomasWaldmann> looks a bit weird, esp. if there is no sort ^v but still the place for it is kept free, that makes the TH text not look centered, but slightly right-of-center
202 2014-08-16T17:10:50 <ThomasWaldmann> summary is right in the middle of the rather broad summary column
203 2014-08-16T17:11:37 <skathpalia> Ok will remove the space for ths not having sorting
204 2014-08-16T17:12:50 <RogerHaase> OK, after switching to different repo, I now see summary instead of ID in global history
205 2014-08-16T17:13:53 <ThomasWaldmann> skathpalia: maybe <sort-control><1em space><header text> and that left-aligned usually, same as td
206 2014-08-16T17:14:18 <ThomasWaldmann> the only td which should be right aligned are TDs showing numbers with different amount of digits
207 2014-08-16T17:15:02 <ThomasWaldmann> or datetime values with different amount of chars (e.g. due to am/pm formatting and no leading 0)
208 2014-08-16T17:16:05 <ThomasWaldmann> ah, and hex columns should be monospace font, ofc
209 2014-08-16T17:16:26 <skathpalia> Currently we have fields EDSP and id that are numbers but they have same length so we do't have such td as of now
210 2014-08-16T17:16:50 <skathpalia> yeah id column is monospace already
211 2014-08-16T17:17:52 <ThomasWaldmann> yeah, that were just general comments
212 2014-08-16T17:18:10 <skathpalia> Oh
213 2014-08-16T17:18:13 <skathpalia> :)
214 2014-08-16T17:18:15 <ThomasWaldmann> because while doing the click-through i found quite some such issues
215 2014-08-16T17:18:29 <ThomasWaldmann> ok, anything else for the meeting
216 2014-08-16T17:18:41 <RogerHaase> none here
217 2014-08-16T17:18:53 <skathpalia> nope
218 2014-08-16T17:19:01 <ThomasWaldmann> dimazest: anything? :)
219 2014-08-16T17:19:51 <ThomasWaldmann> use the last 2 days to cleanup minor issues. do not invent any bigger new stuff.
220 2014-08-16T17:20:12 <skathpalia> Ok
221 2014-08-16T17:20:49 <ThomasWaldmann> also, if you are doing trivial fixes, like fixing alignment issues, just commit after checking your fix yourself.
222 2014-08-16T17:20:57 <ThomasWaldmann> randomax: skathpalia: ^
223 2014-08-16T17:21:01 <randomax> ok
224 2014-08-16T17:21:08 <skathpalia> Ok
225 2014-08-16T17:21:58 <ThomasWaldmann> ok, thanks for attending. one last note: monday 19:00 utc is pencils down, but please be available until the eval deadline for mentors at friday 19:00 in case there are any questions.
226 2014-08-16T17:22:34 <randomax> ok
227 2014-08-16T17:22:39 <skathpalia> Ok
228 2014-08-16T17:23:06 <ThomasWaldmann> happy hacking :)
229 2014-08-16T17:23:18 <randomax> :)
230 2014-08-16T17:23:55 <skathpalia> :)
231 2014-08-16T17:25:56 <ThomasWaldmann> skathpalia: randomax: also make sure not to miss any google TODOs you have to do (evals, submitting code, papers)
232 2014-08-16T17:26:47 <skathpalia> Ok
233 2014-08-16T17:26:52 <RogerHaase> blogs
234 2014-08-16T17:26:53 <dimazest> not really
235 2014-08-16T17:27:07 <randomax> ok
236 2014-08-16T17:27:15 <skathpalia> will update blog also :)
237 2014-08-16T17:35:29 <RogerHaase> back in ~hour
238 2014-08-16T18:03:33 *** sl33k_
239 2014-08-16T18:08:46 *** sl33k_
240 2014-08-16T19:17:16 *** sl33k_
241 2014-08-16T19:37:33 *** skathpalia
242 2014-08-16T19:50:34 *** RogerHaase
243 2014-08-16T19:50:51 *** RogerHaase
244 2014-08-16T20:26:45 <randomax> RogerHaase, ThomasWaldmann shortened item names in index view so they do not disrupt the line - https://codereview.appspot.com/130810043
245 2014-08-16T20:29:31 <RogerHaase> randomax: looks ok, commit it
246 2014-08-16T20:29:35 <randomax> ok
247 2014-08-16T20:34:14 <RogerHaase> randomax: fyi, I closed 450, 451, 454
248 2014-08-16T20:35:12 <randomax> yeah just got the notifications.. thanks
249 2014-08-16T20:35:23 <RogerHaase> ...and removed them from http://moinmo.in/ThomasWaldmann/IssuesToBeClosed
250 2014-08-16T20:36:31 <randomax> ok
251 2014-08-16T21:54:53 <randomax> RogerHaase, are these font sizes ok ?
252 2014-08-16T21:54:57 <randomax> http://codereview.appspot.com/131800043
253 2014-08-16T21:55:14 <randomax> for the tag cloud
254 2014-08-16T22:02:21 *** penguinRaider
255 2014-08-16T22:03:29 <RogerHaase> randomax: yes, those look better
256 2014-08-16T22:05:31 <RogerHaase> randomax: are you getting tracebacks from viewing Admin > Users and Admin > Groups?
257 2014-08-16T22:09:55 <randomax> RogerHaase, you probably have made some nameless items
258 2014-08-16T22:10:53 <randomax> nameless items do crash group view as the regex search in the backend uses item name
259 2014-08-16T22:14:48 <RogerHaase> randomax: you appear to be right as creating new wiki clears the problem
260 2014-08-16T22:15:21 *** penguinRaider
261 2014-08-16T22:15:40 <RogerHaase> I will add that to skathpalia's troubles
262 2014-08-16T22:21:57 <randomax> Haha :D I think i found a fix
263 2014-08-16T22:22:16 <randomax> changing it to "if self.item_group_regex.search(rev.revid)" works
264 2014-08-16T22:22:36 <RogerHaase> randomax: https://bitbucket.org/saurabh_k/moin-2.0/issue/10/traceback-in-admin-users-and-admin-groups
265 2014-08-16T22:23:14 <RogerHaase> randomax: gtg, must be late there as well, gn
266 2014-08-16T22:23:24 <randomax> yeah.. gn
267 2014-08-16T22:23:28 *** RogerHaase
268 2014-08-16T22:30:50 *** randomax
269
