1 2014-08-14T00:01:04 *** yufra
2 2014-08-14T00:07:29 *** yufra
3 2014-08-14T01:22:18 *** xiaq
4 2014-08-14T01:24:15 *** xiaq
5 2014-08-14T03:50:24 *** jek_
6 2014-08-14T03:51:42 *** dreimark
7 2014-08-14T03:52:10 *** ananasov1
8 2014-08-14T03:52:15 *** sharky93_
9 2014-08-14T03:52:44 *** jek
10 2014-08-14T03:52:45 *** dreimark_
11 2014-08-14T03:52:47 *** sharky93
12 2014-08-14T03:52:47 *** waldi
13 2014-08-14T03:52:47 *** ananasova
14 2014-08-14T03:52:54 *** jek_
15 2014-08-14T03:53:22 *** waldi
16 2014-08-14T03:53:22 *** waldi
17 2014-08-14T04:19:35 *** penguinRaider
18 2014-08-14T05:10:29 *** ananasova
19 2014-08-14T05:11:09 *** ananasov1
20 2014-08-14T05:20:58 *** eSyr
21 2014-08-14T05:29:13 *** eSyr
22 2014-08-14T05:49:05 *** penguinRaider
23 2014-08-14T06:01:59 *** sharky93_
24 2014-08-14T07:00:29 *** xiaq
25 2014-08-14T09:49:25 *** greg_f
26 2014-08-14T11:40:31 *** randomax
27 2014-08-14T12:04:03 <randomax> ThomasWaldmann, can i commit these -
28 2014-08-14T12:04:04 <randomax> https://codereview.appspot.com/123360043/
29 2014-08-14T12:04:09 <randomax> https://codereview.appspot.com/123370043/
30 2014-08-14T12:04:14 <randomax> https://codereview.appspot.com/119880046/
31 2014-08-14T12:04:21 <randomax> https://codereview.appspot.com/123150043/
32 2014-08-14T12:21:51 *** skathpalia
33 2014-08-14T12:23:33 <skathpalia> ThomasWaldmann, Made css patch having changes in ticket view and +tickets view https://codereview.appspot.com/127850043/
34 2014-08-14T12:27:58 <skathpalia> screenshots:
35 2014-08-14T12:28:03 <skathpalia> ticket in basic theme: http://picpaste.com/pics/ticket-basic-KqZMVn16.1407693682.png
36 2014-08-14T12:28:08 <skathpalia> ticket in modernized theme: http://picpaste.com/pics/ticket-modernized-STo1YoaH.1407693684.png
37 2014-08-14T12:28:13 <skathpalia> +tickets view in basic theme: http://picpaste.com/pics/tickets-dyEnZLWA.1407693686.png
38 2014-08-14T12:58:03 *** dave_largo
39 2014-08-14T14:46:30 *** RogerHaase
40 2014-08-14T14:52:47 <RogerHaase> randomax: I added some thoughts on smileys to your EP. But I suggest not working on it: 1. tw has not agreed on approach; 2. too big to finish by 8/18; 3. outside your project scope (involves converters); 4. not consistent with gsoc 8/11 to 8/18 tasks.
41 2014-08-14T14:54:33 <RogerHaase> randomax: if you have more time, work on smaller open issues related to your project. I will delete the smiley stuff from your ep and add it to a new issue
42 2014-08-14T14:58:25 <randomax> RogerHaase, ok
43 2014-08-14T15:13:04 <RogerHaase> randomax: I replied to 3 of your 4 open CRs
44 2014-08-14T15:13:52 <randomax> yeah.. working on it..
45 2014-08-14T15:34:46 *** penguinRaider
46 2014-08-14T15:34:46 *** skathpalia
47 2014-08-14T15:34:46 *** randomax
48 2014-08-14T15:36:07 <RogerHaase> skathpalia: I do not understand https://codereview.appspot.com/127240043/. I assigned a ticket to a valid user JaneDoe and did a search, nothing found. If I do a search on my ID, I get all the tickets I created with that ID
49 2014-08-14T15:47:50 *** randomax
50 2014-08-14T15:50:44 *** skathpalia
51 2014-08-14T15:52:30 *** penguinRaider
52 2014-08-14T15:57:27 <skathpalia> RogerHaase, Can I commit this https://codereview.appspot.com/127850043/ ?
53 2014-08-14T16:01:10 <RogerHaase> skathpalia: go ahead and commit
54 2014-08-14T16:01:15 <skathpalia> Ok
55 2014-08-14T16:01:49 <skathpalia> Also just read the logs about this cr https://codereview.appspot.com/127240043/ .. checking it again :)
56 2014-08-14T16:05:31 <skathpalia> RogerHaase, Just now I tried it. I created a new user saurabh1 and there was an existing user saurabh and then I assigned a ticket to saurabh1 and I was logged in as saurabh and then I searched for tickets assigned to saurabh1 and I got that ticket
57 2014-08-14T16:07:12 <skathpalia> Can you please try it once again http://127.0.0.1:8080/+tickets?assigned_to=JaneDoe
58 2014-08-14T16:11:07 <RogerHaase> skathpalia: ok, that works. Is there a link to that "assigned_to somewhere?
59 2014-08-14T16:11:52 <skathpalia> No I am actually thinking of its GUI
60 2014-08-14T16:12:09 <RogerHaase> ok, great
61 2014-08-14T16:15:14 <skathpalia> RogerHaase, Can I commit this also https://codereview.appspot.com/129060043/ ?
62 2014-08-14T16:23:15 *** dave_largo
63 2014-08-14T16:30:05 <RogerHaase> skathpalia: https://paste.thinkmo.de/979a92ba-069d-4888-9053-9b7d32eda3e6 - that 3dc3de9 seems strangely positioned; that is the dependency
64 2014-08-14T16:30:50 <skathpalia> Ok aligning it properly
65 2014-08-14T16:36:00 <randomax> RogerHaase, i had looked into issue 449 https://bitbucket.org/thomaswaldmann/moin-2.0/issue/449/traceback-after-clicking-save-button-on
66 2014-08-14T16:36:28 <randomax> the problem seems to be that the validator is made for the modify item form
67 2014-08-14T16:36:43 <RogerHaase> skathpalia: https://paste.thinkmo.de/ac8c9648-b405-448d-8d6c-0353da729e15 Here I claim I created a depends on and got the non-existent link to fb1762f, then created another depends on and got a valid link to 10576bc
68 2014-08-14T16:36:43 <randomax> hence it gives error here https://bitbucket.org/thomaswaldmann/moin-2.0/src/3bc9fd6d054eeeb9a88bc83526eeb54ca165c5db/MoinMoin/forms.py?at=default#cl-127
69 2014-08-14T16:37:51 <randomax> when it tries to check for ['extra_meta_text']
70 2014-08-14T16:38:25 <randomax> what i was thinking was that i can either check for Null value or add and exception
71 2014-08-14T16:38:34 <randomax> *add an exception
72 2014-08-14T16:39:08 <skathpalia> RogerHaase, updated the cr https://codereview.appspot.com/129060043/
73 2014-08-14T16:39:14 <skathpalia> Added css for the links
74 2014-08-14T16:44:13 <RogerHaase> randomax: hmm, no idea, but give it a try and delete the TODO comment in your CS
75 2014-08-14T16:47:18 <randomax> RogerHaase, also can i just add the css for the smileys in the basic theme for the time being bcoz it is missing in the basic theme and hence smileys dont work
76 2014-08-14T16:49:45 <RogerHaase> randomax: yes, that is best way to fix for now
77 2014-08-14T16:50:05 <randomax> RogerHaase, ok i'll do that
78 2014-08-14T16:53:09 <RogerHaase> skathpalia: will pull your latest commits, apply that 129060043 patch, and refresh wiki to see if I can recreate that non-existent link. Will take a while...
79 2014-08-14T16:56:32 <RogerHaase> skathpalia: that Superseded By field is similar to "duplicate" and when used, the ticket is likely to be closed - is that correct?
80 2014-08-14T16:58:46 <skathpalia> But it may happen that the superseded ticket may be similar but not exactly same so I think it should not be closed when this field is selected
81 2014-08-14T17:00:31 <RogerHaase> skathpalia: ok, agree not automatically closed, but likely closed by user in some/most cases
82 2014-08-14T17:00:46 <skathpalia> Yeah
83 2014-08-14T17:04:07 <RogerHaase> skathpalia: btw under Back References, there is inconsistent indentation or fonts: https://paste.thinkmo.de/ac8c9648-b405-448d-8d6c-0353da729e15
84 2014-08-14T17:06:06 <skathpalia> Yeah I was thinking of fixing this in a separate patch
85 2014-08-14T17:07:55 <randomax> RogerHaase, added css for smileys in basic theme
86 2014-08-14T17:08:00 <randomax> https://codereview.appspot.com/129200043/
87 2014-08-14T17:08:39 <skathpalia> RogerHaase, what do you say ?
88 2014-08-14T17:09:04 <skathpalia> on making the css changes of back references in a separate patch
89 2014-08-14T17:09:34 <RogerHaase> skathpalia: separate patch is good idea
90 2014-08-14T17:10:21 <skathpalia> yeah.. so Can I commit this https://codereview.appspot.com/129060043/ ?
91 2014-08-14T17:12:03 <RogerHaase> skathpalia: not yet, want to test that more. But we do need to commit some of your CRs to avoid a log jam on or before the 18Th
92 2014-08-14T17:13:18 <skathpalia> May be this one can be committed https://codereview.appspot.com/127900043/
93 2014-08-14T17:13:24 <skathpalia> RogerHaase ^^
94 2014-08-14T17:16:36 <RogerHaase> skathpalia: since it appears unlikely that this nameless ticket creation will not be resolved before the 18th; have you thought about changing the Create Ticket button from "http://127.0.0.1:8080/+new?itemtype=ticket" that shows not-implemented traceback to something like "http://127.0.0.1:8080/+modify/Ticket<timestamp>?itemtype=ticket" -- so the button is at least useful?
95 2014-08-14T17:18:20 <skathpalia> RogerHaase, I tried that about 2 months back. Here is the cr https://codereview.appspot.com/106110043/
96 2014-08-14T17:19:29 <skathpalia> This one creates ticket with a temporary name 'ticket' which doesn't remain with the ticket after creation
97 2014-08-14T17:24:04 <skathpalia> But creating ticket with name Ticket<timestamp> would be a better approach. Ok will try to so that :)
98 2014-08-14T17:28:04 <RogerHaase> skathpalia: yes, looks like a small change to tickets.html -- maybe add a comment that this is workaround for nameless ticket creation issue
99 2014-08-14T17:29:46 <skathpalia> Ok will add a comment in this cr https://codereview.appspot.com/106110043/
100 2014-08-14T17:30:33 *** greg_f
101 2014-08-14T17:31:29 <skathpalia> May be till then we can have some more crs finalized and committet
102 2014-08-14T17:31:35 <skathpalia> *committed
103 2014-08-14T17:31:49 <skathpalia> https://codereview.appspot.com/125180043/
104 2014-08-14T17:32:06 <skathpalia> https://codereview.appspot.com/127900043/
105 2014-08-14T17:32:14 <skathpalia> RogerHaase, Can I commit these?
106 2014-08-14T17:35:39 <RogerHaase> skathpalia: yes to those 2
107 2014-08-14T17:35:53 <skathpalia> Ok
108 2014-08-14T17:39:58 <RogerHaase> skathpalia: on https://codereview.appspot.com/106110043/, are all those changes needed for the Create Ticket button? I was thinking a new patch that would just change the href in line 42 of tickets.html
109 2014-08-14T17:44:26 <skathpalia> Yeah the above cr contains all those changes for ticket-create button but it needs to be updated as per the current repo
110 2014-08-14T17:46:52 *** sl33k_
111 2014-08-14T17:49:39 <skathpalia> Yeah may be we can have a separate patch for changing href
112 2014-08-14T17:52:10 <RogerHaase> skathpalia: cannot recreate problem with broken superseded link. But noticed that Superseded and depends on has current ticket in drop down list so a ticket could be made dependent on itself
113 2014-08-14T17:52:21 <RogerHaase> must breat for ~30 min
114 2014-08-14T17:55:36 <skathpalia> Ok will try to remove that :)
115 2014-08-14T17:58:52 <ThomasWaldmann> moin
116 2014-08-14T18:00:15 * ThomasWaldmann looks at PRs
117 2014-08-14T18:04:59 <randomax> ThomasWaldmann, please dont merge my PR as yet
118 2014-08-14T18:05:05 <randomax> I found a bug
119 2014-08-14T18:05:16 <randomax> currently working on fixing it
120 2014-08-14T18:07:38 <randomax> ThomasWaldmann, ^
121 2014-08-14T18:14:41 <ThomasWaldmann> randomax: to late
122 2014-08-14T18:14:46 <ThomasWaldmann> too*
123 2014-08-14T18:14:57 <randomax> ok.. i'll fix it now
124 2014-08-14T18:16:19 <ThomasWaldmann> skathpalia: can you please pull from main repo and merge your stuff and then ping me when done?
125 2014-08-14T18:16:54 <skathpalia> Ok
126 2014-08-14T18:28:54 <skathpalia> ThomasWaldmann, there are merge conflicts in theme.css and theme.less when I try to pull from the main repo so should I make another commit to revert my changes in these files and then pull from main repo and then again commit my css changes?
127 2014-08-14T18:37:25 <RogerHaase> skathpalia: no, just do the merge. Depending on your hg setup you will either see kdiff and be able to fix or be forced to update manually
128 2014-08-14T18:40:58 <randomax> ThomasWaldmann, RogerHaase can i commit this - fixed an error in modify view
129 2014-08-14T18:40:59 <randomax> https://codereview.appspot.com/126230044
130 2014-08-14T18:50:52 <RogerHaase> skathpalia: hmm, I used an aged repo, pulled from your repo, pulled from main; got a "not updating: not a linear update" message; did a merge, then commit; was not asked about conflicts but merge commit shows theme.css, theme.less, and basic/foobar layout.html was updated
131 2014-08-14T18:52:08 <skathpalia> RogerHaase, I have now removed the merge conflicts
132 2014-08-14T18:52:36 <skathpalia> ThomasWaldmann, updated the pr (removed merge conflicts and pulled from the main repo)
133 2014-08-14T18:54:07 <randomax> RogerHaase, and also this https://codereview.appspot.com/122610043/
134 2014-08-14T19:02:38 <RogerHaase> randomax: haha, we both forgot to test normal save!
135 2014-08-14T19:03:41 <randomax> yeah.. :)
136 2014-08-14T19:03:52 <randomax> sorry for that..
137 2014-08-14T19:04:01 <RogerHaase> randomax: does that need a return false, return true or something -- updates are not being saved
138 2014-08-14T19:06:20 <randomax> yeah i fixed that in this https://codereview.appspot.com/126230044/
139 2014-08-14T19:06:46 <randomax> somehow modify view needs the itemid in the 'extra_meta_text' itself
140 2014-08-14T19:07:11 <randomax> RogerHaase, ^
141 2014-08-14T19:07:50 <randomax> Thats why i was requesting some time for my pr
142 2014-08-14T19:09:51 <RogerHaase> randomax: ah, ok, applied both patches and modified changes are saved
143 2014-08-14T19:10:38 <randomax> should i commit ?
144 2014-08-14T19:11:02 *** sl33k_
145 2014-08-14T19:11:49 <RogerHaase> randomax: OK by me
146 2014-08-14T19:13:30 <randomax> ok..
147 2014-08-14T19:14:37 <skathpalia> RogerHaase, Can I commit this https://codereview.appspot.com/127240043/ ?, I was thinking of defining GUI for this in a separate patch
148 2014-08-14T19:15:13 <RogerHaase> skathpalia: if you get another shot at a merge conflict you should try using the tools to do the merge. Backing off and reapplying your patches works, but is not the best way (in most cases)
149 2014-08-14T19:16:11 <skathpalia> sorry.... will try to use tools for this in future
150 2014-08-14T19:17:49 <RogerHaase> skathpalia: yes, commit that one
151 2014-08-14T19:18:02 <skathpalia> Ok
152 2014-08-14T19:25:16 <randomax> RogerHaase, added smileys for basic theme - https://codereview.appspot.com/129200043/
153 2014-08-14T19:39:31 <RogerHaase> randomax: replied
154 2014-08-14T19:44:31 <randomax> RogerHaase, i think your comments did not get published.. bcoz i cannot see your reply
155 2014-08-14T19:45:24 <RogerHaase> randomax: duh, published now
156 2014-08-14T19:48:48 <randomax> RogerHaase, regarding the triplicating if I put the css in common.css i would have to put the images in the Moinmoin/static/img folder and then again ThomasWaldmann said that we should be able to use different smileys in different themes
157 2014-08-14T19:53:57 <RogerHaase> randomax: you are right, let's do easy way and just triplicate to get it working
158 2014-08-14T19:57:46 <randomax> so should i wait for tw ?
159 2014-08-14T20:06:23 <RogerHaase> randomax: works per my test, and is simple, commit
160 2014-08-14T20:07:20 <randomax> ok
161 2014-08-14T20:55:46 *** skathpalia
162 2014-08-14T20:57:16 <RogerHaase> ThomasWaldmann: please close 415, 384 as fixed; 435 as duplicate, 419 as invalid
163 2014-08-14T21:06:30 <randomax> RogerHaase, committing the smiley css would cause conflicts with skathpalia's PR
164 2014-08-14T21:23:14 *** randomax
165 2014-08-14T22:02:34 *** RogerHaase
166
