1 2014-08-13T05:17:55 *** randomax
2 2014-08-13T05:38:04 *** xiaq
3 2014-08-13T06:33:08 *** xiaq
4 2014-08-13T09:37:03 *** dimazest_
5 2014-08-13T09:37:35 *** dimazest
6 2014-08-13T09:37:35 *** dimazest_
7 2014-08-13T09:40:51 *** skathpalia
8 2014-08-13T10:01:57 *** greg_f
9 2014-08-13T10:54:26 <randomax> Fixed issue #451 - https://codereview.appspot.com/123360043
10 2014-08-13T13:10:20 *** randomax
11 2014-08-13T13:10:35 *** randomax
12 2014-08-13T14:09:44 <randomax> Solved issue 454 https://codereview.appspot.com/123370043
13 2014-08-13T14:43:19 *** RogerHaase
14 2014-08-13T14:46:30 <RogerHaase> skathpalia: I think I added some bugs to your repo's issues (confusing because the two issues I added weeks ago were missing)
15 2014-08-13T14:46:43 <RogerHaase> randomax: done with reviews
16 2014-08-13T15:02:38 <skathpalia> RogerHaase, Actually my pull had merge conflicts so I had to delete the repo and again fork new one
17 2014-08-13T15:02:58 <skathpalia> But the 2 bugs that you reported were solved by then :)
18 2014-08-13T15:03:23 <skathpalia> RogerHaase, I added comments on the bugs reported in my repo
19 2014-08-13T15:04:26 <skathpalia> crs:
20 2014-08-13T15:04:46 <skathpalia> #1- https://codereview.appspot.com/123340043/
21 2014-08-13T15:05:46 <skathpalia> #2- Ticket update and reopen button are aligned properly as per this cr https://codereview.appspot.com/127850043/
22 2014-08-13T15:06:06 <skathpalia> #3- https://codereview.appspot.com/125180043/
23 2014-08-13T15:06:32 <skathpalia> #5- https://codereview.appspot.com/122470043/
24 2014-08-13T15:07:13 <skathpalia> #6- https://codereview.appspot.com/127240043/ still need to define GUI for this
25 2014-08-13T15:08:07 <skathpalia> #7- https://codereview.appspot.com/129060043/ need to improve UI for this
26 2014-08-13T15:09:07 <skathpalia> #8- This is solved in the cr of #2. Here are the screenshots: ticket in basic theme: http://picpaste.com/pics/ticket-basic-KqZMVn16.1407693682.png ticket in modernized theme: http://picpaste.com/pics/ticket-modernized-STo1YoaH.1407693684.png
27 2014-08-13T15:11:20 <skathpalia> RogerHaase, ^^
28 2014-08-13T15:48:25 *** dave_largo
29 2014-08-13T16:30:03 *** magu_cic_
30 2014-08-13T16:41:05 <randomax> RogerHaase, changed the classname - https://codereview.appspot.com/123360043/
31 2014-08-13T16:41:40 <randomax> RogerHaase, also please review https://codereview.appspot.com/127840043/
32 2014-08-13T16:43:07 <RogerHaase> randomax: looks OK.
33 2014-08-13T16:44:11 <randomax> ThomasWaldmann, said that it would not be favourable when we would want to have different smileys for different themes
34 2014-08-13T16:44:25 <skathpalia> RogerHaase, Updated the cr https://codereview.appspot.com/129060043/
35 2014-08-13T16:44:32 <skathpalia> Removed HTML validation error
36 2014-08-13T16:44:48 <randomax> he asked me if i could find any way to reduce copying while still keeping it possible to use different smileys
37 2014-08-13T16:44:57 <randomax> i couldnt think of anything
38 2014-08-13T16:45:04 <randomax> do you have any ideas regarding that ?
39 2014-08-13T17:00:04 <randomax> RogerHaase, ^
40 2014-08-13T17:08:56 <RogerHaase> randomax: for things like #moin-content div.attention{background-image:url("../img/admonitions/important.png")} -- I think the url can be a list so you could try loading images from theme/static/img/... and from static/img/... and hopefully the first one found will be displayed
41 2014-08-13T17:16:47 <RogerHaase> randomax: things like .moin-smile:before { content: url('../img/smileys/smile.png'); } may be impossible. Will think about it some more
42 2014-08-13T17:16:58 <randomax> ok
43 2014-08-13T17:17:34 <RogerHaase> sorry, gtg, back tomorrow
44 2014-08-13T17:17:39 <randomax> np
45 2014-08-13T17:17:40 *** RogerHaase
46 2014-08-13T17:17:47 *** randomax
47 2014-08-13T17:28:12 *** skathpalia
48 2014-08-13T17:41:47 *** greg_f
49 2014-08-13T18:14:01 *** magu_cic
50 2014-08-13T19:55:55 *** magu_cic
51 2014-08-13T20:13:37 *** RogerHaase
52 2014-08-13T20:38:24 *** xiaq
53 2014-08-13T20:43:32 *** RogerHaase
54 2014-08-13T20:57:32 *** RogerHaase
55 2014-08-13T21:11:51 *** dave_largo
56 2014-08-13T23:02:38 <RogerHaase> randomax: I added some thoughts on handling smileys to your ep
57 2014-08-13T23:02:56 <RogerHaase> ThomasWaldmann: ^^
58 2014-08-13T23:03:01 *** RogerHaase
59
MoinMoin: MoinMoinChat/Logs/moin-dev/2014-08-13 (last edited 2014-08-13 05:30:02 by IrcLogImporter)