1 2014-08-12T06:26:46  *** xiaq has joined #moin-dev
   2 2014-08-12T08:46:52  *** penguinRaider has quit IRC
   3 2014-08-12T08:49:38  *** penguinRaider has joined #moin-dev
   4 2014-08-12T08:53:46  *** greg_f has joined #moin-dev
   5 2014-08-12T09:04:33  *** randomax has joined #moin-dev
   6 2014-08-12T09:04:43  <randomax> ThomasWaldmann, reviews needed
   7 2014-08-12T09:04:48  <randomax> https://codereview.appspot.com/119880046/
   8 2014-08-12T09:04:53  <randomax> https://codereview.appspot.com/123150043/
   9 2014-08-12T09:51:32  *** dimazest has quit IRC
  10 2014-08-12T09:53:56  *** jek has quit IRC
  11 2014-08-12T09:55:16  *** dimazest has joined #moin-dev
  12 2014-08-12T09:58:23  *** jek has joined #moin-dev
  13 2014-08-12T10:09:57  *** xiaq has quit IRC
  14 2014-08-12T10:10:16  *** xiaq has joined #moin-dev
  15 2014-08-12T10:21:09  *** xiaq has quit IRC
  16 2014-08-12T10:32:22  *** randomax has quit IRC
  17 2014-08-12T10:41:34  *** skathpalia has joined #moin-dev
  18 2014-08-12T10:57:08  *** randomax has joined #moin-dev
  19 2014-08-12T11:52:20  *** randomax has quit IRC
  20 2014-08-12T12:57:27  *** randomax has joined #moin-dev
  21 2014-08-12T13:53:25  *** randomax has quit IRC
  22 2014-08-12T14:27:30  *** randomax has joined #moin-dev
  23 2014-08-12T15:19:28  *** randomax has quit IRC
  24 2014-08-12T15:34:31  *** RogerHaase has joined #moin-dev
  25 2014-08-12T15:48:28  *** randomax has joined #moin-dev
  26 2014-08-12T15:49:17  <randomax> RogerHaase, Hi :)
  27 2014-08-12T15:49:23  <randomax> could you review these
  28 2014-08-12T15:49:25  <randomax> https://codereview.appspot.com/119880046/
  29 2014-08-12T15:49:29  <randomax> https://codereview.appspot.com/123150043/
  30 2014-08-12T15:50:46  <RogerHaase> randomax: moin :); code on both of those looks OK, tested quicklinks patch, about to apply edit acl patch and test
  31 2014-08-12T15:58:47  <RogerHaase> randomax: both changes work fine for me.  :)
  32 2014-08-12T15:58:59  <randomax> ok.. i'll wait for tw then
  33 2014-08-12T15:59:01  <randomax> :)
  34 2014-08-12T15:59:28  <RogerHaase> randomax: are there any other things you have in the queue to finish before pencils down?
  35 2014-08-12T16:00:34  <randomax> Regarding the user defined css objects me and ThomasWaldmann discussed and he pointed out that it could be a potential security threat as users could upload js files through the css
  36 2014-08-12T16:00:41  <randomax> as in malicious js files
  37 2014-08-12T16:00:46  <randomax> so we dropped the idea
  38 2014-08-12T16:01:03  <randomax> apart from that just a couple of bugs i am working on
  39 2014-08-12T16:01:32  <randomax> #444
  40 2014-08-12T16:01:45  <randomax> and automatically unchecking the
  41 2014-08-12T16:02:06  <randomax> "All" option in the search options bar in case the user selects any other option
  42 2014-08-12T16:07:32  <RogerHaase> randomax: sounds good
  43 2014-08-12T16:07:58  <randomax> RogerHaase, any other things you want me to do ?
  44 2014-08-12T16:15:37  <RogerHaase> randomax: If you have time, do more bugs that are close to your proposal. 451 is especially annoying for me during my testing, but there are many others to choose from...
  45 2014-08-12T16:16:57  <randomax> RogerHaase, Ok I'll do that :)
  46 2014-08-12T16:22:21  <RogerHaase> skathpalia: I saw a discussion about ticket.css.  Is that still unresolved?
  47 2014-08-12T16:37:34  <skathpalia> RogerHaase, No I discussed with ThomasWaldmann regarding this and he said that we will decide after discussion  you
  48 2014-08-12T16:37:46  <skathpalia> *with you
  49 2014-08-12T16:39:08  <RogerHaase> skathpalia: if I understand the discussion, he was OK with killing ticket.styl, but did not like the ticket.css format
  50 2014-08-12T16:39:49  <skathpalia> Yeah I showed him the changed version also of the ticket.css that you made
  51 2014-08-12T16:41:57  <RogerHaase> ok, then change the ticket.css format to look like the common.css in the same directory, and do a changeset witht he improved format and killing ticket.styl
  52 2014-08-12T16:42:32  <skathpalia> Ok will make this :)
  53 2014-08-12T16:49:03  *** randomax has quit IRC
  54 2014-08-12T16:50:15  *** penguinRaider has quit IRC
  55 2014-08-12T16:51:37  *** penguinRaider has joined #moin-dev
  56 2014-08-12T16:53:27  <RogerHaase> skathpalia:  when tw returns, we should discuss merging the new ticket.css into common.css.  I would do that, not sure if he would
  57 2014-08-12T16:53:49  <RogerHaase> or, ask on your cr
  58 2014-08-12T16:54:03  <skathpalia> Ok will ask him on my cr :)
  59 2014-08-12T17:00:51  <skathpalia> RogerHaase, Made the cr https://codereview.appspot.com/128030043
  60 2014-08-12T17:13:10  *** randomax has joined #moin-dev
  61 2014-08-12T17:19:18  <RogerHaase> skathpalia: ran that though csslint.net;  only worry is why line 75 has "-webkit-user-select: none;" rather than standard "user-select: none;"  - googling....
  62 2014-08-12T17:23:13  <skathpalia> Yeah checked that- it works with user-select also in both chrome and firefox, updating the cr..
  63 2014-08-12T17:24:00  <skathpalia> RogerHaase, updated the cr
  64 2014-08-12T17:30:18  *** randomax has quit IRC
  65 2014-08-12T17:37:09  <RogerHaase> skathpalia: sorry, was still googling http://caniuse.com/css-transitions; looks like all those "-xxx-transition:" on line 30+ can also be changed to just a single standard "transition:"
  66 2014-08-12T17:37:34  <skathpalia> checking it
  67 2014-08-12T17:38:43  <skathpalia> yeah it works, updating cr now
  68 2014-08-12T17:39:59  <skathpalia> RogerHaase, updated the cr
  69 2014-08-12T17:41:08  <RogerHaase> looks OK to me
  70 2014-08-12T17:42:24  <RogerHaase> skathpalia: do you have other open reviews that must be completed before pencils down?
  71 2014-08-12T17:42:46  <skathpalia> 2 more open crs
  72 2014-08-12T17:42:51  <skathpalia> https://codereview.appspot.com/127900043/
  73 2014-08-12T17:42:58  <skathpalia> https://codereview.appspot.com/127850043/
  74 2014-08-12T17:43:33  <skathpalia> screenshots for second cr:
  75 2014-08-12T17:43:38  <skathpalia> ticket in basic theme: http://picpaste.com/pics/ticket-basic-KqZMVn16.1407693682.png
  76 2014-08-12T17:43:43  <skathpalia> ticket in modernized theme: http://picpaste.com/pics/ticket-modernized-STo1YoaH.1407693684.png
  77 2014-08-12T17:43:48  <skathpalia> +tickets view in basic theme: http://picpaste.com/pics/tickets-dyEnZLWA.1407693686.png
  78 2014-08-12T17:49:45  <RogerHaase> skathpalia: both of those look OK, will try testing a bit later
  79 2014-08-12T17:50:18  <RogerHaase> must break for ~30 min
  80 2014-08-12T17:51:32  *** greg_f has quit IRC
  81 2014-08-12T17:53:10  *** randomax has joined #moin-dev
  82 2014-08-12T18:24:52  *** randomax has quit IRC
  83 2014-08-12T18:42:51  *** mapreri is now known as mapreri|holiday
  84 2014-08-12T19:32:07  *** skathpalia has quit IRC
  85 2014-08-12T20:53:31  *** magu_cic_ has joined #moin-dev
  86 2014-08-12T20:56:33  *** magu_cic has quit IRC
  87 2014-08-12T20:56:50  *** xiaq has joined #moin-dev
  88 2014-08-12T21:45:04  <RogerHaase> skathpalia: I added some issues related to tickets to your repo
  89 2014-08-12T21:52:03  <RogerHaase> ThomasWaldmann: please close 415, 384 as fixed; 437 as duplicate; 419 as invalid
  90 2014-08-12T22:00:18  *** RogerHaase has left #moin-dev
  91 2014-08-12T22:17:23  *** xiaq has quit IRC
  92

MoinMoin: MoinMoinChat/Logs/moin-dev/2014-08-12 (last edited 2014-08-12 06:30:02 by IrcLogImporter)