1 2014-08-06T05:51:25 *** randomax
2 2014-08-06T09:01:36 *** greg_f
3 2014-08-06T12:06:27 *** skathpalia
4 2014-08-06T12:32:37 <skathpalia> ThomasWaldmann, Added a very basic test for ticket items(just to give start to their tests) https://codereview.appspot.com/122940043/
5 2014-08-06T12:41:01 *** dave_largo
6 2014-08-06T12:50:19 <ThomasWaldmann> randomax: what are you working on, i don't see much activity from you the last days.
7 2014-08-06T12:58:22 *** magu_cic_
8 2014-08-06T13:00:46 <randomax> ThomasWaldmann, I was waiting for you to review the crs
9 2014-08-06T13:01:03 *** magu_cic
10 2014-08-06T13:01:33 <randomax> Improved global history view in basic theme - https://codereview.appspot.com/116560043/
11 2014-08-06T13:01:57 <randomax> Added heading to global index view in Basic theme - https://codereview.appspot.com/123720043/
12 2014-08-06T13:02:15 <randomax> Added background color to sidebar so that it looks separate from the content Preview of changes - http://picpaste.com/pics/newbasic-RQz0yyJz.1406995574.png
13 2014-08-06T13:02:19 <randomax> https://codereview.appspot.com/118330043/
14 2014-08-06T13:02:37 <randomax> Removed subitems sidebar in modernized theme https://codereview.appspot.com/114700043/
15 2014-08-06T13:02:59 <randomax> Added capability to edit acl in item acl report view itself https://codereview.appspot.com/119880046/
16 2014-08-06T13:03:36 <randomax> Refreshed the page to load selected theme as per issue #66 in sharky93 repo https://codereview.appspot.com/121720043/
17 2014-08-06T13:04:01 <randomax> Added bootstrap tables to Item Size view and Interwiki Names view and also made item sizes human readable - https://codereview.appspot.com/119150043/
18 2014-08-06T13:04:17 <randomax> made modify edit textarea expand/contract to fit window size like modernized and foobar - https://codereview.appspot.com/113570043/
19 2014-08-06T13:04:37 <randomax> Removed auto-computed values from metadata-edit view, added usergroup section https://codereview.appspot.com/113780043/
20 2014-08-06T13:05:21 <randomax> apart from that i am trying out old stuff to find any errors
21 2014-08-06T13:05:31 <randomax> and working on a couple of old crs
22 2014-08-06T13:06:38 <skathpalia> ThomasWaldmann, Worked on trail in foobar theme, used fqname instead of item_name similar to what I did for basic theme https://codereview.appspot.com/115700043/
23 2014-08-06T13:48:54 <ThomasWaldmann> randomax: i thought i had reviewed all of the CRs you gave at sunday.
24 2014-08-06T13:53:19 <randomax> Umm.. you had only reviewed one :/
25 2014-08-06T13:55:00 <ThomasWaldmann> btw, descriptions like "improved <something>" are not very useful if you do not tell what exactly changed (or give a before/after screenshot if it is UI stuff)
26 2014-08-06T13:55:56 <ThomasWaldmann> same for "fixed ..." without telling what was wrong / how one fixed it
27 2014-08-06T14:00:50 <randomax> Screenshot for global history view - http://picpaste.com/pics/globalhistory-0bE7tBtI.1407333634.png
28 2014-08-06T14:01:23 <ThomasWaldmann> ah, much better \o/
29 2014-08-06T14:01:58 <ThomasWaldmann> is there a way to let the column spacing be the same, not changing for every day?
30 2014-08-06T14:02:31 <ThomasWaldmann> (see how timestamp and description move to the right for jun 20 in that screenshot)
31 2014-08-06T14:03:16 <ThomasWaldmann> (also, that "set bookmark" looks a bit big - maybe use a smaller button and place it to the right of the date)
32 2014-08-06T14:04:49 <randomax> Ok.. i'll change that
33 2014-08-06T14:07:16 <randomax> ThomasWaldmann, also regarding removing the subitem sidebar in modernized theme me and roger had discussed that on the etherpad - http://etherpad.osuosl.org/moin-improve-gui line 269
34 2014-08-06T14:08:39 <skathpalia> ThomasWaldmann, Improved UI of blog items in modernized theme and also displayed itemviews in blog view https://codereview.appspot.com/118490044/
35 2014-08-06T14:08:53 <skathpalia> Oh sorry foobar theme ^^
36 2014-08-06T14:09:32 <ThomasWaldmann> randomax: about subitems: sounds reasonable. i'ld suggest to insert only names, not markup
37 2014-08-06T14:09:46 <ThomasWaldmann> (as markup varies widely, names do not)
38 2014-08-06T14:15:36 <randomax> ThomasWaldmann, I did not get you
39 2014-08-06T14:16:08 <ThomasWaldmann> if you edit a moin wiki item, link markup has to be [[name]], transclusion is {{name}}
40 2014-08-06T14:16:26 <ThomasWaldmann> if you edit items of other types, the markup changes, but not the name
41 2014-08-06T14:16:47 <ThomasWaldmann> so, it is easier to just insert the name and let the markup to the user
42 2014-08-06T14:18:01 <ThomasWaldmann> the time you save supporting N different markups you can invest in better subitems / item name discovery
43 2014-08-06T14:18:25 <randomax> we actually decided to do away with the subitems bar as a whole as then it would be uniform with the other themes
44 2014-08-06T14:18:43 <randomax> line 254 and line 271
45 2014-08-06T14:22:37 <ThomasWaldmann> ok, i thought you wanted to have that insertion stuff
46 2014-08-06T14:37:46 * ThomasWaldmann done with CRs
47 2014-08-06T14:38:28 <ThomasWaldmann> in general: if you want feedback on whether it looks good, do not only show the source.
48 2014-08-06T14:38:50 <randomax> ThomasWaldmann, regarding the IMMUTABLE_KEYS list, i already tried finding a similar list but i couldnt find any..
49 2014-08-06T14:38:52 <ThomasWaldmann> i am good at executing python in my brain, but rather poor when it comes to rendering html and css.
50 2014-08-06T14:38:59 <randomax> ok :)
51 2014-08-06T14:39:20 <randomax> yeah i missed adding the screenshot for the history view
52 2014-08-06T14:39:38 <skathpalia> Ok will add screenshot also :)
53 2014-08-06T14:40:02 <ThomasWaldmann> randomax: i would've bet we have one.... did you search for some of the more rarely used non-editable things?
54 2014-08-06T14:40:12 <skathpalia> going for dinner....
55 2014-08-06T14:40:29 <ThomasWaldmann> (i mean with grep or pycharm)
56 2014-08-06T14:41:40 <randomax> ThomasWaldmann, yeah i used grep.. ok i'll try once again with other keywords
57 2014-08-06T16:34:08 *** randomax
58 2014-08-06T17:29:14 *** greg_f
59 2014-08-06T17:34:42 *** magu_cic
60 2014-08-06T17:38:22 *** magu_cic_
61 2014-08-06T18:19:10 *** magu_cic_
62 2014-08-06T18:19:15 *** skathpalia
63 2014-08-06T18:22:37 *** magu_cic
64 2014-08-06T19:34:32 *** turtlemansam
65 2014-08-06T19:58:48 *** spyyy
66 2014-08-06T20:07:57 *** turtlemansam
67 2014-08-06T21:20:35 *** dave_largo
68 2014-08-06T22:30:08 *** spyyy
69
