1 2014-07-04T03:07:10  *** penguinRaider has quit IRC
   2 2014-07-04T03:20:38  *** penguinRaider has joined #moin-dev
   3 2014-07-04T03:34:07  *** penguinRaider has quit IRC
   4 2014-07-04T05:27:48  *** skathpalia has joined #moin-dev
   5 2014-07-04T07:19:05  <skathpalia> dimazest, Added subscribe and quicklink option in ticket's base.html in basic theme
   6 2014-07-04T07:19:15  <skathpalia> cr: https://codereview.appspot.com/107440046
   7 2014-07-04T07:19:44  <skathpalia> Now working on adding these features in modernized theme as well
   8 2014-07-04T07:36:23  *** penguinRaider has joined #moin-dev
   9 2014-07-04T07:41:59  *** penguinRaider__ has joined #moin-dev
  10 2014-07-04T07:47:26  <skathpalia> dimazest, I have updated the cr
  11 2014-07-04T07:47:40  <skathpalia> Added these options in other themes as well
  12 2014-07-04T08:08:54  *** skathpalia has quit IRC
  13 2014-07-04T08:24:05  *** randomax has joined #moin-dev
  14 2014-07-04T08:26:52  *** skathpalia has joined #moin-dev
  15 2014-07-04T08:30:51  <skathpalia> dimazest, updated the cr
  16 2014-07-04T08:31:38  <skathpalia> passed item only not fqname
  17 2014-07-04T08:32:00  <dimazest> ok, looks good
  18 2014-07-04T08:33:15  <skathpalia> Can I commit it?
  19 2014-07-04T08:34:36  <skathpalia> dimazest, ^^
  20 2014-07-04T08:34:50  <dimazest> yes
  21 2014-07-04T08:35:01  <skathpalia> Ok
  22 2014-07-04T08:39:26  *** skathpalia has quit IRC
  23 2014-07-04T08:45:10  *** skathpalia has joined #moin-dev
  24 2014-07-04T08:46:42  *** skathpalia has quit IRC
  25 2014-07-04T08:55:35  *** greg_f has joined #moin-dev
  26 2014-07-04T09:28:44  *** skathpalia has joined #moin-dev
  27 2014-07-04T09:49:30  *** skathpalia has quit IRC
  28 2014-07-04T10:16:42  *** jhermann has quit IRC
  29 2014-07-04T10:21:53  <dimazest> i've played a bit with never py.test version
  30 2014-07-04T10:21:54  *** penguinRaider__ has quit IRC
  31 2014-07-04T10:21:58  <dimazest> here are my findings https://codereview.appspot.com/101680044/
  32 2014-07-04T10:37:57  *** skathpalia has joined #moin-dev
  33 2014-07-04T10:39:23  *** penguinRaider has left #moin-dev
  34 2014-07-04T10:45:37  <skathpalia> dimazest, I noticed that the features I added was also shown on ticket creation page also which should not be there so I removed that
  35 2014-07-04T10:45:48  <skathpalia> updated the cr https://codereview.appspot.com/107440046
  36 2014-07-04T10:46:52  <dimazest> looks good
  37 2014-07-04T10:47:09  <skathpalia> Now I will commit it :)
  38 2014-07-04T10:56:45  *** randomax has quit IRC
  39 2014-07-04T11:02:52  *** skathpalia has quit IRC
  40 2014-07-04T11:43:48  *** randomax has joined #moin-dev
  41 2014-07-04T11:55:57  *** randomax has quit IRC
  42 2014-07-04T12:06:33  *** randomax has joined #moin-dev
  43 2014-07-04T12:29:47  <randomax> ThomasWaldmann, hi
  44 2014-07-04T12:29:51  <randomax> crs needed
  45 2014-07-04T12:29:52  <randomax> https://codereview.appspot.com/110360043/
  46 2014-07-04T12:30:04  <randomax> https://codereview.appspot.com/106390046/
  47 2014-07-04T12:30:31  <randomax> https://codereview.appspot.com/109410043/
  48 2014-07-04T12:30:40  <randomax> https://codereview.appspot.com/101630045/
  49 2014-07-04T12:30:49  <randomax> https://codereview.appspot.com/109440043/
  50 2014-07-04T12:47:43  <randomax> https://codereview.appspot.com/110210043/
  51 2014-07-04T13:01:54  *** Bernard2 has joined #moin-dev
  52 2014-07-04T13:14:44  *** skathpalia has joined #moin-dev
  53 2014-07-04T13:53:34  *** randomax has quit IRC
  54 2014-07-04T14:10:29  *** RogerHaase has joined #moin-dev
  55 2014-07-04T14:11:26  *** jhermann has joined #moin-dev
  56 2014-07-04T14:13:50  *** randomax has joined #moin-dev
  57 2014-07-04T14:16:20  <randomax> RogerHaase, hi.. crs needed
  58 2014-07-04T14:16:24  <randomax> https://codereview.appspot.com/110360043/
  59 2014-07-04T14:16:30  <randomax> https://codereview.appspot.com/110360043/
  60 2014-07-04T14:17:04  <randomax> sorry pasted the same link twice - https://codereview.appspot.com/106390046/
  61 2014-07-04T14:17:13  <randomax> https://codereview.appspot.com/109410043/
  62 2014-07-04T14:17:19  <randomax> https://codereview.appspot.com/101630045/
  63 2014-07-04T14:17:27  <randomax> https://codereview.appspot.com/109440043/
  64 2014-07-04T14:22:41  <RogerHaase> randomax: is EMAIL_UNVALIDATED the email address?
  65 2014-07-04T14:23:13  <randomax> yes.. each time an account is created
  66 2014-07-04T14:23:21  <randomax> the user is sent a confirmation
  67 2014-07-04T14:23:38  <randomax> until he confirms the account from the link sent to him
  68 2014-07-04T14:24:02  <randomax> the email is stored in the EMAIL_UNVALIDATED field
  69 2014-07-04T14:41:14  *** skathpalia has quit IRC
  70 2014-07-04T14:41:30  <randomax> going for dinner.. will brb
  71 2014-07-04T14:49:09  *** skathpalia has joined #moin-dev
  72 2014-07-04T15:02:29  *** skathpalia has quit IRC
  73 2014-07-04T15:25:18  *** mansi has joined #moin-dev
  74 2014-07-04T16:35:21  *** skathpalia has joined #moin-dev
  75 2014-07-04T16:42:33  *** skathpalia has quit IRC
  76 2014-07-04T16:53:16  *** skathpalia has joined #moin-dev
  77 2014-07-04T16:55:04  <randomax> RogerHaase, updated cr https://codereview.appspot.com/101650043/
  78 2014-07-04T16:55:34  <randomax> for issue #444
  79 2014-07-04T17:03:58  <RogerHaase> randomax: done
  80 2014-07-04T17:05:16  <RogerHaase> randomax: took me a while, but I eventually got all your patches applied together (hopefully correctly).
  81 2014-07-04T17:08:16  <randomax> ok :)
  82 2014-07-04T17:10:07  <RogerHaase> randomax: in skathpalia's 4cc1d15c203c patch, he repositioned table sorter background image to left instead of right. So now it overlays your heading text on User ACL Info and ACL Report
  83 2014-07-04T17:13:17  <skathpalia> randomax, may be padding-left: 20px would work
  84 2014-07-04T17:13:28  <skathpalia> worked in case of mine as https://bitbucket.org/thomaswaldmann/moin-2.0/src/bc0f43fecbc7699157d5d981d16f527c779d7b6d/MoinMoin/themes/basic/static/css/basic.css?at=default#cl-6945
  85 2014-07-04T17:16:03  <randomax> ok.. yeah i see that..
  86 2014-07-04T17:16:15  <randomax> ok.. i'll add padding
  87 2014-07-04T17:16:38  <skathpalia> randomax,I think padding should be added here
  88 2014-07-04T17:16:40  <skathpalia> https://bitbucket.org/thomaswaldmann/moin-2.0/src/bc0f43fecbc7699157d5d981d16f527c779d7b6d/MoinMoin/themes/basic/static/css/basic.css?at=default#cl-6945
  89 2014-07-04T17:17:25  <skathpalia> then it would be generic and no one has to specifically add this in future
  90 2014-07-04T17:17:41  <randomax> yeah.. i'll change that
  91 2014-07-04T17:22:10  <skathpalia> randomax, Oh I gave you wrong line number
  92 2014-07-04T17:22:23  <skathpalia> The correct one is 6967
  93 2014-07-04T17:22:48  <skathpalia> Here I have defined the css for table-sorter-header
  94 2014-07-04T17:24:36  *** Bernard2 has quit IRC
  95 2014-07-04T17:25:03  <randomax> ok
  96 2014-07-04T17:27:37  <RogerHaase> I am thinking 6945 is correct, but also apply rule to ".moin-tablesort > thead > th" or similar
  97 2014-07-04T17:28:51  <randomax> i guess the class that needs the padding is tablesorter-header-inner
  98 2014-07-04T17:29:24  <randomax> it works fine when i apply padding 20px for tablesorter-header-inner
  99 2014-07-04T17:31:26  <RogerHaase> that looks like it should work
 100 2014-07-04T17:34:06  *** mansi has quit IRC
 101 2014-07-04T17:34:12  <RogerHaase> are you adding to existing rule so you pick up cursor:pointer as well?
 102 2014-07-04T17:34:55  <RogerHaase> where :P s/b : p
 103 2014-07-04T17:35:57  <randomax> added that..
 104 2014-07-04T17:39:08  <RogerHaase> randomax: this is more potential scope creep, are we leaving issue of css for modernized theme for another patch?
 105 2014-07-04T17:39:50  <randomax> yes i think we should do that
 106 2014-07-04T17:39:59  <randomax> i'll create an issue for that in my repo
 107 2014-07-04T17:40:05  <randomax> so that i remember
 108 2014-07-04T17:40:10  <RogerHaase> ok, good
 109 2014-07-04T17:41:47  <RogerHaase> randomax: did you succeed in creating a ACL rule that used a group?
 110 2014-07-04T17:44:22  <randomax> sorry i was doing the other cr's today.. i'll try that now
 111 2014-07-04T17:46:34  <RogerHaase> randomax: you saw my note yesterday:  I did get the WikiGroups working... Create an item ending in Group, like TrustedGroup, then edit the metadata and add """ "usergroup": ["RogerHaase","JohnDoe"],  """, then use that in an ACL rule: TrustedGroup:read,write,create,destroy,admin
 112 2014-07-04T17:47:26  *** skathpalia has quit IRC
 113 2014-07-04T17:47:32  <randomax> yes.. doing that only
 114 2014-07-04T17:49:40  <RogerHaase> afaik that seems undocumented.  In moin 1.9 you just made a list of users inside the page content and could even have a link to another page containing lists of users
 115 2014-07-04T17:56:09  <randomax> RogerHaase, the page seems to get created as said
 116 2014-07-04T17:56:17  <randomax> along with the specified metadata
 117 2014-07-04T17:57:08  <randomax> but the groupname does get shown in the "Member of groups" section in userbrowser view
 118 2014-07-04T17:57:29  <randomax> and also the user acl info does not seem to get affected
 119 2014-07-04T17:57:55  <RogerHaase> randomax: sorry for late comment, on User ACL Info, I would remove Can's so "Can Write" becomes "Write", etc.
 120 2014-07-04T17:58:18  <randomax> ok.. np.. will do that
 121 2014-07-04T17:58:47  <RogerHaase> hmm, it shows member of groups for me
 122 2014-07-04T18:00:51  <randomax> does the user acl info get affected accordingly ?
 123 2014-07-04T18:02:45  *** greg_f has quit IRC
 124 2014-07-04T18:03:18  <RogerHaase> yes
 125 2014-07-04T18:05:28  <RogerHaase> the meta data of my TrustedGroup:  https://paste.thinkmo.de/4aa11d3e-2994-40e1-bf39-5d092d5215b1
 126 2014-07-04T18:05:40  <RogerHaase> must break for 30 min
 127 2014-07-04T18:06:25  <randomax> ok.. i'll try it out till then
 128 2014-07-04T18:28:35  * dimazest ported MoinMoin tests to the latest pytests
 129 2014-07-04T18:28:46  <dimazest> could you have a look to https://codereview.appspot.com/101680044/
 130 2014-07-04T18:28:58  <dimazest> it's quite big, but the changes are mechanical
 131 2014-07-04T18:29:09  <dimazest> the main change is in conftest.py
 132 2014-07-04T18:38:04  <RogerHaase> back
 133 2014-07-04T18:39:35  <randomax> RogerHaase, yeah i made it work
 134 2014-07-04T18:43:22  <randomax> RogerHaase, i think currently there are no methods to check acl rights for groups for an item.. are there ?
 135 2014-07-04T18:45:07  <RogerHaase> no, there are none
 136 2014-07-04T18:50:16  <RogerHaase> randomax: how about expanding / correcting your thoughts on EP week 8?
 137 2014-07-04T20:08:09  <RogerHaase> dimazest: I downloaded your patch and ran on windows. seems like number of tests doubled and run time was twice as long. Will look at it more later.
 138 2014-07-04T20:08:45  <RogerHaase> gtg, attend holiday celebrations
 139 2014-07-04T20:08:51  *** RogerHaase has left #moin-dev
 140 2014-07-04T20:49:48  *** penguinRaider has joined #moin-dev
 141 2014-07-04T21:11:13  *** randomax has quit IRC
 142

MoinMoin: MoinMoinChat/Logs/moin-dev/2014-07-04 (last edited 2014-07-04 03:15:03 by IrcLogImporter)