1 2014-07-02T00:56:32 *** RogerHaase
2 2014-07-02T02:44:16 *** penguinRaider
3 2014-07-02T04:05:12 *** sl33k_
4 2014-07-02T04:23:19 *** sl33k_
5 2014-07-02T04:26:47 *** RogerHaase
6 2014-07-02T04:29:46 *** sl33k_
7 2014-07-02T04:33:12 *** RogerHaase
8 2014-07-02T04:51:33 *** sl33k_
9 2014-07-02T05:21:13 *** skathpalia
10 2014-07-02T05:23:24 <skathpalia> dimazest, I am not able to get why we need to use moin functions directly for testing
11 2014-07-02T05:23:36 <skathpalia> as it is mentioned here https://bitbucket.org/thomaswaldmann/moin-2.0/src/647ee04f863e71976300646c938787bf668e3ce7/_ui_tests/README.txt?at=default#cl-7
12 2014-07-02T05:24:36 <skathpalia> In _ui_tests the tests are not calling moin functions
13 2014-07-02T05:25:21 <skathpalia> May be we should discuss this with ThomasWaldmann and get an idea of how tests should be written
14 2014-07-02T05:26:22 <skathpalia> Whats your view on this?
15 2014-07-02T06:55:08 <dimazest> skathpalia: true
16 2014-07-02T06:57:35 <dimazest> look here https://code.google.com/p/selenium/issues/detail?id=4477
17 2014-07-02T06:57:41 <dimazest> seems that selenium can be used
18 2014-07-02T06:58:04 <dimazest> so, while we figure out all the legal issues
19 2014-07-02T06:58:27 <dimazest> could you create a file inside of _ui_tests, for example, test_tickets.py
20 2014-07-02T06:58:33 <dimazest> put your test there
21 2014-07-02T06:58:51 <dimazest> remove object instantiation and method call
22 2014-07-02T06:59:04 <dimazest> you will be able to run the tests by
23 2014-07-02T06:59:20 <dimazest> py.test _ui_tests/
24 2014-07-02T06:59:55 <dimazest> or py.test _ui_tests/ -vlx # these are the flags I usually set, check py.test -h for more
25 2014-07-02T07:00:20 <dimazest> could you also create a code review
26 2014-07-02T07:13:51 <skathpalia> dimazest, making a cr
27 2014-07-02T07:20:06 <skathpalia> dimazest, I think instantiation is required for test to work
28 2014-07-02T07:20:36 <skathpalia> as it is done here also https://bitbucket.org/thomaswaldmann/moin-2.0/src/647ee04f863e71976300646c938787bf668e3ce7/_ui_tests/test_subitems.py?at=default#cl-64
29 2014-07-02T07:21:01 <dimazest> No, that's done for other reasons
30 2014-07-02T07:21:24 <dimazest> A test runner will execute that code
31 2014-07-02T07:22:35 <dimazest> Could you create a cr, I have a bit of time, then I need to go
32 2014-07-02T07:23:52 <skathpalia> here is the cr https://codereview.appspot.com/109400043
33 2014-07-02T07:24:44 *** sl33k_
34 2014-07-02T07:32:01 <skathpalia> dimazest, ^^
35 2014-07-02T07:32:13 <dimazest> i'm commenting
36 2014-07-02T07:39:14 <dimazest> skathpalia: see my comments
37 2014-07-02T07:48:58 *** sl33k_
38 2014-07-02T07:50:20 <skathpalia> dimazest, should I remove the create ticket method in the test?
39 2014-07-02T07:50:36 <skathpalia> so that it uses the earlier create tickets
40 2014-07-02T07:50:49 <skathpalia> *earlier created tickets
41 2014-07-02T07:50:49 <dimazest> leave it for now
42 2014-07-02T07:51:00 <dimazest> actually, it should be a fixture as well
43 2014-07-02T07:52:24 <dimazest> I need to go, I'll try to be back soon
44 2014-07-02T07:52:46 <skathpalia> Ok
45 2014-07-02T07:57:43 *** penguinRaider
46 2014-07-02T08:13:14 *** sl33k_
47 2014-07-02T08:29:07 *** sl33k_
48 2014-07-02T08:51:23 <skathpalia> dimazest, I have updated the cr
49 2014-07-02T08:51:57 <skathpalia> But when whoosh query is run then an error is raised "RuntimeError: working outside of application context"
50 2014-07-02T08:52:08 <skathpalia> I am not able to remove this error
51 2014-07-02T08:52:28 <dimazest> i'm checking it
52 2014-07-02T08:55:59 *** sl33k_
53 2014-07-02T08:58:05 <skathpalia> going for lunch, will be back soon
54 2014-07-02T09:00:19 <dimazest> ok, i'm looking how to get the context
55 2014-07-02T09:00:26 <dimazest> try to run the tests as py.test -k ticket
56 2014-07-02T09:00:40 <dimazest> without giving the path to the tests
57 2014-07-02T09:01:54 <dimazest> this should create the context https://bitbucket.org/thomaswaldmann/moin-2.0/src/647ee04f863e71976300646c938787bf668e3ce7/MoinMoin/conftest.py?at=default#cl-80
58 2014-07-02T09:02:17 *** penguinRaider
59 2014-07-02T09:18:27 *** greg_f
60 2014-07-02T09:20:13 <skathpalia> dimazest, py.test -k ticket is showing import error ImportError: No module named flask.ext.cache
61 2014-07-02T09:24:55 *** sl33k_
62 2014-07-02T09:33:05 *** randomax
63 2014-07-02T10:03:16 <skathpalia> dimazest, ^^
64 2014-07-02T10:35:07 <dimazest> Did you install it?
65 2014-07-02T10:35:33 <dimazest> You need to activate the virtual environment
66 2014-07-02T10:35:48 <dimazest> source activate
67 2014-07-02T10:36:05 <dimazest> Type this in shell
68 2014-07-02T10:36:29 <skathpalia> Oh I activated that
69 2014-07-02T10:36:46 <skathpalia> and now it cannot import selenium
70 2014-07-02T10:36:59 <skathpalia> which I have done in test_tickets.py
71 2014-07-02T10:39:05 <skathpalia> dimazest, If I remove that import selenium statement then it shows that pytest has no attribute yield_fixture
72 2014-07-02T10:49:39 *** randomax
73 2014-07-02T10:55:10 <dimazest> That's an old pytest version
74 2014-07-02T10:55:13 <dimazest> Run
75 2014-07-02T10:55:25 <dimazest> Pip -U pytest
76 2014-07-02T10:56:07 <skathpalia> but it also shows error on import selenium statement
77 2014-07-02T10:56:13 <skathpalia> while selenium is installed
78 2014-07-02T10:56:41 <skathpalia> Also I installed pytest this way only
79 2014-07-02T11:03:44 <dimazest> you should do this http://cl.ly/image/0h2n3X3l0T2P/Screen%20Shot%202014-07-02%20at%2014.02.35.png
80 2014-07-02T11:05:01 <skathpalia> Yeah I tried that but it still shows import error for selenium
81 2014-07-02T11:11:56 <skathpalia> dimazest, Can you please check where is the selenium directory in your pc?
82 2014-07-02T11:15:22 <dimazest> https://paste.thinkmo.de/41fdbdef-d1f9-4dcd-90dd-65ebe51bf1cd
83 2014-07-02T11:18:48 <skathpalia> dimazest, Can you please import my patch and then run tests?
84 2014-07-02T11:19:01 <skathpalia> May be you won't get any error
85 2014-07-02T11:21:50 *** sl33k_
86 2014-07-02T11:23:04 <dimazest> skathpalia: first i had to hack setup.py
87 2014-07-02T11:23:07 <dimazest> https://paste.thinkmo.de/7ac18fe2-f8a1-45ec-a15f-3bc3f1b5aea2
88 2014-07-02T11:24:45 <skathpalia> But i am not able to understand why import selenium is causing error
89 2014-07-02T11:24:51 <dimazest> http://bpaste.net/show/428126/
90 2014-07-02T11:25:27 <dimazest> did you install it inside of the virtual environment?
91 2014-07-02T11:25:41 <skathpalia> No
92 2014-07-02T11:26:11 <skathpalia> But still I copied the directory to <virtual-env>
93 2014-07-02T11:26:24 <dimazest> better do pip install selenium
94 2014-07-02T11:27:05 <dimazest> or add selenium to setup.py and run quickinstall
95 2014-07-02T11:28:01 <dimazest> (though adding selenium to setup.py needs a revision)
96 2014-07-02T11:30:25 <skathpalia> i am installing it :)
97 2014-07-02T11:33:09 <skathpalia> dimazest, what may be the reason of the error RuntimeError: working outside of application context which comes on running test?
98 2014-07-02T11:41:06 *** randomax
99 2014-07-02T11:46:58 *** sl33k_
100 2014-07-02T12:00:05 <skathpalia> dimazest, any idea about the reason of this error?
101 2014-07-02T12:46:13 *** skathpalia
102 2014-07-02T12:51:01 *** dave_largo
103 2014-07-02T12:55:49 <randomax> ThomasWaldmann, cr for https://bitbucket.org/thomaswaldmann/moin-2.0/issue/444/traceback-on-trying-to-access-item-which
104 2014-07-02T12:55:54 <randomax> https://codereview.appspot.com/101650043
105 2014-07-02T12:59:55 *** skathpalia
106 2014-07-02T13:02:33 <dimazest> skathpalia: i'll have a look
107 2014-07-02T13:02:42 <dimazest> do you get the same error as i do?
108 2014-07-02T13:03:36 <skathpalia> yeah
109 2014-07-02T13:08:00 <dimazest> MoinMoin/macro/_tests/test_GetVal.py:24 :)
110 2014-07-02T13:08:57 <ananasova> moin :)
111 2014-07-02T13:09:01 <dimazest> hi
112 2014-07-02T13:09:10 <dimazest> skathpalia: i made the test passing
113 2014-07-02T13:09:36 <dimazest> the problem is that the test setup (testconfig.py) is inside of the MoinMoin folder
114 2014-07-02T13:09:44 <dimazest> but the _ui tests are outside
115 2014-07-02T13:09:53 <ananasova> how is gsoc going? i see the channel is very active.
116 2014-07-02T13:10:17 <dimazest> so, when the _ui tests are run, the pytest is not configured as desired
117 2014-07-02T13:10:39 <dimazest> i've just linked the MoinMoin/conftest.py to conftest.py
118 2014-07-02T13:11:33 <dimazest> i've also had to comment out MoinMoin/log.py:16
119 2014-07-02T13:11:39 <dimazest> as l is not defined there
120 2014-07-02T13:11:50 <dimazest> ananasova: indeed :)
121 2014-07-02T13:14:27 <ananasova> i have a question regarding open source licences. i remember last year moin was very careful and knowledgeable when picking twitter bootstrap for UI building
122 2014-07-02T13:16:07 <ananasova> is it possible to contribute to a project which lacks a licence?
123 2014-07-02T13:16:45 <ananasova> does that imply that this is not an open source contribution? if so, what is it?
124 2014-07-02T13:17:41 <dimazest> i guess, then it's copyrighted by the author
125 2014-07-02T13:18:08 <dimazest> ThomasWaldmann: regarding https://code.google.com/p/selenium/issues/detail?id=4477
126 2014-07-02T13:18:29 <dimazest> if we put functional tests outside of MoinMoin folder
127 2014-07-02T13:18:44 <dimazest> are there still gpl/apache licensing issues
128 2014-07-02T13:19:45 <dimazest> ananasova: is the code on github or something similar, where you can send a pull request?
129 2014-07-02T13:19:55 <ananasova> dimazest: yes
130 2014-07-02T13:20:01 <ananasova> and we are actually doing that
131 2014-07-02T13:20:48 <dimazest> maybe just propose to license the project to the owner
132 2014-07-02T13:21:15 <ananasova> writing an issue about that now
133 2014-07-02T13:21:44 <ananasova> i thought it's peculiar that the project was not released under a licence till now
134 2014-07-02T13:22:07 <ananasova> knowing that there are going to be contributors
135 2014-07-02T13:22:50 <dimazest> was it developed by several people?
136 2014-07-02T13:23:19 * dimazest thinks that if it's just one author, then it's up to her to change the license
137 2014-07-02T13:24:12 <ananasova> it's a new project started within gsoc and there are 2 contributors atm
138 2014-07-02T13:26:02 <dimazest> then it's up to them
139 2014-07-02T13:27:00 <dimazest> if it was gsoc, it should be some open source license anyway
140 2014-07-02T13:27:35 <ananasova> it is gsoc :)
141 2014-07-02T13:28:31 <ananasova> thanks for the advice
142 2014-07-02T13:29:13 <dimazest> but i'm not an expert, that's more an opinion
143 2014-07-02T13:29:45 <ananasova> the important thing is done, i raised the question
144 2014-07-02T13:30:13 <ananasova> just wasn't sure if the question was appropriate
145 2014-07-02T13:39:12 <skathpalia> dimazest, the search query in the test is always returning none
146 2014-07-02T13:39:50 <dimazest> because you haven't created a ticket
147 2014-07-02T13:40:13 <dimazest> so
148 2014-07-02T13:40:46 <dimazest> create a fixture, call it closed_ticket
149 2014-07-02T13:41:02 <dimazest> and move the code from create_ticket
150 2014-07-02T13:41:42 <skathpalia> But then when it goes to browser then it would check for the tickets that are earlier created also
151 2014-07-02T13:41:44 <dimazest> for now, keep itemname, summary and tags as random strings
152 2014-07-02T13:41:55 <dimazest> yes
153 2014-07-02T13:42:15 <dimazest> but we can assert that this ticket is shown
154 2014-07-02T13:42:24 <dimazest> (because we know it's id)
155 2014-07-02T13:42:53 <dimazest> (we need to look for the best solution)
156 2014-07-02T13:42:55 <skathpalia> Okay do you mean that I should check if that id is in the the ids that are shown in the browser
157 2014-07-02T13:43:00 <skathpalia> right?
158 2014-07-02T13:43:08 <dimazest> yes
159 2014-07-02T13:43:33 <dimazest> in addition you can also create an open ticket an check that it's not shown
160 2014-07-02T13:44:34 <skathpalia> Okay
161 2014-07-02T13:45:13 <skathpalia> How would I get the itemid of the ticket that is create by test?
162 2014-07-02T13:45:48 <dimazest> the fixture should return the ticket
163 2014-07-02T13:46:00 <dimazest> then the test should take it as an arguement
164 2014-07-02T13:46:14 <dimazest> once you have a ticket object, you can get it's id
165 2014-07-02T13:47:04 <skathpalia> But in the fixture the ticket is created by UI so how can we get itemid until the underlying code is not directly involved?
166 2014-07-02T13:48:02 <dimazest> right, then you need to create it without UI
167 2014-07-02T13:48:43 <dimazest> alternatively you should be able to get it from the url after the redirect
168 2014-07-02T13:48:54 <dimazest> or show a message that a ticket was created
169 2014-07-02T13:49:15 <skathpalia> But that would just tell initial name of the ticket
170 2014-07-02T13:49:24 <dimazest> is there a simple way to create a ticket using python?
171 2014-07-02T13:49:49 <skathpalia> I haven't tried that
172 2014-07-02T13:49:59 <dimazest> don't you get a link like http://localhost:8080/%40itemid/ab305fa2cd4e4c8f92827e650c451e4d
173 2014-07-02T13:50:00 *** RogerHaase
174 2014-07-02T13:50:05 <dimazest> after ticket creation?
175 2014-07-02T13:50:19 <skathpalia> No its the link after ticket updation
176 2014-07-02T13:50:42 <skathpalia> one more thing can be done that we update the ticket as soon as it is created
177 2014-07-02T13:50:53 <skathpalia> Then we will have itemid in the redirected url
178 2014-07-02T13:51:31 <skathpalia> what do you say about this idea?
179 2014-07-02T13:52:09 <dimazest> ok, let see how it looks
180 2014-07-02T14:00:28 <skathpalia> oh dimazest even that would not work
181 2014-07-02T14:00:34 <dimazest> why?
182 2014-07-02T14:01:08 <skathpalia> I forgot that when ticket is updated then also it takes it to the url <domail>/'NAME_OF_TICKET'
183 2014-07-02T14:01:23 <skathpalia> itemid is not there in url :(
184 2014-07-02T14:01:55 <skathpalia> We have to create ticket items by simple python only
185 2014-07-02T14:02:24 <dimazest> let's do so then
186 2014-07-02T14:04:07 <skathpalia> Do you know how this can be done?
187 2014-07-02T14:04:37 <dimazest> not really
188 2014-07-02T14:04:49 <dimazest> what view creates ticktes?
189 2014-07-02T14:05:27 <skathpalia> There is generic modify view for creating all items
190 2014-07-02T14:06:12 <dimazest> this https://bitbucket.org/thomaswaldmann/moin-2.0/src/647ee04f863e71976300646c938787bf668e3ce7/MoinMoin/apps/frontend/views.py?at=default#cl-552 ?
191 2014-07-02T14:06:38 <dimazest> seems that item = Item.create(item_name, itemtype=itemtype, contenttype=contenttype)
192 2014-07-02T14:06:41 <skathpalia> yeah
193 2014-07-02T14:06:41 <dimazest> is all we need
194 2014-07-02T14:06:47 <dimazest> will it have id?
195 2014-07-02T14:06:55 <dimazest> or we need to update it?
196 2014-07-02T14:07:12 <skathpalia> it should have id
197 2014-07-02T14:07:42 <skathpalia> we also need to use _save method to save items
198 2014-07-02T14:11:38 *** magu_cic
199 2014-07-02T14:14:00 <RogerHaase> randomax: you are working on your User Wise and Group Wise tab designs?
200 2014-07-02T14:14:49 <RogerHaase> randomax: 101650043 looks OK to me, ask tw
201 2014-07-02T14:28:43 <RogerHaase> randomax: on https://codereview.appspot.com/110210043/ you missed giving a response to tw's name_old to old_name suggestion
202 2014-07-02T14:32:35 <RogerHaase> randomax: do you have any open CR's other than 101650043 and 110210043?
203 2014-07-02T14:55:47 <RogerHaase> randomax: changed my mind on https://codereview.appspot.com/101650043/
204 2014-07-02T15:01:58 * dimazest is looking at MoinTestFunction magik at conftest.py
205 2014-07-02T15:02:14 <dimazest> magic
206 2014-07-02T15:03:22 *** randomax
207 2014-07-02T15:05:46 <dimazest> removing it breaks some tests, but not all of them!
208 2014-07-02T15:16:26 *** randomax
209 2014-07-02T15:18:00 <randomax> sorry something is went wrong in my connection.. i wrote my replies and then it disconnected
210 2014-07-02T15:18:03 <randomax> RogerHaase, isnt 403 error is raised only when access denied situation occurs ?
211 2014-07-02T15:18:09 <randomax> can you give a situation where thats not the case ?
212 2014-07-02T15:18:15 <randomax> on https://codereview.appspot.com/110210043/ .. yeah i did not say anything bcoz i agree i'll change it to Old Name
213 2014-07-02T15:18:19 <randomax> also i am working on https://bitbucket.org/thomaswaldmann/moin-2.0/issue/445/traceback-on-changing-the-acl-rights-such
214 2014-07-02T15:18:36 <dimazest> skathpalia: seems that some changes are needed to be done to be able to use the latest pytest version :(
215 2014-07-02T15:19:27 <skathpalia> Yeah its also mentioned in the comment in setup.py
216 2014-07-02T15:20:28 <skathpalia> Now should I switch to the older version or use the latest one only?
217 2014-07-02T15:23:27 <dimazest> i think so
218 2014-07-02T15:24:23 <dimazest> then instead of yield_fixture
219 2014-07-02T15:24:27 <dimazest> use fixture
220 2014-07-02T15:24:35 <dimazest> and add a finilizer
221 2014-07-02T15:24:35 <skathpalia> then I will have to make test in the earlier format
222 2014-07-02T15:24:36 <dimazest> http://pytest.org/latest/fixture.html#fixture-finalization-executing-teardown-code
223 2014-07-02T15:24:47 <skathpalia> similar to that of test_subitems.py
224 2014-07-02T15:28:11 <RogerHaase> randomax: maybe I am confused, the cr is for 444 or 445?
225 2014-07-02T15:35:03 *** skathpalia
226 2014-07-02T15:35:44 <RogerHaase> randomax: if 444, the access denied message looks like user is a list? I get similar message when acl = "all:read"
227 2014-07-02T15:36:17 <randomax> the cr is for 444
228 2014-07-02T15:38:51 <randomax> RogerHaase, i think you get that bcoz it should be "All" instead of "all"
229 2014-07-02T15:39:04 <RogerHaase> randomax: try with acl = u'All:read,write,create,destroy,admin'
230 2014-07-02T15:39:21 <RogerHaase> I think you get same result
231 2014-07-02T15:41:37 <randomax> ok.. if i use "u'All:read,write,create,destroy,admin'" i get access denied
232 2014-07-02T15:42:00 <randomax> but if i use "All:read,write,create,destroy,admin" i am able to access it
233 2014-07-02T15:42:35 <randomax> without the quotes that is
234 2014-07-02T15:43:00 <randomax> so maybe we just got to use normal text instead of unicode string format over there
235 2014-07-02T15:43:50 <randomax> RogerHaase, ^
236 2014-07-02T15:45:49 <RogerHaase> randomax: you are correct, I get better results with All. I do not think we can switch to plain test though, can user name be non-ascii?
237 2014-07-02T15:50:24 <randomax> RogerHaase, yes
238 2014-07-02T15:50:27 <randomax> just tried it
239 2014-07-02T15:50:39 <randomax> they can be non ascii
240 2014-07-02T15:51:58 <randomax> i tried one more thing
241 2014-07-02T15:52:03 <RogerHaase> randomax: if I create user "all", then I can set acl to lower case all - "all:read,write,create,destroy,admin"
242 2014-07-02T15:52:20 <randomax> yep..
243 2014-07-02T15:52:44 <randomax> but then only the user name all will access it i guess
244 2014-07-02T15:53:11 <randomax> also we can still use non ascii names in the acl section without using u''
245 2014-07-02T15:53:23 <RogerHaase> yes, but you could add other rules
246 2014-07-02T15:55:17 <randomax> RogerHaase, i didnt get you..
247 2014-07-02T15:56:18 <RogerHaase> ... and setting a rule for user "all" should not impact default rule for "All" everyone should be able to read
248 2014-07-02T15:57:47 <RogerHaase> you should be able to set a rule "All:read GrandPoobah:read,write,create,destroy,admin"
249 2014-07-02T16:00:32 <RogerHaase> similar to example here https://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=acl#acls-basic-syntax
250 2014-07-02T16:02:19 <randomax> yes.. i tried it out
251 2014-07-02T16:02:29 <randomax> it works as mentioned
252 2014-07-02T16:03:37 <randomax> RogerHaase, ^
253 2014-07-02T16:04:00 <randomax> does it not in yours ?
254 2014-07-02T16:07:06 <RogerHaase> yes, but if I try to use non-existant user name I get traceback similar to 445
255 2014-07-02T16:20:37 <randomax> RogerHaase, in 445 http://pastebin.com/M3AkL0Az here the search fails to find an object in case I am not allowed to see it.. or as you pointed out that in case you made it for a currently non-existent user
256 2014-07-02T16:20:47 <randomax> i made a patch - http://codereview.appspot.com/109410043
257 2014-07-02T16:20:58 <randomax> it solves both the issues
258 2014-07-02T16:23:47 *** skathpalia
259 2014-07-02T16:29:03 <RogerHaase> ra by both issues you mean 444 and 445?
260 2014-07-02T16:30:08 <randomax> no by both i meant - in case I am not allowed to see it.. or as you pointed out that in case you made it for a currently non-existent user
261 2014-07-02T16:33:33 <randomax> ThomasWaldmann, updated cr and replied to comment - https://codereview.appspot.com/110210043/
262 2014-07-02T16:37:19 *** dave_largo
263 2014-07-02T16:37:44 <RogerHaase> with you patch, I still get AccessDenied: item does not allow user '[u'RogerHaase']' to ''read or pubread'' [u'FutureUser:'] with traceback
264 2014-07-02T16:39:34 <randomax> RogerHaase, you'll need to apply patches for 444 and 445 together
265 2014-07-02T16:47:11 <RogerHaase> randomax: OK, both together get rid of traceback
266 2014-07-02T16:48:22 <RogerHaase> and I agree user.name being a list instead is not a problem, just looks odd in message, but OK
267 2014-07-02T16:55:07 <randomax> can i commit ?
268 2014-07-02T16:58:16 <RogerHaase> wait for tw to agree
269 2014-07-02T16:59:37 <randomax> ok
270 2014-07-02T17:01:48 <RogerHaase> randomax: still testing, but I think I cannot become superuser with both patches applied
271 2014-07-02T17:07:47 <randomax> RogerHaase, where do we change rights for acl_functions ?
272 2014-07-02T17:09:31 <randomax> * acl for functions
273 2014-07-02T17:16:24 *** skathpalia
274 2014-07-02T17:21:02 <ThomasWaldmann> re
275 2014-07-02T17:22:03 <RogerHaase> randomax: I am using https://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=acl#namespaces (there is a missing ")"
276 2014-07-02T17:32:07 * ThomasWaldmann gtg again... (sorry)
277 2014-07-02T17:32:54 <randomax> RogerHaase, i was able to become superuser
278 2014-07-02T17:34:36 <RogerHaase> randomax: yes, I can too, but so far not with https://moin-20.readthedocs.org/en/latest/admin/configure.html?highlight=acl#namespaces modified with a superuser clause
279 2014-07-02T17:41:51 <RogerHaase> need a rest...., back in ~30 min
280 2014-07-02T17:47:21 <randomax> ok
281 2014-07-02T17:47:59 <randomax> i looked and found that acl for functions is configured to work according to the separate key "acl_functions" in the config file
282 2014-07-02T17:48:21 <randomax> so it is separate from the acl mapping you pointed out
283 2014-07-02T17:48:24 <randomax> RogerHaase, ^
284 2014-07-02T18:08:08 *** greg_f
285 2014-07-02T18:27:00 <RogerHaase> re.; flipped back to say https://codereview.appspot.com/101650043/ looks OK
286 2014-07-02T18:27:47 <randomax> ok
287 2014-07-02T20:34:59 <randomax> RogerHaase, Made a sample ACL report view - https://codereview.appspot.com/109440043
288 2014-07-02T20:44:28 <RogerHaase> randomax: nice, should have an initial sequence, probably by item name. Do you know how to make it sortable?
289 2014-07-02T20:45:32 <randomax> what can be the probable parameters for sorting ?
290 2014-07-02T20:50:25 <RogerHaase> from skathpalia's commit it looks like you must add JS or $("#ticket-list").tablesorter(); where #ticket-list is ID of table. The seems non-optimum, we should just have a moin-* class name and every table with that class would be sorted by the mottie tablesorter
291 2014-07-02T20:51:04 <RogerHaase> commit = 647ee04f863e
292 2014-07-02T20:52:32 <RogerHaase> JS or/JS of
293 2014-07-02T21:10:24 <randomax> RogerHaase, added sorting - https://codereview.appspot.com/109440043
294 2014-07-02T21:15:41 <RogerHaase> I meant a class like moin-sortable so no one has to change JS ever - every table that is created with with that class gets sorted
295 2014-07-02T21:29:07 <randomax> oh.. ya my bad.. will add that
296 2014-07-02T21:29:39 <RogerHaase> randomax: and if you add an attribute like data-sortlist="[[0,0]]" http://mottie.github.io/tablesorter/docs/#sortlist then it should get sorted at page load
297 2014-07-02T21:36:54 <randomax> RogerHaase, updated the cr https://codereview.appspot.com/109440043
298 2014-07-02T21:41:18 <RogerHaase> randomax: you probably want a class rather than an ID in case an item ever has more than one table that needs sorting. On the JS, you do not need the if test, if there are no matches nothing bad happens
299 2014-07-02T21:43:15 <RogerHaase> ...trying to figure out why there are no icons to indicate sort sequence (not hard to do in this instance)
300 2014-07-02T21:45:10 <randomax> The icons are there..
301 2014-07-02T21:46:57 <RogerHaase> ah, they appear in basic theme, not modernized
302 2014-07-02T21:50:33 <RogerHaase> looks like skathpalia only added the css to basic theme
303 2014-07-02T21:50:57 <RogerHaase> randomax: do you sleep?
304 2014-07-02T21:52:19 <randomax> Umm.. yeah i have started sleeping late upto the afternoon
305 2014-07-02T21:54:09 <randomax> updated the cr : https://codereview.appspot.com/109440043
306 2014-07-02T21:58:59 <RogerHaase> what does class tablesorter-default in aclreport.html do?
307 2014-07-02T22:00:19 <randomax> it is basically the theme for the table
308 2014-07-02T22:02:44 <RogerHaase> also table-hover... looking for css...
309 2014-07-02T22:09:17 *** penguinRaider
310 2014-07-02T22:10:18 <RogerHaase> I cannot find those 2 classes being used.
311 2014-07-02T22:14:30 <randomax> ok.. then i guess currently we just use the js functionality of the sorter with our own css
312 2014-07-02T22:15:21 *** dennda
313 2014-07-02T22:15:25 <randomax> i'll confirm that with skathpalia
314 2014-07-02T22:15:56 *** dennda
315 2014-07-02T22:17:26 <RogerHaase> randomax: I need to break for day, tomorrow you should try to add to design of User Wise and Group Wise tabs. After this last patch is approved by TW there needs to be a follow on patch to merge skathpalia's way of sorting with yours -- his basic.less changes must be put on modernized and his IDs changed to classes
316 2014-07-02T22:18:28 <randomax> ok
317 2014-07-02T22:19:28 *** RogerHaase
318 2014-07-02T22:27:21 *** randomax
319
