1 2014-06-28T00:01:11 *** Gnarlodious
2 2014-06-28T00:49:57 *** Gnarlodious
3 2014-06-28T00:54:05 *** jek
4 2014-06-28T02:43:09 *** penguinRaider
5 2014-06-28T03:45:26 *** penguinRaider
6 2014-06-28T04:43:39 *** randomax
7 2014-06-28T05:50:49 *** randomax
8 2014-06-28T05:52:51 *** sl33k_
9 2014-06-28T06:40:43 *** sl33k_
10 2014-06-28T07:53:28 *** sl33k_
11 2014-06-28T08:23:48 *** sl33k_
12 2014-06-28T10:35:03 *** magu_cic
13 2014-06-28T10:47:26 *** sl33k_
14 2014-06-28T10:47:27 *** sl33k_
15 2014-06-28T11:45:28 *** sl33k_
16 2014-06-28T12:14:48 *** magu_cic
17 2014-06-28T12:17:27 *** magu_cic
18 2014-06-28T12:51:42 *** magu_cic_
19 2014-06-28T12:54:44 *** magu_cic
20 2014-06-28T12:57:27 *** magu_cic
21 2014-06-28T12:59:51 *** magu_cic_
22 2014-06-28T13:01:35 *** magu_cic_
23 2014-06-28T13:04:57 *** magu_cic
24 2014-06-28T13:14:48 *** magu_cic_
25 2014-06-28T13:16:14 *** magu_cic
26 2014-06-28T13:26:47 *** magu_cic_
27 2014-06-28T13:30:32 *** magu_cic
28 2014-06-28T13:31:42 *** magu_cic
29 2014-06-28T13:34:44 *** magu_cic_
30 2014-06-28T13:41:49 *** greg_f
31 2014-06-28T13:51:37 *** magu_cic_
32 2014-06-28T13:55:12 *** magu_cic
33 2014-06-28T14:35:46 <ThomasWaldmann> moin
34 2014-06-28T14:39:59 *** magu_cic_
35 2014-06-28T14:48:05 *** sl33k_
36 2014-06-28T14:56:03 *** sl33k_
37 2014-06-28T15:05:45 *** skathpalia
38 2014-06-28T15:06:33 <skathpalia> ThomasWaldmann, updated the cr of UI of tickets https://codereview.appspot.com/107060043/
39 2014-06-28T15:55:22 <dimazest> Hi, I'll be 10inutes later, because I need to climb a hill to get a proper mobile connection strength ;)
40 2014-06-28T16:03:11 <ThomasWaldmann> dimazest: ok :)
41 2014-06-28T16:04:00 <dimazest> Done!
42 2014-06-28T16:04:38 <ThomasWaldmann> hmm roger still missing
43 2014-06-28T16:04:58 <ThomasWaldmann> skathpalia: randomax: you are with us?
44 2014-06-28T16:05:02 <skathpalia> moin
45 2014-06-28T16:05:46 *** RogerHaase
46 2014-06-28T16:06:51 <randomax> yes
47 2014-06-28T16:06:57 <ThomasWaldmann> hi RogerHaase! ignore my email :)
48 2014-06-28T16:08:17 <RogerHaase> sorry I am late, busy with other things
49 2014-06-28T16:09:41 <ThomasWaldmann> ok, skathpalia can you begin?
50 2014-06-28T16:09:50 <skathpalia> Ok
51 2014-06-28T16:09:58 <skathpalia> Done:
52 2014-06-28T16:10:03 <skathpalia> Added filter by tags option similar to that of github
53 2014-06-28T16:10:08 <skathpalia> here is the cr https://codereview.appspot.com/101460044/
54 2014-06-28T16:10:14 <skathpalia> Added option of sort by recently and least recently updated tickets
55 2014-06-28T16:10:19 <skathpalia> https://codereview.appspot.com/103610044/#ps60001
56 2014-06-28T16:10:24 <skathpalia> Improved UI of tickets
57 2014-06-28T16:10:36 <skathpalia> https://codereview.appspot.com/107060043/
58 2014-06-28T16:10:46 <skathpalia> Blocked: None
59 2014-06-28T16:10:52 <skathpalia> TODO:
60 2014-06-28T16:10:58 <skathpalia> Add 'Subscribe' and 'Add quicklink' option in modify view of tickets
61 2014-06-28T16:11:07 <skathpalia> Also allow downloading of nameless items
62 2014-06-28T16:11:14 <skathpalia> Done a bit on this https://codereview.appspot.com/102210043/ but it still needs some more optimization.
63 2014-06-28T16:11:26 <skathpalia> Also for adding subscribe and quicklink option in modify view of tickets we need to change name of css classes as css classes have different names for mordenized and basic theme so if we need to add these options without defining different template for different themes we need to have css classes that are same across themes.
64 2014-06-28T16:12:33 <dimazest> OK, anything else?
65 2014-06-28T16:12:39 <skathpalia> Nope
66 2014-06-28T16:13:10 <dimazest> BTW, are this CSS classes documented somewhere, if yes, then the documentation needs to be updated
67 2014-06-28T16:13:38 <skathpalia> yeah I will see if they are documented and make necessary changes there also :)
68 2014-06-28T16:14:16 <ThomasWaldmann> skathpalia: did you tell why you look at the tags returned within the search results?
69 2014-06-28T16:14:22 <dimazest> Also, I'm a bit concerned about tests, because new functionality is added without tests
70 2014-06-28T16:15:29 <ThomasWaldmann> https://codereview.appspot.com/101460044/diff/150001/MoinMoin/apps/frontend/views.py line 2231
71 2014-06-28T16:15:54 <skathpalia> I need tags because we need to show all the tags of the tickets that are currently shown in +tickets view
72 2014-06-28T16:16:11 <skathpalia> so that user can select from one of them
73 2014-06-28T16:16:19 <skathpalia> This is similar to that of github
74 2014-06-28T16:17:01 <skathpalia> dimazest, yeah I will try to write some tests also :)
75 2014-06-28T16:17:17 <ThomasWaldmann> don't we rather need ALL tags that any tickets have (or even could have)?
76 2014-06-28T16:17:35 <dimazest> Maybe there is a way of retrieving all the tags without getting all the documents (if I remember the current code correctly)
77 2014-06-28T16:18:27 <skathpalia> ThomasWaldmann, may be we can have that
78 2014-06-28T16:19:05 <ThomasWaldmann> because otherwise some tags will be missing and you will not be able to select them
79 2014-06-28T16:19:20 <skathpalia> I will add this functionality also :)
80 2014-06-28T16:19:42 <ThomasWaldmann> dimazest: yes, guess we can get them. maybe lexicon of index or so...
81 2014-06-28T16:20:13 <ThomasWaldmann> skathpalia: did you check if there is a way that doesn't require 1 form / tag?
82 2014-06-28T16:21:21 <skathpalia> for which form?
83 2014-06-28T16:21:36 <ThomasWaldmann> https://codereview.appspot.com/101460044/diff/150001/MoinMoin/templates/tickets.html?context=10&column_width=80 line 84
84 2014-06-28T16:22:03 <ThomasWaldmann> that somehow looks too complicated
85 2014-06-28T16:22:31 <skathpalia> I tried that also but couldn't find a way for that
86 2014-06-28T16:23:09 <ThomasWaldmann> dimazest: RogerHaase: can you help here? IMHO there should be a way to represent N tags with inputs that are in selected state or not, in a single form.
87 2014-06-28T16:24:00 <ThomasWaldmann> and then have that form submitted like ?tag=foo&tag=bar&tag=baz (when foo bar and baz are selected but no other tag)
88 2014-06-28T16:24:21 <dimazest> JavaScript could help
89 2014-06-28T16:24:54 * ThomasWaldmann thought this is basic forms stuff
90 2014-06-28T16:24:55 <skathpalia> dimazest, I will try to do it by js
91 2014-06-28T16:25:12 <dimazest> I'm not that good with forms
92 2014-06-28T16:25:25 <dimazest> There could be a nicer solution
93 2014-06-28T16:25:26 * ThomasWaldmann neither, so take with grain of salt
94 2014-06-28T16:26:08 <dimazest> skathpalia: in template you can define a js array wit all selected tags
95 2014-06-28T16:26:36 <dimazest> And then append or exclude a tag once it's clicked and submit a form
96 2014-06-28T16:26:51 <dimazest> (But that's just an idea)
97 2014-06-28T16:27:01 <skathpalia> yeah I will try that
98 2014-06-28T16:28:00 <ThomasWaldmann> for getting all the tags that are present in tickets, see whoosh docs
99 2014-06-28T16:28:22 <skathpalia> Ok will have a look on that
100 2014-06-28T16:28:23 <ThomasWaldmann> (i can maybe help here, but have to look it up myself)
101 2014-06-28T16:29:14 <ThomasWaldmann> that list of tags would be also good to suggest tags for the ticket entry form
102 2014-06-28T16:30:08 <ThomasWaldmann> ok, that's all from me for now
103 2014-06-28T16:30:10 <skathpalia> Yeah it would be good to have tags as suggestions
104 2014-06-28T16:31:08 <ThomasWaldmann> RogerHaase: anything from you?
105 2014-06-28T16:31:15 <RogerHaase> no
106 2014-06-28T16:32:18 <ThomasWaldmann> ok, thanks, randomax you're next
107 2014-06-28T16:35:22 <randomax> sir can i discuss about the cancellation of my project ?
108 2014-06-28T16:36:18 <ThomasWaldmann> no, tell about your last week coding and the state your stuff currently is in
109 2014-06-28T16:36:49 <randomax> ok sir
110 2014-06-28T16:37:00 <ThomasWaldmann> mentors will have a look at the timeline you make as soon as you have it ready
111 2014-06-28T16:37:20 <randomax> i committed patch for pygments classes - https://bitbucket.org/ajgupta93/moin-2.0/commits/82ffb3f45eed569ae2aeab92e3190bb244fac371
112 2014-06-28T16:37:41 <randomax> for fixing footer to the bottom of the page https://bitbucket.org/ajgupta93/moin-2.0/commits/4385775cf3a1aaaad070501c8f6e49ad03f11edd
113 2014-06-28T16:37:54 <randomax> Improved Search GUI - https://bitbucket.org/ajgupta93/moin-2.0/commits/2003e3685733eb19c3052c19d419e36445caea64
114 2014-06-28T16:38:04 <randomax> Added common.css and removed unnecessary pygments_default.css files - https://bitbucket.org/ajgupta93/moin-2.0/commits/9645576dd44d90f608cca417288a9f4d5fc63470
115 2014-06-28T16:38:18 <randomax> Improved Index GUI - https://bitbucket.org/ajgupta93/moin-2.0/commits/011a118feecfe0037d0308257f19f332321d9053
116 2014-06-28T16:38:36 <randomax> worked on metadata UI - https://codereview.appspot.com/110210043/#ps60001
117 2014-06-28T16:40:31 <ThomasWaldmann> hmm, for what is that 105px padding at the bottom?
118 2014-06-28T16:40:50 <randomax> that is set according to the size of the footer itself
119 2014-06-28T16:41:03 <randomax> the footer will be placed in that portion
120 2014-06-28T16:41:46 <ThomasWaldmann> so, how did you come up with 105px?
121 2014-06-28T16:43:03 <randomax> i checked the size of the footer using mozilla developer tools
122 2014-06-28T16:44:57 <ThomasWaldmann> isn't that depending on font-sizes etc. so it may vary depending on the screen resolution/dpi?
123 2014-06-28T16:45:47 <RogerHaase> on basic theme, you can not see the effect of that 105px, on modernized theme the white background for content shows the spacing
124 2014-06-28T16:47:19 <randomax> i tried it on different resolutions and it worked
125 2014-06-28T16:47:52 <ThomasWaldmann> ok, guess I'll have to try it
126 2014-06-28T16:48:39 <ThomasWaldmann> randomax: so, you committed some stuff to your repo, do you have an overview what's still pending on CR or otherwise?
127 2014-06-28T16:49:18 <randomax> metadata ui is in cr : https://codereview.appspot.com/110210043/
128 2014-06-28T16:51:46 <ThomasWaldmann> ok, will have a look at the latest update there after meeting
129 2014-06-28T16:52:37 <ThomasWaldmann> dimazest: RogerHaase: anything from you?
130 2014-06-28T16:52:38 *** sl33k_
131 2014-06-28T16:52:44 <dimazest> No
132 2014-06-28T16:52:46 <RogerHaase> nothing else
133 2014-06-28T16:53:32 <ThomasWaldmann> ok, so thanks everybody for attending
134 2014-06-28T16:54:16 <skathpalia> ThomasWaldmann, Can you please have a look on this cr https://codereview.appspot.com/107060043/
135 2014-06-28T16:54:19 <ThomasWaldmann> randomax: i'ld appreciate if you maybe finish the pending stuff, independently of the further outcome of the discussion we had
136 2014-06-28T16:55:13 <randomax> surely..
137 2014-06-28T16:56:01 <ThomasWaldmann> skathpalia: looks much better now
138 2014-06-28T16:56:11 <skathpalia> Can I commit it?
139 2014-06-28T16:56:45 <ThomasWaldmann> i didn't try it, just had a look at the src. but if it works and roger and dimazest is fine with it...
140 2014-06-28T16:57:38 <skathpalia> Its ok according to dimazest
141 2014-06-28T16:57:40 * ThomasWaldmann and other mentors will have to discuss something outside this channel now, expect use back later
142 2014-06-28T16:57:44 <ThomasWaldmann> us*
143 2014-06-28T16:58:22 <dimazest> Yeah, it's fine
144 2014-06-28T17:05:54 *** skathpalia
145 2014-06-28T17:12:49 *** skathpalia
146 2014-06-28T17:35:43 *** skathpalia
147 2014-06-28T18:35:12 *** sl33k_
148 2014-06-28T18:38:52 *** sl33k_
149 2014-06-28T18:55:55 *** greg_f
150 2014-06-28T19:32:22 *** sl33k_
151 2014-06-28T20:48:31 *** randomax
152 2014-06-28T21:38:36 *** RogerHaase
153 2014-06-28T22:58:47 * ThomasWaldmann hacked something quickly together to play with flask, forms, bootstrap:
154 2014-06-28T22:59:04 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/flask-former
155 2014-06-28T23:25:14 * ThomasWaldmann looked up what we need in the whoosh docs
156 2014-06-28T23:25:44 <ThomasWaldmann> lexicon(fieldname) gives all bytestrings in that field, so we can know all the tags we have indexed
157 2014-06-28T23:32:32 <ThomasWaldmann> even better: field_terms(fieldname) (does same, but converts to correct datatype)