1 2014-06-19T03:37:55  *** penguinRaider has quit IRC
   2 2014-06-19T03:59:20  *** penguinRaider has joined #moin-dev
   3 2014-06-19T04:46:24  *** randomax has joined #moin-dev
   4 2014-06-19T04:59:22  *** penguinRaider has quit IRC
   5 2014-06-19T04:59:42  *** penguinRaider has joined #moin-dev
   6 2014-06-19T05:16:39  *** randomax has quit IRC
   7 2014-06-19T05:45:57  *** sl33k_ has joined #moin-dev
   8 2014-06-19T05:52:41  *** sl33k_ has quit IRC
   9 2014-06-19T06:08:54  *** sl33k_ has joined #moin-dev
  10 2014-06-19T07:25:03  *** sl33k_ has quit IRC
  11 2014-06-19T07:57:33  *** randomax has joined #moin-dev
  12 2014-06-19T08:04:39  *** sl33k_ has joined #moin-dev
  13 2014-06-19T08:50:26  *** sl33k_ has quit IRC
  14 2014-06-19T08:52:41  *** greg_f has joined #moin-dev
  15 2014-06-19T09:16:13  *** skathpalia has joined #moin-dev
  16 2014-06-19T09:16:28  <skathpalia> dimazest, ThomasWaldmann I have added XStatic.JQuery.TableSorter plugin in +tickets view
  17 2014-06-19T09:16:35  <skathpalia> Here is the cr https://codereview.appspot.com/106120044
  18 2014-06-19T09:41:29  <randomax> ThomasWaldmann, i just cloned a new repo and on running it i see that the glyphicons are all gone..
  19 2014-06-19T09:42:28  <randomax> it loads up something like this - http://picpaste.com/pics/test-cPshbSNb.1403170927.png
  20 2014-06-19T09:45:19  *** sl33k_ has joined #moin-dev
  21 2014-06-19T10:13:55  *** skathpalia has quit IRC
  22 2014-06-19T11:47:21  <ThomasWaldmann> randomax: i didn't change anything relating to glyphicons
  23 2014-06-19T12:00:39  <randomax> ThomasWaldmann, i confirmed with skathpalia and he also sees the same problem when he makes a new clone of his repo
  24 2014-06-19T12:01:11  <randomax> i see something like this - http://picpaste.com/pics/test-cPshbSNb.1403179249.png
  25 2014-06-19T12:14:58  <ThomasWaldmann> maybe some css file is missing and needs to be generated?
  26 2014-06-19T12:39:06  <randomax> hmm.. i'll try to find something
  27 2014-06-19T12:39:13  <randomax> ThomasWaldmann, another doubt
  28 2014-06-19T12:39:24  <randomax> i have a pull request in waiting for the quicklinks
  29 2014-06-19T12:40:18  <randomax> i have another patch ready to be committed - about the pygments css classes.. should i add that into the same request or wait for it to be merged ?
  30 2014-06-19T12:42:28  *** skathpalia has joined #moin-dev
  31 2014-06-19T12:56:57  <ThomasWaldmann> randomax: try that quicklink stuff with non-ascii item name and then report back whether it works
  32 2014-06-19T13:03:38  <ThomasWaldmann> randomax: i had to reject that PR, see bitbucket
  33 2014-06-19T13:08:11  *** RogerHaase has joined #moin-dev
  34 2014-06-19T13:08:28  <randomax> ok.. in case of a non ascii item name it throws an error in Moinmoin/util/subscriptions.py..
  35 2014-06-19T13:09:11  <randomax> as in this error was already there in the original code
  36 2014-06-19T13:09:15  <ThomasWaldmann> that's not the only problem, see my "decline comment"
  37 2014-06-19T13:09:53  <ThomasWaldmann> you didn't really look at what split_navilink is doing
  38 2014-06-19T13:10:10  <ThomasWaldmann> and the code you added only works for 1 case
  39 2014-06-19T13:11:36  <ThomasWaldmann> also, your commit mixed up whitespace cleanups with code changes (that was not the rejection reason, but it is not good to do either)
  40 2014-06-19T13:12:51  <randomax> whitespace was bcoz of ./m coding-std
  41 2014-06-19T13:14:50  <ThomasWaldmann> cr url for that changeset?
  42 2014-06-19T13:16:43  <randomax> https://codereview.appspot.com/91680043/
  43 2014-06-19T13:19:17  <randomax> I didnt get you when you said "and the code you added only works for 1 case" ... could you explain ?
  44 2014-06-19T13:22:00  <ThomasWaldmann> see the different return values of split_navilink
  45 2014-06-19T13:22:32  <ThomasWaldmann> you are assuming that you get something back like /ItemName
  46 2014-06-19T13:22:51  <ThomasWaldmann> but it could be also /path/ItemName
  47 2014-06-19T13:22:57  <ThomasWaldmann> or http://google.de/
  48 2014-06-19T13:23:46  <ThomasWaldmann> also, if item name has non-ascii, the path is not just "/" + itemname, but a encoded/urlquoted version of itemname
  49 2014-06-19T13:24:07  <ThomasWaldmann> so, in short: you can't extra the itemname that way
  50 2014-06-19T13:24:13  <ThomasWaldmann> extract*
  51 2014-06-19T13:39:33  *** sl33k_ has quit IRC
  52 2014-06-19T13:44:39  <randomax> i just rechecked it works for subitems like abcd/efgh/lmno/pqrs
  53 2014-06-19T13:45:23  <randomax> but if the "path/ItemName" is shorter than 15 chars then it will leave it as it is
  54 2014-06-19T13:45:38  <randomax> like "a/b/c/d" will be displayed like that itself
  55 2014-06-19T13:45:41  <ThomasWaldmann> see CR
  56 2014-06-19T13:46:33  <ThomasWaldmann> and i don't care for some special cases where it works. i just showed you some fundamental cases where it does not.
  57 2014-06-19T14:03:08  <ThomasWaldmann> (also that "/path" was meant as a technical deployment detail, like when the wiki is not installed at "/" url but at "/path" url, so it should never show)
  58 2014-06-19T14:03:56  * ThomasWaldmann had internet disconnected. seems like cable company doing maintenance stuff.
  59 2014-06-19T14:11:51  <randomax> how to create an item named http://google.de/ ?
  60 2014-06-19T14:12:06  *** sl33k_ has joined #moin-dev
  61 2014-06-19T14:29:08  * ThomasWaldmann back on cable
  62 2014-06-19T14:29:37  <ThomasWaldmann> randomax: you don't create such an item, but a quicklink can point to an outside url
  63 2014-06-19T14:31:27  *** sl33k_ has quit IRC
  64 2014-06-19T14:38:18  <RogerHaase> ThomasWaldmann: randomax you can do that in moin 1.9.x under User Settings > Preferences, but in moin2, there is User Settings > Navigation, but the code to add such a link is not there yet
  65 2014-06-19T14:38:46  <RogerHaase> link/quick link
  66 2014-06-19T14:41:33  *** sl33k_ has joined #moin-dev
  67 2014-06-19T14:41:45  <RogerHaase> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/19/user-settings-are-incomplete
  68 2014-06-19T14:51:43  <ThomasWaldmann> btw, June 23: midterm evals starting
  69 2014-06-19T14:53:56  <ThomasWaldmann> students should try to get their stuff into a good state and committed
  70 2014-06-19T15:06:12  <randomax> review needed for cr : https://codereview.appspot.com/109730047/
  71 2014-06-19T15:18:08  *** RogerHaase has left #moin-dev
  72 2014-06-19T15:18:59  <ThomasWaldmann> randomax: you do first review yourself and make sure you handled all the feedback from last review
  73 2014-06-19T15:40:24  <skathpalia> dimazest, I have updated the cr https://codereview.appspot.com/106120044
  74 2014-06-19T15:40:44  <skathpalia> Added up and down arrows in table header
  75 2014-06-19T15:59:10  *** skathpalia has quit IRC
  76 2014-06-19T16:02:44  <randomax> ThomasWaldmann, done https://codereview.appspot.com/109730047/
  77 2014-06-19T16:24:15  <ThomasWaldmann> randomax: it is still "advanced search"?
  78 2014-06-19T16:34:35  <randomax> That is the css class name.. ok i'll change that too..
  79 2014-06-19T16:37:31  *** sl33k_ has quit IRC
  80 2014-06-19T16:39:20  <ThomasWaldmann> (just be consistent. if the stuff we do there is not really advanced, it shouldn't be called so. nowhere.)
  81 2014-06-19T16:39:25  <ThomasWaldmann> review done
  82 2014-06-19T16:39:29  * ThomasWaldmann away
  83 2014-06-19T16:42:42  *** sl33k_ has joined #moin-dev
  84 2014-06-19T16:49:27  *** randomax has quit IRC
  85 2014-06-19T16:58:14  *** RogerHaase has joined #moin-dev
  86 2014-06-19T17:41:56  *** penguinRaider has left #moin-dev
  87 2014-06-19T18:08:35  *** eSyr has quit IRC
  88 2014-06-19T18:08:35  *** RogerHaase has quit IRC
  89 2014-06-19T18:08:37  *** jek has quit IRC
  90 2014-06-19T18:10:47  *** RogerHaase has joined #moin-dev
  91 2014-06-19T18:10:47  *** eSyr has joined #moin-dev
  92 2014-06-19T18:10:47  *** jek has joined #moin-dev
  93 2014-06-19T18:14:52  *** eSyr has quit IRC
  94 2014-06-19T18:14:52  *** RogerHaase has quit IRC
  95 2014-06-19T18:14:53  *** jek has quit IRC
  96 2014-06-19T18:16:23  *** RogerHaase has joined #moin-dev
  97 2014-06-19T18:16:23  *** eSyr has joined #moin-dev
  98 2014-06-19T18:16:23  *** jek has joined #moin-dev
  99 2014-06-19T18:17:34  *** eSyr has quit IRC
 100 2014-06-19T18:38:42  *** eSyr has joined #moin-dev
 101 2014-06-19T18:59:15  *** penguinRaider_ has joined #moin-dev
 102 2014-06-19T19:03:26  *** penguinRaider_ has quit IRC
 103 2014-06-19T20:12:56  * dimazest wonders whether it makes sense to use .png instead of .gif
 104 2014-06-19T20:13:24  <dimazest> skathpalia PR done
 105 2014-06-19T21:56:52  *** sl33k_ has quit IRC
 106 2014-06-19T22:11:29  *** RogerHaase has quit IRC
 107

MoinMoin: MoinMoinChat/Logs/moin-dev/2014-06-19 (last edited 2014-06-19 03:45:02 by IrcLogImporter)