1 2014-05-30T00:58:38 *** penguinRaider
2 2014-05-30T01:17:25 *** derdon
3 2014-05-30T01:19:24 *** sl33k_
4 2014-05-30T04:33:13 *** magu_cic_
5 2014-05-30T04:37:55 *** skathpalia
6 2014-05-30T04:38:31 <skathpalia> ThomasWaldmann, dimazest I have made the required changes in the cr https://codereview.appspot.com/99560043
7 2014-05-30T04:39:02 <skathpalia> Now there is no pep-8 error
8 2014-05-30T04:39:11 <skathpalia> Can I commit it now?
9 2014-05-30T04:47:08 *** skathpalia
10 2014-05-30T05:54:41 <dimazest> morning
11 2014-05-30T05:54:56 <dimazest> see my tiny stylistic remark
12 2014-05-30T06:05:47 *** skathpalia
13 2014-05-30T06:06:12 <skathpalia> moin
14 2014-05-30T06:06:29 <skathpalia> dimazest, I have added commas in the cr
15 2014-05-30T06:11:33 <dimazest> looks good
16 2014-05-30T06:12:21 <skathpalia> Can I commit it now?
17 2014-05-30T06:13:29 <dimazest> yes
18 2014-05-30T06:20:49 <skathpalia> dimazest, by mistake I introduced one pep-8 error in my last commit in items/ticket.py
19 2014-05-30T06:22:24 <skathpalia> I have to make one more commit to remove that error
20 2014-05-30T06:24:10 *** penguinRaider
21 2014-05-30T06:27:34 <dimazest> sure fix it
22 2014-05-30T06:28:31 <skathpalia> done
23 2014-05-30T06:30:29 <dimazest> ok, i'm leaving to the university, see you in a bit
24 2014-05-30T06:59:44 *** skathpalia
25 2014-05-30T08:28:40 *** aboutGod
26 2014-05-30T08:33:46 *** aboutGod
27 2014-05-30T09:20:45 *** greg_f
28 2014-05-30T10:47:55 *** randomax
29 2014-05-30T11:07:15 *** derdon
30 2014-05-30T12:09:05 *** sl33k_
31 2014-05-30T12:53:18 *** dave_largo
32 2014-05-30T14:15:47 *** RogerHaase
33 2014-05-30T14:50:08 *** penguinRaider
34 2014-05-30T14:50:08 *** randomax
35 2014-05-30T15:06:14 *** penguinRaider
36 2014-05-30T15:06:39 *** randomax
37 2014-05-30T15:16:51 *** skathpalia
38 2014-05-30T15:33:08 *** skathpalia
39 2014-05-30T15:51:50 *** sl33k_
40 2014-05-30T16:05:05 <RogerHaase> randomax: what are you working on today?
41 2014-05-30T16:25:28 *** skathpalia
42 2014-05-30T16:27:33 <randomax> RogerHaase, i looked at the flaw you pointed out
43 2014-05-30T16:27:46 <randomax> the search is actually working fine
44 2014-05-30T16:28:05 <randomax> once you save the items again
45 2014-05-30T16:28:44 <randomax> as in after creating the sample if u go on an item and doubleclick to modify and then just save it
46 2014-05-30T16:28:55 <randomax> then it starts displaying in the search result
47 2014-05-30T16:29:06 <randomax> so its just something related to indexing
48 2014-05-30T16:29:39 <randomax> it has a got 2 modes - searching all revisions and searching only the latest revisions
49 2014-05-30T16:30:17 <randomax> i tried to search the items with the ALL_REVS mode
50 2014-05-30T16:30:32 <randomax> but still they didnt show up until i saved them once
51 2014-05-30T16:30:46 <randomax> so basically the items are not in the index initially
52 2014-05-30T16:31:29 <RogerHaase> randomax: nice discovery! I was testing rebuilding the indexes and discovered bugs 431 and 432
53 2014-05-30T16:35:08 <randomax> RogerHaase, i am bit confused with what is the aim behind the name terms suggestions and content term suggestions..
54 2014-05-30T16:35:37 <randomax> could you tell what is their purpose.. as in what are they actually suggesting ?
55 2014-05-30T16:40:10 <RogerHaase> randomax: hopefully it is the whoosh docs somewhere..., I think it is supposed to help you refine your search if you have too many hits
56 2014-05-30T16:48:21 <RogerHaase> randomax: another discovery - if you apply this patch https://codereview.appspot.com/98660043/ then do ./m sample, the indexes are build and search works (without having to save each item)
57 2014-05-30T16:51:58 <randomax> RogerHaase, hmm.. wondering how does lineno_attr affect item indexing ? O.o
58 2014-05-30T16:52:49 <randomax> *add_lineno_attr
59 2014-05-30T16:54:31 <RogerHaase> randomax: apparently, there was a silent failure for all item types except html during the restore process
60 2014-05-30T17:05:06 <RogerHaase> ... because html items do not support the edit textarea autoscroll
61 2014-05-30T17:06:15 <RogerHaase> randomax: only clue I could find in whoosh docs http://whoosh.readthedocs.org/en/latest/keywords.html#query-expansion-and-key-word-extraction
62 2014-05-30T17:13:24 <randomax> RogerHaase, oh.. those suggestions seem quite weird actually.. for example i search for "table" and they suggest http, syntax, line, definition, code :D
63 2014-05-30T17:16:46 <randomax> btw i after constantly using the messed up index i remembered i had made a gui patch for it :D i'll revisit that too.. and first find out why this search bar is extending beyond the screen :)
64 2014-05-30T17:17:15 <RogerHaase> agree, hopefull they will make more sense when there is a lot of data.
65 2014-05-30T17:18:26 <RogerHaase> randomax: this is the search bar fix: https://codereview.appspot.com/80700049/
66 2014-05-30T17:18:50 <skathpalia> randomax, the patchset 2 is the relevant one in this cr
67 2014-05-30T17:22:42 <skathpalia> randomax, I will commit it soon, ThomasWaldmann has to review it :)
68 2014-05-30T17:27:04 *** skathpalia
69 2014-05-30T17:34:37 <randomax> ohh.. :)
70 2014-05-30T17:51:14 <RogerHaase> randomax: btw, did you notice that if you are on the search page, click on the search field, hit enter, then another line of "input suggestions" appears
71 2014-05-30T18:06:02 <randomax> yep..
72 2014-05-30T18:07:38 <randomax> it actually gives terms similar to the search term input by the user..
73 2014-05-30T18:12:21 *** greg_f
74 2014-05-30T19:28:07 <RogerHaase> randomax: something happened to the sharky 73 fix or the merge after it. When I do ./m css on current repo tip, some of the basic.css changes are backed off
75 2014-05-30T19:34:12 <randomax> ok.. i'll check it..
76 2014-05-30T19:56:39 <randomax> RogerHaase, sorry i made a mistake.. i'll send in another pull request.. in actuality the css getting implemented is the same as i wrote.. its just a code overlap problem..
77 2014-05-30T20:01:15 *** randomax
78 2014-05-30T20:17:19 *** ananasov1
79 2014-05-30T20:21:36 *** ananasova
80 2014-05-30T20:50:43 *** sl33k_
81 2014-05-30T21:00:14 *** dave_largo
82 2014-05-30T22:20:25 *** sl33k_
83 2014-05-30T22:22:30 *** RogerHaase
84