MoinMoin: MoinMoinChat/Logs/moin-dev/2014-05-23

   1 2014-05-23T00:15:39  *** sl33k_ has quit IRC
   2 2014-05-23T05:19:52  *** skathpalia has joined #moin-dev
   3 2014-05-23T05:20:25  <skathpalia> dimazest, I have added some comments in my code regarding  explanation of try-except statement
   4 2014-05-23T05:20:39  <skathpalia> Please have a look at it https://codereview.appspot.com/100720043
   5 2014-05-23T05:20:56  <skathpalia> Then only I will commit it to my repo
   6 2014-05-23T05:56:27  *** magu_cic has joined #moin-dev
   7 2014-05-23T05:57:07  *** magu_cic_ has quit IRC
   8 2014-05-23T06:56:35  *** skathpalia has quit IRC
   9 2014-05-23T08:11:56  *** sl33k_ has joined #moin-dev
  10 2014-05-23T08:23:50  *** sl33k_ has quit IRC
  11 2014-05-23T08:48:55  *** greg_f has joined #moin-dev
  12 2014-05-23T08:50:17  *** greg_f has joined #moin-dev
  13 2014-05-23T08:54:08  <dimazest> ThomasWaldmann: could you have a look to https://codereview.appspot.com/100720043/diff/160001/MoinMoin/forms.py
  14 2014-05-23T08:54:31  <dimazest> skathpalia: we are almost there :)
  15 2014-05-23T09:25:05  *** skathpalia has joined #moin-dev
  16 2014-05-23T09:25:43  <skathpalia> moin
  17 2014-05-23T09:26:01  <dimazest> hello
  18 2014-05-23T09:26:08  <dimazest> i put some minor points
  19 2014-05-23T09:26:22  <skathpalia> dimazest, I have updated the cr
  20 2014-05-23T09:26:36  <skathpalia> https://codereview.appspot.com/100720043/
  21 2014-05-23T09:27:49  <dimazest> looks good to me, but let see what ThomasWaldmann thinks
  22 2014-05-23T09:28:18  <dimazest> what is next?
  23 2014-05-23T09:28:28  <skathpalia> The next task?
  24 2014-05-23T09:29:51  <skathpalia> The next task would be to remove the asertion error that comes on updating
  25 2014-05-23T09:29:57  <skathpalia> ticket items
  26 2014-05-23T09:30:08  <skathpalia> Here I would remove this line https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/items/__init__.py?at=default#cl-619
  27 2014-05-23T09:30:40  <skathpalia> And then pass fqname instead of just item_name and then fetch that in the MoinMoin/util/notifications.py
  28 2014-05-23T09:33:10  <skathpalia> As mentioned in the comment above this line
  29 2014-05-23T09:33:18  <skathpalia> in the code
  30 2014-05-23T09:34:12  <dimazest> ok, the code mentions a unit test
  31 2014-05-23T09:34:28  <dimazest> do you know what test it is
  32 2014-05-23T09:34:51  <skathpalia> No I haven't looked upon that test
  33 2014-05-23T09:36:13  <skathpalia> dimazest, can you tell me which test is failing ?
  34 2014-05-23T09:40:21  <skathpalia> I am searching for the failing test :)
  35 2014-05-23T09:41:37  *** sl33k_ has joined #moin-dev
  36 2014-05-23T09:46:23  *** sl33k_ has quit IRC
  37 2014-05-23T10:01:11  *** skathpalia has quit IRC
  38 2014-05-23T11:00:17  *** skathpalia has joined #moin-dev
  39 2014-05-23T11:39:17  *** skathpalia has quit IRC
  40 2014-05-23T11:55:12  *** sl33k_ has joined #moin-dev
  41 2014-05-23T12:37:03  *** dave_largo has joined #moin-dev
  42 2014-05-23T13:13:02  *** sl33k_ has quit IRC
  43 2014-05-23T13:53:32  *** RogerHaase has joined #moin-dev
  44 2014-05-23T14:44:15  *** RogerHaase has quit IRC
  45 2014-05-23T14:59:17  *** RogerHaase has joined #moin-dev
  46 2014-05-23T15:02:32  *** RogerHaase has quit IRC
  47 2014-05-23T15:03:52  *** RogerHaase has joined #moin-dev
  48 2014-05-23T15:18:55  *** sl33k_ has joined #moin-dev
  49 2014-05-23T15:25:01  *** randomax has joined #moin-dev
  50 2014-05-23T16:46:44  <randomax> RogerHaase, code review needed https://codereview.appspot.com/96520046/#ps20001
  51 2014-05-23T17:01:12  <RogerHaase> randomax: I like it :)
  52 2014-05-23T17:03:52  <randomax> RogerHaase, should i push it to my repo ?
  53 2014-05-23T17:05:38  <RogerHaase> randomax: not yet, you need to set your editor to remove trailing blanks -- and fix common.js
  54 2014-05-23T17:05:53  *** magu_cic_ has joined #moin-dev
  55 2014-05-23T17:05:59  <RogerHaase> run ./m coding-std to see
  56 2014-05-23T17:06:14  *** magu_cic has quit IRC
  57 2014-05-23T17:07:34  *** magu_cic has joined #moin-dev
  58 2014-05-23T17:09:28  *** magu_cic__ has joined #moin-dev
  59 2014-05-23T17:10:38  *** magu_cic_ has quit IRC
  60 2014-05-23T17:11:30  *** magu_cic_ has joined #moin-dev
  61 2014-05-23T17:12:19  *** magu_cic has quit IRC
  62 2014-05-23T17:15:02  *** magu_cic__ has quit IRC
  63 2014-05-23T17:19:59  <randomax> RogerHaase, cleaned up the code - https://codereview.appspot.com/96520046/#ps40001
  64 2014-05-23T17:22:41  <RogerHaase> randomax: ok, commit messages are forever, make it descriptive and concise, no spelling errors; commit and push
  65 2014-05-23T17:25:43  <sl33k_> I'm meaning to run moin repo from pycharm. I set up virtualenv apparently referring to http://www.jetbrains.com/pycharm/webhelp/adding-existing-virtual-environment.html . Now do I run make.py? Do I need to do some tweaks in run configurations?
  66 2014-05-23T17:25:57  <randomax> RogerHaase, yep :)
  67 2014-05-23T17:26:18  *** randomax has quit IRC
  68 2014-05-23T17:27:56  <sl33k_> That created one more set of virtualenv artifacts. sigh
  69 2014-05-23T17:28:14  <RogerHaase> sl33k_: maybe this will help:  http://sksaurabhkathpalia.blogspot.in/2014/05/running-moin2-in-pycharm.html
  70 2014-05-23T17:32:17  *** randomax has joined #moin-dev
  71 2014-05-23T17:40:58  *** randomax has quit IRC
  72 2014-05-23T18:00:21  *** greg_f has quit IRC
  73 2014-05-23T19:53:03  <RogerHaase> ThomasWaldmann: enhance media support; add mp4 video; mp3, opus audio; fix wav audio https://codereview.appspot.com/100760044/
  74 2014-05-23T20:46:28  <sl33k_> RogerHaase: Difficult to follow. Does Open Directory not do it instead of create project?
  75 2014-05-23T20:50:13  <sl33k_> What is the entry point here? Does the run configuration option in Run menu item should be made to point to make.py?
  76 2014-05-23T20:50:57  *** dave_largo has quit IRC
  77 2014-05-23T20:54:25  <RogerHaase> sl33k_: no it is not make.py,  booting ubuntu to look...
  78 2014-05-23T20:57:06  <RogerHaase> sl33k_: Script: <path to virtualenv>/bin/moin
  79 2014-05-23T20:57:59  <RogerHaase> Python Interpreter: <path to virtualenv>
  80 2014-05-23T20:58:22  <RogerHaase> Working Directory: <repo root>
  81 2014-05-23T21:00:26  <RogerHaase> If you have those set right, then when you click on the Run "tab" at the top of the display, the the Run and Debug icon under it will be green
  82 2014-05-23T21:03:07  *** sl33k_ has quit IRC
  83 2014-05-23T21:12:52  *** sl33k_ has joined #moin-dev
  84 2014-05-23T21:19:51  <RogerHaase> sl33k_: http://picpaste.com/pycharm-5YlYRe3W.png
  85 2014-05-23T21:25:30  <sl33k_> RogerHaase: Wonderful can't thank you enough!
  86 2014-05-23T21:26:24  <RogerHaase> sl33k_: I had trouble setting it up the first time as well, glad you got it :)
  87 2014-05-23T21:29:54  <sl33k_> I was pointing the script to python. good lord I asked. Also Is Run-> Debug Foo a recommended way?
  88 2014-05-23T21:31:15  <sl33k_> The blog guy might want to correct the path
  89 2014-05-23T21:33:59  <RogerHaase> sl33k_: I normally use run-debug after setting a bunch of breakpoints
  90 2014-05-23T21:38:09  <RogerHaase> occasionally, if I want to debug one test, I change the configuration so Script: points to <venv>/bin/py.test; and then put "-k matchsometest" in the Script Parameters:
  91 2014-05-23T21:41:53  <RogerHaase> you may be able to do the run-bebug Foo sequence with a few things like make.py or quickinstall.py that are standalone programs
  92 2014-05-23T21:43:46  <RogerHaase> bebug/debug
  93 2014-05-23T21:47:28  <sl33k_> RogerHaase: Nifty protips!
  94 2014-05-23T21:47:56  <sl33k_> I assume there is no need for Version Control Integration in the IDE?
  95 2014-05-23T21:51:06  <RogerHaase> There is a VCS tab that seems to support mercurial but I have not tried it.  I am normally on windows and use something called TortoiseHG that provides a graphical interface to most/all of the hg commands.
  96 2014-05-23T22:09:47  *** RogerHaase has left #moin-dev
  97