1 2014-05-15T00:32:14 *** derdon
2 2014-05-15T02:35:38 *** dimazest
3 2014-05-15T02:39:17 *** dimazest
4 2014-05-15T08:12:33 *** greg_f
5 2014-05-15T09:40:10 <dimazest> moin
6 2014-05-15T09:54:49 <ThomasWaldmann> hi dimazest
7 2014-05-15T10:33:34 *** derdon
8 2014-05-15T11:15:34 *** derdon
9 2014-05-15T12:51:51 *** dave_largo
10 2014-05-15T13:31:04 *** ananasova
11 2014-05-15T13:41:49 *** ananasova
12 2014-05-15T13:46:54 *** ananasova
13 2014-05-15T14:02:14 *** RogerHaase
14 2014-05-15T14:18:27 *** derdon
15 2014-05-15T14:22:06 *** ananasova
16 2014-05-15T15:43:27 *** skathpalia
17 2014-05-15T15:43:35 <skathpalia> moin
18 2014-05-15T15:45:26 <skathpalia> I have a doubt in this line https://bitbucket.org/thomaswaldmann/moin-2.0/src/4a997d9f5e26515b90c744582be8aa7393bb57d1/MoinMoin/items/__init__.py?at=default#cl-620
19 2014-05-15T15:46:00 <skathpalia> What is this part doing and where is this function defined?
20 2014-05-15T15:46:17 <skathpalia> I tried with Pycharm also but I couldn't find
21 2014-05-15T15:46:47 <skathpalia> I mean where is send method defined and what is it intended to do?
22 2014-05-15T15:48:18 <ThomasWaldmann> it's sending an event
23 2014-05-15T15:48:45 <ThomasWaldmann> from MoinMoin.signalling import item_modified
24 2014-05-15T15:49:33 <skathpalia> Actually it is taking name which is None in case of ticket
25 2014-05-15T15:50:00 <skathpalia> So where can I find this method so that I make it item_name independent?
26 2014-05-15T15:50:20 <ThomasWaldmann> read the blinker docs
27 2014-05-15T15:51:11 <ThomasWaldmann> and yes, the name-based api relicts should go
28 2014-05-15T15:51:35 <ThomasWaldmann> see the comment right above
29 2014-05-15T15:55:33 <skathpalia> How can this be corrected if you have any idea?
30 2014-05-15T15:55:57 <skathpalia> ThomasWaldmann, ^^
31 2014-05-15T15:55:57 <ThomasWaldmann> did you read the comment?
32 2014-05-15T15:56:21 <skathpalia> Yeah I saw that there is a failing test
33 2014-05-15T15:56:47 <skathpalia> Ok I will try to replace simple name with fqname
34 2014-05-15T15:57:10 <ThomasWaldmann> yup
35 2014-05-15T16:02:07 <skathpalia> But I am not able to understand that name is None so how fqname is going to help
36 2014-05-15T16:02:23 <skathpalia> as it is also one of the parameters for making fqname
37 2014-05-15T16:02:29 <skathpalia> ThomasWaldmann, ^^
38 2014-05-15T16:04:51 <ThomasWaldmann> did you see what fqname means, practically?
39 2014-05-15T16:05:09 <skathpalia> I saw the parameters now
40 2014-05-15T16:05:30 <skathpalia> I have seen it earlier but I have forgotten about that
41 2014-05-15T16:05:39 <ThomasWaldmann> i mean the semantics, very high level
42 2014-05-15T16:06:04 <skathpalia> Ok I am seeing it
43 2014-05-15T16:06:16 <ThomasWaldmann> iirc we talked about it already
44 2014-05-15T16:06:43 <ThomasWaldmann> we just need ways to identify items, that's not necessarily a name like "foobar"
45 2014-05-15T16:07:18 <skathpalia> Also I found one more thing
46 2014-05-15T16:08:09 <skathpalia> That if we try to edit any other item through this page 127.0.0.1/@itemid/"itemid" then also we get the same error
47 2014-05-15T16:08:21 <skathpalia> i.e. name not defined error
48 2014-05-15T16:08:33 <skathpalia> even if the name is defined
49 2014-05-15T16:09:03 <ThomasWaldmann> well, there are 2 different things
50 2014-05-15T16:09:19 <ThomasWaldmann> a) the stuff that exists in metadata (of existing items/revisions)
51 2014-05-15T16:09:48 <ThomasWaldmann> b) the fqname (built from URL params) we use to identify such an item/revision
52 2014-05-15T16:12:04 <ThomasWaldmann> so, there might be no readable name within the url, but it might exist in the metadata of the identified item (or it might not)
53 2014-05-15T16:12:20 <ThomasWaldmann> or, it might have multiple names even
54 2014-05-15T16:14:36 <skathpalia> or there might be no readable name within the url and also there is no name in the meta data
55 2014-05-15T16:14:48 <skathpalia> which is in the case of tickets
56 2014-05-15T16:15:16 <ThomasWaldmann> yeah, i just said that
57 2014-05-15T16:17:39 <skathpalia> Ok then I will try to incorporate the fqname stuff in this so that we can edit an item just by itemid
58 2014-05-15T16:18:00 <ThomasWaldmann> we can edit it in any way we want then :)
59 2014-05-15T16:18:09 <ThomasWaldmann> that's the whole point
60 2014-05-15T16:18:43 <ThomasWaldmann> there's also one more noticable thing:
61 2014-05-15T16:19:16 <ThomasWaldmann> the fqname which is made from the URL might give more information than just identification of an item
62 2014-05-15T16:19:37 <ThomasWaldmann> imagine you have an item with NAME = ["foo", "bar", ]
63 2014-05-15T16:20:23 <ThomasWaldmann> if you url is .../foo, the fqname will be (NAME, "foo") and you will now that the user is dealing with "foo" (not "bar")
64 2014-05-15T16:20:45 <ThomasWaldmann> you can't see that in the metadata, of course
65 2014-05-15T16:21:05 <ThomasWaldmann> s/now/know/
66 2014-05-15T16:21:25 <skathpalia> The update part of the ticket would also work if this part is done
67 2014-05-15T16:21:44 <ThomasWaldmann> and esp. in case of notications, you should tell that the user modified "foo" (not "bar", not itemid)
68 2014-05-15T16:22:31 *** magu_cic_
69 2014-05-15T16:25:34 *** magu_cic
70 2014-05-15T16:28:02 *** magu_cic
71 2014-05-15T16:30:27 *** magu_cic_
72 2014-05-15T16:33:21 *** derdon
73 2014-05-15T16:33:39 <skathpalia> ThomasWaldmann, if we take fqname instead of simple name at that place then revs becomes empty
74 2014-05-15T16:34:32 <ThomasWaldmann> well, likely you need to adjust the code a bit
75 2014-05-15T16:36:02 * ThomasWaldmann gtg / bbl
76 2014-05-15T16:41:42 *** magu_cic_
77 2014-05-15T16:41:42 *** magu_cic
78 2014-05-15T17:09:29 *** skathpalia
79 2014-05-15T17:41:21 *** derdon
80 2014-05-15T17:52:43 *** magu_cic
81 2014-05-15T17:54:54 *** magu_cic__
82 2014-05-15T17:55:30 *** ananasova
83 2014-05-15T17:56:14 *** magu_cic_
84 2014-05-15T17:58:30 *** magu_cic
85 2014-05-15T17:58:30 *** magu_cic_
86 2014-05-15T17:59:24 *** magu_cic
87 2014-05-15T17:59:45 *** magu_cic__
88 2014-05-15T18:02:54 *** magu_cic_
89 2014-05-15T18:25:10 *** greg_f
90 2014-05-15T18:47:34 *** magu_cic_
91 2014-05-15T18:50:34 *** magu_cic
92 2014-05-15T19:01:58 *** magu_cic
93 2014-05-15T19:05:23 *** magu_cic_
94 2014-05-15T19:15:11 *** ananasova
95 2014-05-15T21:12:59 *** dimazest
96 2014-05-15T21:13:31 *** dave_largo
97 2014-05-15T21:13:55 *** jek
98 2014-05-15T21:26:23 *** jek
99 2014-05-15T21:29:17 *** dimazest
100 2014-05-15T21:56:00 <ThomasWaldmann> re
101 2014-05-15T22:17:30 *** RogerHaase
102 2014-05-15T23:23:14 *** eSyr_
103 2014-05-15T23:23:22 *** eSyr
104 2014-05-15T23:40:23 *** derdon
105 2014-05-15T23:45:21 *** derdon
106
MoinMoin: MoinMoinChat/Logs/moin-dev/2014-05-15 (last edited 2014-05-15 00:45:02 by IrcLogImporter)