1 2014-05-11T00:48:43 *** penguinRaider
2 2014-05-11T01:00:42 *** penguinRaider
3 2014-05-11T03:42:29 *** penguinRaider
4 2014-05-11T05:00:41 *** penguinRaider
5 2014-05-11T06:08:58 *** skathpalia
6 2014-05-11T06:09:02 <skathpalia> moin
7 2014-05-11T06:09:49 <skathpalia> ThomasWaldmann, I have added some information on Etherpad. Can you please have a look at it http://etherpad.osuosl.org/moin-ticket-blog
8 2014-05-11T06:31:59 *** skathpalia
9 2014-05-11T06:48:51 *** penguinRaider
10 2014-05-11T07:01:31 *** penguinRaider
11 2014-05-11T07:07:39 *** ThomasWaldmann
12 2014-05-11T07:09:40 *** ThomasWaldmann
13 2014-05-11T07:10:41 *** ThomasWaldmann
14 2014-05-11T07:11:58 *** ThomasWaldmann
15 2014-05-11T07:50:32 *** ThomasWaldmann
16 2014-05-11T08:06:41 *** ThomasWaldmann
17 2014-05-11T08:08:26 *** derdon
18 2014-05-11T11:54:01 *** derdon
19 2014-05-11T12:48:41 *** penguinRaider
20 2014-05-11T13:01:28 *** penguinRaider
21 2014-05-11T13:06:44 *** ThomasWaldmann
22 2014-05-11T13:17:43 *** ThomasWaldmann
23 2014-05-11T13:22:31 *** penguinRaider
24 2014-05-11T13:34:07 *** ThomasWaldmann
25 2014-05-11T13:43:15 *** magu_cic
26 2014-05-11T13:44:35 *** ThomasWaldmann
27 2014-05-11T13:46:47 *** magu_cic_
28 2014-05-11T13:49:55 *** RogerHaase
29 2014-05-11T13:49:59 *** ThomasWaldmann
30 2014-05-11T13:55:42 <ThomasWaldmann> RogerHaase: looking at CR right now...
31 2014-05-11T13:56:16 * ThomasWaldmann was disconnected from irc as the server i used somehow stopped supporting ssl on ipv6
32 2014-05-11T14:00:04 <RogerHaase> ThomasWaldmann: thanks, I saw. CR seems broken on 942200043 - the overview shows 5 comments and updated 11 minutes ago, but when I display detail, it only shows my 3 comments and no email has come across
33 2014-05-11T14:02:42 <ThomasWaldmann> i just submitted 94220043 a few secs ago
34 2014-05-11T14:03:19 <RogerHaase> oh, looks OK now and email came as well
35 2014-05-11T14:05:16 <ThomasWaldmann> Sorry, an error occurred... on 96800044
36 2014-05-11T14:05:30 <ThomasWaldmann> codereview somehow seems a bit buggy recently
37 2014-05-11T14:14:09 *** skathpalia
38 2014-05-11T14:14:17 <skathpalia> ThomasWaldmann, moin
39 2014-05-11T14:15:40 <ThomasWaldmann> http://etherpad.osuosl.org/moin-improve-gui < no activity at all yet
40 2014-05-11T14:16:23 <ThomasWaldmann> hi skathpalia
41 2014-05-11T14:17:10 <ThomasWaldmann> dimazest: btw, if you have time, maybe also get a bit involved on skathpalia's etherpad
42 2014-05-11T14:17:31 <skathpalia> ThomasWaldmann, so we want to have ticket item to have only itemid not name
43 2014-05-11T14:17:50 <skathpalia> as it will uniquely identify that item
44 2014-05-11T14:17:52 <ThomasWaldmann> i'ld at least try
45 2014-05-11T14:18:36 <ThomasWaldmann> random names in urls are not easy to refer to (except when showing the full url) and also tend to look ugly and rather long...
46 2014-05-11T14:19:01 <dimazest> sure!
47 2014-05-11T14:19:07 <skathpalia> Then how are we supposed to create a ticket
48 2014-05-11T14:19:29 * dimazest will get some time on a train from Groningen to Amsterdam, hopes there will be wifi
49 2014-05-11T14:19:54 <skathpalia> I mean now we just add some name after 127.0.0.1/some_name and then that "some_name" type of object gets created
50 2014-05-11T14:20:33 <skathpalia> But if we are using only ITEMID then we need to change the way ticket should be created
51 2014-05-11T14:22:40 <skathpalia> And also the current bug is also coming because it is calling methods that are used for other items which then look for name field in meta which is not present
52 2014-05-11T14:25:10 <skathpalia> ThomasWaldmann, I think first we should try to have a ticket that has some name
53 2014-05-11T14:25:56 <skathpalia> And then afterwards we can try to have a number also associated which is there in bitbucket and github
54 2014-05-11T14:27:35 <skathpalia> And I think nobody would ever enter any random name for the ticket as while making ticket one generally keeps in mind that the name should be self-explanatory
55 2014-05-11T14:27:45 <skathpalia> ThomasWaldmann, what's your view on this?
56 2014-05-11T14:42:10 <ThomasWaldmann> skathpalia: maybe look at the ui of some other issue trackers, like github or bitbucket
57 2014-05-11T14:42:58 <ThomasWaldmann> directly editing a url line is not the usual way they work (nor is it the usual way how you should use a wiki)
58 2014-05-11T14:44:44 <ThomasWaldmann> skathpalia: and of course you do not enter a random number while making a ticket, it generates the uuid on its own
59 2014-05-11T14:47:30 <skathpalia> ThomasWaldmann, taking the idea from the bitbucket
60 2014-05-11T14:48:07 <skathpalia> we will have an option of creating ticket on the main page
61 2014-05-11T14:48:43 <skathpalia> Then we will have a "number+some initials" of message entered as name of the ticket
62 2014-05-11T14:49:14 <skathpalia> Here number represents the issue number
63 2014-05-11T14:50:40 <skathpalia> for example we have an issue url https://bitbucket.org/thomaswaldmann/moin-2.0/issue/262/gae-logging-configuration-behaves In our wiki the URL will look like this https://bitbucket.org/thomaswaldmann/moin-2.0/issue/262_gae-logging-configuration-behaves
64 2014-05-11T14:51:13 <ThomasWaldmann> so, imagine some chinese issue entry, how will the url look like?
65 2014-05-11T14:52:54 <skathpalia> I think there would be no problem in that
66 2014-05-11T14:53:00 <ThomasWaldmann> (or any other language with non-ascii characters)
67 2014-05-11T14:54:04 <ThomasWaldmann> http://master19.moinmo.in/%E6%9C%80%E6%96%B0%E6%94%B9%E5%8A%A8
68 2014-05-11T14:54:10 <ThomasWaldmann> maybe like that?
69 2014-05-11T14:55:11 <skathpalia> Yeah if we are able to make this type of wiki with chinese name then I think there won't be any problem in creating ticket
70 2014-05-11T14:55:50 <ThomasWaldmann> my point is that such urls are not adding any benefit over just having a ticket id in there
71 2014-05-11T14:57:01 <skathpalia> Then I think we have to use natural numbers
72 2014-05-11T14:57:20 <ThomasWaldmann> also, if you have tickets with names, they will show up in the index of (named) items
73 2014-05-11T14:57:43 <ThomasWaldmann> if you have a lot of tickets, you will have difficulties to find other stuff
74 2014-05-11T14:58:10 <ThomasWaldmann> and i already told what problems sequential numbers have
75 2014-05-11T14:59:07 <ThomasWaldmann> it's not just a random decision that systems like git or hg usually identify changesets by their hash and not just a number from 1 .. n
76 2014-05-11T14:59:28 <skathpalia> Regarding the index problem we can edit it in such a way that in named items all items other than tickets
77 2014-05-11T14:59:58 <skathpalia> I mean in named items it shows all items other than ticket items
78 2014-05-11T15:00:33 <ThomasWaldmann> so, what benefit does the name give if you don't list it?
79 2014-05-11T15:01:02 <skathpalia> I mean we cab have a separate section for tickets
80 2014-05-11T15:01:05 <skathpalia> *can
81 2014-05-11T15:01:22 <ThomasWaldmann> you mean a separate namespace?
82 2014-05-11T15:02:09 <skathpalia> Yeah this can also be an option
83 2014-05-11T15:02:24 <skathpalia> But we can also do this by keeping same namespace
84 2014-05-11T15:02:41 <ThomasWaldmann> so, what is the benefit of having named tickets?
85 2014-05-11T15:03:15 <skathpalia> As the name is somewhat explanatory what ticket is all about
86 2014-05-11T15:03:30 <skathpalia> I mean atleast a vague idea we can have on seeing the name
87 2014-05-11T15:03:34 <ThomasWaldmann> the description is doing the same
88 2014-05-11T15:03:48 <ThomasWaldmann> (or title or however it is currently called in the metadata)
89 2014-05-11T15:04:17 <skathpalia> I mean without viewing the ticket
90 2014-05-11T15:04:24 <skathpalia> I mean just by looking the URL
91 2014-05-11T15:04:42 <ThomasWaldmann> well, if i give you a pastebin url, what do you do?
92 2014-05-11T15:05:32 <ThomasWaldmann> or a shortened url as long urls often cause problems
93 2014-05-11T15:05:46 <skathpalia> Yeah I think it may cause some problems
94 2014-05-11T15:05:59 <skathpalia> Then we can only have itemid
95 2014-05-11T15:06:40 <ThomasWaldmann> maybe check if it already can lookup by itemid prefix
96 2014-05-11T15:07:21 <ThomasWaldmann> so if the itemid is 0123456789abcdef, that a lookup also works by 0123 prefix given that there is no other itemid with that prefix
97 2014-05-11T15:08:32 <skathpalia> I have an idea lets add name in its meta field and we keep it same as itemid then automatically it will search in that
98 2014-05-11T15:08:38 <ThomasWaldmann> for the issue tracker, we'll need a issue list that can be reorder by some criteria. like tags, like severity,priority,difficulty
99 2014-05-11T15:09:19 <skathpalia> Yeah that part can be done once in UI part
100 2014-05-11T15:09:23 <ThomasWaldmann> what's the point of mixing it up and duplicating it?
101 2014-05-11T15:11:04 <skathpalia> Because now it is calling methods which are called by other items also and then it looks for name which it doesn't find for ticket items
102 2014-05-11T15:11:25 <skathpalia> Also in this way we can have all items defined in a similar way
103 2014-05-11T15:11:44 <ThomasWaldmann> have a look at the TicketMetaForm definition, that's the stuff (aside from itemid, which is always there) you deal with
104 2014-05-11T15:12:21 <ThomasWaldmann> and if the api still relies on names, it needs to be refactored to be generic
105 2014-05-11T15:12:41 <ThomasWaldmann> that maybe wasn't done yet as it was in a parallel project
106 2014-05-11T15:13:15 <skathpalia> Yeah this was the problem ^
107 2014-05-11T15:13:20 <ThomasWaldmann> look at the fqname stuff to see what i mean
108 2014-05-11T15:13:55 <ThomasWaldmann> you can give (ITEMID, "1234...") now to address the item via the itemid (not the name)
109 2014-05-11T15:14:06 <ThomasWaldmann> or (NAME, "foobar") to address via name
110 2014-05-11T15:15:03 <ThomasWaldmann> names should be completely optional at most places
111 2014-05-11T15:15:54 <ThomasWaldmann> the itemid has the nice property to be globally unique and never-changing
112 2014-05-11T15:16:23 <ThomasWaldmann> just think of a badly named ticket. if you rename it, all links to it via the (old) name will break.
113 2014-05-11T15:17:22 <skathpalia> I don't think we should add rename option in tickets
114 2014-05-11T15:17:31 <skathpalia> as it is not there in bitbucket also
115 2014-05-11T15:17:43 <ThomasWaldmann> rename is a generic functionality of named items
116 2014-05-11T15:18:14 <ThomasWaldmann> and not having it is just avoiding the issues that you introduce by having names :D
117 2014-05-11T15:19:08 <ThomasWaldmann> but if you can't rename something that has a bad or even misleading name, your system has a broken design
118 2014-05-11T15:19:43 <ThomasWaldmann> so maybe just let's take itemids for the url for now
119 2014-05-11T15:20:18 <ThomasWaldmann> the user interface (issue list) will of course show more info, like the other metadata we have (see that class)
120 2014-05-11T15:20:58 <skathpalia> So you want that ticket url will look like this 127.0.0.1/+itemid/1234567890abcdef ?
121 2014-05-11T15:21:21 <ThomasWaldmann> yes, or the abbreviated version using a itemid prefix
122 2014-05-11T15:22:13 <ThomasWaldmann> for usage in the wiki, you can use the interwiki mechanism
123 2014-05-11T15:22:28 <skathpalia> So the current code needs to be changed in such a way that name is not necessary for the items especially for the ticket items?
124 2014-05-11T15:22:39 <skathpalia> Only itemid is required
125 2014-05-11T15:22:41 <skathpalia> ?
126 2014-05-11T15:22:55 <ThomasWaldmann> so one would define a shortcut like Ticket -> "http://example.org/+itemid/" in the map and then write
127 2014-05-11T15:23:02 <ThomasWaldmann> Ticket:12345
128 2014-05-11T15:23:32 <ThomasWaldmann> yes (and same for blog maybe)
129 2014-05-11T15:24:11 <skathpalia> You mean blog also should only have itemid?
130 2014-05-11T15:24:18 <ThomasWaldmann> the addressing mechanism via url is generic in moin
131 2014-05-11T15:24:30 <ThomasWaldmann> so you can choose how you want to address
132 2014-05-11T15:24:46 <ThomasWaldmann> each item has an itemid, so you can lookup it that way
133 2014-05-11T15:25:00 <ThomasWaldmann> if an item has name(s), you can also look it up via name
134 2014-05-11T15:25:33 <ThomasWaldmann> but it's bad if the code is not using the full power of that and limits you to using just the name mechanism
135 2014-05-11T15:26:01 <skathpalia> the current code is limited to names only
136 2014-05-11T15:26:25 <ThomasWaldmann> for blog and tickets maybe yes, for wiki items no
137 2014-05-11T15:26:52 <skathpalia> Okay I will try to change it so that this limit is removed in case of ticket and blog
138 2014-05-11T15:27:25 <skathpalia> I will be back in 20-30 minutes
139 2014-05-11T15:28:09 <ThomasWaldmann> later, if there are special reasons to use names (e.g. if you want to optimize your urls so google likes them better for some search terms, so people find your blog post better, you can do that)
140 2014-05-11T15:28:42 * ThomasWaldmann will have to leave soon. but there are other mentors around.
141 2014-05-11T15:37:17 <Cthulhux> hm.. minefield macht lustige dinge mit dem quellcode
142 2014-05-11T15:37:17 <Cthulhux> http://i.imgur.com/mnZIYwB.png
143 2014-05-11T15:39:24 <ThomasWaldmann> wrong chan?
144 2014-05-11T15:40:05 <Cthulhux> no, why?
145 2014-05-11T15:41:34 <ThomasWaldmann> hmm, why "minefield"?
146 2014-05-11T15:41:42 * ThomasWaldmann thought of a MS game
147 2014-05-11T15:41:45 <Cthulhux> it's called "minefield" in the wiki :-D
148 2014-05-11T15:41:55 <Cthulhux> the moinmoin alpha thing :p
149 2014-05-11T15:42:26 <ThomasWaldmann> ah :D
150 2014-05-11T15:42:40 <Cthulhux> hence the URL on the screenshot :p
151 2014-05-11T15:42:49 <Cthulhux> minesweeper != minefield ;)
152 2014-05-11T15:49:54 <ThomasWaldmann> so, what are you pointing to, the superfluous linefeeds?
153 2014-05-11T15:50:49 <ThomasWaldmann> (that is a cosmetic effect caused by template usage)
154 2014-05-11T15:50:53 <ThomasWaldmann> Cthulhux:
155 2014-05-11T15:51:29 <Cthulhux> cosmetic? (well, afaik it invalidates the standards compliance.)
156 2014-05-11T15:51:53 <ThomasWaldmann> where? line no?
157 2014-05-11T15:55:30 <ThomasWaldmann> btw, the test.moinmo.in instance is usually a bit outdated
158 2014-05-11T15:55:47 <ThomasWaldmann> so, for testing the current code, it is better to run it locally from a repo checkout
159 2014-05-11T15:55:50 <ThomasWaldmann> Cthulhux: ^
160 2014-05-11T15:57:46 <Cthulhux> uh,
161 2014-05-11T15:57:52 <Cthulhux> ok ;:-) (which line no?)
162 2014-05-11T16:10:02 *** randomax
163 2014-05-11T16:11:06 <RogerHaase> randomax: moin
164 2014-05-11T16:12:18 <randomax> RogerHaase: moin
165 2014-05-11T16:17:46 <RogerHaase> randomax: I see you found EP link from here http://moinmo.in/GoogleSoc2014. If you have time, try to add more project details
166 2014-05-11T16:18:46 <randomax> yes.. i'll upload blog posts and EP notes by tonight
167 2014-05-11T16:19:03 <randomax> i have been looking into the syntax highlighting working
168 2014-05-11T16:19:13 <randomax> DOM conversion and related stuff
169 2014-05-11T16:19:27 <RogerHaase> great!
170 2014-05-11T16:30:38 <RogerHaase> randomax: you will be doing a lot of work with jinja2 templates - have you read about that yet? Also do you have a tool to do html5 validation?
171 2014-05-11T16:42:22 <randomax> yes.. i have reading up on jinja2 templates too..
172 2014-05-11T16:42:58 <randomax> regarding validation.. you had told me about jslint.. i had looked into that
173 2014-05-11T16:43:03 <randomax> apart from thta
174 2014-05-11T16:43:07 <randomax> *that
175 2014-05-11T16:43:43 <randomax> i generally use mozilla and chrome developer tools for checking for errors
176 2014-05-11T16:44:12 <randomax> w3c provides an offline tool too for validation but its only for 4.1 till now
177 2014-05-11T16:44:26 <randomax> besides it has an online tool for html5 validation
178 2014-05-11T16:44:39 <randomax> RogerHaase: ^
179 2014-05-11T16:47:45 <RogerHaase> randomax: I have been using windows version of http://users.skynet.be/mgueury/mozilla/ for quite some time. But if you have another way that works, fine.
180 2014-05-11T16:48:05 *** skathpalia
181 2014-05-11T16:58:49 <Cthulhux> probably firebug can do that
182 2014-05-11T17:04:04 <randomax> yep.. thats what i was talking about
183 2014-05-11T17:08:12 *** mansi
184 2014-05-11T17:08:29 *** randomax
185 2014-05-11T17:08:52 *** randomax
186 2014-05-11T17:22:53 *** skathpalia
187 2014-05-11T17:25:40 *** skathpalia
188 2014-05-11T18:03:29 *** mansi
189 2014-05-11T18:11:10 *** randomax
190 2014-05-11T18:11:26 *** randomax
191 2014-05-11T18:37:52 <randomax> uploaded a couple of blog posts - http://ajiteshg.blogspot.in/ :D
192 2014-05-11T18:42:21 <RogerHaase> randomax: :-D
193 2014-05-11T18:50:57 *** randomax
194 2014-05-11T19:11:29 *** derdon
195 2014-05-11T19:28:28 *** derdon
196 2014-05-11T21:55:02 <RogerHaase> ThomasWaldmann: creole interwiki links https://codereview.appspot.com/94220043/
197 2014-05-11T21:56:51 <RogerHaase> ThomasWaldmann: also new items.moin at https://codereview.appspot.com/91380043/ but nothing to see there as it is binary, demo at http://www.digitalrockart.org/moin2/Home
198 2014-05-11T22:02:04 <RogerHaase> ThomasWaldmann: btw, my demo site is at my repo tip plus the 9422 creole patch
199 2014-05-11T22:05:30 *** penguinRaider
200 2014-05-11T22:27:06 *** RogerHaase
201
