1 2014-02-20T00:46:01 *** penguinRaider
2 2014-02-20T01:20:02 *** penguinRaider
3 2014-02-20T02:10:15 *** sudo_dirk
4 2014-02-20T02:11:38 *** sudo_dirk
5 2014-02-20T06:04:10 *** moin9
6 2014-02-20T06:08:33 *** moin9
7 2014-02-20T06:18:49 *** xiaq_
8 2014-02-20T06:38:38 *** bithin
9 2014-02-20T06:59:10 *** bithin
10 2014-02-20T07:26:32 *** ajitesh
11 2014-02-20T07:30:07 *** bithin
12 2014-02-20T07:38:11 *** bithin
13 2014-02-20T08:03:32 *** penguinRaider
14 2014-02-20T08:21:00 *** skathpalia
15 2014-02-20T09:02:47 *** greg_f
16 2014-02-20T09:17:17 *** daddy1
17 2014-02-20T09:17:18 *** daddy1
18 2014-02-20T09:42:59 *** penguinRaider
19 2014-02-20T09:53:31 *** xjjk
20 2014-02-20T09:55:20 *** penguinRaider
21 2014-02-20T10:59:49 *** bithin
22 2014-02-20T11:02:45 *** penguinRaider
23 2014-02-20T11:04:34 *** bithin
24 2014-02-20T11:36:23 *** skathpalia
25 2014-02-20T11:39:51 <ThomasWaldmann> moin
26 2014-02-20T12:37:17 <ananasova> moin
27 2014-02-20T12:37:44 <ananasova> ThomasWaldmann: can you please review when free - https://codereview.appspot.com/65070043/
28 2014-02-20T13:06:52 *** skathpalia
29 2014-02-20T13:07:10 *** ajitesh
30 2014-02-20T13:08:25 <skathpalia> xiaq, I have a doubt regarding the ticket which was made by you last summer . In class Ticket do_modify method the is_new always returns True I mean how are you calculating is_new
31 2014-02-20T13:11:04 <skathpalia> xiaq, Also when we store a ticket it gets stored but the name becomes empty string (it is accessible by itemid ) . In which part are you storing it with the help of name ??
32 2014-02-20T13:24:03 *** derdon
33 2014-02-20T13:32:22 *** dave_largo
34 2014-02-20T13:33:52 *** RogerHaase
35 2014-02-20T13:36:01 <skathpalia> RogerHaase, I have added a comment regarding the patch https://codereview.appspot.com/65420044/
36 2014-02-20T13:38:58 <ajitesh> RogerHaase, code review for GUI change in index page - https://codereview.appspot.com/65920047/
37 2014-02-20T13:39:40 <ajitesh> includes fix for smileys not working in the basic theme
38 2014-02-20T13:40:01 <RogerHaase> skathpalia: OK, as styling wasn't part of the issue and we are sort of blocked by less compile, let's leave that part as is.
39 2014-02-20T13:41:11 <skathpalia> RogerHaase, Ok I will put the css part in the basic.less and after compilation send it for review again :)
40 2014-02-20T13:53:45 *** dimazest_
41 2014-02-20T13:54:46 <skathpalia> RogerHaase, I have added the css to basic.less file and compiled it . You can check here https://codereview.appspot.com/65420044/
42 2014-02-20T13:59:45 *** dimazest
43 2014-02-20T13:59:47 *** ThomasWaldmann
44 2014-02-20T14:02:06 <RogerHaase> ajitesh: done, just one point about using a "moin-" prefix for class names and IDs. (Does anyone know where that is written on some docs?)
45 2014-02-20T14:05:13 *** derdon
46 2014-02-20T14:08:06 <RogerHaase> skathpalia: I missed the tabs and trailing spaces in prior review. What editor do you use?
47 2014-02-20T14:09:04 <RogerHaase> skathpalia: ajitesh what exactly did you do to get around the less compile error?
48 2014-02-20T14:09:45 *** ThomasWaldmann
49 2014-02-20T14:09:56 <skathpalia> RogerHaase, I use vim
50 2014-02-20T14:11:51 <skathpalia> This time I have tried to make as much errors as possible regarding the spaces :)
51 2014-02-20T14:12:59 <skathpalia> I mean minimal errors :D
52 2014-02-20T14:15:47 *** ajitesh
53 2014-02-20T14:16:00 *** ajitesh
54 2014-02-20T14:16:39 <RogerHaase> skathpalia: http://vim.wikia.com/wiki/Converting_tabs_to_spaces http://www.bestofvim.com/tip/trailing-whitespace/
55 2014-02-20T14:20:40 *** ThomasWaldmann
56 2014-02-20T14:33:54 *** ThomasWaldmann
57 2014-02-20T14:36:03 <ThomasWaldmann> ananasova: done
58 2014-02-20T14:39:05 <RogerHaase> ThomasWaldmann: fix for 395, pip 1.5+ https://codereview.appspot.com/65520044/
59 2014-02-20T14:40:14 <RogerHaase> ThomasWaldmann: set modernized theme as default (at least until basic becomes more stable) https://codereview.appspot.com/61410054/
60 2014-02-20T14:48:26 <ajitesh> RogerHaase, using bootstrap 3.0.0rc2 we dont get a compile error..
61 2014-02-20T14:48:36 *** bithin
62 2014-02-20T14:49:20 <RogerHaase> ajitesh: OK, thanks
63 2014-02-20T14:49:22 *** bithin
64 2014-02-20T14:49:38 <ajitesh> but if we use a higher version of bootstrap it does give an error.. we'll have to define the variable "@screen-medium" in the file "moin-variables.less"
65 2014-02-20T14:50:08 <ajitesh> ThomasWaldmann, review needed https://codereview.appspot.com/65430043/
66 2014-02-20T14:50:52 <ajitesh> also can u please add ACL to this page : http://moinmo.in/AjiteshGupta/GSOC2014Ideas
67 2014-02-20T14:57:23 <skathpalia> Thanks RogerHaase I will add this to my editor . From next time there won't be any errors of indentation
68 2014-02-20T14:57:52 *** bithin
69 2014-02-20T14:59:50 <skathpalia> ThomasWaldmann, I have added the subscription tab in the basic theme (bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/408/basic-theme-missing-subscription-tab) . You can review it here https://codereview.appspot.com/64370043/
70 2014-02-20T15:11:52 *** derdon
71 2014-02-20T15:16:17 *** derdon
72 2014-02-20T15:25:29 *** derdon
73 2014-02-20T16:37:20 *** ajitesh
74 2014-02-20T16:41:45 *** ajitesh
75 2014-02-20T17:19:03 *** bithin
76 2014-02-20T17:28:18 *** bithin
77 2014-02-20T17:37:26 *** greg_f
78 2014-02-20T18:00:14 *** bithin
79 2014-02-20T18:00:25 *** bithin
80 2014-02-20T18:01:54 *** bithin
81 2014-02-20T18:19:09 *** bithin
82 2014-02-20T18:42:41 <skathpalia> RogerHaase, I have removed the extra spaces from the two lines pointed by you
83 2014-02-20T18:45:36 *** bithin_
84 2014-02-20T18:45:38 *** bithin
85 2014-02-20T18:47:32 *** bithin_
86 2014-02-20T18:47:47 <RogerHaase> skathpalia: see cr, still has a few tabs
87 2014-02-20T18:47:50 *** bithin_
88 2014-02-20T18:52:42 <skathpalia> RogerHaase, Actually the link you suggested in which retab command is there was creating some problems thats why the errors came
89 2014-02-20T18:53:23 <skathpalia> Sorry for the inconvenience from next time I would use some other better editor so that error would not come
90 2014-02-20T18:53:36 <skathpalia> I have made the changes in th cr :0
91 2014-02-20T18:53:39 <skathpalia> :)
92 2014-02-20T18:54:17 *** dimazest_
93 2014-02-20T18:59:20 <RogerHaase> skathpalia: see again - indentation
94 2014-02-20T19:07:26 <skathpalia> RogerHaase, In the original code also after the if statement there were 2 spaces indentation (the else you pointed ) . correcting that also :)
95 2014-02-20T19:10:31 <skathpalia> RogerHaase, you can check it now
96 2014-02-20T19:16:55 <RogerHaase> skathpalia: tabs are back
97 2014-02-20T19:18:33 <ajitesh> RogerHaase, all the classes i used belong to bootstrap.. so should i change them ?
98 2014-02-20T19:19:12 <RogerHaase> ajitesh: in that case, no, do not change
99 2014-02-20T19:20:46 <ajitesh> ok
100 2014-02-20T19:22:06 *** bithin_
101 2014-02-20T19:23:57 *** bithin_
102 2014-02-20T19:27:15 <skathpalia> Seriously this time there some problem in my editor settings :(
103 2014-02-20T19:28:08 <skathpalia> RogerHaase, changed it now there are no more tabs in this https://codereview.appspot.com/65420044/diff2/1:200001/MoinMoin/themes/basic/templates/layout.html
104 2014-02-20T19:30:26 <skathpalia> I have removed the tabs which were previously in the main code also
105 2014-02-20T19:37:10 <RogerHaase> skathpalia: looks good :)
106 2014-02-20T19:37:29 <skathpalia> Thanks :)
107 2014-02-20T19:37:37 <ThomasWaldmann> re
108 2014-02-20T19:39:49 <skathpalia> ThomasWaldmann, I have added the subscription tab in the basic theme You can review it here https://codereview.appspot.com/65420044/
109 2014-02-20T19:41:21 <ThomasWaldmann> ok
110 2014-02-20T19:43:47 <ajitesh> ThomasWaldmann, code review needed https://codereview.appspot.com/65430043/
111 2014-02-20T19:44:07 <ThomasWaldmann> floating point fluctuations...
112 2014-02-20T19:46:59 <skathpalia> ThomasWaldmann, while compiling basic.less some values get changed
113 2014-02-20T19:49:03 <skathpalia> This is an open bug
114 2014-02-20T19:50:03 *** bithin_
115 2014-02-20T19:52:01 <skathpalia> ThomasWaldmann, Once that bug is fixed the floating point fluctuations won't be there.
116 2014-02-20T20:04:11 *** bithin_
117 2014-02-20T20:36:48 *** bithin_
118 2014-02-20T21:02:28 *** sudo_dirk_
119 2014-02-20T21:04:10 *** ThomasWaldmann
120 2014-02-20T21:05:18 *** sudo_dirk
121 2014-02-20T21:05:22 *** xiaq
122 2014-02-20T21:05:26 *** sunu
123 2014-02-20T21:05:30 *** eSyr-ng
124 2014-02-20T21:05:33 *** ronny
125 2014-02-20T21:05:35 *** sharky93
126 2014-02-20T21:05:35 *** samgtr_
127 2014-02-20T21:05:35 *** ananasova
128 2014-02-20T21:06:04 *** ronny
129 2014-02-20T21:06:04 *** sharky93
130 2014-02-20T21:06:04 *** samgtr_
131 2014-02-20T21:06:04 *** ananasova
132 2014-02-20T21:06:24 *** xiaq
133 2014-02-20T21:06:24 *** sunu
134 2014-02-20T21:07:56 *** eSyr-ng
135 2014-02-20T21:14:56 *** ThomasWaldmann
136 2014-02-20T21:18:33 <skathpalia> xiaq, I have a doubt regarding the ticket which was made by you last summer . In class Ticket do_modify method the is_new always returns True I mean how are you calculating is_new
137 2014-02-20T21:18:57 <skathpalia> xiaq, Also when we store a ticket it gets stored but the name becomes empty string (it is accessible by itemid ) . In which part are you storing it with the help of name ??
138 2014-02-20T21:27:26 *** xiaq__
139 2014-02-20T21:33:23 *** xorAxAx
140 2014-02-20T21:34:16 *** xorAxAx
141 2014-02-20T21:40:02 *** eSyr-ng
142 2014-02-20T21:40:34 *** xiaq
143 2014-02-20T21:40:37 *** sunu
144 2014-02-20T21:42:02 *** RogerHaase
145 2014-02-20T21:44:46 *** sunu
146 2014-02-20T22:00:00 *** derdon
147 2014-02-20T22:00:21 *** jek
148 2014-02-20T22:00:22 *** Cthulhux
149 2014-02-20T22:03:35 *** Cthulhux
150 2014-02-20T22:05:20 <ThomasWaldmann> skathpalia: done
151 2014-02-20T22:05:25 <ThomasWaldmann> ajitesh: looking now
152 2014-02-20T22:06:29 *** jek
153 2014-02-20T22:06:29 *** eSyr-ng
154 2014-02-20T22:21:19 <ThomasWaldmann> ajitesh: acl added
155 2014-02-20T22:22:18 <ThomasWaldmann> ajitesh: is there a bug open that you fix with https://codereview.appspot.com/65430043/ ?
156 2014-02-20T22:25:11 *** bithin_
157 2014-02-20T22:27:03 *** jek
158 2014-02-20T22:33:12 *** eSyr-ng
159 2014-02-20T22:36:09 *** bithin_
160 2014-02-20T22:36:27 *** jek
161 2014-02-20T22:36:27 *** eSyr-ng
162 2014-02-20T22:46:13 *** eSyr-ng
163 2014-02-20T22:47:01 *** eSyr-ng
164 2014-02-20T22:57:52 *** skathpalia
165 2014-02-20T23:57:10 *** dave_largo
166
