1 2014-02-17T02:15:41 *** sudo_dirk_
2 2014-02-17T02:16:39 *** sudo_dirk
3 2014-02-17T02:27:41 *** hellboy2k8
4 2014-02-17T02:28:26 *** penguinRaider
5 2014-02-17T04:00:07 *** skathpalia
6 2014-02-17T04:55:43 *** hellboy2k8
7 2014-02-17T04:55:48 *** penguinRaider
8 2014-02-17T05:15:14 *** penguinRaider
9 2014-02-17T05:15:39 *** penguinRaider
10 2014-02-17T05:57:16 *** hellboy2k8
11 2014-02-17T05:57:39 *** penguinRaider
12 2014-02-17T06:23:38 *** resurrectorx
13 2014-02-17T07:09:23 *** resurrectorx
14 2014-02-17T07:17:43 *** ajitesh
15 2014-02-17T07:18:11 *** ajitesh
16 2014-02-17T08:01:21 <xiaq> RogerHaase: i can not tell exactly, but it should be still viable
17 2014-02-17T08:17:10 *** skathpalia
18 2014-02-17T08:36:06 *** hellboy2k8
19 2014-02-17T08:37:42 *** penguinRaider
20 2014-02-17T08:51:51 *** skathpalia
21 2014-02-17T09:02:00 *** greg_f
22 2014-02-17T10:08:20 *** penguinRaider
23 2014-02-17T10:08:27 *** hellboy2k8
24 2014-02-17T10:57:08 <ananasova> moin :)
25 2014-02-17T12:00:07 *** skathpalia
26 2014-02-17T12:01:27 *** ajitesh
27 2014-02-17T12:20:01 *** ajitesh
28 2014-02-17T13:25:31 *** derdon
29 2014-02-17T13:55:22 *** RogerHaase
30 2014-02-17T14:21:35 <skathpalia> RogerHaase, I asked you earlier about making the css of the html tables better in basic theme then we should add the css to the custom.css or basic.less??
31 2014-02-17T14:37:55 <RogerHaase> skathpalia: it must go in basic.less and then be compiled to the .css files
32 2014-02-17T14:39:35 <RogerHaase> skathpalia: also make.py should be updated to do the less compile along with the Stylus compile (may as well do all at same time)
33 2014-02-17T14:41:24 <skathpalia> RogerHaase, So then should I wait for the updation of make.py and then ask ThomasWaldmann for review ?
34 2014-02-17T14:42:36 <ananasova> ThomasWaldmann: please review the subscription updates - https://codereview.appspot.com/65070043/
35 2014-02-17T14:43:26 *** derdon
36 2014-02-17T14:52:52 <skathpalia> ThomasWaldmann, I made some changes regarding the bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/408/basic-theme-missing-subscription-tab which were reviewed by RogerHaase and according to him it is Ok. You can review it here https://codereview.appspot.com/64370043/
37 2014-02-17T15:07:05 <RogerHaase> skathpalia: until make.py is updated, you can compile the .less files, see: https://moin-20.readthedocs.org/en/latest/devel/development.html?highlight=less#templates-and-themes
38 2014-02-17T15:08:25 <RogerHaase> skathpalia: on 64370043, why did you change the textarea width from autosize to 500?
39 2014-02-17T15:14:53 *** xiaq
40 2014-02-17T15:28:56 <skathpalia> RogerHaase, the autosize generates textarea which is very small .
41 2014-02-17T15:29:17 <skathpalia> So to make it big enough I added the width to be 500
42 2014-02-17T15:29:57 <skathpalia> RogerHaase, If we don't do this then textarea is as small as an input field :)
43 2014-02-17T15:31:39 <skathpalia> RogerHaase, the command to compile creates error which has been reported https://bitbucket.org/thomaswaldmann/moin-2.0/issue/409/basicless-fails-to-compile-due-to So I can't compile till this bug is fixed
44 2014-02-17T15:38:56 <RogerHaase> skathpalia: did you consider min-width or percentage.? Seems like foobar and modernized have adjustable widths based on window size
45 2014-02-17T15:41:22 <penguinRaider> RogerHaase, should +rename work by itemid too like localhost:8080/+rename/@itemid/id ?
46 2014-02-17T15:42:17 <RogerHaase> penguinRaider: I have no idea about that
47 2014-02-17T15:44:17 <skathpalia> RogerHaase, This one also has adjustable width like in other themes I just added a default value to it
48 2014-02-17T15:51:36 <skathpalia> No I didn't consider min-width or percentage
49 2014-02-17T16:01:49 <RogerHaase> skathpalia: when width is put into js like that it becomes and inline style, so that overrides anything in css. Per my tests, it looks like a fixed width of 500px. It is rather odd to have that in js, should normally be in css. Leave as is, we will see what tw says. Maybe another enhancement is to look through basic theme js and move stuff like that to CSS (.less).
50 2014-02-17T16:02:50 <skathpalia> RogerHaase, Yeah I was also thinking of the same of adding the width to basic.css file
51 2014-02-17T16:04:28 <RogerHaase> skathpalia: re. compiling less files, I think ajitesh said he found a fix for the bug a couple of days ago. I don't see it in a pull request. Maybe he can share the fix so you can at least do a compile.
52 2014-02-17T16:04:35 <skathpalia> Ok then I will change that line to textarea.autosize() only and after this has been merged I will discuss with ThomasWaldmann about this enhancement in the basic.css file right
53 2014-02-17T16:05:10 <RogerHaase> skathpalia: sounds like a plan
54 2014-02-17T16:05:38 <skathpalia> Ok then I will ask ajitesh about how to compile .less files :)
55 2014-02-17T16:10:04 <ajitesh> RogerHaase, yes i found that though it is able to compile on bootstrap 3.0.0rc2 it'll give an error beyond that version because beyond that version screen-medium variable is not defined..
56 2014-02-17T16:10:11 <ajitesh> so for now it'll compile...
57 2014-02-17T16:10:12 <ajitesh> but
58 2014-02-17T16:11:17 <ajitesh> on compiling it makes a lot of minor changes in the basic.css .. like for instance "width : 15.555555555556%" becomes something like "width: 15.55556%"
59 2014-02-17T16:12:26 <ajitesh> all changes are like that (big decimal --> small decimal) .. so i was seeking help from sharky93 on the matter..
60 2014-02-17T16:17:52 <RogerHaase> ajitesh: haha, we have the same issue with Stylus. I think nodejs is the problem. On windows, that number will probably be 15.666666666668. sharky93 fixed most of the issues by eliminating divisions
61 2014-02-17T16:45:06 <ajitesh> RogerHaase, skathpalia its working now.. updated my lessc version.. :)
62 2014-02-17T16:49:18 <ajitesh> oh wait.. it came again.. :|
63 2014-02-17T16:50:54 <sharky93> moin
64 2014-02-17T16:51:32 *** RogerHaase
65 2014-02-17T16:53:06 <sharky93> my lessc version is 1.4.2 .. if that helps.
66 2014-02-17T16:54:41 *** RogerHaase
67 2014-02-17T16:54:53 <ajitesh> sharky93, so the changes should be there i guess then.. maybe in a separate commit i guess ??
68 2014-02-17T16:55:28 <ajitesh> because its better to use an updated compiler..
69 2014-02-17T16:57:19 <sharky93> imo, adding the compiler version to moin-docs is more important.
70 2014-02-17T17:00:00 <sharky93> it would help if you could somehow eliminate divisions further. i too think nodejs is the issue here, as RogerHaase pointed out :) .. don't be surprised if that issue pops up again in further releases of lessc coming up :P
71 2014-02-17T17:01:43 *** dreimark
72 2014-02-17T17:10:29 <ajitesh> sharky93, could you give an example of where divisions take place ? i tried to find but could not get anything..
73 2014-02-17T17:32:56 *** ReimarBauer
74 2014-02-17T18:17:37 *** nitinagarwal3006
75 2014-02-17T18:20:24 <nitinagarwal3006> Hi ThomasWaldmann
76 2014-02-17T19:09:23 *** nitinagarwal3006
77 2014-02-17T19:43:40 *** derdon
78 2014-02-17T19:49:05 <skathpalia> RogerHaase, on the main page in the basic theme on the left side we have view options which have comments and Transclusions. What are they supposed to do?
79 2014-02-17T20:07:03 <RogerHaase> skathpalia: it is working here, http://test.moinmo.in/moin. Click on transclusion link and look for moin logo under External Links - see highlighted corners with mouseover effect. Also see comment toggle visible at bottom of page when you click comments link.
80 2014-02-17T20:09:35 <RogerHaase> skathpalia: pull request 191 should fix it when tw merges it into main repo https://bitbucket.org/thomaswaldmann/moin-2.0/pull-requests
81 2014-02-17T20:21:48 <skathpalia> Ok :)
82 2014-02-17T20:26:31 *** skathpalia
83 2014-02-17T22:00:06 *** ajitesh
84 2014-02-17T22:05:32 *** RogerHaase
85 2014-02-17T23:02:14 *** penguinRaider
86 2014-02-17T23:20:41 *** penguinRaider
87
