1 2014-02-15T01:37:13 *** derdon
2 2014-02-15T01:38:53 *** penguinRaider
3 2014-02-15T02:13:37 *** sudo_dirk
4 2014-02-15T02:19:20 *** sudo_dirk
5 2014-02-15T03:01:26 *** Guest65967
6 2014-02-15T03:04:20 <xiaq> RogerHaase: xstatic-datatables is usable and up-to-date.
7 2014-02-15T05:12:46 *** skathpalia
8 2014-02-15T06:43:50 *** penguinRaider
9 2014-02-15T07:07:17 *** penguinRaider
10 2014-02-15T07:11:07 *** sudo_dirk
11 2014-02-15T07:16:48 *** sudo_dirk
12 2014-02-15T07:19:18 *** penguinRaider
13 2014-02-15T09:53:45 *** sudo_dirk
14 2014-02-15T09:58:18 *** sudo_dirk
15 2014-02-15T10:06:38 *** xjjk
16 2014-02-15T10:07:04 *** xjjk
17 2014-02-15T10:28:22 *** ajitesh
18 2014-02-15T10:35:31 *** dimazest
19 2014-02-15T11:18:40 *** dimazest
20 2014-02-15T13:27:12 *** RogerHaase
21 2014-02-15T13:32:01 <ananasova> moin
22 2014-02-15T13:34:08 <ananasova> ThomasWaldmann: regarding the subscription mechanism: how about using fqnames as params to subscribe/unsubscribe methods?
23 2014-02-15T13:35:17 <ananasova> as i made the essential changes to is_subscribed_to(), i discovered that fqnames are easy to use and offer nice and clean interface
24 2014-02-15T13:59:15 *** resurrectorx
25 2014-02-15T14:14:55 *** skathpalia
26 2014-02-15T14:16:03 *** resurrectorx
27 2014-02-15T14:29:57 *** ajitesh
28 2014-02-15T15:07:34 <skathpalia> RogerHaase, I tried to solve the bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/408/basic-theme-missing-subscription-tab here you can check it https://codereview.appspot.com/64370043
29 2014-02-15T15:08:54 <skathpalia> I am having some problem in this like if I go to personal settings tab I get subscriptions also there below the save button of the personal settings
30 2014-02-15T15:17:05 <skathpalia> But if I got to some other tab first then go to the personal settings tab then the subscriptions does not come but if I reload the page the subscriptions again appear below the save button of the personal settings
31 2014-02-15T15:17:26 <skathpalia> I am not able to figure why is this happening
32 2014-02-15T15:17:47 <skathpalia> RogerHaase, Any idea of how to get rid of these?
33 2014-02-15T15:27:32 <RogerHaase> skathpalia: there is a rather large piece of javascript code in MoinMoin/static/js/common.js related to settings starting ~262-397 - did you look there?
34 2014-02-15T15:28:09 <skathpalia> Oh Ok then I will have a look on it :)
35 2014-02-15T15:40:37 <RogerHaase> xiaq: I see you also created https://pypi.python.org/pypi/XStatic-Tablesorter-Mottie, and created CR https://codereview.appspot.com/12229043/ after saying DataTables was to complex. I also like mottie tablesorter over DataTables. Is that CR still viable or abandoned for a reason?
36 2014-02-15T15:58:13 <penguinRaider> ThomasWaldmann, I did exception handling in #407 as suggested by you. https://codereview.appspot.com/63500043/diff2/90001:110001/MoinMoin/items/__init__.pyhttps://codereview.appspot.com/63500043/diff2/90001:110001/MoinMoin/items/__init__.py .
37 2014-02-15T15:58:16 <penguinRaider> But I cannot think of any appropriate comment at the line you pointed so I removed it for now. By query I meant calling the method without name with revid, itemid.
38 2014-02-15T16:03:13 *** skathpalia
39 2014-02-15T16:10:22 *** skathpalia
40 2014-02-15T16:51:27 *** penguinRaider
41 2014-02-15T17:10:17 *** penguinRaider
42 2014-02-15T17:37:15 <skathpalia> RogerHaase, I went through the MoinMoin/static/js/common.js file but still I am not able to figure out the problem...
43 2014-02-15T17:38:25 <skathpalia> According to me I have defined the subscriptions tab very similar to other tabs so ideally the problem should not be in js
44 2014-02-15T17:39:10 <skathpalia> Can you see my code review and suggest some changes ....
45 2014-02-15T17:39:44 <skathpalia> Here is the link to cr https://codereview.appspot.com/64370043
46 2014-02-15T17:46:48 <ajitesh> RogerHaase, ThomasWaldmann code review needed : https://codereview.appspot.com/64160043/
47 2014-02-15T17:46:56 <ajitesh> w.r.t. https://bitbucket.org/thomaswaldmann/moin-2.0/issue/403/select-all-and-action-links-not-working-in
48 2014-02-15T18:03:50 *** derdon
49 2014-02-15T18:53:58 <skathpalia> RogerHaase, ThomasWaldmann I tried to solve the bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/408/basic-theme-missing-subscription-tab . You can review it here https://codereview.appspot.com/64370043/
50 2014-02-15T19:01:53 *** penguinRaider
51 2014-02-15T19:06:03 <RogerHaase> skathpalia: the active class is not being removed from #subscriptions. line 5 of basic.js should do that. What browser do you use for testing?
52 2014-02-15T19:14:01 <RogerHaase> skathpalia: I use Firefox with View Source Chart add-on. If I right click on page, I see html source after javascript has run shows: <div id="personal" class="tab-pane active"> .... <div id="subscriptions" class="tab-pane active">.
53 2014-02-15T19:15:19 <skathpalia> RogerHaase, I use firefox/Chrome for testing
54 2014-02-15T19:16:06 <skathpalia> Yeah I have done that in my new patch https://codereview.appspot.com/64370043/ (removed active class from #subscriptions)
55 2014-02-15T19:16:53 <skathpalia> You can review it here ^^
56 2014-02-15T19:19:33 <RogerHaase> skathpalia: search here for "tab-pane active" http://rn0.ru/show/iysdMouG6e2f5VOpvnbR/
57 2014-02-15T19:20:10 *** penguinRaider
58 2014-02-15T19:24:28 <RogerHaase> skathpalia: on different topic, when you start a code review the "new issue topic" should be close to a commit message and state an issue no. (if there is one). Then when you upload the 2nd, 3rd... patchsets, describe what has changed since the last patchset -- makes it easier for reviewers.
59 2014-02-15T19:44:20 <RogerHaase> ajitesh: reviewed your cr
60 2014-02-15T19:51:40 <ajitesh> RogerHaase, Regarding the color of the links, i already changed that in the gui change i showed you yesterday.. :) i'll fix the more and toggle links..
61 2014-02-15T19:52:18 <RogerHaase> ajitesh: OK, there are so many CRs I forget :-D
62 2014-02-15T20:13:36 *** penguinRaider
63 2014-02-15T20:21:41 *** penguinRaider_
64 2014-02-15T20:23:15 *** ajitesh
65 2014-02-15T20:23:38 *** ajitesh
66 2014-02-15T20:29:43 *** penguinRaider
67 2014-02-15T20:31:48 <penguinRaider> RogerHaase, https://bitbucket.org/thomaswaldmann/moin-2.0/issue/411/url-feed-atom-gives-builderror can you please try to reproduce it ?
68 2014-02-15T20:38:05 <RogerHaase> penguinRaider: what theme and what link are you clicking to get the 411 traceback?
69 2014-02-15T20:39:50 <penguinRaider> RogerHaase, modernized theme and http://localhost:8080/+feed/atom
70 2014-02-15T20:43:08 <RogerHaase> penguinRaider: I do not get a traceback, but a more or less normal looking page
71 2014-02-15T20:43:16 <skathpalia> RogerHaase, from next time I will take care of that :)
72 2014-02-15T20:47:37 <skathpalia> RogerHaase, yeah I got it two times but is it for the new patch I submitted or the old one because as in the new patch it is working fine ??
73 2014-02-15T20:50:45 *** penguinRaider
74 2014-02-15T20:50:45 *** penguinRaider_
75 2014-02-15T21:02:30 <skathpalia> RogerHaase, I also used that view source chart add-on of firefox and now if we search "tab-pane active" it shows it only once :)
76 2014-02-15T21:03:48 <RogerHaase> skathpalia: OK, tested again and works fine. I added a note to CR about tab spaces; fix and ask tw for review
77 2014-02-15T21:07:59 <skathpalia> ThomasWaldmann, I made some changes regarding the bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/408/basic-theme-missing-subscription-tab . You can review it here https://codereview.appspot.com/64370043
78 2014-02-15T21:13:37 *** penguinRaider
79 2014-02-15T21:13:39 *** penguinRaider_
80 2014-02-15T21:26:56 <RogerHaase> skathpalia: you fixed spacing on 1 line, it is needed 159-162
81 2014-02-15T21:27:35 <skathpalia> Ok doing that :)
82 2014-02-15T21:29:34 <skathpalia> RogerHaase, done :)
83 2014-02-15T21:35:05 <RogerHaase> skathpalia: :) see "set options on your favorite editor..." here https://moin-20.readthedocs.org/en/latest/devel/development.html#add-more-tools-exercise-tools
84 2014-02-15T21:48:05 *** skathpalia
85 2014-02-15T21:48:19 <ajitesh> RogerHaase, Fixed the toggle and more buttons in the index page.. code review needed : https://codereview.appspot.com/64160043/
86 2014-02-15T21:58:29 *** derdon
87 2014-02-15T22:05:23 <RogerHaase> ajitesh: looks OK, ask tw for review
88 2014-02-15T22:05:33 <RogerHaase> gtg
89 2014-02-15T22:05:37 *** RogerHaase
90 2014-02-15T22:08:50 <ajitesh> ThomasWaldmann, code review needed : https://codereview.appspot.com/64160043/
91 2014-02-15T22:09:13 <ajitesh> w.r.t. https://bitbucket.org/thomaswaldmann/moin-2.0/issue/403/select-all-and-action-links-not-working-in
92 2014-02-15T22:18:31 <ThomasWaldmann> ree
93 2014-02-15T22:24:46 *** derdon
94 2014-02-15T22:25:21 <ajitesh> ThomasWaldmann, what does ree mean ??
95 2014-02-15T22:25:27 <ajitesh> :|
96 2014-02-15T22:25:39 <ThomasWaldmann> re means re-enter. reeeee is reenter after a long time. :D
97 2014-02-15T22:28:05 <ThomasWaldmann> ajitesh: why .get(0)?
98 2014-02-15T22:28:26 <ThomasWaldmann> and why do you do == true?
99 2014-02-15T22:31:18 <ajitesh> ThomasWaldmann, .get(0) because it gives me the native dom object and any changes i do on it will be reflected on the html page
100 2014-02-15T22:32:05 <ajitesh> whereas getAttribute retrieves a jquery object and its chages do not reflect in the html page
101 2014-02-15T22:34:07 <ajitesh> '==' behaves identical to '===', only differing in the fact that '===' does not do any type conversion
102 2014-02-15T22:40:58 <ajitesh> http://stackoverflow.com/questions/3334935/checked-true-not-working-with-jquery-function
103 2014-02-15T22:46:35 <ThomasWaldmann> i don't remember ever seeing .get(0) before...
104 2014-02-15T22:47:57 <ThomasWaldmann> $('#checkone').attr('checked', true); isn't that the cleaner way?
105 2014-02-15T22:51:45 <ajitesh> ThomasWaldmann, yes it is.. but when i use that, the html element inspection tool shows that the checked attribute is being set to true while it does not actually reflect on the visible html
106 2014-02-15T22:52:41 <ajitesh> as in there is no visible tick mark in any of the checkboxes on toggling the second time
107 2014-02-15T22:58:52 <ajitesh> ThomasWaldmann, i'll change the '==' to '==='
108 2014-02-15T23:00:00 <ThomasWaldmann> https://stackoverflow.com/questions/901712/check-checkbox-checked-property-using-jquery
109 2014-02-15T23:00:05 <ThomasWaldmann> maybe that? ^^
110 2014-02-15T23:00:18 <ThomasWaldmann> and my point is not == vs ===, read my comment again
111 2014-02-15T23:00:24 <ThomasWaldmann> on CR
112 2014-02-15T23:16:09 <ajitesh> ThomasWaldmann, ohh yeah there is no need to check equality..
113 2014-02-15T23:17:13 <ajitesh> but if i use "toggle(this.checked)" it just makes the checkbox invisible and hence unusable individually..
114 2014-02-15T23:19:27 <ThomasWaldmann> ok, i suggest you please read the jquery docs about this
115 2014-02-15T23:19:42 <ThomasWaldmann> (hopefully the correct way is documented there)
116 2014-02-15T23:20:02 <ThomasWaldmann> try also .toggle()
117 2014-02-15T23:26:10 <ThomasWaldmann> stackoverflow is not always the best way to solve.
118 2014-02-15T23:26:43 <ThomasWaldmann> sometimes there is a completely stupid (but seemingly "correct") answer with high votes
119 2014-02-15T23:27:09 <ThomasWaldmann> ajitesh: you know jsfiddle.net?
120 2014-02-15T23:27:22 <ajitesh> yes
121 2014-02-15T23:38:59 <ThomasWaldmann> .prop('checked', true) sets the checkmark
122 2014-02-15T23:41:35 <ajitesh> yep just saw that on the documentation page
123 2014-02-15T23:44:01 <ajitesh> ThomasWaldmann, code review needed https://codereview.appspot.com/64160043/
124 2014-02-15T23:48:08 <ThomasWaldmann> why attr and prop?
125 2014-02-15T23:48:34 * ThomasWaldmann somehow misses the usual jquery elegance here
126 2014-02-15T23:54:51 <ajitesh> ThomasWaldmann, i played around with it.. using only using .prop() does not set the "checked" attribute in the DOM.. its just affects the tick marks..
127 2014-02-15T23:58:22 <ajitesh> ok.. this is interesting..
128 2014-02-15T23:59:01 <ajitesh> if i only use .prop() to check and toggle between true and false, it acts as required
