1 2014-02-13T02:11:25 *** dimazest_
2 2014-02-13T02:14:41 *** vpv_
3 2014-02-13T02:15:42 *** eSyr
4 2014-02-13T02:15:42 *** dimazest
5 2014-02-13T02:15:56 *** eSyr
6 2014-02-13T02:19:07 *** sudo_dirk
7 2014-02-13T02:19:07 *** vpv
8 2014-02-13T02:19:33 *** sudo_dirk
9 2014-02-13T02:20:50 *** dimazest
10 2014-02-13T02:22:29 *** dimazest_
11 2014-02-13T02:29:28 *** vpv_
12 2014-02-13T02:29:41 *** vpv
13 2014-02-13T02:33:36 *** eSyr
14 2014-02-13T02:38:18 *** eSyr
15 2014-02-13T02:47:47 *** eSyr_
16 2014-02-13T02:48:47 *** eSyr
17 2014-02-13T05:00:38 *** penguinRaider
18 2014-02-13T05:55:15 *** penguinRaider
19 2014-02-13T07:57:47 *** penguinRaider
20 2014-02-13T08:17:54 *** skathpalia
21 2014-02-13T08:22:16 *** ronny
22 2014-02-13T08:31:20 *** skathpalia
23 2014-02-13T08:40:54 <dreimark> in 1.9 I see two heads ?
24 2014-02-13T08:40:58 <dreimark> moin
25 2014-02-13T09:04:12 *** greg_f
26 2014-02-13T09:57:25 *** ronny
27 2014-02-13T10:20:44 *** dimazest
28 2014-02-13T10:20:58 *** dimazest
29 2014-02-13T11:06:47 *** skathpalia
30 2014-02-13T12:17:53 *** ajitesh
31 2014-02-13T12:29:27 <ajitesh> ThomasWaldmann, I have fixed the broken links in the index page in the basic theme and have made it look better.. how should i show it to you ? as in most of the changes are there in the css so should i send you a screenshot along with the codereview or something like that ?
32 2014-02-13T13:01:05 *** skathpalia
33 2014-02-13T13:02:17 <ajitesh> ^ with regard to issue #403
34 2014-02-13T13:02:40 <ajitesh> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/403/select-all-and-action-links-not-working-in
35 2014-02-13T13:08:31 *** derdon
36 2014-02-13T13:42:49 *** RogerHaase
37 2014-02-13T14:07:33 <ajitesh> RogerHaase, Is it ok for me to mark an issue as resolved once my pull request is merged.. ?
38 2014-02-13T14:11:04 <RogerHaase> ajitesh: yes, close issue after it is added to main repo. add the date and the commit #
39 2014-02-13T14:12:19 <penguinRaider> Hi ThomasWaldmann RogerHaase I filed a bug regarding assertion error while reverting deleted file. Can you please try to reproduce it ? https://bitbucket.org/thomaswaldmann/moin-2.0/issue/407/assertion-error-when-reverting-a-deleted
40 2014-02-13T14:13:35 <RogerHaase> ajitesh: also close out any open code reviews
41 2014-02-13T14:21:18 <RogerHaase> penguinRaider: yes, can reproduce
42 2014-02-13T14:22:51 <penguinRaider> RogerHaase, Also I am still working on #404 everything goes fine with all the themes till apps/frontend/views.py Infact both have same value till there, problem starts when the templates get called for the respective themes somewhere in foobar theme context there is a fqname variable missing
43 2014-02-13T14:23:26 <penguinRaider> RogerHaase, Even with #407 there is a problem of fqname missing somewhere in the meta from what I have gathered till now
44 2014-02-13T14:24:10 <RogerHaase> penguinRaider: you will become a fqname specialist :-D
45 2014-02-13T14:26:46 <penguinRaider> RogerHaase, Yeah this is one nasty thing that keeps popping in all my bugs :-) I am kind of stuck with #404 as of now trying to proceed somehow
46 2014-02-13T14:28:14 <RogerHaase> penguinRaider: will take a look at 404 later today if I get some time
47 2014-02-13T14:29:29 <penguinRaider> RogerHaase, Thanks alot :-)
48 2014-02-13T14:57:12 *** derdon
49 2014-02-13T15:15:01 <ajitesh> RogerHaase, Ok :) ... I made some changes to the index page GUI in the basic theme and fixed non functional links.. how should i show the changes.. as in most of the change in code is in css files..
50 2014-02-13T15:19:01 <RogerHaase> ajitesh: do code review to start
51 2014-02-13T15:36:35 *** skathpalia
52 2014-02-13T15:46:30 <ajitesh> RogerHaase, code review : https://codereview.appspot.com/62920045/
53 2014-02-13T15:54:13 *** eSyr_
54 2014-02-13T15:54:41 *** eSyr
55 2014-02-13T16:05:45 <RogerHaase> ajitesh: are you doin a lot more than solving what is describe in 403?
56 2014-02-13T16:05:56 <RogerHaase> doin/doing
57 2014-02-13T16:08:02 *** eSyr
58 2014-02-13T16:08:03 <ajitesh> RogerHaase, Yes in a way.. 403 only describes errors and broken links.. I improved the GUI too.. should i propose that in a separate issue ??
59 2014-02-13T16:08:09 *** eSyr
60 2014-02-13T16:13:54 <RogerHaase> ajitesh: Yes, in general, patches should cover one issue (but you will find "scope creep" here and there). Before you create new issues on basic theme, look here: https://bitbucket.org/sharky93/moin-2.0-bootstrap/issues?status=new&status=open
61 2014-02-13T16:14:54 <RogerHaase> ajitesh: I think sharky93 is working on a script to copy those issues to main repo
62 2014-02-13T16:18:09 *** dave_largo
63 2014-02-13T16:26:24 <skathpalia> RogerHaase, I discussed with ThomasWaldmann regarding improvement in the css of all the tables in basic theme and also the in the user tab in item sizes I added the sorting like if we click on size or item name then it gets sorted according to that
64 2014-02-13T16:26:42 <skathpalia> I used a plugin to do sorting thing
65 2014-02-13T16:27:04 <ajitesh> RogerHaase, Yes i guess issue #47 in that list concerns to what i did in the GUI..
66 2014-02-13T16:27:12 <ajitesh> https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/47/remake-the-global-index-view-local-index
67 2014-02-13T16:27:29 <skathpalia> I have made changes regarding that here https://codereview.appspot.com/63290043. You can review it :)
68 2014-02-13T16:27:45 <skathpalia> This was a proposal by me :)
69 2014-02-13T16:28:33 <RogerHaase> ajitesh: did you read the top of MoinMoin/themes/foobar/static/css/common.css? For foobar and modernized CSS, you must install Stylus (see https://moin-20.readthedocs.org/en/latest/devel/development.html?highlight=stylus#add-more-tools-exercise-tools), then change the stylus .sty files and run stylus to compile the CSS.
70 2014-02-13T16:30:16 <RogerHaase> ajitesh: I guess there is a similar process for the basic theme CSS using Less. afaik, there is no docs on how to do that.
71 2014-02-13T16:35:25 <ajitesh> Ohkk.. will do that.. but i see basic.css contains definitions for elements not defined in the basic.less
72 2014-02-13T16:39:52 <RogerHaase> sharky93: assuming we must somehow compile the basic theme CSS from the less files, are there any docs on how to do that?
73 2014-02-13T16:41:46 <RogerHaase> ajitesh: There is probably some bootstrap magic that automatically adds CSS
74 2014-02-13T16:44:43 <RogerHaase> I don't think there is any bootstrap software to install like there is for Stylus, it is already in the virtualenv under xstatic/pkg/bootstrap.
75 2014-02-13T16:46:10 <RogerHaase> skathpalia: did you also discuss choice of jquery utility with tw?
76 2014-02-13T16:53:07 <skathpalia> No I just discussed the idea with him and he was interested in it :)
77 2014-02-13T16:54:46 *** dave_largo
78 2014-02-13T16:57:58 *** derdon
79 2014-02-13T17:02:57 <RogerHaase> Guest65967: you built an xstatic DataTables package last summer, what is status?
80 2014-02-13T17:04:34 <skathpalia> RogerHaase, Is there any constraint regarding the usage of jquery utility or we can use any one??
81 2014-02-13T17:10:52 <RogerHaase> skathpalia: there was some discussion and work on jquery DataTables last GSOC, trying to find out what happened. If we have already chosen a jquery sorting package, we should use the same one. xiaq built https://pypi.python.org/pypi/XStatic-DataTables, but it is not in the <venv>...xstatic/pkg.
82 2014-02-13T17:16:56 <RogerHaase> skathpalia: see setup.py line 80+. Usually we want jquery packages to be installed by setup so if there are bug fixes and enhancements the newer packages will be installed
83 2014-02-13T17:21:47 <skathpalia> Ok I will try to use the package which is already installed :)
84 2014-02-13T17:23:18 <RogerHaase> skathpalia: not yet, the problem is DataTables is not installed
85 2014-02-13T17:24:19 <skathpalia> So I have to first add it to setup.py and then work on it ??
86 2014-02-13T17:26:16 <RogerHaase> there are several jquery sorting packages. We first have to learn if we have already decided on one, else we need to decide which one we want.
87 2014-02-13T17:27:03 <RogerHaase> ThomasWaldmann: do you know what happened to jquery DataTables ^ ?
88 2014-02-13T17:36:11 *** ajitesh
89 2014-02-13T17:36:39 *** ajitesh
90 2014-02-13T17:37:14 <RogerHaase> skathpalia: see here line 10: https://github.com/joequery/Stupid-Table-Plugin/blob/master/LICENSE. If you use someone's software, you must check copy right and license for restrictions
91 2014-02-13T17:41:04 <skathpalia> Oh I was not aware of that license thing
92 2014-02-13T17:41:16 <skathpalia> Thanks RogerHaase for pointing that :)
93 2014-02-13T17:43:24 <skathpalia> So should I use this plugin after adding this copyright thing or there is some other plugin which is already used by moin??
94 2014-02-13T17:53:12 <skathpalia> RogerHaase, Oh I didn't see what you asked ThomasWaldmann regarding the plugin Ok then I will wait for his reply then accordingly use that plugin :)
95 2014-02-13T17:58:01 <RogerHaase> skathpalia: added comments to cr, yeas, we have to wait for others. Have you installed Stylus (+nodejs)?
96 2014-02-13T18:00:58 <skathpalia> No I haven't installed Stylus
97 2014-02-13T18:35:39 <RogerHaase> skathpalia: ThomasWaldmann: Guest65967: found where xiaq gave up on DataTables http://moinmo.in/MoinMoinChat/Logs/moin-dev/2013-08-01?highlight=%28datatable%29, packaged Motties Tablesorter https://pypi.python.org/pypi/XStatic-Tablesorter-Mottie, and created CR https://codereview.appspot.com/12229043/
98 2014-02-13T18:53:00 <RogerHaase> skathpalia: while we are waiting for others, you could try pulling the relevant code from https://codereview.appspot.com/12229043/ and redo your patch.
99 2014-02-13T18:56:56 <skathpalia> Ok I will try :)
100 2014-02-13T19:06:24 *** ajitesh
101 2014-02-13T19:19:36 <skathpalia> RogerHaase, I have a proposal of an enhancement that while running ./m run command port number on which the server should run should be entered while running this command
102 2014-02-13T19:20:09 <skathpalia> because sometimes the port is busy so we are unable to run the server until 8080 port becomes free
103 2014-02-13T19:21:02 <skathpalia> we can ask the user for a port number and if he does not specify any port number then the server runs on default port number 8080
104 2014-02-13T19:22:02 <skathpalia> does it seem interesting to you?
105 2014-02-13T19:28:40 *** ajitesh
106 2014-02-13T19:32:20 <RogerHaase> skathpalia: you can do "./m run --port 8088" now
107 2014-02-13T19:32:55 <RogerHaase> ... where 8088 is any port number
108 2014-02-13T19:44:17 <RogerHaase> skathpalia: I have short memory: I also looked at DataTable plugin and ended up using Motties table sorter with my moin 1.9 theme http://moinmo.in/ThemeMarket/FixedLeft#Sortable_Tables
109 2014-02-13T19:54:49 <skathpalia> RogerHaase, Are you talking about markup tables??
110 2014-02-13T19:56:29 <skathpalia> Actually I am talking of the tables which are used in moin to display things for example for displaying interwiki names a table is used and at many other places the table of same class(zebra) is used.
111 2014-02-13T20:03:05 <RogerHaase> skathpalia: no, I was just talking of sorting data tables
112 2014-02-13T20:06:04 <skathpalia> So you are saying that sorting should be done using the above mentioned Sortable Tables and the rest of the changed css remain as it is?
113 2014-02-13T20:06:35 <RogerHaase> skathpalia: I don't see where the alt class is used in CSS
114 2014-02-13T20:07:05 <RogerHaase> skathpalia: you probably should have 2 changesets, one to do the zebra, and the other to do the table sorting
115 2014-02-13T20:09:40 <skathpalia> Oh I used used for having alternate colors but afterwards I found that it can be done without adding any new class Sorry forgot to remove it :)
116 2014-02-13T20:10:19 <skathpalia> Ok I will do it int two changesets one for css part and the other for jquery part :)
117 2014-02-13T20:12:04 <RogerHaase> I think the zebra stripes should be added to the custom-less/basic.less file, and we are waiting for sharky93 to tell us how to compile that (or find a way...)
118 2014-02-13T20:12:29 <ajitesh> RogerHaase, its already there in the documentation
119 2014-02-13T20:12:58 <ajitesh> http://moin-20.readthedocs.org/en/latest/devel/development.html?highlight=stylus#templates-and-themes
120 2014-02-13T20:14:04 <RogerHaase> ajitesh: ahhh, thanks!
121 2014-02-13T20:15:12 <ThomasWaldmann> moin
122 2014-02-13T20:16:01 *** penguinRaider
123 2014-02-13T20:16:05 <ajitesh> while compiling i realized that basic.less imports bootstrap.less which isn't present in the directory.. i downloaded the bootstrap source and it turns out that bootstrap.less itself imports from a bunch of other less files.. so should i add all of them to the custom-less folder in the basic theme ?
124 2014-02-13T20:16:11 <ajitesh> RogerHaase, ^
125 2014-02-13T20:17:00 <ajitesh> moin
126 2014-02-13T20:18:09 <ThomasWaldmann> ajitesh: you read the docs (of moin2)?
127 2014-02-13T20:18:51 <ThomasWaldmann> how to get the bs stuff working SHOULD be there. if not, bump sharky93.
128 2014-02-13T20:22:04 <RogerHaase> ThomasWaldmann: we have mentioned sharky93 once or twice ^^
129 2014-02-13T20:24:00 <RogerHaase> ajitesh: hmmm, I think there are version issues involved, so we need the right one I would expect to find bootstrap related files in site-packages/xstatic/pkg/bootstrap/ but do not see any .less files
130 2014-02-13T20:25:37 <ThomasWaldmann> the bs files were in sharky's repo, but we removed them from there.
131 2014-02-13T20:26:07 <ThomasWaldmann> the replacement for now is the docs he has written about the procedure and the required bs version.
132 2014-02-13T20:26:26 <ajitesh> RogerHaase, yes i see there is something there in the docs.. its said that we manually have to download and compile the bootstrap.. but i wonder why we have to remove it everytime..
133 2014-02-13T20:26:54 <ThomasWaldmann> it's a separate project and doesn't belong into our repo
134 2014-02-13T20:27:09 <ajitesh> ok..
135 2014-02-13T20:27:42 <ThomasWaldmann> at some time, i'll make a xstatic package
136 2014-02-13T20:29:16 <RogerHaase> there is one, so you are saing the .less files will be added there? https://pypi.python.org/pypi/XStatic-Bootstrap/2.1.0.1
137 2014-02-13T20:29:29 <RogerHaase> saing/saying
138 2014-02-13T20:30:34 <ThomasWaldmann> there's also https://pypi.python.org/pypi/XStatic-Bootstrap/3.0.0.2
139 2014-02-13T20:31:04 <ThomasWaldmann> and I'm not sure about the .less files. that's stuff only for developers, right?
140 2014-02-13T20:33:51 <skathpalia> RogerHaase, Should I make the desired changes in the basic.less and then send for review?
141 2014-02-13T20:35:10 <RogerHaase> yes, but in virtual env there are other things things that are likely only for developers - setuptools, sphinx
142 2014-02-13T20:35:33 <RogerHaase> skathpalia: give it a try
143 2014-02-13T20:35:39 <skathpalia> OK
144 2014-02-13T20:37:08 <ThomasWaldmann> sharky93: just wondering about the bs version
145 2014-02-13T20:37:38 <ThomasWaldmann> you said you used some beta or rc, but I've just seen that on pypi the static package is version 3.0.0
146 2014-02-13T20:38:17 <ThomasWaldmann> (of course the stuff should be carefully upgraded to 3.1.x now)
147 2014-02-13T20:39:04 <RogerHaase> ThomasWaldmann: earlier we were discussing DataTables http://moinmo.in/MoinMoinChat/Logs/moin-dev/2013-08-01?highlight=%28datatable%29, packaged Motties Tablesorter https://pypi.python.org/pypi/XStatic-Tablesorter-Mottie, and created CR https://codereview.appspot.com/12229043/ --- was there a decision about a table sorter plugin?
148 2014-02-13T20:40:00 <RogerHaase> discussing/discussing xiaq's work on
149 2014-02-13T20:40:33 <ThomasWaldmann> don't remember details, guess there were some
150 2014-02-13T20:40:52 <skathpalia> RogerHaase, I have added the css for the tables you can review it here https://codereview.appspot.com/63290043
151 2014-02-13T20:42:59 <ThomasWaldmann> i see *.css.map files in the 3.1.1 download
152 2014-02-13T20:43:05 <ThomasWaldmann> any idea what that is?
153 2014-02-13T20:44:36 <RogerHaase> skathpalia: you have to compile the .less files to get the changes into the respective css file and show that all as one changeset
154 2014-02-13T20:46:46 <skathpalia> Ok
155 2014-02-13T20:47:02 * ThomasWaldmann updates package to 3.1.1
156 2014-02-13T20:51:39 *** penguinRaider
157 2014-02-13T20:54:37 <ajitesh> RogerHaase, even on copying bs files.. i get an error on compile regarding an undefined variable.. i'll look into it..
158 2014-02-13T20:55:16 <ThomasWaldmann> https://stackoverflow.com/questions/21504611/what-are-the-map-files-used-for-in-bootstrap-3-1
159 2014-02-13T21:08:28 <ThomasWaldmann> Submitting dist/XStatic-Bootstrap-3.1.1.1.tar.gz to http://pypi.python.org/pypi
160 2014-02-13T21:09:04 *** derdon_
161 2014-02-13T21:09:26 *** derdon
162 2014-02-13T21:10:38 *** derdon_
163 2014-02-13T21:22:04 <skathpalia> RogerHaase, I am also getting the same error as ajitesh
164 2014-02-13T21:24:20 <skathpalia> ThomasWaldmann, have you reviewed this https://codereview.appspot.com/61650043 which is a fix to the bug https://bitbucket.org/thomaswaldmann/moin-2.0/issue/400/creation-of-new-default-wiki-html-item
165 2014-02-13T21:26:11 <ajitesh> RogerHaase, solved the issue.. but i see there are a huge number of changes in my diff due to bs 3.0.0 ---> 3.1.1.. should i stick to them or use bs 3.0.0 files ?
166 2014-02-13T21:26:19 <ajitesh> ThomasWaldmann, ^
167 2014-02-13T21:30:27 <RogerHaase> we appear to have a bootstrap traffic jam... the 3.1.1 changes should be done as a separate commit.. by ?
168 2014-02-13T21:32:08 <ajitesh> RogerHaase, i can do it if u want :)
169 2014-02-13T21:34:54 *** Varaug994
170 2014-02-13T21:35:06 <RogerHaase> ajitesh: try, tw may be working on it as well. Can you tell if the boostrap changes made the basic theme even more broken?
171 2014-02-13T21:38:34 <ajitesh> RogerHaase, i do see a disoriented search box.. but other than that everything looks fine.. i'll check on the search box..
172 2014-02-13T21:44:31 *** Varaug994
173 2014-02-13T21:44:54 <ajitesh> but thats my fault i guess ^
174 2014-02-13T21:45:50 *** Varaug1994
175 2014-02-13T21:50:34 <Varaug1994> SETNAME Gaurav
176 2014-02-13T22:10:19 <penguinRaider> ThomasWaldmann, RogerHaase tried solving issue #407 http://codereview.appspot.com/63500043 please review also this bug caused modification to fail too solved that too https://bitbucket.org/thomaswaldmann/moin-2.0/issue/407/assertion-error-when-reverting-a-deleted
177 2014-02-13T22:19:46 *** Varaug1994
178 2014-02-13T22:20:54 <RogerHaase> penguinRaider: I would suggest adding a comment in the code re. what is fixing revert from trash and what is fixing modify. I assume you ran tests with no new failures. Otherwise, I can add no help.
179 2014-02-13T22:22:07 <RogerHaase> penguinRaider: started looking at 404, so far only found new bug 408
180 2014-02-13T22:27:08 <penguinRaider> RogerHaase, py.test none failed I will comment the code on code review
181 2014-02-13T22:42:10 <penguinRaider> RogerHaase, i added some comments, https://codereview.appspot.com/63500043/diff/1/MoinMoin/items/__init__.py
182 2014-02-13T22:42:36 <penguinRaider> tell me if you don't understand anything.
183 2014-02-13T22:52:20 <skathpalia> ThomasWaldmann, I have made required changes in my new patch . You can review it here https://codereview.appspot.com/61650043/
184 2014-02-13T22:55:07 <RogerHaase> penguinRaider: those are good, but moin suffers from lack of comments in the code. Please add some to the code and ask tw for review
185 2014-02-13T22:58:33 <penguinRaider> RogerHaase, I was going through the tests seems like there are good tests to check fqname compatibility so some work can be done on it too
186 2014-02-13T22:59:01 <penguinRaider> s/good tests/no good tests
187 2014-02-13T22:59:07 <RogerHaase> great, always good to improve the tests
188 2014-02-13T23:01:25 <penguinRaider> RogerHaase, when are you guys targeting to release moin 2.0 ?
189 2014-02-13T23:01:46 <ajitesh> RogerHaase, bs 3.1.1 causes alignment and spacing disturbances in the basic theme i guess..
190 2014-02-13T23:02:36 <RogerHaase> penguinRaider: I think only answer is when it is ready...
191 2014-02-13T23:05:13 *** skathpalia
192 2014-02-13T23:06:00 <RogerHaase> ajitesh: if the problems are not too bad, I guess I would push vanilla 3.1.1 and then another changeset to do fixups, but ThomasWaldmann rules...
193 2014-02-13T23:08:32 <ajitesh> ok :)
194 2014-02-13T23:08:34 <RogerHaase> gtg
195 2014-02-13T23:08:40 *** RogerHaase
196 2014-02-13T23:16:36 <penguinRaider> ThomasWaldmann, I got the #407 https://codereview.appspot.com/63500043/ reviewed by RogerHaase. He asked me to comment the code too. Can you please review https://bitbucket.org/thomaswaldmann/moin-2.0/issue/407/assertion-error-when-reverting-a-deleted
197 2014-02-13T23:51:19 <ThomasWaldmann> penguinRaider: looking at it now
