1 2014-02-09T00:01:14 <ananasova> ThomasWaldmann: indeed. must have checked the issues page and set the issue 'in progress'
2 2014-02-09T00:01:33 <ananasova> anyway, the solution is all the same
3 2014-02-09T00:02:21 <ThomasWaldmann> slightly offtopic, but maybe someone of you has an idea
4 2014-02-09T00:02:42 <ananasova> but the question is whether we want to get back to lists - I mean changing the API in such way that is_subscribed_to accepts a list of fqnames
5 2014-02-09T00:02:53 <ThomasWaldmann> assume you have a encrypted file on a http server (could be small or large file)
6 2014-02-09T00:03:25 <ThomasWaldmann> you want to download AND decrypt it using a browser and either display it in browser or save it to disk
7 2014-02-09T00:03:51 <ThomasWaldmann> ananasova: fqnames sounds preferable
8 2014-02-09T00:06:11 <ananasova> ThomasWaldmann: what is going to be the workflow? pull the current changes to fix the bug and then change the api OR apply the changes with fqnames and pull it alltogether with the bugfix?
9 2014-02-09T00:07:26 <ThomasWaldmann> i can pull the fix first, so it stops crashing
10 2014-02-09T00:08:51 <ananasova> we need to tell kumar to make a pr. it's a pity if his effort would be wasted :)
11 2014-02-09T00:09:27 <ananasova> then i can do the rest. shall i create a issue on bb for that?
12 2014-02-09T00:10:08 <ThomasWaldmann> yes, please
13 2014-02-09T00:15:41 <sharky93> ajitesh: ngrams, facetting, autocompletion and spellchecking are DONE pretty much.
14 2014-02-09T00:15:46 <sharky93> ThomasWaldmann: sure, will have a look.
15 2014-02-09T00:16:13 <sharky93> those things were a part of the first part of my last year SoC's yet to be merged work
16 2014-02-09T00:16:20 <ThomasWaldmann> sharky93: ok, update the page to your best knowledge then
17 2014-02-09T00:16:41 <ThomasWaldmann> sharky93: it is merged
18 2014-02-09T00:16:57 <sharky93> oh :D
19 2014-02-09T00:17:01 <sharky93> i didnt know that :)
20 2014-02-09T00:17:06 <ThomasWaldmann> try it
21 2014-02-09T00:18:18 <sharky93> that JS lint merge, did that hurt? :)
22 2014-02-09T00:18:55 <sharky93> moves the whole js around. ah, should add that to docs.
23 2014-02-09T00:21:51 <ThomasWaldmann> i didn't notice "js lint" merge issues
24 2014-02-09T00:22:16 <ThomasWaldmann> but there were some other conflicts i had to resolve and it wasn't always very clear.
25 2014-02-09T00:23:28 <sharky93> hmm, i think i had read on the channel, you mentioned about something unclear in the commit message
26 2014-02-09T00:23:40 <sharky93> sorry for the troubles :)
27 2014-02-09T00:23:44 * sharky93 still learning
28 2014-02-09T00:24:09 * sharky93 pulling code
29 2014-02-09T00:33:36 <ananasova> please correct me if i am wrong - an item can have more than one fqname, due to the fact that an item can have multiple names, but it is impossible to have a collision of fqnames on a wiki
30 2014-02-09T00:38:19 <ananasova> is the new method for checking subscription supposed to return a bool?
31 2014-02-09T00:39:45 <ananasova> for example we have a list of 3 fqnames and the user is subscribed to 2 of them, but not to the other 3rd, then it returns False?
32 2014-02-09T00:41:19 <ThomasWaldmann> yes, names are unique per namespace
33 2014-02-09T00:42:22 <ThomasWaldmann> and a fqname is just (field, fieldcontent)
34 2014-02-09T00:43:20 <ThomasWaldmann> how was it in old code?
35 2014-02-09T00:43:21 <ananasova> ah yes, I see - it is a compound name
36 2014-02-09T00:43:32 <ananasova> just a list of names
37 2014-02-09T00:43:59 <ThomasWaldmann> i mean return type and semantics
38 2014-02-09T00:47:51 <ananasova> here: https://bitbucket.org/thomaswaldmann/moin-2.0/src/78b7a11369847325efc1ef7c85bce28d0a9e50a5/MoinMoin/user.py?at=default#cl-496
39 2014-02-09T00:49:44 <ananasova> returns book, checks if the user is subscribed to any page from the list of pages
40 2014-02-09T00:50:15 <ananasova> bool*
41 2014-02-09T01:06:05 <sharky93> so .. http://localhost:8080/ returns all sorts of KeyErrors but http://127.0.0.1:8080 works
42 2014-02-09T01:12:11 <ananasova> sharky93: i don't get any errors :)
43 2014-02-09T01:12:55 <sharky93> weird
44 2014-02-09T01:13:32 <sharky93> ananasova: running the latest code?
45 2014-02-09T01:15:07 <ananasova> yes, i have noticed your fork pulled earlier :P
46 2014-02-09T01:52:48 <sharky93> :D
47 2014-02-09T02:18:11 *** sudo_dirk
48 2014-02-09T02:18:49 *** sudo_dirk
49 2014-02-09T05:16:11 *** skathpalia
50 2014-02-09T05:17:59 *** skathpalia
51 2014-02-09T05:18:43 <skathpalia> So I am thinking of making a table using some css with displaying of the items and their sizes in(KB or MB as per the size of the item)
52 2014-02-09T05:20:05 <skathpalia> Also clicking on the size or item name would sort it according to their respective values
53 2014-02-09T05:20:57 <skathpalia> Should I add it as a proposal in your repository ?
54 2014-02-09T05:31:20 <skathpalia> ThomasWaldmann, I have a proposal regarding the ui of the item sizes under user tab size does not display units and also the display is too congested
55 2014-02-09T05:31:36 <skathpalia> my proposal ^
56 2014-02-09T05:45:22 *** skathpalia
57 2014-02-09T06:36:13 *** skathpalia
58 2014-02-09T06:58:57 *** skathpalia
59 2014-02-09T08:20:52 *** skathpalia
60 2014-02-09T10:52:30 *** greg_f
61 2014-02-09T11:11:20 <ananasova> moin
62 2014-02-09T11:34:57 *** derdon
63 2014-02-09T11:41:47 *** derdon
64 2014-02-09T11:46:08 *** derdon
65 2014-02-09T12:31:55 <ananasova> ThomasWaldmann: can you please add acl to this page https://moinmo.in/AnaBalica/GSOC-2014-Application ?
66 2014-02-09T12:41:57 <ThomasWaldmann> ok
67 2014-02-09T12:47:15 <ananasova> thank you :)
68 2014-02-09T13:03:51 <ThomasWaldmann> skathpalia: sounds good. maybe think about making it in a way that is reusable.
69 2014-02-09T13:30:08 <skathpalia> Yeah I will try to do that
70 2014-02-09T13:33:59 <skathpalia> ThomasWaldmann, It can be made reusable in this way : I will define the css and js in some other file and then that css and js can be imported in any other file by using some unique id or class and in thsi way all the tables can be changed easily even in future
71 2014-02-09T14:04:09 <ThomasWaldmann> please try to avoid any js or css hacks (or keep them at minimum really needed)
72 2014-02-09T14:04:21 <ThomasWaldmann> we have bootstrap, which offers a lot of nice css
73 2014-02-09T14:04:35 <ThomasWaldmann> there's jquery also
74 2014-02-09T14:04:52 <ThomasWaldmann> skathpalia: you are talking about "basic" theme, right?
75 2014-02-09T14:13:39 <skathpalia> No I was talking of the bootstrap theme only
76 2014-02-09T14:14:19 <skathpalia> Ok then I will try to use the table css which is provided by bootstrap
77 2014-02-09T14:14:40 <skathpalia> avoiding any extra css or js
78 2014-02-09T14:23:42 *** RogerHaase
79 2014-02-09T14:45:39 *** derdon
80 2014-02-09T14:46:25 * ThomasWaldmann posted to moin-user ML about GSOC 2014 mentors and helpers needed
81 2014-02-09T15:03:47 * ThomasWaldmann also linked it from tweet and g+ post
82 2014-02-09T15:06:41 <ThomasWaldmann> http://sourceforge.net/mailarchive/message.php?msg_id=31952992
83 2014-02-09T15:07:14 *** nitinagarwal3006
84 2014-02-09T15:07:26 <nitinagarwal3006> Hello Everyone
85 2014-02-09T15:07:33 <nitinagarwal3006> ThomasWaldmann: Hi
86 2014-02-09T15:07:59 <ThomasWaldmann> hi nitinagarwal3006
87 2014-02-09T15:08:08 <nitinagarwal3006> I would like to discuss about the Gsoc Project Ideas
88 2014-02-09T15:09:00 <ThomasWaldmann> sure, ask specific questions :)
89 2014-02-09T15:09:03 <nitinagarwal3006> I'm llooking forward to participate as a student in the upcoming summer of code
90 2014-02-09T15:09:49 <nitinagarwal3006> ThomasWaldmann: ok, will send you a mail
91 2014-02-09T15:10:45 <ThomasWaldmann> you can ask here rather
92 2014-02-09T15:11:09 <ThomasWaldmann> except if it is confidential, then use a query or email
93 2014-02-09T15:11:13 <nitinagarwal3006> I would like to know whether a student can be both a participant as well as mentor or helper
94 2014-02-09T15:11:19 <ThomasWaldmann> for generic stuff, irc is preferred, though
95 2014-02-09T15:11:25 <nitinagarwal3006> ok
96 2014-02-09T15:11:53 <ThomasWaldmann> iirc, you can't be both at same time
97 2014-02-09T15:12:11 <nitinagarwal3006> ok
98 2014-02-09T15:12:12 <nitinagarwal3006> thnaks
99 2014-02-09T15:12:14 <ThomasWaldmann> because that would be a conflict of interests and if only due to available time for both tasks
100 2014-02-09T15:12:26 <nitinagarwal3006> Ok, thanks
101 2014-02-09T15:12:51 <ThomasWaldmann> are you asking because of my ML / twitter / g+ post?
102 2014-02-09T15:13:27 <nitinagarwal3006> yes
103 2014-02-09T15:13:34 <nitinagarwal3006> I saw your post
104 2014-02-09T15:13:45 <ThomasWaldmann> ("helper" is no official role in GSOC btw, so whether you help somewhere or not is not covered by gsoc rules)
105 2014-02-09T15:13:56 <nitinagarwal3006> ok
106 2014-02-09T15:14:09 <ThomasWaldmann> you could also help your parents with gardening :D
107 2014-02-09T15:15:19 <ThomasWaldmann> so "both" above referred to student and (mentor|admin)
108 2014-02-09T15:15:52 <nitinagarwal3006> yes
109 2014-02-09T15:16:06 <ThomasWaldmann> in general, if you want to official version, read the rules from google
110 2014-02-09T15:17:21 <nitinagarwal3006> ok
111 2014-02-09T15:17:40 <ThomasWaldmann> but thanks anyway for considering!
112 2014-02-09T15:18:41 * ThomasWaldmann looks at some pull requests...
113 2014-02-09T15:24:05 <ThomasWaldmann> skathpalia: i can't just pull in your changes as it would pull in 3 changesets
114 2014-02-09T15:24:22 <ThomasWaldmann> docs updated, revert (of that), docs updated
115 2014-02-09T15:25:03 <ThomasWaldmann> so if there are changesets that should not be there, could you clean up first?
116 2014-02-09T15:25:39 <ThomasWaldmann> (e.g. export the good changeset, do a fresh clone from main repo, import changeset)
117 2014-02-09T15:25:56 <ThomasWaldmann> would be cleaner in the end
118 2014-02-09T15:26:47 <ThomasWaldmann> https://bitbucket.org/saurabh_k/moin-2.0/commits/all
119 2014-02-09T15:30:51 <skathpalia> Ok I am doing it :)
120 2014-02-09T15:33:22 <ThomasWaldmann> thanks
121 2014-02-09T15:33:43 <ThomasWaldmann> sharky93: do you remember why the click handler is set even if there are no comments or transclusions?
122 2014-02-09T15:33:54 <ThomasWaldmann> (referring to your PR)
123 2014-02-09T16:19:11 *** dimazest
124 2014-02-09T16:19:56 <dimazest> hello
125 2014-02-09T16:20:08 <ThomasWaldmann> hey dimazest!
126 2014-02-09T16:20:16 <dimazest> long time no see. I've seen you mentoring announcement and would like to help :)
127 2014-02-09T16:20:53 <dimazest> some python, mercurial and testing would be great
128 2014-02-09T16:23:53 <ThomasWaldmann> cool, that's very welcome! :)
129 2014-02-09T16:24:20 <ThomasWaldmann> so, as a informal helper or as mentor?
130 2014-02-09T16:25:06 <dimazest> as a mentor i guess
131 2014-02-09T16:25:15 <dimazest> but being informal would be cool
132 2014-02-09T16:26:14 <ThomasWaldmann> did you read the mailing list post?
133 2014-02-09T16:27:00 <dimazest> yes, and i'm editing the wiki page
134 2014-02-09T16:27:34 <ThomasWaldmann> (primary) mentor means that you'ld be the formal main contact of the student (and would also have to fill out midterm/final eval forms)
135 2014-02-09T16:27:35 <dimazest> i also want to advertise GSOC at my uni, and get some students interested
136 2014-02-09T16:28:08 <dimazest> i see, so the other side of the project
137 2014-02-09T16:28:20 <ThomasWaldmann> in practice (as you may remember), we usually do collab mentoring on irc, so mentoring is not really 1 mentor <-> 1 student
138 2014-02-09T16:28:24 <dimazest> what kind of help regarding testing are you looking for?
139 2014-02-09T16:28:46 <dimazest> yes, i remember that, which is a great way to do mentoring
140 2014-02-09T16:29:28 <dimazest> at work we took testing quite seriously
141 2014-02-09T16:29:36 <dimazest> and used a lot of py.test fixtures
142 2014-02-09T16:29:38 <ThomasWaldmann> about gsoc advertisement: do it soon, students need to get in contact with orgs as soon as possible
143 2014-02-09T16:30:17 <ThomasWaldmann> testing: students will have to write (or change) tests, so there might be some questions about py.test or in general
144 2014-02-09T16:31:24 <ThomasWaldmann> (those questions can often be answered by multiple people, but not everybody is there all the time)
145 2014-02-09T16:32:08 <skathpalia> ThomasWaldmann, I have sent a new pull request :)
146 2014-02-09T16:33:09 <ThomasWaldmann> btw, (iirc) we still have your groups code, but we'll go with whoosh for moin2 (pure python), not xapian
147 2014-02-09T16:33:25 <ThomasWaldmann> skathpalia: thanks, will have a look
148 2014-02-09T16:37:01 <dimazest> whoosh is a cool library
149 2014-02-09T16:37:08 <dimazest> i used it for my thesis
150 2014-02-09T16:37:18 <dimazest> it did the job very nicely
151 2014-02-09T16:38:45 <ThomasWaldmann> ah, great, so you can answer whoosh questions also :D
152 2014-02-09T16:39:07 <ThomasWaldmann> moin2 is now very much whoosh at the core
153 2014-02-09T16:39:31 <ThomasWaldmann> not just for search done from the UI, but also for all internal lookups
154 2014-02-09T16:39:34 <dimazest> haha, if a couple of days experience is enough then yes
155 2014-02-09T16:40:19 <dimazest> i've added myself to the group announcement page and to he potential projects
156 2014-02-09T16:48:46 <ThomasWaldmann> great
157 2014-02-09T16:49:57 <dimazest> ok, i need to go
158 2014-02-09T16:50:26 <dimazest> and potentially use another irc client to avoid annoying "leave" messages
159 2014-02-09T16:51:12 *** dimazest
160 2014-02-09T16:51:20 *** nitinagarwal3006
161 2014-02-09T16:51:53 <ThomasWaldmann> hm
162 2014-02-09T16:53:26 <ThomasWaldmann> skathpalia: merged!
163 2014-02-09T16:53:36 <skathpalia> Thanks :)
164 2014-02-09T16:53:44 <ThomasWaldmann> skathpalia: one additional remark:
165 2014-02-09T16:53:45 <sharky93> ThomasWaldmann: not really, no. dont remember why does it have that.
166 2014-02-09T16:54:30 <ThomasWaldmann> try to be meaningful with the commit comment. "changed docs" is soso, better is to say a bit about what the change was about.
167 2014-02-09T16:55:03 <ThomasWaldmann> sharky93: can you check whether that other change you removed was a fix?
168 2014-02-09T16:55:24 <skathpalia> Sorry for that From next time I will take care of that
169 2014-02-09T16:55:27 <ThomasWaldmann> so your lines should be moved into that "if" block?
170 2014-02-09T16:55:51 <ThomasWaldmann> skathpalia: np :)
171 2014-02-09T16:57:36 <sharky93> ThomasWaldmann: i'm sure the line i removed was not a fix, since the LOC doesn't make sense at all. with the current class/object structure. it was mostly dragged from the code which we had earlier. not sure how.
172 2014-02-09T16:59:09 <ThomasWaldmann> well, there were projects in parallel, so if it doesn't fit into your changes, that is kind of expected
173 2014-02-09T16:59:36 <ThomasWaldmann> the question is if the move of the line into the block was a fix
174 2014-02-09T16:59:53 <ThomasWaldmann> compared to your common base revision
175 2014-02-09T17:00:05 <ThomasWaldmann> (from before gsoc)
176 2014-02-09T17:00:38 <ThomasWaldmann> or, whether your moving it out from the if block was a fix.
177 2014-02-09T17:00:41 * sharky93 looks
178 2014-02-09T17:00:58 <ThomasWaldmann> hg annotate might help
179 2014-02-09T17:01:40 <ThomasWaldmann> looks like it kill either some irc server or some internet connection, dimazest quit a bit suddenly...
180 2014-02-09T17:04:24 <sharky93> annotate / blame :D
181 2014-02-09T17:29:54 *** greg_f
182 2014-02-09T17:40:32 <sharky93> ThomasWaldmann: the line outside the IF statement was added in some changeset of mine while fixing the lint issues.
183 2014-02-09T17:40:53 <sharky93> not sure why its there, but atleast not from some other work. its safe to move it in
184 2014-02-09T18:21:11 *** penguinRaider
185 2014-02-09T18:32:04 <penguinRaider> Hi all , I plan to participate in gsoc this year tried solving #397 but seems like #401 would nullify what I did :-) . So can I know bit more about fqnames ?
186 2014-02-09T18:32:19 <penguinRaider> ananasova, ^
187 2014-02-09T18:33:18 <penguinRaider> ThomasWaldmann, but for now I guess atleast it would save it from crashing :-)
188 2014-02-09T18:38:41 <RogerHaase> penguinRaider: #397 is being worked on by kumar rishabh https://codereview.appspot.com/60490049/. I think anansova also looked at it
189 2014-02-09T18:41:14 <penguinRaider> RogerHaase, I am kumar rishabh :-)
190 2014-02-09T18:41:46 <RogerHaase> :-D
191 2014-02-09T18:44:01 <RogerHaase> penguinRaider: then I think you are rady for a commit, push, and pull request. See here: http://moinmo.in/MoinMoinChat/Logs/moin-dev/2014-02-09#CA-56e2a1363eadd18f3b67f31ab87b429bd7702f09_10
192 2014-02-09T18:44:15 <RogerHaase> rady/ready
193 2014-02-09T18:44:51 <penguinRaider> RogerHaase, Thanks Yeah I just sent one . But then I went through #401 and it seems to change the method I was working on
194 2014-02-09T18:48:06 <RogerHaase> yes, as I understand the discussion on line 11 and 12, ana was going to create an issue and build on top of your fix
195 2014-02-09T18:48:37 <ThomasWaldmann> penguinRaider: hi. nice nick. hope no penguins were harmed. :P
196 2014-02-09T18:49:25 * ThomasWaldmann looks at PR...
197 2014-02-09T18:51:49 <penguinRaider> ThomasWaldmann, I love penguins :-) they are so awesome I can never think of harming one :-P
198 2014-02-09T18:51:59 <penguinRaider> ThomasWaldmann, what are fqnames ?
199 2014-02-09T18:53:42 <ThomasWaldmann> (NAME, "itemname"), (ID, "123456"), (TAG, "software")
200 2014-02-09T18:53:50 <ThomasWaldmann> (FIELD, fieldcontent)
201 2014-02-09T18:54:12 <ThomasWaldmann> as we have whoosh, we can no only lookup by name, but also by other identifiers or fields
202 2014-02-09T18:54:20 <ThomasWaldmann> not*
203 2014-02-09T18:54:52 <ThomasWaldmann> fully qualified name (name used in a more generic sense here, not meaning NAME field only)
204 2014-02-09T18:56:32 <penguinRaider> ThomasWaldmann, oh thanks I got it a bit. Can I work on #401 if no one is working ?
205 2014-02-09T18:57:04 <ThomasWaldmann> in general, leaving a comment on an issue that one is working on it, is a good idea (or have it assigned, if possible)
206 2014-02-09T18:58:08 <ThomasWaldmann> ananasova: penguinRaider: just talk to each other who solves #401
207 2014-02-09T18:58:54 <ThomasWaldmann> there are about ~163 other issues in the tracker, btw
208 2014-02-09T18:59:18 <ThomasWaldmann> plus EasyToDo page on the wiki
209 2014-02-09T18:59:41 <penguinRaider> ThomasWaldmann, yeah thanks I will try something easier first :-)
210 2014-02-09T19:03:02 *** penguinRaider
211 2014-02-09T19:03:37 *** penguinRaider
212 2014-02-09T19:05:14 <ananasova> penguinRaider: we were discussing the issue recently and came to the conclusion that it is better to pull the fix now
213 2014-02-09T19:05:30 <ananasova> penguinRaider: the fqnames is an enhancement
214 2014-02-09T19:05:48 <ananasova> if you don't mind, i just started working on it
215 2014-02-09T19:06:12 <penguinRaider> ananasova, yeah sure :-) I will find something easy
216 2014-02-09T19:06:29 <ananasova> then i will assign it to myself on bb :)
217 2014-02-09T19:13:55 <ajitesh> ThomasWaldmann, are the "select all" and "actions" supposed to work as links or just plain text in the "index" section ??
218 2014-02-09T19:20:52 <ThomasWaldmann> well, select all should obviously select all items
219 2014-02-09T19:21:05 <ThomasWaldmann> if you click on it
220 2014-02-09T19:23:21 <ajitesh> and actions too should work ?? bcoz none of it is working.. as in its acting like plain text..
221 2014-02-09T19:32:15 <ThomasWaldmann> ajitesh: did you try all the builtin themes?
222 2014-02-09T19:32:36 <ThomasWaldmann> for basic theme, it is likely still broken, but for modernized it might work
223 2014-02-09T19:38:41 <ajitesh> ThomasWaldmann, i dont know how to change themes.. can u tell me how ??
224 2014-02-09T19:43:37 <ThomasWaldmann> create a user, log in, change theme
225 2014-02-09T19:43:58 <ThomasWaldmann> or set a different theme_default in the config
226 2014-02-09T19:46:05 <ThomasWaldmann> ajitesh: and before you try to log in, pull latest code from main repo ;)
227 2014-02-09T19:47:35 <ajitesh> ThomasWaldmann, yep.. just noticed the crash
228 2014-02-09T19:51:24 *** xiaq
229 2014-02-09T19:51:59 *** xiaq
230 2014-02-09T19:52:23 *** xiaq
231 2014-02-09T19:56:36 <ananasova> wow! ThomasWaldmann, thanks for the pycharm licence
232 2014-02-09T19:59:21 <ThomasWaldmann> thanks to jetbrains ;)
233 2014-02-09T20:00:33 * ThomasWaldmann updates to pycharm 3.1
234 2014-02-09T20:00:46 <ajitesh> ThomasWaldmann, yep it works in the modernized theme..
235 2014-02-09T20:06:35 <ajitesh> Also i think the in global index section the upload fields are too cluttered and the list is also unorganized.. i think i can make it better looking and organized using bootstrap..
236 2014-02-09T20:06:54 <ananasova> ThomasWaldmann: semantically do fqnames means composite names with NAME_EXACT field or composite names with any kind of field (tag, itemid etc)
237 2014-02-09T20:09:52 <ThomasWaldmann> ananasova: any kind
238 2014-02-09T20:10:12 <ananasova> the reason i am asking is because (i suppose) we would like to check if a user is subscribed to an item by providing not only its name, but other meta information too (not at the same time necessarily)
239 2014-02-09T20:10:13 <ThomasWaldmann> it's a generalization of the name-based api
240 2014-02-09T20:10:49 <ThomasWaldmann> ananasova: ah, and thus we need the full meta in the end, right?
241 2014-02-09T20:11:45 <ThomasWaldmann> ok, guess we need an item object for that
242 2014-02-09T20:11:56 <ananasova> full meta is useful for checking patterns (NAMERE and NAMEPREFIX) also
243 2014-02-09T20:13:23 <ThomasWaldmann> btw, that fix create a new item object. is that needed or do we have an already initialized object there already?
244 2014-02-09T20:14:24 <ananasova> unfortunatelly we need to create a new object. and maybe even check if the user has access to it
245 2014-02-09T20:17:37 <ananasova> or maybe it's redundant to do it in theme initialization; it is being handled in the views
246 2014-02-09T20:18:55 <ananasova> so shall we drop the idea of fqnames to check if user is subscribed to any of them?
247 2014-02-09T20:28:35 <ThomasWaldmann> well, in the end we need an item anyway. so it is just a question of where it gets created and how the api looks like.
248 2014-02-09T20:29:04 <ThomasWaldmann> maybe check where this call is made and what the use cases are
249 2014-02-09T20:37:24 <ananasova> item object can be created in is_subscribed_to if fqname contains name or itemid field
250 2014-02-09T20:39:06 <ThomasWaldmann> or any other real (unique) id
251 2014-02-09T20:39:57 <ThomasWaldmann> maybe it doesn't make that much sense with a revid, though
252 2014-02-09T20:41:18 <ananasova> what do you mean?
253 2014-02-09T20:41:41 <ThomasWaldmann> well, who cares about who is subscribed to old revisions?
254 2014-02-09T20:42:13 * ThomasWaldmann just wanted to point out that revid is also unique
255 2014-02-09T20:43:32 <ananasova> hm, we don't check subscriptions to older revisions, just by the itemid, which is the same through all item's lifespan
256 2014-02-09T20:44:06 <ThomasWaldmann> yup
257 2014-02-09T20:47:22 <RogerHaase> ThomasWaldmann: pushed fix for 398, created pull request
258 2014-02-09T20:49:37 <ajitesh> ThomasWaldmann, so should i work on it ?
259 2014-02-09T20:51:00 <ThomasWaldmann> ajitesh: feel free to improve the looks. ;)
260 2014-02-09T20:51:15 <ajitesh> okk :D
261 2014-02-09T20:53:59 *** skathpalia
262 2014-02-09T21:20:40 <RogerHaase> ananasova: not sure if https://bitbucket.org/thomaswaldmann/moin-2.0/issue/404/jinja2exceptionsundefinederror is same or related to 401
263 2014-02-09T21:51:15 <ananasova> RogerHaase: not sure it is related to 401, so far subscriptions system from the main repo isn't using fqnames.
264 2014-02-09T21:53:01 <ananasova> as far as i know ashutosh was working on fqnames
265 2014-02-09T21:54:15 <RogerHaase> OK, then 404 is available for anyone
266 2014-02-09T21:56:24 <ananasova> not found :D
267 2014-02-09T22:04:58 <ajitesh> ^ haha.. nice one :D
268 2014-02-09T22:13:00 *** RogerHaase
269 2014-02-09T22:31:16 *** ajitesh
270
