MoinMoin: MoinMoinChat/Logs/moin-dev/2014-01-31

   1 2014-01-31T00:02:29  *** Jigar54 has quit IRC
   2 2014-01-31T00:09:14  *** sudo_dirk has quit IRC
   3 2014-01-31T00:09:31  *** sudo_dirk has joined #moin-dev
   4 2014-01-31T01:15:37  *** moin8 has joined #moin-dev
   5 2014-01-31T01:15:47  <moin8> hi
   6 2014-01-31T01:16:17  *** moin8 has quit IRC
   7 2014-01-31T01:45:01  *** derdon has quit IRC
   8 2014-01-31T05:16:35  *** Jigar54 has joined #moin-dev
   9 2014-01-31T06:13:45  *** Jigar54 has quit IRC
  10 2014-01-31T07:03:01  *** moin4 has joined #moin-dev
  11 2014-01-31T07:03:03  <moin4> hello
  12 2014-01-31T07:04:05  <moin4> suppose i wanted my moin to support metadata in pages (like tags, and so on), is it too early to consider moin2?
  13 2014-01-31T07:10:24  * moin4 sad
  14 2014-01-31T07:16:53  *** moin4 has quit IRC
  15 2014-01-31T08:16:19  *** moin7 has joined #moin-dev
  16 2014-01-31T08:16:29  <moin7> so i asked a question about metadata before ...
  17 2014-01-31T08:16:30  <moin7> did i miss the answer?
  18 2014-01-31T08:52:02  *** greg_f has joined #moin-dev
  19 2014-01-31T08:56:33  <ronny_> moin7: didnt miss anything ,but its in the morning where most of the devs are and they have work as well
  20 2014-01-31T08:56:44  * ronny_ is out of the loop since about a year
  21 2014-01-31T09:07:45  <dreimark> moin
  22 2014-01-31T09:09:41  <dreimark> ThomasWaldmann: I just entered me to https://moinmo.in/GoogleSoc2014
  23 2014-01-31T09:11:28  <dreimark> ronny_: can we get your time too?
  24 2014-01-31T09:19:48  *** moin7 has quit IRC
  25 2014-01-31T10:12:01  *** Jigar54 has joined #moin-dev
  26 2014-01-31T10:21:35  *** ajitesh_ has quit IRC
  27 2014-01-31T11:02:54  <ronny_> dreimark: i dont think i can manage atm
  28 2014-01-31T11:03:14  <ronny_> dreimark: i can elp i reminded, but tis year i cant manage full mentor
  29 2014-01-31T11:07:17  *** ajitesh has joined #moin-dev
  30 2014-01-31T11:21:56  *** moin8 has joined #moin-dev
  31 2014-01-31T11:21:59  <moin8> sup
  32 2014-01-31T11:32:27  <ThomasWaldmann> moin
  33 2014-01-31T11:35:05  <ajitesh> moin :)
  34 2014-01-31T11:35:58  <ajitesh> ThomasWaldmann, how do i test the changes i made in the unicode strings bug ?
  35 2014-01-31T11:39:38  <moin8> test
  36 2014-01-31T11:39:41  <moin8> hmm
  37 2014-01-31T11:47:14  <ajitesh> https://bitbucket.org/thomaswaldmann/moin-2.0/issue/124/moin-crashed-on-cyrillic-urls-internal
  38 2014-01-31T11:50:13  *** moin8 has quit IRC
  39 2014-01-31T11:55:29  *** eSyr has quit IRC
  40 2014-01-31T11:56:35  *** eSyr has joined #moin-dev
  41 2014-01-31T12:04:45  *** eSyr has quit IRC
  42 2014-01-31T12:04:51  *** eSyr has joined #moin-dev
  43 2014-01-31T12:25:19  *** ajitesh has quit IRC
  44 2014-01-31T12:33:14  *** Jigar54 has quit IRC
  45 2014-01-31T12:45:12  *** Jigar54 has joined #moin-dev
  46 2014-01-31T12:47:49  *** ajitesh has joined #moin-dev
  47 2014-01-31T13:14:53  *** Jigar54 has quit IRC
  48 2014-01-31T13:27:22  *** Jigar54 has joined #moin-dev
  49 2014-01-31T13:44:07  <dreimark> ronny_: ok
  50 2014-01-31T13:47:28  *** RogerHaase has joined #moin-dev
  51 2014-01-31T13:57:16  <ThomasWaldmann> ajitesh: a) run the unit tests (py.test --pep8)
  52 2014-01-31T13:57:57  <ThomasWaldmann> b) do manual tests and try to execute the code you modified (look at hg diff to find places you modified)
  53 2014-01-31T13:58:18  <ThomasWaldmann> c) upload your work to codereview.appspot.com to get a review from other devs
  54 2014-01-31T14:00:45  <ajitesh> ThomasWaldmann, i saw it shows some pep-8 errors already present in the code i forked..
  55 2014-01-31T14:01:23  <ajitesh> should i try to fix them too ?
  56 2014-01-31T14:01:30  <RogerHaase> ajitesh: are you using windows?
  57 2014-01-31T14:01:38  <ThomasWaldmann> only if you introduced them with your changes
  58 2014-01-31T14:01:47  <ThomasWaldmann> otherwise it should be a separate commit
  59 2014-01-31T14:01:58  <ajitesh> no.. ubuntu 12.04.3
  60 2014-01-31T14:02:08  <ThomasWaldmann> ajitesh: same here :)
  61 2014-01-31T14:02:15  <ThomasWaldmann> ajitesh: same linux here :)
  62 2014-01-31T14:03:04  <ajitesh> ThomasWaldmann, hehe.. i always prefer LTS versions :)
  63 2014-01-31T14:03:44  <ThomasWaldmann> yup. soon there will be a new one.
  64 2014-01-31T14:06:34  <ajitesh> yep.. This April i guess
  65 2014-01-31T14:20:21  *** Jigar54 has quit IRC
  66 2014-01-31T14:42:37  *** Jigar54 has joined #moin-dev
  67 2014-01-31T15:08:27  *** Jigar54 has quit IRC
  68 2014-01-31T17:01:01  *** Jigar54 has joined #moin-dev
  69 2014-01-31T17:22:42  *** greg_f has quit IRC
  70 2014-01-31T17:31:40  *** Jigar54 has quit IRC
  71 2014-01-31T17:52:30  *** Jigar54 has joined #moin-dev
  72 2014-01-31T17:59:34  *** Jigar54 has quit IRC
  73 2014-01-31T18:41:59  <ajitesh> i'd have to manually do a diff and then use upload.py from codereview.appspot.com  -- is that correct ?
  74 2014-01-31T18:42:28  <ThomasWaldmann> no, just run upload.py in your hg repo (with uncommitted changes)
  75 2014-01-31T18:46:07  <ThomasWaldmann> sharky93: sunu: EuroPython early bird ticket sale starts 2014-02-05
  76 2014-01-31T18:46:43  <ThomasWaldmann> including student tickets (and personal and business)
  77 2014-01-31T18:47:52  <ThomasWaldmann> student tickets are limited in number and you'll need to email a copy of your student id card then
  78 2014-01-31T18:49:43  <ThomasWaldmann> ajitesh: (see above)
  79 2014-01-31T18:50:34  <ajitesh> ThomasWaldmann, okk.. on it :D
  80 2014-01-31T18:59:58  <ajitesh> ThomasWaldmann, i added some wiki items for testing.. would just deleting them from inside the moin gui work ??
  81 2014-01-31T19:00:41  <ajitesh> as in i dont want them to appear in my diff
  82 2014-01-31T19:12:20  <ThomasWaldmann> wiki items are not revision controlled. do you see them in hg diff?
  83 2014-01-31T19:18:03  <ajitesh> ThomasWaldmann, No..
  84 2014-01-31T19:18:19  <ajitesh> i just understood the use of .hgignore
  85 2014-01-31T19:18:39  <ThomasWaldmann> good ;)
  86 2014-01-31T19:20:18  <ajitesh> ThomasWaldmann, uploaded a patch.. needs review - https://codereview.appspot.com/55370044/  :)
  87 2014-01-31T19:24:30  <ThomasWaldmann> long list is long
  88 2014-01-31T19:28:01  <ajitesh> i know :) ..
  89 2014-01-31T19:32:50  <ThomasWaldmann> ajitesh: review done
  90 2014-01-31T19:42:56  <ajitesh> ThomasWaldmann, ok..
  91 2014-01-31T19:44:06  <ajitesh> ThomasWaldmann, one more doubt - is it correct to assume that the sql queries would all be ascii ?
  92 2014-01-31T19:44:51  <ThomasWaldmann> in what module?
  93 2014-01-31T19:45:29  <ThomasWaldmann> maybe easier to say:
  94 2014-01-31T19:45:49  <ThomasWaldmann> user names, item names, tags, ..., content is all unicode
  95 2014-01-31T19:46:16  <ThomasWaldmann> uuids, view names, urls, reprs is ascii
  96 2014-01-31T19:47:47  <ajitesh> like in ' MoinMoin/storage/stores/sqlite.py '
  97 2014-01-31T19:53:54  <ajitesh> regarding the urls.. i saw that url also had been typecasted in unicode at other places in the code and also one test case tried to check a non-ascii url  in the mail section and similar with the repr.. so i did it that way..
  98 2014-01-31T19:54:18  <ajitesh> but i'll change it now
  99 2014-01-31T20:00:43  <ThomasWaldmann> hmm
 100 2014-01-31T20:00:55  <ThomasWaldmann> maybe you have to look into that
 101 2014-01-31T20:01:38  <ThomasWaldmann> in the end, urls are ascii. but maybe we really use unicode stuff and werkzeug transforms them to ascii.
 102 2014-01-31T20:02:08  <ThomasWaldmann> so maybe first fix the other stuff and have a 2nd look at urls
 103 2014-01-31T20:07:25  <ajitesh> ok..
 104 2014-01-31T20:22:11  *** Jigar54 has joined #moin-dev
 105 2014-01-31T21:01:25  *** Jigar54 has quit IRC
 106 2014-01-31T21:15:15  *** Jigar54 has joined #moin-dev
 107 2014-01-31T21:20:25  *** Jigar54 has quit IRC
 108 2014-01-31T22:09:14  *** RogerHaase has left #moin-dev
 109