1 2013-11-18T02:18:37 *** sudo_dirk
2 2013-11-18T02:19:33 *** sudo_dirk
3 2013-11-18T06:42:38 *** TakSuyu
4 2013-11-18T06:42:51 *** TakSuyu
5 2013-11-18T08:59:30 <ananasova> moin
6 2013-11-18T09:09:40 *** greg_f
7 2013-11-18T12:41:14 *** dave_largo
8 2013-11-18T13:15:10 <ThomasWaldmann> moin
9 2013-11-18T13:16:26 <ananasova> ThomasWaldmann: can you please review this? https://codereview.appspot.com/13274046/
10 2013-11-18T13:16:57 <ananasova> btw this Thursday I am attending a GSoC meetup in Bucharest
11 2013-11-18T13:17:16 <ananasova> also will prepare a short presentation about the work on moin :)
12 2013-11-18T13:59:53 <ThomasWaldmann> ah, cool :)
13 2013-11-18T14:02:05 <ThomasWaldmann> ananasova: you know about try/finally?
14 2013-11-18T14:02:23 <ThomasWaldmann> (and its typical use cases)
15 2013-11-18T14:29:28 <ananasova> ThomasWaldmann: in general yes, finally contains cleaning up code (closing files, connections)
16 2013-11-18T14:30:16 <ThomasWaldmann> ananasova: and unlocking locks ;)
17 2013-11-18T14:30:29 <ananasova> when sendmail raises an exception, the execution returns to the EmailHandler and it is being unlocked
18 2013-11-18T14:32:49 <ananasova> now i wrapped the sendmail into a try clause and the release into finally, and it works the same
19 2013-11-18T14:33:12 <ThomasWaldmann> guess it does no harm
20 2013-11-18T14:33:17 * ThomasWaldmann gtg / bbl
21 2013-11-18T14:33:38 <ananasova> ok, i am updating the cr :)
22 2013-11-18T14:37:52 <ananasova> ThomasWaldmann: when got time, please take a look -> https://codereview.appspot.com/13274046/diff2/30001:50001/MoinMoin/log.py
23 2013-11-18T14:55:49 <ThomasWaldmann> ananasova: almost, see there
24 2013-11-18T15:00:04 <ananasova> ThomasWaldmann: ah, ok. updated
25 2013-11-18T15:06:54 <ThomasWaldmann> ananasova: and another try :)
26 2013-11-18T15:07:10 <ThomasWaldmann> (you can commit it after the final fix, see there)
27 2013-11-18T15:09:39 <ananasova> yeah, makes sense. even the initial suggestion said it must be below.
28 2013-11-18T15:10:01 <ananasova> ThomasWaldmann: thanks for being so patient
29 2013-11-18T15:12:11 <ThomasWaldmann> (just to be clear: it is not extremely important in the case there, i think it could even reliably work without that, so it is mostly for learning the general pattern and rather applying it than risking malfunction)
30 2013-11-18T15:17:29 *** brunomartin
31 2013-11-18T15:20:07 <ananasova> got it
32 2013-11-18T15:20:42 <ananasova> commited the changes and created a pr
33 2013-11-18T15:54:26 *** brunomartin
34 2013-11-18T16:02:14 *** brunomartin
35 2013-11-18T16:58:07 *** greg_f
36 2013-11-18T17:00:03 *** dreimark
37 2013-11-18T17:06:47 *** brunomartin
38 2013-11-18T17:41:15 *** ReimarBauer
39 2013-11-18T18:06:39 *** brunomartin
40 2013-11-18T19:21:01 *** RogerHaase
41 2013-11-18T19:23:27 *** brunomartin
42 2013-11-18T21:03:22 *** dave_largo
43 2013-11-18T21:08:42 <RogerHaase> ThomasWaldmann: 378 simplify venv name, add small helper scripts to reduce keying, share pip cache among multiple repos: https://codereview.appspot.com/27770044/
44 2013-11-18T21:38:10 <ThomasWaldmann> hi RogerHaase - some comments there ^^
45 2013-11-18T21:39:07 * ThomasWaldmann brb
46 2013-11-18T22:15:22 <RogerHaase> ThomasWaldmann: replied
47 2013-11-18T22:45:27 *** RogerHaase
48
MoinMoin: MoinMoinChat/Logs/moin-dev/2013-11-18 (last edited 2013-11-18 02:30:02 by IrcLogImporter)