1 2013-10-03T09:07:29 *** greg_f
2 2013-10-03T11:46:32 *** lu_zero
3 2013-10-03T11:46:36 <lu_zero> hi =)
4 2013-10-03T11:47:33 * lu_zero reads his pending issues
5 2013-10-03T11:47:49 <lu_zero> one, I found was directly in the moin command
6 2013-10-03T11:48:28 <lu_zero> moin account-password errors out with quite mysterious errors
7 2013-10-03T11:49:32 <lu_zero> it asserts missing key email
8 2013-10-03T11:50:43 <lu_zero> KeyError: u'email'
9 2013-10-03T11:50:49 <lu_zero> to be precise
10 2013-10-03T11:51:24 <lu_zero> moin account-password -n lu_zero -p testmeplenty -v
11 2013-10-03T11:52:11 <lu_zero> the other is if would be useful for other people adding a theme helper to flatten the action menu
12 2013-10-03T11:52:52 <lu_zero> so the theme will get a single array instead of nested iterables
13 2013-10-03T11:54:00 <ThomasWaldmann> lu_zero: guess email is required maybe. but yes, there maybe should be better error msg.
14 2013-10-03T11:56:52 <lu_zero> I'm a bit surprised since it is looking for it in meta
15 2013-10-03T11:57:01 <lu_zero> and in theory the account creation
16 2013-10-03T11:57:08 <lu_zero> requires you to add it
17 2013-10-03T11:57:20 <lu_zero> (used the command line tool)
18 2013-10-03T12:04:28 <ThomasWaldmann> Option('--email', '-e', required=True, dest='email', type=unicode,
19 2013-10-03T12:05:16 <ThomasWaldmann> (env)tw@tux:~/w/moin-2.0$ moin account-create -n tw44 -p foo
20 2013-10-03T12:05:27 <ThomasWaldmann> moin account-create: error: argument --email/-e is required
21 2013-10-03T12:05:40 <ThomasWaldmann> are you sure you run the current moin/2.0 code?
22 2013-10-03T12:05:49 <lu_zero> absolutely
23 2013-10-03T12:06:04 <lu_zero> I guess I can grep the user definition
24 2013-10-03T12:06:27 <lu_zero> last commit fix/avoid some pep8 issues
25 2013-10-03T12:07:04 <ThomasWaldmann> did you update your workdir? if workdir should be same as last commit: hg up -C
26 2013-10-03T12:07:48 <lu_zero> I see email_unvalidated key in the lu_zero user meta
27 2013-10-03T12:07:54 <lu_zero> that explains
28 2013-10-03T12:08:50 <ThomasWaldmann> can you please create a NEW user just to verify your and my code work the same?
29 2013-10-03T12:14:54 <lu_zero> sure
30 2013-10-03T12:16:12 <lu_zero> the check for email and password lenght triggers as expected
31 2013-10-03T12:16:31 <lu_zero> giving it a password of 8+ and an email results in the account created
32 2013-10-03T12:17:11 <lu_zero> with the email key not existent since you have email_unvalidated as key
33 2013-10-03T12:27:53 <ThomasWaldmann> $ moin account-create -n xxxxxx -p yyyyyy
34 2013-10-03T12:28:08 <ThomasWaldmann> can you just try that to check you get the same error msg as i got?
35 2013-10-03T12:28:20 <lu_zero> usage: This command allows you to create a user account
36 2013-10-03T12:28:21 <lu_zero> moin account-create: error: argument --email/-e is required
37 2013-10-03T12:28:25 <lu_zero> I said yes
38 2013-10-03T12:28:27 <lu_zero> 14:15 < lu_zero> the check for email and password lenght triggers as expected
39 2013-10-03T12:29:00 <ThomasWaldmann> yes, now we have cleared that, we can look at next topic
40 2013-10-03T12:29:48 <lu_zero> the assumption not holding is line 106 in resetpw.py
41 2013-10-03T12:31:00 <ThomasWaldmann> ok, gave it 8char pw and email and it created the account
42 2013-10-03T12:31:21 <ThomasWaldmann> so how to trigger the KeyError?
43 2013-10-03T12:31:49 * ThomasWaldmann looks at resetpw.py...
44 2013-10-03T12:32:21 <lu_zero> ThomasWaldmann: users newly created have their email put in the email_unvalidated key
45 2013-10-03T12:34:54 <lu_zero> editing manually the meta to have the expected key makes resetpw work
46 2013-10-03T12:36:16 <ThomasWaldmann> ok, i could reproduce what you are talking about. it would've been easier with in-order instructions how to reproduce.
47 2013-10-03T12:38:04 <lu_zero> sure, sorry for the scattered information
48 2013-10-03T12:38:12 <ThomasWaldmann> it looks like "Set_Password" is getting the email just for information
49 2013-10-03T12:38:20 <lu_zero> yes
50 2013-10-03T12:38:45 *** dave_largo
51 2013-10-03T12:38:47 <lu_zero> but even if you comment it out something deep down breaks as well
52 2013-10-03T12:40:07 <ThomasWaldmann> AttributeError id you mean?
53 2013-10-03T12:40:11 <lu_zero> yes
54 2013-10-03T12:41:02 <ThomasWaldmann> somehow i get rather short tracebacks with little info...
55 2013-10-03T12:41:02 <lu_zero> and looking at set_password you are bound to get an error by design
56 2013-10-03T12:41:21 <lu_zero> ThomasWaldmann: you see why I was puzzled =)
57 2013-10-03T12:52:49 <ThomasWaldmann> lu_zero: ok, first issue fixed and pushed
58 2013-10-03T12:53:32 <lu_zero> thanks
59 2013-10-03T12:53:42 <ThomasWaldmann> now looking at 2nd issue
60 2013-10-03T12:54:25 <lu_zero> MoinMoin/templates/itemviews.html
61 2013-10-03T12:59:15 <lu_zero> I'd move all this logic in ThemeSupport
62 2013-10-03T12:59:42 * ThomasWaldmann is still at last issue
63 2013-10-03T13:12:31 <ThomasWaldmann> lu_zero: ok, fixed the 2nd one. needs more testing for all the scenarios
64 2013-10-03T13:13:28 <ThomasWaldmann> thanks for finding these
65 2013-10-03T13:30:44 <lu_zero> no problem
66 2013-10-03T13:31:26 <lu_zero> is there any information on how the parser integration work?
67 2013-10-03T13:32:16 * lu_zero is still puzzled at Markdown + extra being escaped
68 2013-10-03T13:34:06 <lu_zero> input http://pastebin.com/JgyiPJKD and output http://pastebin.com/KQqHVqVe
69 2013-10-03T13:34:55 <lu_zero> and this is the small change to enable extra http://pastebin.com/hxakthQV
70 2013-10-03T13:38:49 <ThomasWaldmann> lu_zero: i didn't implement the markdown stuff, it was a contribution
71 2013-10-03T13:40:41 <lu_zero> I see
72 2013-10-03T13:40:58 <lu_zero> I'll try to see what's wrong
73 2013-10-03T13:41:00 <ThomasWaldmann> and i don't even use markdown, so i can't comment on what you are saying
74 2013-10-03T13:41:58 <lu_zero> enough people seem to like Markdown or at least know it so I wanted to make sure it works on par with the github flavour
75 2013-10-03T14:27:09 *** brunomartin
76 2013-10-03T16:08:08 *** RogerHaase
77 2013-10-03T17:20:21 *** greg_f
78 2013-10-03T21:12:34 *** dave_largo
79 2013-10-03T22:19:32 *** RogerHaase
80 2013-10-03T22:43:26 *** brunomartin
81
MoinMoin: MoinMoinChat/Logs/moin-dev/2013-10-03 (last edited 2013-10-03 09:15:02 by IrcLogImporter)