1 2013-09-15T00:37:36 *** ashutosh1461
2 2013-09-15T03:25:36 *** ashutosh1461
3 2013-09-15T06:42:11 <sharky93> moin
4 2013-09-15T06:42:19 * sharky93 fixed the topnav
5 2013-09-15T08:31:49 <sharky93> TheSheep: how do we verify HTML validity, we surely do not want to check each page manually?
6 2013-09-15T08:32:22 <TheSheep> why not
7 2013-09-15T08:33:04 <sharky93> TheSheep: you mean clicking on each link, then copy pasting the source?
8 2013-09-15T08:33:34 <TheSheep> you can do wget -r
9 2013-09-15T08:33:50 <TheSheep> and validate the downloaded files
10 2013-09-15T08:34:50 <sharky93> hmm, there also might be plugins available with browsers .., you know of any?
11 2013-09-15T08:34:59 <TheSheep> hundreds
12 2013-09-15T08:35:19 <TheSheep> I used webdeveloper toolbar
13 2013-09-15T08:35:29 <sharky93> chromium?
14 2013-09-15T08:35:47 <TheSheep> ff
15 2013-09-15T08:36:19 * sharky93 looks up something for chromium ..
16 2013-09-15T09:34:27 <ananasova> moin
17 2013-09-15T09:56:43 <ThomasWaldmann> moin
18 2013-09-15T09:56:51 <ThomasWaldmann> who's here?
19 2013-09-15T09:57:13 * sharky93 getting ready
20 2013-09-15T09:57:31 <ananasova> here
21 2013-09-15T09:57:56 <ThomasWaldmann> waldi: meeting in 3mins
22 2013-09-15T09:57:58 *** ashutosh1461
23 2013-09-15T09:58:44 <waldi> moint
24 2013-09-15T10:01:58 <ThomasWaldmann> ok, welcome to the 2nd last meeting for this SOC
25 2013-09-15T10:02:15 <ThomasWaldmann> sharky93: TheSheep: please begin
26 2013-09-15T10:02:21 <ashutosh1461> moin
27 2013-09-15T10:03:14 <sharky93> ok
28 2013-09-15T10:03:17 <sharky93> DONE:
29 2013-09-15T10:03:17 <sharky93> Fixed reponsive navbar
30 2013-09-15T10:03:17 <sharky93> Fixed alert-message display
31 2013-09-15T10:03:17 <sharky93> Major layout upgrade with issues #24, #33, #64, positioning of some other elements like SiteMap, Similar
32 2013-09-15T10:03:20 <sharky93> Breadcrumbs combined
33 2013-09-15T10:03:23 <sharky93> Active states added for various elements in the page
34 2013-09-15T10:03:25 <sharky93> Added the register new user view
35 2013-09-15T10:03:28 <sharky93> Fixed permalinks
36 2013-09-15T10:03:30 <sharky93> More Bug Fixes
37 2013-09-15T10:03:33 <sharky93> Repo in a better state
38 2013-09-15T10:03:35 <sharky93> TODO:
39 2013-09-15T10:03:38 <sharky93> Fix HTML validation
40 2013-09-15T10:03:40 <sharky93> Finish the responsive design by finalizing the footer
41 2013-09-15T10:03:43 <sharky93> Add relevant DOCS
42 2013-09-15T10:03:45 <sharky93> Close on #46 is pending
43 2013-09-15T10:03:48 <sharky93> BLOCKERS:
44 2013-09-15T10:03:50 <sharky93> None
45 2013-09-15T10:05:01 <waldi> what do you mean with "fix html validation"?
46 2013-09-15T10:05:26 <ThomasWaldmann> sharky93: was that alert / navbar fix after my comments yesterday?
47 2013-09-15T10:05:54 <sharky93> waldi: umm, wrong words i guess, i mean fix the HTML validation errors
48 2013-09-15T10:06:04 <waldi> okay
49 2013-09-15T10:06:26 <ThomasWaldmann> sharky93: how many test failures does your repo have for "make test"?
50 2013-09-15T10:06:30 <sharky93> ThomasWaldmann: yes, the navbar fix is after that, though i've not changed the alert
51 2013-09-15T10:07:28 <ThomasWaldmann> so alert is still looking crappy?
52 2013-09-15T10:08:19 <sharky93> ThomasWaldmann: the main issue with alert was the width, right?
53 2013-09-15T10:08:45 <ThomasWaldmann> yes and that it is pushing the nav stuff on the left down (due to its width)
54 2013-09-15T10:09:28 <ThomasWaldmann> btw, i like the breadcrumbs combined view
55 2013-09-15T10:10:39 <sharky93> ThomasWaldmann: i like it too :) , btw about the alert, changing the width is easy, but we want to do that only for the desktop view, since at lower widths, everything is 100% width
56 2013-09-15T10:11:08 <ThomasWaldmann> maybe, yes.
57 2013-09-15T10:11:25 <ThomasWaldmann> you can just look at it yourself, i guess you can also see if something doesn't look ok.
58 2013-09-15T10:12:04 <ThomasWaldmann> 12:06 ThomasWaldmann$ sharky93: how many test failures does your repo have for "make test"?
59 2013-09-15T10:12:18 <sharky93> ThomasWaldmann: make test gives 13 errors, 6 for PEP-8 and rest involve the exception for index.
60 2013-09-15T10:12:39 <sharky93> ThomasWaldmann: we'll finalize the alert
61 2013-09-15T10:12:42 <ThomasWaldmann> that's a bit much...
62 2013-09-15T10:13:21 <sharky93> i still havent had a look, why is the index view failing ..
63 2013-09-15T10:15:51 * ThomasWaldmann runs test on main repo. student repos must not introduce additional test failures, that is a blocker for merging the stuff.
64 2013-09-15T10:16:21 <ThomasWaldmann> sharky93: did you close all issues that are solved?
65 2013-09-15T10:17:13 <sharky93> ThomasWaldmann: #46 is left, and now #54 too
66 2013-09-15T10:18:22 <ThomasWaldmann> you mean "left to close" ? left are many more iirc.
67 2013-09-15T10:18:36 <sharky93> ThomasWaldmann: yeah left to close
68 2013-09-15T10:19:22 <ThomasWaldmann> so 46 and 54 are completely fixed?
69 2013-09-15T10:20:14 <sharky93> ThomasWaldmann: #46 is done, #54 is under discussion .. a major part of #54 is done i think
70 2013-09-15T10:20:27 <sharky93> with the responsive navbar fix that is.
71 2013-09-15T10:21:09 <ThomasWaldmann> btw, in the main repo, i currently see 4 test failures, which are all pep8. i'll fix these asap and expect student repos are not in a worse state.
72 2013-09-15T10:22:03 <sharky93> ThomasWaldmann: not in a worse state by?
73 2013-09-15T10:22:22 <waldi> more or different failures
74 2013-09-15T10:22:25 <ThomasWaldmann> by the gsoc deadline.
75 2013-09-15T10:23:18 <ThomasWaldmann> (and students shall merge after i fixed the pep8 in the main repo to get rid of those)
76 2013-09-15T10:24:04 <sharky93> ThomasWaldmann: more or different failures?
77 2013-09-15T10:24:28 <ananasova> errors, pep8 failures
78 2013-09-15T10:25:01 <ThomasWaldmann> anything different/more is by definition caused by your changes and should not be there
79 2013-09-15T10:25:25 <ThomasWaldmann> and assuming you didn't fix failures you didn't cause yourself, more === different
80 2013-09-15T10:25:54 <ThomasWaldmann> ok, anything else for sharky?
81 2013-09-15T10:26:18 <ThomasWaldmann> hmm, one thing from me: some elements seem to miss padding (I think)
82 2013-09-15T10:27:12 <sharky93> ThomasWaldmann: the site logo is the only remaining thing i think
83 2013-09-15T10:27:28 <ThomasWaldmann> e.g. the logo sometimes directly touches other elements (when width goes below threshold) and also the left navbar links (e.g. Supplementation) touches the right border of the box around it. can this be fixed by padding?
84 2013-09-15T10:28:34 <ThomasWaldmann> maybe border? I don't know...
85 2013-09-15T10:29:22 <ThomasWaldmann> and i suggest you do a complete click-through to find many more things...
86 2013-09-15T10:29:35 <sharky93> ThomasWaldmann: the logo can be fixed, however i dont see the about the left navbar links
87 2013-09-15T10:30:10 <ThomasWaldmann> ok, if there's nothing else for sharky93: thanks to sharky93 and thesheep, next is ashutosh1461 / me.
88 2013-09-15T10:30:18 <sharky93> ThomasWaldmann: what should be the preference, should i have to choose, fixing the test failures or fixing other things?
89 2013-09-15T10:31:10 <ThomasWaldmann> i likely won't merge stuff if it introduces more failures
90 2013-09-15T10:31:10 <sharky93> ThomasWaldmann: one "different" test which fails for me is the exception on GLobal Index, which is rather odd.
91 2013-09-15T10:32:17 <ThomasWaldmann> well, discuss that after the meeting.
92 2013-09-15T10:32:21 <sharky93> ok
93 2013-09-15T10:32:48 <ashutosh1461> DONE :-
94 2013-09-15T10:32:49 <ashutosh1461> Fixed all views. (frontend, admin, misc).
95 2013-09-15T10:32:49 <ashutosh1461> Fixed broken links, and did practical tests, Closed bugs (two remaining.).
96 2013-09-15T10:32:49 <ashutosh1461> Fixed failing tests (1 failing test left).
97 2013-09-15T10:32:49 <ashutosh1461> TODO:-
98 2013-09-15T10:32:50 <ashutosh1461> Fix the search view bugs by today.
99 2013-09-15T10:32:52 <ashutosh1461> Repo should be in a working state by tomorrow.
100 2013-09-15T10:34:10 <ThomasWaldmann> ashutosh1461: i just ran the tests and >= 10 are failing for me.
101 2013-09-15T10:35:05 <ashutosh1461> ThomasWaldmann, 9 were pep8 failures, just fixed them.
102 2013-09-15T10:35:52 <ThomasWaldmann> 10, to be precise, maybe including some from main repo
103 2013-09-15T10:36:31 <ThomasWaldmann> ok, so commit / push that and I'll try again
104 2013-09-15T10:36:46 <ashutosh1461> ok fine.
105 2013-09-15T10:37:00 <ThomasWaldmann> about fixed views:
106 2013-09-15T10:37:09 <ThomasWaldmann> global history -> crash
107 2013-09-15T10:37:27 <ThomasWaldmann> tags -> crash
108 2013-09-15T10:37:37 <ThomasWaldmann> user -> crash
109 2013-09-15T10:37:47 <ThomasWaldmann> admin -> crash
110 2013-09-15T10:37:59 <ronny> moin
111 2013-09-15T10:38:15 <ThomasWaldmann> user settings -> crash
112 2013-09-15T10:39:09 <ThomasWaldmann> similar -> crash
113 2013-09-15T10:39:58 <ThomasWaldmann> also, you destroyed layout for modernized view, there's a unstyled list appearing now in the header
114 2013-09-15T10:41:04 * ThomasWaldmann tried with lasted public repo code, empty wiki, new env made by quickinstall script
115 2013-09-15T10:42:28 <ashutosh1461> hmm, i am also observing the bad layout in the main repo, will fix it.
116 2013-09-15T10:42:58 <ThomasWaldmann> it's in the main repo?
117 2013-09-15T10:42:58 <ashutosh1461> ThomasWaldmann, what message do you get on opening the history/tags/user/admin views ?
118 2013-09-15T10:43:16 <ThomasWaldmann> i get server error
119 2013-09-15T10:44:08 <ThomasWaldmann> UndefinedError: 'fqname' is undefined
120 2013-09-15T10:44:13 <ThomasWaldmann> that was one of them
121 2013-09-15T10:45:25 <ashutosh1461> that should be similar views i guess (1 failing tests was relating to similar views only). rest are working fine here. will check
122 2013-09-15T10:45:46 <ThomasWaldmann> looks like all of them were caused by this kind of error
123 2013-09-15T10:46:48 <ThomasWaldmann> i suggest you rm -rf env, rm -rf wiki, quickinstall, moin index-create -s -i, then you should see it also
124 2013-09-15T10:47:03 <ashutosh1461> ThomasWaldmann, ran hg diff on my repo, did not see any change that could cause them to crash.
125 2013-09-15T10:47:13 <ashutosh1461> ok
126 2013-09-15T10:47:42 <ThomasWaldmann> you don't need to fix stuff also present in main repo, just notify me in case you find anything there
127 2013-09-15T10:48:34 <ashutosh1461> ok.
128 2013-09-15T10:49:08 <ThomasWaldmann> and as the last weeks were rather lacking effort on gsoc, i strongly suggest much more work in the remaining time
129 2013-09-15T10:51:20 <ashutosh1461> can you test my repo tomorrow so that i can fix if you find any mistakes?
130 2013-09-15T10:52:31 <ThomasWaldmann> well, in the first place you can run make test yourself and click on all links you see yourself
131 2013-09-15T10:52:58 <ThomasWaldmann> but if i see fixes for all the stuff mentioned above already, i can do a test afterwards, sure
132 2013-09-15T10:53:08 <ashutosh1461> hmm, sure
133 2013-09-15T10:53:54 <TheSheep> sorry for being late
134 2013-09-15T10:54:28 <ThomasWaldmann> do we have some namespaces switching meanwhile?
135 2013-09-15T10:55:38 <ThomasWaldmann> TheSheep: oh, i thought you were here as i've already seen you talking today. but i just noticed that was 1.5h before meeting...
136 2013-09-15T10:56:20 <ashutosh1461> ThomasWaldmann, namespace switching meanwhile ?
137 2013-09-15T10:57:15 <ThomasWaldmann> yes, your projects goal is making namespaces usable, so if one is currently in namespace "sales", how do i switch to namespace "engineering"?
138 2013-09-15T10:58:04 <ashutosh1461> by using the switching UI in breadcrubms ?
139 2013-09-15T10:59:58 <ThomasWaldmann> i don't currently see that
140 2013-09-15T11:01:12 <ThomasWaldmann> ok, guess you have enough to do next week. just bring it into a reasonable state.
141 2013-09-15T11:01:21 <ThomasWaldmann> any more questions for ashutosh1461 ?
142 2013-09-15T11:01:31 <ashutosh1461> ok, will fix that too.
143 2013-09-15T11:02:04 <ashutosh1461> hmm, found out the css files in the repo are not updated. I changed the stylus files only.
144 2013-09-15T11:02:44 <ThomasWaldmann> ok
145 2013-09-15T11:02:51 <ThomasWaldmann> ok, thanks ashutosh1461
146 2013-09-15T11:02:59 <ThomasWaldmann> ananasova: waldi: your stage
147 2013-09-15T11:03:18 <ananasova> ok
148 2013-09-15T11:03:23 <ananasova> DONE:
149 2013-09-15T11:03:23 <ananasova> * Finished with sending notification mails
150 2013-09-15T11:03:24 <ananasova> * Closed some trivial issues (usage of constants)
151 2013-09-15T11:03:28 <ananasova> TODO next week:
152 2013-09-15T11:03:28 <ananasova> * Configuration of postfix and mail import
153 2013-09-15T11:03:28 <ananasova> * Send mails to the web process (http request via curl)
154 2013-09-15T11:03:28 <ananasova> * Add DSN headers to sendmail
155 2013-09-15T11:03:33 <ananasova> BLOCKERS: none
156 2013-09-15T11:05:55 <ThomasWaldmann> there is still https://bitbucket.org/ana-balica/moin-2.0/issue/6/sending-subscription-mails-does-not-work open
157 2013-09-15T11:06:31 <ananasova> open, but i want to close it after somebody from mentors tests it
158 2013-09-15T11:06:46 <ananasova> so that i am sure there are no bugs involved
159 2013-09-15T11:07:24 <ThomasWaldmann> you have to test you stuff after fixing it
160 2013-09-15T11:07:41 <ThomasWaldmann> and then you have to close the issue, linking to the fix in the repo
161 2013-09-15T11:07:51 <ananasova> as for me it works.
162 2013-09-15T11:08:02 * ananasova is closing the issue...
163 2013-09-15T11:09:39 <ThomasWaldmann> some of the todo stuff above somehow reads like last weeks todo, btw
164 2013-09-15T11:10:00 <waldi> and i don't think this is even possible within one weeks time
165 2013-09-15T11:10:29 <ananasova> true, had some troubles with accomodation and internet here (and still having)
166 2013-09-15T11:10:39 <ThomasWaldmann> so i suggest you concentrate on fixing and documenting, rather than starting new stuff
167 2013-09-15T11:11:21 <ananasova> ok
168 2013-09-15T11:11:33 <dreimark> moin
169 2013-09-15T11:11:58 <ananasova> moin dreimark :)
170 2013-09-15T11:11:59 <ThomasWaldmann> and a list of known issues and todos - or rather issue tracker entries for such
171 2013-09-15T11:12:23 <waldi> ananasova: did you check for the amount of test failures lately?
172 2013-09-15T11:12:52 <ananasova> yes
173 2013-09-15T11:13:01 <ananasova> 4 pep8 test failures
174 2013-09-15T11:13:05 <ananasova> from the main repo
175 2013-09-15T11:13:19 <ananasova> waldi: did you get more after running make test?
176 2013-09-15T11:14:21 <waldi> no, this was just a question
177 2013-09-15T11:15:57 * ThomasWaldmann confirms 4 pep8 for ananasova
178 2013-09-15T11:16:17 <ThomasWaldmann> ananasova: merge main repo after i fix these to get rid of them
179 2013-09-15T11:16:38 <ananasova> ok
180 2013-09-15T11:17:22 <ThomasWaldmann> waldi: ananasova: lets talk about TODO next week
181 2013-09-15T11:17:56 <ThomasWaldmann> * fixes (see issue tracker)
182 2013-09-15T11:18:10 <ThomasWaldmann> * testing (put new stuff you find into issue tracker)
183 2013-09-15T11:18:36 <ThomasWaldmann> * docs for existing functionality, for admins, for users
184 2013-09-15T11:19:06 <ThomasWaldmann> * todo (put into issue tracker)
185 2013-09-15T11:19:44 <ThomasWaldmann> * extract useful stuff from etherpad and put into issue tracker and docs, clean up there - try to keep stuff somewhere else, EP empty
186 2013-09-15T11:20:15 <ThomasWaldmann> does that sound reasonable?
187 2013-09-15T11:20:22 <ananasova> one question about documentation: we create crs after adding documentation to docs/?
188 2013-09-15T11:20:43 <dreimark> crs?
189 2013-09-15T11:20:51 <ananasova> codereviews
190 2013-09-15T11:20:54 <waldi> ThomasWaldmann: apart from the rain outside, yes
191 2013-09-15T11:21:43 <ThomasWaldmann> ananasova: you can do that, but as you know best what you did, you should try to write docs yourself mostly. we can give feedback, though.
192 2013-09-15T11:23:01 <ananasova> i will ask kindly for feedback to see if the docs are clear enough to everybody
193 2013-09-15T11:23:09 <ThomasWaldmann> ashutosh1461: sharky93: in case you get bored, that is the cleanup intended for the last week ^^
194 2013-09-15T11:26:05 <ThomasWaldmann> ok, anything else for ananasova?
195 2013-09-15T11:26:32 <waldi> no
196 2013-09-15T11:27:13 <ThomasWaldmann> ok, so official meeting is over. TheSheep: if sharky93 is still here, talk now. :)
197 2013-09-15T11:27:57 * sharky93 currently working on squashing the Global Index bug
198 2013-09-15T11:32:56 * ThomasWaldmann goes fixing pep8 stuff
199 2013-09-15T11:33:21 * ThomasWaldmann wonders whether rules in pep8 checker changed or how that crept in
200 2013-09-15T11:38:08 <sharky93> TheSheep: the global index bug has been there since boostrap was initialized, the first commit!
201 2013-09-15T11:38:33 <TheSheep> sharky93: in that case search the moin's global repo for the commit where it was fixed
202 2013-09-15T11:42:11 * sharky93 looks up global repo's history
203 2013-09-15T11:53:16 <sharky93> ThomasWaldmann: TheSheep I have two local copies both on revision number 2131, one crashes at the global index, other does not
204 2013-09-15T11:53:42 <sharky93> ThomasWaldmann: TheSheep the one which crashes is my bootstrap fork, not crashing version is the global repo
205 2013-09-15T11:53:58 <sharky93> how is that possible? :o
206 2013-09-15T11:55:39 <TheSheep> sharky93: untracked files?
207 2013-09-15T11:55:45 <TheSheep> sharky93: configuration? cache?
208 2013-09-15T11:56:40 <TheSheep> special character in the paths?
209 2013-09-15T11:56:45 <TheSheep> gremlins?
210 2013-09-15T11:56:53 * sharky93 fears gremlins
211 2013-09-15T11:57:12 <TheSheep> sharky93: make a clone of your repo and test that
212 2013-09-15T11:57:45 <sharky93> TheSheep: version 2131 is when i had not even made the first commit!
213 2013-09-15T11:58:21 <TheSheep> sharky93: I have a feeling that if you make a fresh clone of your repo, it won't have the bug
214 2013-09-15T11:58:57 <sharky93> TheSheep: doing it.
215 2013-09-15T11:59:15 <TheSheep> you can clone from a local repo too, btw
216 2013-09-15T11:59:27 <TheSheep> just hg clone /path/to/your/local/repo
217 2013-09-15T12:00:26 <sharky93> already ran clone from the bitbucket online version
218 2013-09-15T12:02:45 <ThomasWaldmann> ok, main repo now has 0 failures
219 2013-09-15T12:02:54 <ThomasWaldmann> ananasova: sharky93: ashutosh1461: ^^ please merge
220 2013-09-15T12:03:43 <ThomasWaldmann> and run make test after merging, so you see test failures introduced by yourself
221 2013-09-15T12:05:50 <ananasova> looks good, no failures
222 2013-09-15T12:12:11 <ThomasWaldmann> sharky93: so, you are writing your 9.9. diary entry on 15.9.?
223 2013-09-15T12:15:33 <ThomasWaldmann> and 10. and 11. and 12. and 13. and 14.
224 2013-09-15T12:16:19 * ThomasWaldmann notes a complete failure to update the calendar for sharky
225 2013-09-15T12:19:15 <sharky93> ThomasWaldmann: yeah, the updates got delayed, so i updated them as per the commit i made each day
226 2013-09-15T12:20:15 <ThomasWaldmann> if you don't link the commits from the page, I will consider the calendar entries as not trustworthy
227 2013-09-15T12:21:01 <sharky93> ThomasWaldmann: ok, willdo.
228 2013-09-15T12:21:50 <sharky93> ThomasWaldmann: should i link each line with the commit, or just make a list of commits for the day, since the commit message is similar?
229 2013-09-15T12:21:50 <ThomasWaldmann> (do that on the day after pencils-down)
230 2013-09-15T12:23:12 <ThomasWaldmann> just add the commit to the line about it
231 2013-09-15T12:23:20 <sharky93> ok
232 2013-09-15T12:25:13 <sharky93> TheSheep: the freshclone of the bootstrap fork, has the Global Index failing too, but due to a different Assertion Error.
233 2013-09-15T12:25:35 <sharky93> fails only for the basic theme
234 2013-09-15T12:25:45 <TheSheep> I think I will start drinking
235 2013-09-15T12:26:56 <ThomasWaldmann> X)
236 2013-09-15T12:27:14 <ThomasWaldmann> or rather %*)
237 2013-09-15T12:49:19 <sharky93> TheSheep: I went through the history for the new clone, Global index breaks @ revision number 2275
238 2013-09-15T12:49:32 <sharky93> that was 6 days ago.
239 2013-09-15T14:53:31 *** ashutosh1461
240 2013-09-15T15:05:39 *** ashutosh1461
241 2013-09-15T16:48:01 * sharky93 fixed the Global Index.
242 2013-09-15T17:35:18 *** ashutosh1461
243 2013-09-15T17:53:37 <TheSheep> sharky93: \o/
244 2013-09-15T18:12:21 <sharky93> TheSheep: ThomasWaldmann 0 failures.
245 2013-09-15T20:16:44 * sharky93 says gn
246 2013-09-15T22:08:48 *** bilal
247 2013-09-15T23:36:28 *** bilal
248
