1 2013-09-09T00:26:35 <sharky93> TheSheep: i added an issue #66 addressing the same, please have a look.
2 2013-09-09T00:26:37 * sharky93 gn
3 2013-09-09T08:23:53 <ThomasWaldmann> moin
4 2013-09-09T08:29:06 <dreimark> moin
5 2013-09-09T09:26:46 <sharky93> moin
6 2013-09-09T09:48:31 *** MaikuMori
7 2013-09-09T11:11:40 <ananasova> moin
8 2013-09-09T11:14:26 <ananasova> ThomasWaldmann: waldi: please review https://codereview.appspot.com/13239050/
9 2013-09-09T11:14:59 <ananasova> also this update to subscription user settings - https://codereview.appspot.com/13240047/
10 2013-09-09T11:15:12 <ThomasWaldmann> waldi: ^^
11 2013-09-09T11:26:12 <ananasova> after this refactoring, i'd like also to make some other changes in a separate cr/commit
12 2013-09-09T11:26:56 <ananasova> _get_data_diff_text can be used for _render_data_diff_text
13 2013-09-09T11:30:55 *** MaikuMori
14 2013-09-09T11:30:59 *** MaikuMori_
15 2013-09-09T11:38:23 <ThomasWaldmann> ananasova: done
16 2013-09-09T11:38:33 * ThomasWaldmann bbl
17 2013-09-09T11:42:34 <sharky93> TheSheep: for displaying links properly in the alert boxes, we have two solutions, either change in the code and add a class to the HTML being generated or add the class via JS.. we need it to have the "alert-link" BS class ..
18 2013-09-09T11:45:05 <TheSheep> sharky93: or make a LESS rule that applies the same CSS to links inside the messages
19 2013-09-09T12:09:02 *** jhermann
20 2013-09-09T12:10:29 <jhermann> ThomasWaldmann, since i'm investing more time into OS again, i thought i'd do some drive-by coding
21 2013-09-09T12:10:51 <jhermann> and/or project mgmt (seen my Ci question?)
22 2013-09-09T12:46:25 *** dave_largo
23 2013-09-09T13:11:48 <ThomasWaldmann> jhermann: yes, we don't use CI (yet)
24 2013-09-09T13:11:48 *** jhermann
25 2013-09-09T13:11:55 <ThomasWaldmann> hm
26 2013-09-09T13:20:12 *** jhermann
27 2013-09-09T14:10:33 <ThomasWaldmann> jhermann: yes, we don't use CI (yet)
28 2013-09-09T14:20:16 <sharky93> TheSheep: any comment on #66?
29 2013-09-09T14:24:57 <jhermann> ThomasAH, well, I can look into changing that
30 2013-09-09T14:25:35 <jhermann> (too many baby boomer names in here)
31 2013-09-09T14:42:35 <ThomasAH> jhermann :)
32 2013-09-09T14:43:52 <ThomasAH> jhermann: at least I took a different last name when marrying, so I do not have a firstname+lastname that appears more than 100 times within 100km radius :)
33 2013-09-09T15:22:06 <ThomasWaldmann> ThomasAH: hehe
34 2013-09-09T15:22:30 <ThomasWaldmann> but nowadays that might be good for better privacy/"anonymity"!!1
35 2013-09-09T15:23:43 <ThomasWaldmann> jhermann: in moin2, we currently only target python 2.7 and we use py.test locally, so tests are simple to run
36 2013-09-09T17:02:06 *** jek_
37 2013-09-09T17:02:06 *** jek_
38 2013-09-09T17:13:56 <ananasova> hi jek_ :) need a piece of advice regarding flatland
39 2013-09-09T17:14:19 <jek_> hi
40 2013-09-09T17:14:58 *** jek_
41 2013-09-09T17:18:02 <ananasova> suppose we have a flatland List of Strings. when we display the list to the user, we want to have some Strings with some additional notes about it
42 2013-09-09T17:18:46 <ananasova> for ex: [a, b, c] we want to display as a (this is a), b (this is b), c etc...
43 2013-09-09T17:19:34 <ananasova> so far the solution was to inherit from JoinedString compound and overwrite `u` and `value` methods
44 2013-09-09T17:19:47 <ananasova> but we are not sure this is the best possible way
45 2013-09-09T17:19:48 <jek> a fixed size list, or dynamic?
46 2013-09-09T17:19:55 <ananasova> dynamic
47 2013-09-09T17:20:32 <jek> one approach would be to assign that data after you have instantiated your list
48 2013-09-09T17:21:17 <jek> e.g. strings = YourListType(['a', 'b', 'c']); for el in strings: el.label = '(this is %s)' % el.u
49 2013-09-09T17:21:43 <ananasova> ah, and one more thing, we display the data in a form (textarea) and the user can edit and save it
50 2013-09-09T17:21:58 <jek> like placeholder text?
51 2013-09-09T17:22:31 <jek> you might look into the calculated default values
52 2013-09-09T17:22:42 <jek> i've used those for placeholder-ish content
53 2013-09-09T17:23:48 <jek> like List.of(String.using(default_factory=lambda el: '(this is %s)' % el.value))
54 2013-09-09T17:24:05 <ananasova> it's not a placeholder, it's the textarea data
55 2013-09-09T17:24:24 <jek> ok, so saving the data as-is is ok
56 2013-09-09T17:24:41 <jek> in that case i'd either do the default thing or set the values explicitly in a loop
57 2013-09-09T17:25:21 <jek> the default approach is nice for placeholders you don't want to save, because you can compare the value coming back from the web with the calculated default value and know if the user edited the field
58 2013-09-09T17:25:49 <ananasova> aha
59 2013-09-09T17:26:21 <jek> with a simple validator like "if el.value == el.default"
60 2013-09-09T17:26:50 <jek> ".default_value", rather
61 2013-09-09T17:28:09 <ananasova> hm, the appended values to the strings are not default, they are very specific for each user
62 2013-09-09T17:32:57 <ananasova> one more question, when using List.of(String) is it possible to not display it with []?
63 2013-09-09T17:35:09 <jek> do you mean the unicode version of List? you can override that if you're printing it directly somewhere.
64 2013-09-09T17:37:24 <ananasova> yep, the unicode version.
65 2013-09-09T17:38:46 <ananasova> isn't JoinedString fit for such purposes?
66 2013-09-09T17:39:57 <jek> could be, really depends on the specifics of your usecase
67 2013-09-09T17:44:34 <ananasova> is it generally a good practice to make your own compounds for some specific displaying? just asking before i try to override the list of strings printing
68 2013-09-09T17:49:24 <jek> it can be a good practice
69 2013-09-09T17:49:31 <jek> really depends on the specifics :)
70 2013-09-09T17:51:15 <ananasova> i will use your advice to use String.using(default_factory=...) and will compare the results afterwords
71 2013-09-09T17:51:25 <ananasova> thank you jek :)
72 2013-09-09T17:51:34 <jek> np!
73 2013-09-09T18:08:10 <ananasova> btw if using default, is the data going to be saved as-is? for the earlier example the el.value will become '(this is el.value)'
74 2013-09-09T18:11:47 <jek> yes
75 2013-09-09T18:12:04 <jek> but you have an opportunity to normalize that in a validator function
76 2013-09-09T18:12:14 <jek> set it to None or whatever
77 2013-09-09T18:24:35 *** xorAxAx
78 2013-09-09T18:32:59 *** xorAxAx
79 2013-09-09T18:36:06 <sharky93> TheSheep: can we close #46?
80 2013-09-09T19:32:44 <sharky93> ThomasWaldmann: TheSheep do we want views in the breadcrumbs? like in #32 ..
81 2013-09-09T19:34:56 <ThomasWaldmann> no
82 2013-09-09T19:42:06 *** brunomartin
83 2013-09-09T19:43:54 <sharky93> ThomasWaldmann: if the url is /+somerandomstring/itemname where no view like "somerandomstring" exists, we do not want that to register in the path/location?
84 2013-09-09T19:45:15 <sharky93> ThomasWaldmann: with the current state, if a view like "somerandomstring" existed, it is not registered in path/location ..
85 2013-09-09T19:50:43 <ThomasWaldmann> the show view should add to trail, nothing else
86 2013-09-09T20:16:38 <ananasova> ThomasWaldmann: one more short refactoring - https://codereview.appspot.com/13301046/
87 2013-09-09T21:03:32 *** dave_largo
88 2013-09-09T21:28:10 * ananasova says good night
89 2013-09-09T23:36:59 *** bilal
90
