1 2013-09-08T07:05:00 <ananasova> moin
2 2013-09-08T07:49:33 <ananasova> ThomasWaldmann: please review when free - https://codereview.appspot.com/13239050/
3 2013-09-08T08:45:28 <sharky93> moin
4 2013-09-08T08:47:28 <ananasova> ThomasWaldmann: also made user subscriptions a little bit more user-friendly - https://codereview.appspot.com/13240047/
5 2013-09-08T08:54:47 <sharky93> TheSheep: have a look at the comment and transclusions buttons
6 2013-09-08T08:55:32 <TheSheep> ok
7 2013-09-08T08:57:22 <TheSheep> sharky93: it's not clear when it's on and when off
8 2013-09-08T08:57:33 <TheSheep> sharky93: also, a heading would be nice
9 2013-09-08T08:59:22 <TheSheep> sharky93: when it's grayed out, is it on or off?
10 2013-09-08T09:00:51 <sharky93> TheSheep: its on, when grayed out
11 2013-09-08T09:01:28 <TheSheep> so the comments and transclusions are off by default?
12 2013-09-08T09:01:42 <sharky93> yeah
13 2013-09-08T09:01:51 <TheSheep> how is the user supposed to know that grayed out means on?
14 2013-09-08T09:01:51 <sharky93> this screenshot shows the comment @ http://imagebin.org/270209
15 2013-09-08T09:02:41 <TheSheep> shouldn't they be under 'item navigation'?
16 2013-09-08T09:02:50 <sharky93> im not sure
17 2013-09-08T09:02:52 <TheSheep> they are not user actions
18 2013-09-08T09:03:29 <TheSheep> also, the 'user actions' heading is not displayed when you are not logged in
19 2013-09-08T09:03:40 <TheSheep> try logging out and see how it looks
20 2013-09-08T09:03:43 <sharky93> ah, right.
21 2013-09-08T09:04:27 <sharky93> TheSheep: we could change the text of the button, when its in the active state?
22 2013-09-08T09:04:38 <TheSheep> so either put it under one of the Item's headings, or make a special heading for it
23 2013-09-08T09:04:42 <sharky93> something like "Comments - ON"
24 2013-09-08T09:04:52 <TheSheep> or 'show comments' 'hide comments'
25 2013-09-08T09:05:06 <TheSheep> or better, 'comments shown' 'comments hidden'
26 2013-09-08T09:05:20 <sharky93> that is too long, no?
27 2013-09-08T09:05:35 <sharky93> we could render that in the "title"?
28 2013-09-08T09:05:43 <TheSheep> how about changing the icon?
29 2013-09-08T09:06:07 <TheSheep> have it crossed out when they are hidden
30 2013-09-08T09:07:45 <sharky93> hm that could work too
31 2013-09-08T09:08:43 <sharky93> TheSheep: is there an easy way to make a crossed out icon?
32 2013-09-08T09:12:36 <TheSheep> http://fortawesome.github.io/Font-Awesome/examples/#stacked
33 2013-09-08T09:13:53 *** ashutosh1461
34 2013-09-08T09:15:21 <TheSheep> sharky93: also, maybe use a different icon for the comments than for the discussion
35 2013-09-08T09:15:50 <TheSheep> maybe http://fortawesome.github.io/Font-Awesome/icon/comments/
36 2013-09-08T09:16:00 <TheSheep> or http://fortawesome.github.io/Font-Awesome/icon/comment-alt/
37 2013-09-08T09:20:01 <TheSheep> (I wounder if we could get the font awesome people to include MoinMoin icon...)
38 2013-09-08T09:20:05 <TheSheep> wonder*
39 2013-09-08T09:20:30 <TheSheep> also http://fortawesome.github.io/Font-Awesome/icon/sitemap/
40 2013-09-08T09:22:24 <TheSheep> for the sitemap
41 2013-09-08T09:22:32 <TheSheep> and for the 'highlight': http://fortawesome.github.io/Font-Awesome/icon/code/
42 2013-09-08T09:32:03 <sharky93> TheSheep: it starts looking odd have a look @ http://imagebin.org/270212
43 2013-09-08T09:35:34 <sharky93> i mean the the overlay of icon-ban..
44 2013-09-08T09:54:13 <ThomasWaldmann> ok, who's here?
45 2013-09-08T09:54:25 <ananasova> here
46 2013-09-08T09:54:46 <ThomasWaldmann> sharky93: your calendar has not been updated since 2 weeks. and i am really getting annoyed by this.
47 2013-09-08T09:55:20 <sharky93> TheSheep: because of the stack, it increases the container height and width too, it may be best to display a title, or search for a simple strikeout icon
48 2013-09-08T09:56:13 <sharky93> ThomasWaldmann: last week had exams, so was not able to work much, i started yesterday night, have not added that. sorry.
49 2013-09-08T09:56:49 <ThomasWaldmann> so the calender is uptodate, no work done since 2 weeks?
50 2013-09-08T09:57:09 <sharky93> no, not uptodate :(
51 2013-09-08T09:57:19 <ThomasWaldmann> ok, then no lame excuses
52 2013-09-08T09:57:55 <ashutosh1461> here
53 2013-09-08T09:58:21 <TheSheep> here
54 2013-09-08T09:58:54 <TheSheep> sharky93: isn't it because of your icon-fixed-width class?
55 2013-09-08T09:59:43 <sharky93> TheSheep: nope, its the stack, previously had faced that issue too.
56 2013-09-08T10:00:15 <ThomasWaldmann> ok, let's have a meeting now.
57 2013-09-08T10:00:25 <ThomasWaldmann> sharky93 / TheSheep please begin.
58 2013-09-08T10:01:21 <sharky93> ok
59 2013-09-08T10:02:04 <sharky93> Last week, DONE - some bug fixes, like fixing the alert on saving the editor
60 2013-09-08T10:02:36 <sharky93> Closed #42
61 2013-09-08T10:03:02 <sharky93> Had exams so not much other work
62 2013-09-08T10:03:40 <sharky93> Improved position for Comments and Transclusions, some trivial work remaining before we close on that
63 2013-09-08T10:03:59 <sharky93> TODO: add docs, work on the index view
64 2013-09-08T10:04:07 <sharky93> BLOCKERS: none
65 2013-09-08T10:04:12 <sharky93> EOF
66 2013-09-08T10:04:34 <ThomasWaldmann> well, there is still #59 open
67 2013-09-08T10:05:17 <ThomasWaldmann> https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/59/alert-on-closing-editor-wrong-text-and
68 2013-09-08T10:05:38 <sharky93> we'll need TheSheep 's comments there, that is too firefox specific, im not sure exactly why does it happen with that browser
69 2013-09-08T10:06:40 <ThomasWaldmann> also a ton of other open issues.
70 2013-09-08T10:09:41 <sharky93> hmm, that lists milestones too, basically shows what is our final target with this, i expect it will improve this week.
71 2013-09-08T10:09:48 <ThomasWaldmann> maybe as a general comment (to whoever feels the pattern matches to him/her): if you did not enough work the past weeks on SOC (due to whatever circumstances/reasons), it is now the time to impress us. there is one week left to do some hard work and another week to do some hard work cleaning up / finishing.
72 2013-09-08T10:13:21 <ThomasWaldmann> finishing means to bring your project into a good, usable state. it doesn't mean you can't continue working on your project after SOC (we would be very happy if you stayed with us), but for final evals, we only have to look at what was done while soc was running.
73 2013-09-08T10:13:50 <ThomasWaldmann> TheSheep: still there?
74 2013-09-08T10:16:50 <ThomasWaldmann> short comment about unclear state with buttons: I very often have the issue on misc. websites that there is some control element (e.g. a button) and I have no idea whether it is showing me the current state or what will happen when I click on it (which is often the opposite). I would appreciate if that is not the case for moin ui.
75 2013-09-08T10:18:07 <TheSheep> ThomasWaldmann: yes
76 2013-09-08T10:18:58 <TheSheep> ThomasWaldmann: as it is now, you basically have no idea which state is which
77 2013-09-08T10:19:20 <TheSheep> ThomasWaldmann: and since most pages don't have comments/inclusions, it can take a while to learn it
78 2013-09-08T10:19:50 <TheSheep> that's why I wanted a checkbox -- everybody understands checkboxes
79 2013-09-08T10:21:14 <sharky93> TheSheep: ThomasWaldmann pressed state doesnt make much sense? @ http://imagebin.org/270213 ..
80 2013-09-08T10:23:16 <ThomasWaldmann> it is somehow mixing up views and modifiers/settings for views
81 2013-09-08T10:23:41 <ThomasWaldmann> (see discussion 1 or 2 w ago)
82 2013-09-08T10:24:31 <TheSheep> we can put an additional heading
83 2013-09-08T10:24:40 <TheSheep> in that menu
84 2013-09-08T10:25:06 <sharky93> a heading named Toggle smth.. ?
85 2013-09-08T10:25:06 <TheSheep> like 'Item Details' or something?
86 2013-09-08T10:25:56 <ThomasWaldmann> View control?
87 2013-09-08T10:26:25 <sharky93> If we add "toggle" it makes it more obvious.
88 2013-09-08T10:26:30 <sharky93> imho.
89 2013-09-08T10:26:46 <ThomasWaldmann> or just "View" - that's used in many application menues to control how it looks like
90 2013-09-08T10:27:55 <ThomasWaldmann> ok, we can discuss details later also.
91 2013-09-08T10:28:14 <ThomasWaldmann> anything else from/to sharky93 / TheSheep ?
92 2013-09-08T10:28:39 * TheSheep no
93 2013-09-08T10:29:47 <ThomasWaldmann> ok, thanks to sharky93 / TheSheep. waldi, are you here?
94 2013-09-08T10:30:16 <ananasova> does that mean i go next?
95 2013-09-08T10:30:37 <ThomasWaldmann> no, it means whether waldi is here. :)
96 2013-09-08T10:31:16 <ThomasWaldmann> ok, he's not (yet?), so ashutosh1461 is next.
97 2013-09-08T10:31:47 <ashutosh1461> Done last two weeks:-
98 2013-09-08T10:31:48 <ashutosh1461> Added fqname support to history views.
99 2013-09-08T10:31:48 <ashutosh1461> Added UI to toggle b//w itemid and name based history views.
100 2013-09-08T10:31:48 <ashutosh1461> Started with testing/cleanup.
101 2013-09-08T10:31:48 <ashutosh1461> Blocker:-
102 2013-09-08T10:31:48 <ashutosh1461> Pending jek's comments, UI for editing names on hold.
103 2013-09-08T10:33:21 <ThomasWaldmann> if sync communications with jek don't work, try async communications, like email.
104 2013-09-08T10:34:17 <ashutosh1461> I sent him a message at bitbucket.
105 2013-09-08T10:34:20 <ThomasWaldmann> and we are only talking about the 1 past week in meetings, no need to repeat the previous week.
106 2013-09-08T10:35:31 <ashutosh1461> oh, I did not involve the work done in the previous week, the header is wrong.
107 2013-09-08T10:35:50 <ashutosh1461> i thought of adding it, as I did not had a meeting last week.
108 2013-09-08T10:36:12 <ashutosh1461> *Done This week
109 2013-09-08T10:36:49 * ThomasWaldmann needs to look at EP...
110 2013-09-08T10:37:26 <ThomasWaldmann> btw "cleanup..." is no good commit comment
111 2013-09-08T10:38:23 <ThomasWaldmann> is #18 still open?
112 2013-09-08T10:39:04 <ashutosh1461> yes, minor editing left.
113 2013-09-08T10:39:26 <ThomasWaldmann> please review all open bugs
114 2013-09-08T10:40:49 <ThomasWaldmann> i added some comments to your EP "things left" list yesterday, btw
115 2013-09-08T10:41:27 <ashutosh1461> #5, #14, #18 would be resolved in cleanup/merging.
116 2013-09-08T10:45:23 <ThomasWaldmann> ok. i would also like that you try to practically use the code you have written.
117 2013-09-08T10:46:01 <ThomasWaldmann> and while doing so, always consider where UI is missing or unintuitive, watch out for crashes or non-working stuff.
118 2013-09-08T10:47:09 <ThomasWaldmann> esp. for your main goals, using moin with itemids and namespaces.
119 2013-09-08T10:47:13 <ashutosh1461> ok fine.
120 2013-09-08T10:47:37 <ThomasWaldmann> (you need to setup multiple namespaces for that)
121 2013-09-08T10:47:51 <ThomasWaldmann> think of 2 departments of a company
122 2013-09-08T10:48:33 <ThomasWaldmann> look at how they can separate their stuff as well as work together / look at the other's stuff
123 2013-09-08T10:50:01 <ThomasWaldmann> what you also could do, is produce a total-work diff. from the start where you began working to the current state.
124 2013-09-08T10:50:48 <ThomasWaldmann> and then review it. find TODOs / XXX, find inconsistencies. make sure you didn't forget something.
125 2013-09-08T10:51:29 <ashutosh1461> sure.
126 2013-09-08T10:52:14 <ThomasWaldmann> you can alternatively try to create that big patch for google you'll need to submit later anyway.
127 2013-09-08T10:52:44 <ThomasWaldmann> (but it might be more stuff as it would include multiple edits on same stuff)
128 2013-09-08T10:53:20 <ashutosh1461> would submitting the total-work diff to google be fine ?
129 2013-09-08T10:53:33 <ThomasWaldmann> also try to catch up all the time lost on the past weeks.
130 2013-09-08T10:54:11 <ThomasWaldmann> ok, anything else for ashutosh1461 ?
131 2013-09-08T10:54:22 <ThomasWaldmann> waldi: are you with us?
132 2013-09-08T10:55:58 <ThomasWaldmann> seems he's busy on the phone...
133 2013-09-08T10:56:13 <ThomasWaldmann> ok, thanks ashutosh1461
134 2013-09-08T10:56:23 <ThomasWaldmann> ananasova: you're next, with or without waldi
135 2013-09-08T10:56:32 <ananasova> ok
136 2013-09-08T10:56:47 <ananasova> DONE:
137 2013-09-08T10:56:47 <ananasova> * Created a unified method for text diff and doing some additional changes to Text methods
138 2013-09-08T10:56:50 <ananasova> * Change the interface of get_subscribers and
139 2013-09-08T10:56:53 <ananasova> get_matched_subscription_patterns funcs - https://bitbucket.org/ana-balica/moin-2.0/commits/ec2029ab65856eba059692c405822e66b504e416
140 2013-09-08T10:56:56 <ananasova> * Update sending notifications functionality
141 2013-09-08T10:56:56 <ananasova> TODO next week:
142 2013-09-08T10:56:59 <ananasova> * Make user subscriptions settings more user-friendly - https://codereview.appspot.com/13240047/
143 2013-09-08T10:57:02 <ananasova> * Add DSN headers to sendmail
144 2013-09-08T10:57:04 <ananasova> * Create is_dsn_failure() func
145 2013-09-08T10:57:07 <ananasova> * Add documentation on pipeing incoming mails
146 2013-09-08T10:57:09 <ananasova> * Fix and close all the trivial issues from bb
147 2013-09-08T10:57:43 <ThomasWaldmann> i have no idea about that dsn stuff, is it clear enough to you what you have to do?
148 2013-09-08T10:58:54 <ananasova> yes, it's about checking the headers of the incoming mails, they have a specific Content-Type and also Action field
149 2013-09-08T11:00:15 <ThomasWaldmann> is it clear how to get the incoming mail and interface it to moin?
150 2013-09-08T11:00:36 <ananasova> yes, i will document that.
151 2013-09-08T11:00:42 <ThomasWaldmann> and how to test that?
152 2013-09-08T11:01:03 <ThomasWaldmann> (i mean practically, not unit tests)
153 2013-09-08T11:01:50 <ananasova> for testing one needs to setup an MTA on its machine and also configure it, which might be a bit problematic
154 2013-09-08T11:02:24 <ThomasWaldmann> the unified method, is that finished? thought there was some todo left...
155 2013-09-08T11:02:41 <ThomasWaldmann> if you need basic postfix configuration help, google or ask
156 2013-09-08T11:03:08 <ananasova> the todos are reflected in a separate cr
157 2013-09-08T11:03:52 <ThomasWaldmann> ah, just wondered about the "unified" and "DONE"
158 2013-09-08T11:04:09 <ananasova> ok, if i will face some extreme unclarities with postfix config, i will ask here :)
159 2013-09-08T11:04:45 <ananasova> hmmm. considered it done because i already use for generating mail notification message
160 2013-09-08T11:05:27 <ThomasWaldmann> having it work somehow and having it unified / consitent with other api is not necessarily the same thing
161 2013-09-08T11:05:49 <ananasova> ok, so it's work in progress
162 2013-09-08T11:06:38 <ThomasWaldmann> you also should go through your bugs in issue tracker
163 2013-09-08T11:06:59 <ananasova> yep
164 2013-09-08T11:09:14 <ThomasWaldmann> about the dsn mechanism, it is ok to document it for some usual usecase you can manage, like e.g. postfix
165 2013-09-08T11:10:04 <ThomasWaldmann> the mechanism itself should not only work on POSIX OSes, though, so try to create it in a way that can work on windows also
166 2013-09-08T11:10:28 <ananasova> ok, i will document it for postfix and there is also a universal way on linux systems to do that using .forward
167 2013-09-08T11:10:35 <ananasova> ohh windows...
168 2013-09-08T11:10:51 <ThomasWaldmann> yeah, I know it's a PITA :D
169 2013-09-08T11:11:29 <ThomasWaldmann> but sometimes, being generic / compatible is better than doing a posix-only quick hack
170 2013-09-08T11:13:29 <ThomasWaldmann> EP line 11
171 2013-09-08T11:14:26 <ThomasWaldmann> while EP gets enhanced, are there any other questions for ananasova ?
172 2013-09-08T11:15:50 <TheSheep> no questions from me
173 2013-09-08T11:16:20 <TheSheep> we should really do that, waiting for everyone to say something takes too long
174 2013-09-08T11:16:32 <TheSheep> I mean, we should say that we have nothing to say
175 2013-09-08T11:21:28 <ThomasWaldmann> :)
176 2013-09-08T11:21:57 <ThomasWaldmann> ok, no meeting-questions from me either, but i will discuss some stuff with ananasova on EP now.
177 2013-09-08T11:22:14 <ThomasWaldmann> thanks for attending the meeting, meeting is over.
178 2013-09-08T13:04:36 <sharky93> ThomasWaldmann: this @ https://bitbucket.org/thomaswaldmann/moin-2.0/src/56ca9d2dcfc912ad042d5a791a3163ff5a7669df/MoinMoin/templates/itemviews.html?at=default#cl-84 suggests that suppose i'm @ /HomePage/Discussion, i dont want to render the 'Discussion' item in the bar, but how does the User know its a discussion page for "Home" ?
179 2013-09-08T13:04:45 <sharky93> TheSheep: ^
180 2013-09-08T13:05:30 <sharky93> ThomasWaldmann: TheSheep are we depending on the content added to that page?
181 2013-09-08T13:10:47 <TheSheep> for now just leave it as it was
182 2013-09-08T13:10:56 <sharky93> sure.
183 2013-09-08T13:11:20 <TheSheep> in the future we might want to have something like "back to page" or such
184 2013-09-08T13:13:56 <sharky93> TheSheep: we can close #3 too, now?
185 2013-09-08T13:23:00 <TheSheep> sharky93: as long as you remember to fix the index page too
186 2013-09-08T13:23:04 <ThomasWaldmann> if you are at Homepage/Discussion, it is rather obvious from location for what the discussion is
187 2013-09-08T13:24:24 <TheSheep> ThomasWaldmann: the problem is that you click on an item in the menu, and it disappears
188 2013-09-08T13:24:31 <TheSheep> ThomasWaldmann: at least that's the first impression
189 2013-09-08T13:24:49 <TheSheep> ThomasWaldmann: it would be nice to have it replaced by something, as to avoid the confusion
190 2013-09-08T13:25:05 <TheSheep> even if it's just a link to the page itself
191 2013-09-08T13:25:12 <TheSheep> just highlighted
192 2013-09-08T13:25:33 *** ashutosh1461
193 2013-09-08T13:27:08 <ThomasWaldmann> ah, ok
194 2013-09-08T13:27:25 <ThomasWaldmann> btw, later it might be same-name in other namespace, not subpage
195 2013-09-08T13:51:20 <sharky93> ThomasWaldmann: your view on @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/65/site-map-and-index-are-views
196 2013-09-08T13:52:28 <sharky93> TheSheep: what happens to "Discussion" in context with #65?
197 2013-09-08T13:59:59 <sharky93> TheSheep: also #46 is done, no?
198 2013-09-08T14:11:11 <ThomasWaldmann> updated 65
199 2013-09-08T14:17:12 <sharky93> ThomasWaldmann: the question still remains, site map and index are views, should we render them in the main horizontal tab?
200 2013-09-08T14:18:44 <sharky93> i think maybe not SiteMap but only Index ..
201 2013-09-08T14:27:56 <TheSheep> sharky93: why not site map?
202 2013-09-08T14:28:09 <TheSheep> sharky93: site map only displays partial site map starting at that item
203 2013-09-08T14:28:17 <TheSheep> not the global one for the whole website
204 2013-09-08T14:30:07 <sharky93> TheSheep: but Site Map in a way helps in item navigation, no? ..
205 2013-09-08T14:31:50 <TheSheep> sharky93: if we remove sitemap and index, then there is only discussion left in that section
206 2013-09-08T14:32:13 <waldi> ThomasWaldmann: now i'm back. family called
207 2013-09-08T14:33:49 <sharky93> TheSheep: do you suggest getting rid of that section altogether?
208 2013-09-08T14:34:31 <TheSheep> no point having a section with a single item
209 2013-09-08T14:37:26 <sharky93> true
210 2013-09-08T14:38:11 <TheSheep> though I would then put the discussion link on the left side, with all other page links
211 2013-09-08T14:40:12 <TheSheep> then it wouldn't be so confusing
212 2013-09-08T14:40:27 <sharky93> but discussion is not a global link
213 2013-09-08T14:40:40 <TheSheep> yeah, it would need to say Home/Discussion
214 2013-09-08T14:40:44 <TheSheep> or such
215 2013-09-08T14:42:48 <TheSheep> I don't know, maybe you have a better idea
216 2013-09-08T14:44:31 <sharky93> TheSheep: how about moving the Item Navigation menu to the left.
217 2013-09-08T14:44:49 <sharky93> so its like, "Site Navigation" and "Item Navigation" one below the other on the left..
218 2013-09-08T14:44:56 <TheSheep> yeah
219 2013-09-08T14:45:14 <sharky93> and "User Actions", "Item Actions" and "View Options" on the right. ..
220 2013-09-08T14:45:50 <TheSheep> but then again you have a section with just one item
221 2013-09-08T14:46:53 *** ebo^
222 2013-09-08T14:47:01 <sharky93> we could then leave Index and Site Map within that.. in some sense they are Item Navigations right?, like we have an "Index" in Site Navigation.. we'll have an "Index" in Item Navigation ..
223 2013-09-08T14:47:34 <TheSheep> but Index and SiteMap are not links to pages
224 2013-09-08T14:47:34 <sharky93> should make sense, i guess
225 2013-09-08T14:47:45 <sharky93> hmm ..
226 2013-09-08T14:47:54 <TheSheep> you would have two items highlighted at the same time in the left menu then
227 2013-09-08T14:48:10 <TheSheep> for example, Home and Index, when displaying Index for Home
228 2013-09-08T14:49:21 <sharky93> TheSheep: we do the highlight by the URL .. for Index for Home .. the url will be "/+index/Home" .. so "/Home" will not be highlighted
229 2013-09-08T14:49:39 <sharky93> TheSheep: just like we have for SiteMap currently
230 2013-09-08T14:49:57 <TheSheep> that's bad
231 2013-09-08T14:50:05 <TheSheep> because it *should* be highlighted
232 2013-09-08T14:51:18 <sharky93> ok :) even then, highlight for two items in the left menu will only be for one special case.. i.e the "/Home"
233 2013-09-08T14:52:25 <TheSheep> the highlighting itself is not the problem, it just highlights the logical problem that these two belong to two categories
234 2013-09-08T14:53:05 <TheSheep> SiteMap is some special view generated for that particular item, while Discussion is a whole separate page
235 2013-09-08T14:57:34 <TheSheep> we have a clear hierarchy here:
236 2013-09-08T14:57:37 <TheSheep> we have pages
237 2013-09-08T14:57:43 <TheSheep> those pages have different views
238 2013-09-08T14:57:54 <TheSheep> and those views have various actions you can perform on them
239 2013-09-08T14:58:19 <TheSheep> or with them
240 2013-09-08T14:59:35 <ThomasWaldmann> waldi: was just because of the gsoc meeting you missed (again)
241 2013-09-08T15:03:36 <sharky93> TheSheep: hmm, its just another subpage but with special importance, such that it needs to be displayed everytime ..
242 2013-09-08T15:03:39 * sharky93 in a fix
243 2013-09-08T15:04:13 <TheSheep> I would say just like RecentChanges or HelpContent
244 2013-09-08T15:05:29 <TheSheep> btw, when gsoc is over I want to try making a theme that would have most of this in the footer
245 2013-09-08T15:11:31 <sharky93> TheSheep: maybe get rid of the heading, just the "Discussion" floating on the right side?
246 2013-09-08T15:11:41 <sharky93> separate from the rest
247 2013-09-08T15:14:12 <TheSheep> a single-item section sounds better
248 2013-09-08T15:15:31 <TheSheep> I suppose it's the best we have so far
249 2013-09-08T15:16:05 <sharky93> TheSheep: you too mean getting rid of the heading right? :)
250 2013-09-08T15:16:23 <TheSheep> no, heading and a single item below it
251 2013-09-08T15:16:27 <TheSheep> on the left side
252 2013-09-08T15:17:10 <TheSheep> that link is called "Supplementation" or something, so we could use that name, then people will have easier time guessing what that option in settings does
253 2013-09-08T15:17:19 <TheSheep> just remember to make it translatable
254 2013-09-08T15:18:09 <TheSheep> by the way, you do remmeber about adding all the new translatable strings to that pyhton file?
255 2013-09-08T15:18:34 <TheSheep> any new strings that you use in js, that is
256 2013-09-08T15:19:47 <sharky93> hmm
257 2013-09-08T15:21:05 <sharky93> btw which option in settings?
258 2013-09-08T15:21:30 <TheSheep> cfg.supplementation_item_names
259 2013-09-08T15:21:40 <TheSheep> oh, you can have more than one
260 2013-09-08T15:22:14 <TheSheep> that gives that section more sense!
261 2013-09-08T15:23:30 <sharky93> \o/
262 2013-09-08T15:28:58 <TheSheep> ThomasWaldmann: by the way, is that a word from German?
263 2013-09-08T15:29:04 <TheSheep> ThomasWaldmann: it's awfully long :P
264 2013-09-08T15:30:30 <TheSheep> I would just use "extra", but that's me
265 2013-09-08T15:32:53 <TheSheep> [Middle English, from Old French, from Latin supplmentum, from supplre, to complete;]
266 2013-09-08T15:32:57 <TheSheep> hmm
267 2013-09-08T15:42:00 <ThomasWaldmann> no, not from german. it means directly-related other supporting items
268 2013-09-08T15:42:21 <ThomasWaldmann> extra items has less than that meaning, right?
269 2013-09-08T15:42:37 <TheSheep> auxiliary :)
270 2013-09-08T15:43:08 <ThomasWaldmann> that's fine. is that easier/better?
271 2013-09-08T15:43:23 <TheSheep> no
272 2013-09-08T15:43:25 <TheSheep> http://words.bighugelabs.com/supplement
273 2013-09-08T15:43:27 <TheSheep> let's see
274 2013-09-08T15:43:57 <TheSheep> appurtance ;)
275 2013-09-08T15:44:37 <ThomasWaldmann> first of course there was the idea to just configure the name of the discussion item, but that was too special as you can use all sorts of supplementary pages. discussion, comment, notes, whatever
276 2013-09-08T15:44:54 <ThomasWaldmann> i have never read appurtance before :)
277 2013-09-08T15:45:34 <TheSheep> just kidding
278 2013-09-08T15:46:37 <TheSheep> the simplest I can see is "addition"
279 2013-09-08T15:47:09 <TheSheep> but "additional item names" would sound like you are adding more names
280 2013-09-08T15:47:53 <TheSheep> there is appendix which at least has familiar root
281 2013-09-08T15:49:42 <TheSheep> addon
282 2013-09-08T15:53:18 <TheSheep> unnecessary \o/
283 2013-09-08T15:53:58 <TheSheep> no better option, it seems
284 2013-09-08T16:03:14 <ThomasWaldmann> we had thought a while back then before choosing supplementary and also didn't find a really better one
285 2013-09-08T16:20:00 <sharky93> TheSheep: what do we name it finally then?
286 2013-09-08T16:31:18 <TheSheep> just leave it like it is
287 2013-09-08T16:31:23 <TheSheep> supplementation
288 2013-09-08T16:33:31 <sharky93> TheSheep: i pushed the commit, have a look
289 2013-09-08T16:36:28 <TheSheep> the icon seems out of place there
290 2013-09-08T16:37:09 <TheSheep> especially since other supplementation pages might be for other things than discussion
291 2013-09-08T16:37:41 <TheSheep> like review, or scores, or citation sources, etc.
292 2013-09-08T16:37:51 <sharky93> hmm, removing icon.
293 2013-09-08T16:37:53 <TheSheep> whatever people configure their wikis for
294 2013-09-08T16:38:15 <TheSheep> also, can you call the section "Supplementation" instead of "Item Navigation"?
295 2013-09-08T16:39:02 <TheSheep> the index page doesn't display the tabs
296 2013-09-08T16:40:26 <sharky93> yeah, i havent touched the index page.
297 2013-09-08T16:40:33 <sharky93> infact next is that.
298 2013-09-08T16:40:47 <TheSheep> by the way, are those section names translatable?
299 2013-09-08T16:41:11 <sharky93> yeah, its in the macro
300 2013-09-08T16:41:43 <TheSheep> ok
301 2013-09-08T16:41:53 <TheSheep> no, wait
302 2013-09-08T16:41:55 <TheSheep> not ok
303 2013-09-08T16:42:02 <TheSheep> how is gettext going to pick that?
304 2013-09-08T16:42:21 <TheSheep> it has to be in the same place where you use the string
305 2013-09-08T16:42:37 <sharky93> in the macro i have {{ _(variablename) }}
306 2013-09-08T16:42:37 <TheSheep> so it has to be _("some string") and not _(some_variable)
307 2013-09-08T16:42:48 <TheSheep> how is gettext going to extract the text to translate?
308 2013-09-08T16:43:09 <sharky93> it cannot use the variable?
309 2013-09-08T16:43:13 * sharky93 checks
310 2013-09-08T16:43:20 <TheSheep> how would it know what it contains?
311 2013-09-08T16:43:30 <TheSheep> it would need to execute the program for that
312 2013-09-08T16:43:45 <TheSheep> and to try all possible code paths to get all possible values
313 2013-09-08T16:43:49 <sharky93> hmm, right, nice catch.
314 2013-09-08T16:48:39 <sharky93> TheSheep: but its working!
315 2013-09-08T16:49:40 <TheSheep> only because those strings are already translated
316 2013-09-08T16:51:59 <TheSheep> sharky93: isn't "similar" also a tab?
317 2013-09-08T16:52:13 <TheSheep> once you are moving stuff around :)
318 2013-09-08T16:52:57 <sharky93> xD
319 2013-09-08T16:55:59 * sharky93 is happy atleast the current code makes it easy to move stuff around :)
320 2013-09-08T16:58:29 <sharky93> TheSheep: similar moved to the tabs :)
321 2013-09-08T17:27:24 <sharky93> TheSheep: i've run into a problem, on Saving after changing the theme from "Wiki Appearance" in Settings, since the theme has changed, it renders the "Wiki Appearance" form section from the new theme, where as rest everything is from the basic theme !
322 2013-09-08T17:27:41 <sharky93> TheSheep: try chnanging the theme from Basic to something else, you'll see
323 2013-09-08T17:27:55 <sharky93> TheSheep: any ideas how to fix this
324 2013-09-08T17:40:38 *** xorAxAx
325 2013-09-08T17:41:24 *** xorAxAx
326 2013-09-08T21:07:21 *** ebo^
327 2013-09-08T22:01:18 *** jek_
328 2013-09-08T22:07:05 *** jek
329 2013-09-08T22:07:06 *** xorAxAx
330 2013-09-08T22:07:07 *** xjjk
331 2013-09-08T22:07:07 *** eSyr
332 2013-09-08T22:18:35 *** xorAxAx
333 2013-09-08T22:19:21 *** eSyr
334 2013-09-08T22:19:33 *** xjjk
335
