1 2013-09-01T00:02:11 *** ashutosh1461
2 2013-09-01T06:34:52 <ananasova> moin
3 2013-09-01T06:42:30 <ananasova> ThomasWaldmann: are you talking about diff method for different Content types? in that case we need to add methods for diff to those classes
4 2013-09-01T06:46:27 <ananasova> there are methods that render diffs, which is not exactly what we need.
5 2013-09-01T07:24:44 <sharky93> moin
6 2013-09-01T07:26:51 <sharky93> ThomasWaldmann: bad health :( i will try to complete the backlog asap.
7 2013-09-01T09:09:52 <sharky93> is it a good habit to refer to commits from comments in the code?
8 2013-09-01T09:47:55 <ThomasWaldmann> sharky93: can be done (using the changeset hash), for what do you need it?
9 2013-09-01T09:48:56 <sharky93> ThomasWaldmann: i was wondering if i add a reference to sheeps comment on some earlier commit to the version that fixed it.
10 2013-09-01T09:49:00 <ThomasWaldmann> waldi: TheSheep: ananasova: sharky93: ashutosh1461: meeting soon
11 2013-09-01T09:49:12 <ananasova> here since morning
12 2013-09-01T09:49:47 <waldi> yep
13 2013-09-01T09:49:56 <sharky93> ThomasWaldmann: added a comment @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/60/wrong-navigate-away-warning
14 2013-09-01T09:50:11 <ThomasWaldmann> sharky93: looking up something via the repo is some effort. maybe just telling it directly is easier.
15 2013-09-01T09:51:27 <ananasova> waldi: got some questions. shall we use .forward for mail import and should I write a script for setting it's contents or just document it how to do it?
16 2013-09-01T09:51:28 <ThomasWaldmann> also, if it is a COMMENT on a commit, then it is a bitbucket feature and not part of the repo, you shouldn't rely on that
17 2013-09-01T09:52:16 <sharky93> sure, i added it as a comment withint the code.
18 2013-09-01T09:55:07 <TheSheep> moin
19 2013-09-01T09:56:23 <sharky93> TheSheep: added some replies to your comments, you might have got notifications :)
20 2013-09-01T09:56:30 <waldi> ananasova: not sure what you mean. .forward is outside of the domain of moin. you must not write stuff outside of /tmp, /var/tmp or the specified directories
21 2013-09-01T09:57:23 <ananasova> got it. then it's the admin responsability to set up the forwarding
22 2013-09-01T09:57:41 <dreimark> moin
23 2013-09-01T09:58:58 <ananasova> waldi: are we implementing the idea with encoding the uid to FROM field? or you another idea?
24 2013-09-01T10:00:14 <ananasova> you have*
25 2013-09-01T10:01:50 <ThomasWaldmann> ananasova: maybe discuss that later
26 2013-09-01T10:02:01 <ananasova> sure, it's meeting time.
27 2013-09-01T10:02:08 <ThomasWaldmann> ok, let's begin with the meeting.
28 2013-09-01T10:02:20 <ThomasWaldmann> ananasova / waldi are first, your stage.
29 2013-09-01T10:02:27 <ananasova> ok
30 2013-09-01T10:02:42 <ananasova> DONE:
31 2013-09-01T10:02:42 <ananasova> * Create send_notification receiver function
32 2013-09-01T10:02:42 <ananasova> * Context manager for temporary locale in flask-babel
33 2013-09-01T10:02:43 <ananasova> * Investing on mail import
34 2013-09-01T10:03:06 <ananasova> TODO next week:
35 2013-09-01T10:03:06 <ananasova> * Update user notification form
36 2013-09-01T10:03:06 <ananasova> * Finish with sending notifications
37 2013-09-01T10:03:07 <ananasova> * Add DSN headers to sendmail
38 2013-09-01T10:04:03 <ThomasWaldmann> can you give a link for first item?
39 2013-09-01T10:04:23 <ThomasWaldmann> did you receive feedback from mitsuhiko for 2nd?
40 2013-09-01T10:04:37 <ananasova> https://codereview.appspot.com/12745048/ the last patch
41 2013-09-01T10:05:19 <ananasova> no, channel is silent, same is with issues on github
42 2013-09-01T10:06:10 <ThomasWaldmann> did you leave a comment on gh?
43 2013-09-01T10:06:20 <ananasova> yes
44 2013-09-01T10:07:02 <ThomasWaldmann> btw, in that CR, i still see phrases relying on english word order, you likely won't be able to translate this to all languages
45 2013-09-01T10:08:25 <ananasova> can you point me?
46 2013-09-01T10:08:48 <ThomasWaldmann> notifications.py line 61+
47 2013-09-01T10:09:51 <ThomasWaldmann> hmm, no, not that problem, but other: i don't think extract_messages can deal with that way
48 2013-09-01T10:09:59 <waldi> the whole string needs to be translated
49 2013-09-01T10:10:12 <ThomasWaldmann> yup, directly.
50 2013-09-01T10:11:01 <ananasova> i will try to generate the a *.po file, and if it doesn't extract the way we need, i will change it
51 2013-09-01T10:12:03 <ThomasWaldmann> ok
52 2013-09-01T10:12:26 <ThomasWaldmann> with receiver you mean event receiver, right?
53 2013-09-01T10:13:05 <ananasova> yes, event receiver related to blink signals
54 2013-09-01T10:13:28 <ThomasWaldmann> can you give more details about what you did about mail import?
55 2013-09-01T10:14:47 <ThomasWaldmann> and can you tell whether notifications now practically work?
56 2013-09-01T10:18:21 <ananasova> i was looking at different ways to pipe incoming mails to a script. like moin1.9 had xmlrpc, then read about curl. some MTA have their own mechanism for pipeing. also .forward is the most easy way.
57 2013-09-01T10:19:11 <ThomasWaldmann> ok, so you could write some short docs about what's needed in the end
58 2013-09-01T10:19:34 <ananasova> notifications practically work, but there are important problems to solve - determining subscribers for deleted items and creating a content diff that will work for any content type
59 2013-09-01T10:19:51 <ThomasWaldmann> ok
60 2013-09-01T10:20:07 <ananasova> yes, i also left short notes on EP about pipeing
61 2013-09-01T10:20:41 <ThomasWaldmann> another thing about notifications.py - you give "app" to send_notifications. can't it just directly use app with the usual "from flask import current_app as app"?
62 2013-09-01T10:21:49 <ananasova> it can, but it seems a bit strange why the signal is sending that param.
63 2013-09-01T10:22:32 <ThomasWaldmann> well, does it / should it?
64 2013-09-01T10:22:59 <ananasova> there is also another event receiver func in signalling/log.py which makes use of app as a param. but at the same time it also can just import the app directly
65 2013-09-01T10:23:33 <ThomasWaldmann> ok, so it needs to be considered as a global refactoring later maybe.
66 2013-09-01T10:23:53 <ananasova> i probably should change that behaviour for all signal emitters and receivers
67 2013-09-01T10:24:03 <ThomasWaldmann> separate cs then
68 2013-09-01T10:24:14 <ananasova> i am putting it down in issue tracker to not forget accidently
69 2013-09-01T10:24:42 <ThomasWaldmann> what does "update user notification form" mean for next week?
70 2013-09-01T10:25:33 <ananasova> oh it's based on an issue you left - the itemid:<hash> is not user-friendly at all, need to change it
71 2013-09-01T10:26:02 <ThomasWaldmann> so you mean the user setting's subscription editor?
72 2013-09-01T10:26:24 <ananasova> yes.
73 2013-09-01T10:26:50 <ThomasWaldmann> ok. any other questions to/from ananasova / waldi ?
74 2013-09-01T10:27:24 <ananasova> i have a question
75 2013-09-01T10:28:38 <ThomasWaldmann> sharky93 / TheSheep you're next after ananasova / waldi have finished.
76 2013-09-01T10:29:03 <ThomasWaldmann> ashutosh still not here...
77 2013-09-01T10:29:19 <ananasova> what do we display in notification mail if the content type is not "diffable", like a binary file? or if we have an image diff, which can be rendered with PIL? shall we include the image in the mail or give just the URL to the diff on Moin?
78 2013-09-01T10:30:23 <ThomasWaldmann> it would be nice to have some unified diff method(s) on the item that can be used for mail and web
79 2013-09-01T10:31:34 <ThomasWaldmann> but for images, i wouldn't got that far as to include a computed difference image in the email, just a link to web ui in that case.
80 2013-09-01T10:31:42 <dreimark> ananasova: don't make hight traffic with those mails
81 2013-09-01T10:32:00 <dreimark> don't send large files
82 2013-09-01T10:32:11 <ananasova> ok, good point
83 2013-09-01T10:33:48 <ThomasWaldmann> so maybe it could be some generic methods for: a) create html diff content b) create text diff content c) create a link to web diff UI
84 2013-09-01T10:34:42 <ThomasWaldmann> and then 2 handler methods for email and web ui that choose to call a/b/c depending on item type and practical considerations
85 2013-09-01T10:35:28 <ananasova> ok, i will sketch it on EP before implementing
86 2013-09-01T10:35:40 <ThomasWaldmann> ok, anything else?
87 2013-09-01T10:35:42 <ananasova> no
88 2013-09-01T10:36:42 <ThomasWaldmann> sharky93: TheSheep: your stage. thanks to ananasova / waldi.
89 2013-09-01T10:38:33 <sharky93> ok
90 2013-09-01T10:38:36 <sharky93> Schedule still behind
91 2013-09-01T10:38:36 <sharky93> Added various views, login, highlight, meta, rename, delete, destroy.
92 2013-09-01T10:38:36 <sharky93> Fixed a broken unsubscribe. (do we also want to keep track, which commit broke a certain function?)
93 2013-09-01T10:38:37 <dreimark> hmm, also ascii art from images could helpful
94 2013-09-01T10:38:39 <sharky93> User Settings view added
95 2013-09-01T10:38:42 <sharky93> Removed a wrong method of trying to style "required fields" (hardcoding css class into it)
96 2013-09-01T10:38:45 <sharky93> TODO:
97 2013-09-01T10:38:47 <sharky93> Get the already commited stuff reviewed and close milestones on the tracker
98 2013-09-01T10:38:50 <sharky93> Fix basic issues to get the repo in a better state
99 2013-09-01T10:38:52 <sharky93> Work on Global and Local Indexes
100 2013-09-01T10:38:55 <sharky93> BLOCKERS:
101 2013-09-01T10:38:57 <sharky93> None
102 2013-09-01T10:41:09 <ThomasWaldmann> i looked at some commits yesterday. a note about these templates: if you have copied them from main template directory to modify them for bs3, you should have done 2 commits:
103 2013-09-01T10:41:39 <ThomasWaldmann> first, adding the file as copied, commit, second modifying the file for bs, commit
104 2013-09-01T10:41:58 <ThomasWaldmann> like it is now, the adaption for bs is not easily visible
105 2013-09-01T10:43:59 <sharky93> oh, hmm, but is that much important?
106 2013-09-01T10:44:05 <ThomasWaldmann> about finding out which commit broke something: you can do that if you like, might be useful to avoid breaking it again
107 2013-09-01T10:44:36 <ThomasWaldmann> it's not a big effort and easier to review.
108 2013-09-01T10:45:04 <ThomasWaldmann> it's same for copy and rename btw. newer combine that with addtl. changes.
109 2013-09-01T10:45:49 <ThomasWaldmann> because it is effectively hiding those addtl. changes from review...
110 2013-09-01T10:46:20 <ThomasWaldmann> never*
111 2013-09-01T10:46:30 <sharky93> sure, i'll keep that in mind
112 2013-09-01T10:46:48 <ThomasWaldmann> you've seen the new issues i file yesterday?
113 2013-09-01T10:47:20 <sharky93> yes, i made a comment on one, @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/60/wrong-navigate-away-warning
114 2013-09-01T10:47:48 <sharky93> TheSheep: your thoughts on #62?
115 2013-09-01T10:48:35 <TheSheep> I don't have a web browser here, so all I can tell right now is that it's a nice number
116 2013-09-01T10:48:37 * ThomasWaldmann answered there
117 2013-09-01T10:49:26 <ThomasWaldmann> thesheep: "menu headings don't look like such"
118 2013-09-01T10:50:13 <ThomasWaldmann> it's a style/usability issue
119 2013-09-01T10:50:21 <TheSheep> that's not a very important problem, they can be easily styled
120 2013-09-01T10:50:43 <ThomasWaldmann> yeah, if it is so easy, it can be just fixed and closed. :P
121 2013-09-01T10:51:28 <TheSheep> if you'd rather have that fixed than something more important, then sure
122 2013-09-01T10:52:07 <ThomasWaldmann> if it is easy, then it doesn't matter as it is done quickly
123 2013-09-01T10:52:12 <TheSheep> I'm more worried about the growing number of additionnal toolbars and buttons
124 2013-09-01T10:52:47 <ThomasWaldmann> the breadcrumbs are still 2, there's an issue about making it 1
125 2013-09-01T10:53:24 <TheSheep> the comments/inclusion ones should be removed too
126 2013-09-01T10:53:50 <TheSheep> especially since they are in the page content area
127 2013-09-01T10:54:02 <ThomasWaldmann> and how would one trigger that function then?
128 2013-09-01T10:54:22 <TheSheep> from one of the existing toolbars
129 2013-09-01T10:54:54 <TheSheep> no need to add a separate one
130 2013-09-01T10:55:18 <ThomasWaldmann> you mean adding it to the right vertical toolbar?
131 2013-09-01T10:55:38 <TheSheep> that's one option
132 2013-09-01T10:56:09 <sharky93> TheSheep: since its a toggle, would it be better to keep it separate, we dont have toggles in the right vertical bar.?
133 2013-09-01T10:56:26 <ThomasWaldmann> yeah, was just thinking the same
134 2013-09-01T10:56:49 <TheSheep> do as you wish
135 2013-09-01T10:56:59 <ThomasWaldmann> the reason for removing it from top horiz. views bar was that it is not a separate view, but just modifies the show view
136 2013-09-01T10:57:26 <ThomasWaldmann> that's somehow same problem for the right toolbar...
137 2013-09-01T10:58:35 <ThomasWaldmann> could it be hierarchically below "show" somehow, like:
138 2013-09-01T10:58:38 <ThomasWaldmann> * show
139 2013-09-01T10:58:47 <ThomasWaldmann> * comments
140 2013-09-01T10:58:53 <ThomasWaldmann> * transclusions
141 2013-09-01T11:00:33 <sharky93> ThomasWaldmann: that is similar to only rendering the toggles in the show view, no?
142 2013-09-01T11:00:38 <sharky93> which is the case now.
143 2013-09-01T11:01:17 <ThomasWaldmann> logically yes, but looks better if not done in the content area
144 2013-09-01T11:01:38 <ThomasWaldmann> we should keep the content area clean, so people can focus on the content
145 2013-09-01T11:02:19 <sharky93> maybe rendering square icons for the toggles, rather than whole text buttons would help, no?
146 2013-09-01T11:02:24 <sharky93> TheSheep: ^
147 2013-09-01T11:02:58 <ThomasWaldmann> you mean checkmarks?
148 2013-09-01T11:04:57 <sharky93> not exactly. something that makes sense with the content, like we have the dialog box icon for "Discussion", star icon for "Favourites", something like that, with the actual meaning onFocuse..
149 2013-09-01T11:05:49 <ThomasWaldmann> ah, so JUST some icon, no text?
150 2013-09-01T11:06:42 <sharky93> yeah
151 2013-09-01T11:06:58 <ThomasWaldmann> could be hard to find a good icon for "toggle comments" or "toggle transclusions"
152 2013-09-01T11:07:44 <sharky93> the checkbox would do the expressing the meaning that it is a toggle .. what we want are icons for comments, and transclusions..
153 2013-09-01T11:08:04 <sharky93> makes sense?
154 2013-09-01T11:08:30 <ThomasWaldmann> i wouldn't combine the checkbox and the only-icons approach
155 2013-09-01T11:09:08 <ThomasWaldmann> either a checkbox at the left of some small-print text, or a icon that changes appearance
156 2013-09-01T11:09:47 <ThomasWaldmann> or doing "show" sub-items in the right toolbar for these toggles
157 2013-09-01T11:10:10 <ThomasWaldmann> TheSheep: any comment / anything else?
158 2013-09-01T11:10:49 <sharky93> ThomasWaldmann: TheSheep something like this @ http://imagebin.org/269446 ..
159 2013-09-01T11:13:54 <ThomasWaldmann> https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/33/theme-element-arrangement-ideas-visualized btw, that approach has much less stacks of toolbars
160 2013-09-01T11:16:26 <ThomasWaldmann> sharky93: that's a bit better, but it's still sitting on top of the content, pushing it downwards
161 2013-09-01T11:17:05 <ThomasWaldmann> also, that big blue button is rather heavy compared to the rest
162 2013-09-01T11:18:13 <ThomasWaldmann> maybe a dropdown menu attached to "Show" would be best UI
163 2013-09-01T11:19:00 <ThomasWaldmann> doesn't clutter the screen except if you really need it
164 2013-09-01T11:19:19 <sharky93> hmm, we'll need to discuss that, maybe when TheSheep is more free
165 2013-09-01T11:20:52 <ThomasWaldmann> yeah. ok, anything else for sharky93 / TheSheep ?
166 2013-09-01T11:21:38 <ThomasWaldmann> ashutosh still missing, so he has to grab me at some other time.
167 2013-09-01T11:22:41 <sharky93> ThomasWaldmann: i think https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/60/wrong-navigate-away-warning this is fixed by the latest commit, if you confirm, i can close it
168 2013-09-01T11:25:13 <ThomasWaldmann> yeah, close it
169 2013-09-01T11:26:40 <ThomasWaldmann> sharky93: doing calendar stuff days later is strongly discuraged
170 2013-09-01T11:26:56 <ThomasWaldmann> DO GET THIS SORTED :(
171 2013-09-01T11:30:57 <sharky93> i will. that shouldn't happen again.
172 2013-09-01T11:32:10 <ThomasWaldmann> meeting is over, thanks for attending.
173 2013-09-01T11:34:33 <sharky93> TheSheep: around when will you be a bit more free?
174 2013-09-01T11:39:45 <ananasova> waldi: are we implementing the idea with encoding the uid to FROM field? or you have another idea?
175 2013-09-01T12:49:12 * ananasova tried to extract messages and indeed it doesn't work for notifications, so we'll have quite some duplication
176 2013-09-01T13:02:04 <ThomasWaldmann> maybe you can just have a global list / dict of all of these, so they sit right besides each other
177 2013-09-01T13:02:10 <ThomasWaldmann> ananasova: ^
178 2013-09-01T13:06:04 <ananasova> should i put them as in notification class or somewhere appart?
179 2013-09-01T13:15:39 <ThomasWaldmann> keep it in same module where you use it
180 2013-09-01T13:15:52 <ThomasWaldmann> either class attr or global, whatevers fits best
181 2013-09-01T13:44:33 <ananasova> ThomasWaldmann: fixed the strings - https://codereview.appspot.com/12745048/patch/37001/38002
182 2013-09-01T13:44:55 <ananasova> tested and the messages are extracted ok
183 2013-09-01T14:11:16 <ThomasWaldmann> ananasova: as you used a new codereview, i only commented on the messages part
184 2013-09-01T17:58:53 *** eSyr_
185
