MoinMoin: MoinMoinChat/Logs/moin-dev/2013-08-21

   1 2013-08-21T03:38:50  *** sharky93` has quit IRC
   2 2013-08-21T08:11:54  *** spy_ has quit IRC
   3 2013-08-21T08:12:01  *** spy_ has joined #moin-dev
   4 2013-08-21T09:01:38  *** greg_f has joined #moin-dev
   5 2013-08-21T12:58:59  *** dave_largo has joined #moin-dev
   6 2013-08-21T15:46:49  <sharky93> moin
   7 2013-08-21T15:50:50  <ThomasWaldmann> hi sharky93
   8 2013-08-21T16:16:58  <sharky93> ThomasWaldmann: is there a way to detect if the user has unsaved changes, while the modify view is open?
   9 2013-08-21T16:18:09  <ThomasWaldmann> well, i guess you could trigger some js event as soon as something changes and alert the user if he navigates away afterwards.
  10 2013-08-21T16:18:28  <ThomasWaldmann> but, you could also just always alert him if he navigates away from an open editor
  11 2013-08-21T16:18:47  <ThomasWaldmann> there is some code for that in moin 1.9 iirc
  12 2013-08-21T16:19:07  <sharky93> hmm, an alert like "Did you save your changes?", on navigating away from an open editor, works i think
  13 2013-08-21T16:19:29  <ThomasWaldmann> see there
  14 2013-08-21T16:20:11  <ThomasWaldmann> (and asking for saving changes in case there were no changes is wrong...)
  15 2013-08-21T16:21:39  <sharky93> yes, that is why 'Did you save your changes' is more general and does not suggest that there were changes, no?
  16 2013-08-21T16:22:32  <sharky93> TheSheep: ^
  17 2013-08-21T16:28:35  <ThomasWaldmann> did you look at moin 1.9 code?
  18 2013-08-21T16:29:05  <sharky93> yes, just had a look.
  19 2013-08-21T16:30:39  <ThomasWaldmann> (the code i meant is somehow not active on moinmo.in, either it is dysfunctional or gone in current version, not sure - but we had that feature at some time)
  20 2013-08-21T16:31:16  <sharky93> weird. it works for me
  21 2013-08-21T16:31:39  <ThomasWaldmann> how did you trigger it?
  22 2013-08-21T16:31:53  <sharky93> i get alerts if i try to close the tab with the editor open with me having pressed atleast a key inside the editor
  23 2013-08-21T16:32:29  <ThomasWaldmann> i don't
  24 2013-08-21T16:33:06  * sharky93 is using chromium
  25 2013-08-21T16:33:26  <ThomasWaldmann> ah, no. THAT works. but you don't get a warning if you just click some link in the footer to navigate away.
  26 2013-08-21T16:34:35  * ThomasWaldmann gtg
  27 2013-08-21T17:03:20  *** greg_f has quit IRC
  28 2013-08-21T17:03:46  *** greg_f has joined #moin-dev
  29 2013-08-21T17:08:22  *** greg_f has quit IRC
  30 2013-08-21T17:10:11  *** greg_f has joined #moin-dev
  31 2013-08-21T17:15:28  *** greg_f has quit IRC
  32 2013-08-21T17:16:32  *** greg_f has joined #moin-dev
  33 2013-08-21T17:51:55  *** greg_f has quit IRC
  34 2013-08-21T18:05:24  <ananasova> ThomasWaldmann: i have updates the cr and also left some comments - https://codereview.appspot.com/12745048
  35 2013-08-21T18:06:48  <ananasova> also have a question: if the user has no 'mail' metadata, but has 'email_unvalidated' meta set, should we use that email for sending notifications?
  36 2013-08-21T18:20:20  <ananasova> waldi: i have tested the log-to-mail functionality and i can't reproduce your error. can you please give more details on the bb tracker?
  37 2013-08-21T18:26:33  <sharky93> have a look @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/51/alert-on-closing-the-editor-with-unsaved
  38 2013-08-21T19:29:37  *** ashutosh1461 has joined #moin-dev
  39 2013-08-21T20:45:26  *** dave_largo has quit IRC
  40 2013-08-21T23:56:32  *** ashutosh1461 has quit IRC
  41