1 2013-08-18T06:25:52 <ananasova> moin
2 2013-08-18T06:26:45 <ananasova> ThomasWaldmann: can you please take a look at this issue? https://bitbucket.org/ana-balica/moin-2.0/issue/7/get_subscribers-fails-extracting-locale
3 2013-08-18T08:47:04 <sharky93> moin
4 2013-08-18T08:47:43 <sharky93> TheSheep: should i close #21?
5 2013-08-18T08:49:38 <TheSheep> sharky93: yes, it looks much better now
6 2013-08-18T08:58:31 * sharky93 closed #21
7 2013-08-18T09:00:24 <sharky93> TheSheep: i think a similar navbar (like at the top) would work for the footer?
8 2013-08-18T09:00:56 <TheSheep> sure
9 2013-08-18T09:01:18 <TheSheep> sharky93: by the way, there hsould be a button in the search form
10 2013-08-18T09:01:23 <TheSheep> should
11 2013-08-18T09:01:36 <TheSheep> sharky93: because some people need to have something to click
12 2013-08-18T09:02:08 <sharky93> hmm, right :)
13 2013-08-18T09:06:13 <sharky93> TheSheep: for #24, how do we adjust the size?
14 2013-08-18T09:06:57 <TheSheep> add a column to it?
15 2013-08-18T09:07:41 <TheSheep> sharky93: I was also thinking about moving it to the left side, as per #33
16 2013-08-18T09:07:43 <sharky93> TheSheep: i think that makes the core text area much smaller, we might have to try to customise it
17 2013-08-18T09:07:46 <sharky93> im not sure
18 2013-08-18T09:07:56 <TheSheep> https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue-attachment/33/sharky93/moin-2.0-bootstrap/1376175366.91/33/moin2.png
19 2013-08-18T09:12:44 <sharky93> hmm
20 2013-08-18T09:13:06 <sharky93> TheSheep: surely much space is wasted with the left navbar
21 2013-08-18T09:13:41 <TheSheep> we have infinite space vertically though
22 2013-08-18T09:13:54 <TheSheep> and reading text that stretches through all the width of your monitor is not nice
23 2013-08-18T09:14:24 <TheSheep> for optimal readig you want from 11 to 15 words per line
24 2013-08-18T09:14:40 <TheSheep> Germans like slightly longer lines, because they have many long words
25 2013-08-18T09:15:21 <sharky93> TheSheep: we also have two buttons in Comments and Trasnclusions to adjust in the UI
26 2013-08-18T09:15:47 <TheSheep> I've seen that you made some commits with that
27 2013-08-18T09:16:57 <sharky93> TheSheep: those commits just make it functional, no change in their position
28 2013-08-18T09:17:25 <sharky93> and as you suggested i opened a separate issue to fix their position
29 2013-08-18T09:18:03 <TheSheep> sharky93: with well written templates, changing their position would be just a question of moving them from one list to another
30 2013-08-18T09:18:44 <sharky93> right :)
31 2013-08-18T09:19:07 <TheSheep> that's why I wanted you to refactor it
32 2013-08-18T09:20:28 <sharky93> hmm
33 2013-08-18T09:46:00 <sharky93> TheSheep: i added a footer, please have a look
34 2013-08-18T09:51:46 <TheSheep> ugh
35 2013-08-18T09:51:58 <TheSheep> sharky93: make it white
36 2013-08-18T09:52:05 <TheSheep> sharky93: and the icons need adjusting
37 2013-08-18T09:52:39 <TheSheep> sharky93: also, the links need to be made into menu links
38 2013-08-18T09:56:01 <sharky93> TheSheep: menu links?
39 2013-08-18T09:56:06 *** ashutosh1461
40 2013-08-18T09:56:51 <sharky93> oh fish, i forgot to add my snippet file :P
41 2013-08-18T09:57:04 * sharky93 shakes head
42 2013-08-18T09:59:22 <ThomasWaldmann> moin
43 2013-08-18T09:59:33 <ashutosh1461> moin
44 2013-08-18T09:59:37 <ThomasWaldmann> who's here?
45 2013-08-18T09:59:37 <sharky93> TheSheep: have a look now, should be better :)
46 2013-08-18T10:00:46 <TheSheep> what are the dots there for?
47 2013-08-18T10:01:07 <TheSheep> by the way, the html doesn't validate
48 2013-08-18T10:01:19 <ThomasWaldmann> ok, welcome to today's meeting. ashutosh1461 please begin.
49 2013-08-18T10:01:37 <ThomasWaldmann> and sharky93 please prepare.
50 2013-08-18T10:01:58 * sharky93 pauses discussion about footer
51 2013-08-18T10:02:16 <ashutosh1461> ONE LAST WEEK:
52 2013-08-18T10:02:16 <ashutosh1461> -> Finished trash view commited code
53 2013-08-18T10:02:16 <ashutosh1461> -> Added identifier namespace 'all' changed related code, will commit today
54 2013-08-18T10:02:16 <ashutosh1461> -> Commited work done on misc views (adding multiple & fqname functionality)
55 2013-08-18T10:02:16 <ashutosh1461> -> Added validation for namespaces
56 2013-08-18T10:02:16 <ashutosh1461> TODO NEXT WEEK
57 2013-08-18T10:02:18 <ashutosh1461> -> start with the history view.
58 2013-08-18T10:03:07 <ThomasWaldmann> ananasova: dreimark: eSyr: waldi: meeting time
59 2013-08-18T10:03:15 <ananasova> here :)
60 2013-08-18T10:04:15 <ThomasWaldmann> trash view is finished?
61 2013-08-18T10:04:55 <ashutosh1461> you said ok to this https://codereview.appspot.com/12560043/
62 2013-08-18T10:05:45 <ThomasWaldmann> ok to a codereview means that there are no additional comments to the code presented.
63 2013-08-18T10:07:12 * ThomasWaldmann runs the code in parallel
64 2013-08-18T10:07:43 <ThomasWaldmann> did you add the specific namespace and "all" functionality everywhere?
65 2013-08-18T10:09:04 <ashutosh1461> I added it to history, tags and deleted views
66 2013-08-18T10:09:28 <ashutosh1461> the orphans, wanted and some other are left.
67 2013-08-18T10:10:00 <ThomasWaldmann> ok, so please care for all views where it applies
68 2013-08-18T10:10:36 <ThomasWaldmann> https://bitbucket.org/ashu1461/moin-2.0/commits/880f995b9d0b605ef8b7fbd84a4a9e2483cea172 set_root is undocumented
69 2013-08-18T10:12:12 <ashutosh1461> I thought it was clear from the if statement what we are doing, will add a comment.
70 2013-08-18T10:14:27 <ThomasWaldmann> and also think about whether that is a good method
71 2013-08-18T10:15:31 <ThomasWaldmann> btw, afaics there is no check whether the storage configuration accidentally uses "all" as namespace
72 2013-08-18T10:15:32 <ashutosh1461> i thought about it, could not find any other alternative.
73 2013-08-18T10:16:12 <ashutosh1461> i added a validator
74 2013-08-18T10:16:13 <ThomasWaldmann> well, as long as it is unclear, i can't help
75 2013-08-18T10:16:59 <ThomasWaldmann> but the validator does not check that (and that check maybe should be somewhere else)
76 2013-08-18T10:17:35 <ashutosh1461> the validator ensures that namespace belongs to namespace_mapping given in the config
77 2013-08-18T10:17:56 <ashutosh1461> since there is no entry for 'all' there, it will raise an error.
78 2013-08-18T10:18:51 <ashutosh1461> also i added a restriction on items to use identifier namespaces as names.
79 2013-08-18T10:19:25 <ThomasWaldmann> a admin could have the idea that it is nice to have namespaces for reasearch, marketing and all.
80 2013-08-18T10:19:36 <ThomasWaldmann> and configure that.
81 2013-08-18T10:21:05 <ThomasWaldmann> btw, last week was also rather little activity, although you said you want to catch up.
82 2013-08-18T10:22:57 <ashutosh1461> ThomasWaldmann, I am trying hard, there were some college assignments to do, so i got lesser time to contribute :( .
83 2013-08-18T10:24:05 <ThomasWaldmann> anyone else questions for ashutosh1461 / me?
84 2013-08-18T10:24:57 <TheSheep> ashutosh1461: you say you are going to work on the history view next?
85 2013-08-18T10:25:05 <ThomasWaldmann> ashutosh1461: trash view is not reachable via UI btw
86 2013-08-18T10:25:20 <TheSheep> ashutosh1461: because that's also what sharky93 works on now
87 2013-08-18T10:25:31 <ashutosh1461> TheSheep, ok i will discuss it with sharky
88 2013-08-18T10:25:46 <ashutosh1461> my work is to make history view accessible through itemid also.
89 2013-08-18T10:27:32 <sharky93> hmm, should not be much different for me
90 2013-08-18T10:27:52 <TheSheep> I suppose the urls will change
91 2013-08-18T10:27:56 <TheSheep> and that's it
92 2013-08-18T10:27:58 <ThomasWaldmann> ashutosh1461: +trash view didn't work for me when trying it practically. created Home item, deleted it, nothing on +trash view.
93 2013-08-18T10:28:37 * ashutosh1461 tries out
94 2013-08-18T10:29:15 <ashutosh1461> ThomasWaldmann, it is working for me
95 2013-08-18T10:30:12 <ThomasWaldmann> tried again, doesn't work. +trash is saying Total: 0
96 2013-08-18T10:30:35 <ThomasWaldmann> ok, any other questions?
97 2013-08-18T10:31:08 <ThomasWaldmann> ok, thanks ashutosh1461, sharky / TheSheep are next.
98 2013-08-18T10:31:42 <ThomasWaldmann> eSyr: dreimark: btw, did you look at xiaq's / spy_'s code?
99 2013-08-18T10:31:52 <sharky93> ok
100 2013-08-18T10:32:25 <sharky93> Meeting
101 2013-08-18T10:32:25 <sharky93> Visible work was done in the later half of the week
102 2013-08-18T10:32:25 <sharky93> Work started with refactoring with local panel and the tabs
103 2013-08-18T10:32:25 <sharky93> Many bug fixes throughout.
104 2013-08-18T10:32:25 <sharky93> TODO:
105 2013-08-18T10:32:28 <sharky93> I'm a bit behind schedule so need to pick it up
106 2013-08-18T10:32:30 <sharky93> Finalise the history view
107 2013-08-18T10:32:33 <sharky93> BLOCKERS:
108 2013-08-18T10:32:35 <sharky93> None
109 2013-08-18T10:33:00 <sharky93> EOF
110 2013-08-18T10:33:22 <TheSheep> sharky93: did you try to set the milestones in the bitbucket issue tracker?
111 2013-08-18T10:33:48 <sharky93> oh, that is TODO as well :(
112 2013-08-18T10:34:44 <TheSheep> sharky93: I can do it, if you give me admin rights to your repo
113 2013-08-18T10:35:11 <sharky93> sure
114 2013-08-18T10:35:51 <ThomasWaldmann> and please put a footer on that TODO, too
115 2013-08-18T10:36:03 <sharky93> TheSheep: you're the admin
116 2013-08-18T10:36:23 <ThomasWaldmann> #26
117 2013-08-18T10:36:49 <sharky93> ThomasWaldmann: yes, hte issue-tracker is always the TODO
118 2013-08-18T10:37:00 <ThomasWaldmann> #23 no comment yet
119 2013-08-18T10:43:26 <ThomasWaldmann> sharky93: the Timestamp column in +history/XXX looks wider than needed
120 2013-08-18T10:43:47 <ThomasWaldmann> can we have that better fitting and more spaces for comment column?
121 2013-08-18T10:43:52 <ThomasWaldmann> space*
122 2013-08-18T10:44:46 <sharky93> ThomasWaldmann: yes, that needs work as well as the content-type
123 2013-08-18T10:45:13 <sharky93> TheSheep: ThomasWaldmann i was thinking maybe display the content-type onhover for the revision?
124 2013-08-18T10:45:37 <sharky93> something along these lines, so that we can save two big columns! and a lot of space
125 2013-08-18T10:45:47 <ThomasWaldmann> for c-t i somehow envision a filter that shortens it and uses terms that normal users understand, putting the precise c-t into mouse-over
126 2013-08-18T10:46:09 <sharky93> :D
127 2013-08-18T10:46:29 <ThomasWaldmann> but not putting it onto something else
128 2013-08-18T10:47:57 <ThomasWaldmann> ok, any more questions for sharky93 / thesheep?
129 2013-08-18T10:47:59 <sharky93> hmm, we can even club columns together, maybe? the shortened c-t could be clubbed with revision?
130 2013-08-18T10:49:14 <ThomasWaldmann> in the end, the "Name" column might go. because we select for either that or itemid.
131 2013-08-18T10:50:08 <ashutosh1461> ThomasWaldmann, the TRASH key entry was missing in the repo, fixed it. the trash view should now work fine.
132 2013-08-18T10:50:44 <ThomasWaldmann> ok, looks like nothing more for sharky93 / TheSheep. thanks to both, ananasova / waldi are next.
133 2013-08-18T10:50:52 <ananasova> ok
134 2013-08-18T10:50:55 <ananasova> DONE:
135 2013-08-18T10:50:55 <ananasova> * Update HTML notification templates
136 2013-08-18T10:50:55 <ananasova> * Created plain text notification template - https://codereview.appspot.com/13051043/
137 2013-08-18T10:50:58 <ananasova> * Tweak sendmail() function to send multipart emails - https://codereview.appspot.com/12927043/
138 2013-08-18T10:51:01 <ananasova> * Sending notification functionality (in progress, needs more tests, no cr atm)
139 2013-08-18T10:51:06 <ananasova> TODO next week:
140 2013-08-18T10:51:06 <ananasova> * User notification form in settings
141 2013-08-18T10:51:06 <ananasova> * Bugfixing (admin emails, getting subscribers)
142 2013-08-18T10:51:07 <ananasova> * Bounce handling planning
143 2013-08-18T10:51:19 <ananasova> BLOCKERS: none
144 2013-08-18T10:52:39 <ThomasWaldmann> that bounce handling planning is overdue since weeks...
145 2013-08-18T10:52:57 <ThomasWaldmann> waldi: ^
146 2013-08-18T10:54:44 <ThomasWaldmann> waldi: https://codereview.appspot.com/12927043/ that is waiting for a comment from you since almost 4d
147 2013-08-18T10:57:12 <ananasova> also a comment here would be really helpful - https://bitbucket.org/ana-balica/moin-2.0/issue/5/log-to-mail-crash-and-burns
148 2013-08-18T10:57:18 <ThomasWaldmann> ananasova: i think he means nothing else than utf-8 makes sense.
149 2013-08-18T10:57:48 <ThomasWaldmann> but iirc CHARSET *is* utf-8 and likely won't change, so this is rather a stylistic change.
150 2013-08-18T10:59:16 <ThomasWaldmann> ananasova: just search for logging calls inside log code?
151 2013-08-18T11:00:00 <ThomasWaldmann> bug reads clear enough for me, although it is a bit unspecific about precise location in the code.
152 2013-08-18T11:00:20 <ananasova> it makes sense to have utf-8, then what is the problem with setting the charset there?
153 2013-08-18T11:01:04 <ThomasWaldmann> CHARSET could change, then it would not be utf-8 any more. unlikely, but not nice style.
154 2013-08-18T11:01:49 <ananasova> it is clear to me to, but i can't reproduce it. i have tried manually to raise exceptions in the code, and i am getting a traceback emailed. that is the reason i kindly ask for some extra details
155 2013-08-18T11:06:24 <ThomasWaldmann> put that into the bug report
156 2013-08-18T11:06:33 <ananasova> ok
157 2013-08-18T11:06:35 <ThomasWaldmann> https://codereview.appspot.com/13051043/ review done
158 2013-08-18T11:06:52 <ThomasWaldmann> any questions for ananasova and waldi? waldi, are you with us?
159 2013-08-18T11:10:27 <ThomasWaldmann> ananasova: as that planning didn't work yet, I suggest you create a doodle to allocate a 2h meeting with waldi and send it to him via email. meeting should be for bounce planning primarily and maybe other planning activities afterwards.
160 2013-08-18T11:11:32 <ananasova> ok, doodle for the next week, and preferably asap
161 2013-08-18T11:11:36 <ThomasWaldmann> also, you please do some research on the topic, so you are prepared for it and you can ask good questions.
162 2013-08-18T11:11:50 <ananasova> will do
163 2013-08-18T11:14:10 <ThomasWaldmann> ananasova: https://codereview.appspot.com/13051043/ there i only see the template added. where is the code changed so it is used?
164 2013-08-18T11:15:33 <ananasova> locally, i need to add better test coverage and then post a cr.
165 2013-08-18T11:15:43 <ananasova> also there is a problem to be solved
166 2013-08-18T11:16:03 <ananasova> if an item is deleted, then we need to find a way to get this item subscribers
167 2013-08-18T11:16:32 <ThomasWaldmann> you mean if it has no names?
168 2013-08-18T11:16:41 <ananasova> yes
169 2013-08-18T11:17:07 <ThomasWaldmann> assuming you could create that item, would you subscribers code then be able to do that?
170 2013-08-18T11:17:46 <ThomasWaldmann> (if you don't have a unit test for empty names, maybe add one)
171 2013-08-18T11:18:35 <ThomasWaldmann> because ashutosh1461 has been working on creating items by itemid, that works for nameless items, too
172 2013-08-18T11:18:55 <ananasova> get_subscribers fails for NonExistent items, because it tries to extract some metadata
173 2013-08-18T11:19:07 <ThomasWaldmann> anyone else with questions for ananasova / waldi ?
174 2013-08-18T11:19:57 <ThomasWaldmann> yeah, because it is a dummy. that might get resolved after merge with ashutosh1461's code.
175 2013-08-18T11:20:26 <ThomasWaldmann> maybe create an issue for that so we don't forget
176 2013-08-18T11:21:04 <ananasova> ok, i will create an issue, and also a TODO in the code
177 2013-08-18T11:22:08 <ThomasWaldmann> https://bitbucket.org/ana-balica/moin-2.0/commits/all i don't see any commits there since almost a week, bad.
178 2013-08-18T11:22:29 <ThomasWaldmann> do you have locally committed stuff?
179 2013-08-18T11:22:46 <ThomasWaldmann> or is it all in CR?
180 2013-08-18T11:23:00 <ananasova> all in cr
181 2013-08-18T11:23:45 <ThomasWaldmann> ok, so please try to get them resolved asap. if waldi doesn't respond here, send him a mail with all the urls.
182 2013-08-18T11:24:17 <ThomasWaldmann> and cc me.
183 2013-08-18T11:24:29 <ananasova> got it
184 2013-08-18T11:25:12 <ThomasWaldmann> ok, if there are no other questions, i guess we are through for today. thanks for attending, happy hacking! :)
185 2013-08-18T11:27:14 <ThomasWaldmann> ashutosh1461: https://bitbucket.org/ashu1461/moin-2.0/commits/880f995b9d0b605ef8b7fbd84a4a9e2483cea172 so, why do we want to create an item with name u'' ?
186 2013-08-18T11:28:22 <ashutosh1461> index view creates item with name u''
187 2013-08-18T11:28:56 <ThomasWaldmann> i guess to determine "subitems"?
188 2013-08-18T11:29:39 <ashutosh1461> yes
189 2013-08-18T11:29:55 <ThomasWaldmann> so why did you need to introduce that flag?
190 2013-08-18T11:30:23 <ashutosh1461> the u'' gets converted to u'Home' which is the default root.
191 2013-08-18T11:32:01 <ThomasWaldmann> so u'' is given to that method as name (it is not using the default), right?
192 2013-08-18T11:33:23 <ashutosh1461> yes, index calls Item.create(u'') and u'' gets converted to u'Home' in the create func as it is instructed to convert empty names to their default roots
193 2013-08-18T11:33:32 <ronny> sup
194 2013-08-18T11:33:47 <ashutosh1461> i introduced a flag to prevent this from happening
195 2013-08-18T11:35:24 <ThomasWaldmann> the questions is, if one needs such hacks to get stuff working, whether we are doing something wrong / at the wrong place
196 2013-08-18T11:36:43 <ThomasWaldmann> maybe you could investige if that change from '' -> 'Home' maybe just should happen somewhere else and Item.create should use the name "as is"
197 2013-08-18T11:36:53 <ThomasWaldmann> investigate*
198 2013-08-18T11:37:22 <ThomasWaldmann> moin ronny
199 2013-08-18T11:39:05 <ashutosh1461> maybe we can overwrite constructor for fqname and to it there.
200 2013-08-18T11:39:43 <ashutosh1461> do*
201 2013-08-18T11:51:30 <ThomasWaldmann> feels like much too deep in there
202 2013-08-18T11:51:51 <ThomasWaldmann> isn't it like a redirect in the view functions rather?
203 2013-08-18T12:10:09 <ashutosh1461> what kind of redirect ?
204 2013-08-18T12:13:18 <ThomasWaldmann> like / -> /Home
205 2013-08-18T12:13:31 <ThomasWaldmann> http
206 2013-08-18T12:48:09 <ashutosh1461> hmm, good idea, we can redirect in the show function itself, instead of doing it in the Item.create.
207 2013-08-18T13:03:32 <ThomasWaldmann> (and then you can maybe just call show from the root url view handler...)
208 2013-08-18T13:04:17 <ThomasWaldmann> or change the rule, so it just makes the root url handler superfluous
209 2013-08-18T13:19:24 <ThomasWaldmann> TheSheep: use just .hll / .c / ... for the pygments css files or add some additional class like .syntax?
210 2013-08-18T13:19:44 <ThomasWaldmann> currently we have it without
211 2013-08-18T13:22:08 <TheSheep> ThomasWaldmann: just pygaments/[theme name].css I think
212 2013-08-18T13:22:15 <TheSheep> pygments
213 2013-08-18T13:22:53 <TheSheep> they are not language-specific
214 2013-08-18T13:32:11 <ThomasWaldmann> that wasn't about language, but about additional class for more specific selection
215 2013-08-18T13:38:41 <TheSheep> 'highlight' or 'pyments' I suppose
216 2013-08-18T13:38:46 <TheSheep> pygments
217 2013-08-18T13:40:04 <ThomasWaldmann> https://pypi.python.org/pypi/XStatic-Pygments/1.6.0.1 (that is still without the additional class, maybe we can switch to that with a separate cs)
218 2013-08-18T13:40:09 <ThomasWaldmann> sharky93: ^^
219 2013-08-18T13:52:51 <ThomasWaldmann> TheSheep: as we don't have that styles merged into the main css any more, it means 1 additional http request
220 2013-08-18T13:53:08 <TheSheep> ThomasWaldmann: yes, but cached
221 2013-08-18T13:53:32 <TheSheep> ThomasWaldmann: also, I wonder if we could merge it into the theme while building it
222 2013-08-18T13:53:37 <TheSheep> ThomasWaldmann: from the less files
223 2013-08-18T13:53:53 <ThomasWaldmann> then we wouldn't need the xstatic ;)
224 2013-08-18T13:54:09 <ThomasWaldmann> but that shouldn't hold us back
225 2013-08-18T13:54:25 <TheSheep> ThomasWaldmann: it's nice to be able to do both, so that it's easier to make new themes
226 2013-08-18T14:18:08 <sharky93> bbl
227 2013-08-18T18:25:39 *** ashutosh1461
228 2013-08-18T22:12:09 <dreimark> moin
229 2013-08-18T22:12:14 * dreimark readed backlog
230 2013-08-18T22:12:29 <dreimark> sorry for missing the meeting - too much different things happened
