1 2013-08-13T05:24:00  *** rciorba has joined #moin-dev
   2 2013-08-13T06:34:42  *** rciorba has quit IRC
   3 2013-08-13T08:01:33  <ananasova> moin :)
   4 2013-08-13T08:53:05  *** vpv_ is now known as vpv
   5 2013-08-13T09:20:21  *** greg_f has joined #moin-dev
   6 2013-08-13T09:26:19  <ThomasWaldmann> moin
   7 2013-08-13T09:29:06  <ThomasAH> ThomasWaldmann: moin! I just noticed an incompatibility with python2.5 at http://hg.intevation.org/mirrors/moinmo.in/moin/1.9/file/default/MoinMoin/script/account/resetpw.py#l132  (I use hg.intevation.org to have the line highlighted)
   8 2013-08-13T09:29:16  <ThomasAH> ThomasWaldmann: with open(text_file) as f:
   9 2013-08-13T10:03:06  <ThomasWaldmann> ThomasAH: so what's the problem?
  10 2013-08-13T10:03:48  <ThomasAH> ThomasWaldmann: 'moin account resetpw' aborts with a Syntax Error, because the "with ...:" syntax does not exist in python2.5
  11 2013-08-13T10:04:36  <ThomasWaldmann> http://docs.python.org/2/whatsnew/2.5.html#pep-343-the-with-statement
  12 2013-08-13T10:04:49  <ThomasAH> ThomasWaldmann: hmm, I'll recheck
  13 2013-08-13T10:06:26  <ThomasAH> File "/home/moin-foobar/instance/MoinMoin/script/account/resetpw.py", line 132   with open(text_file) as f:   SyntaxError: invalid syntax  (and a ^ pointing to the "n" of "open")
  14 2013-08-13T10:06:42  <ThomasAH> python2.5.2 on that host is the only installed python version
  15 2013-08-13T10:08:03  <ThomasAH> same error with manually entering "with open('.bashrc') as f:" on a machine with python2.5.5 (works with 2.6)
  16 2013-08-13T10:08:16  <ThomasAH> ThomasWaldmann: ah!  from __future__ import with_statement
  17 2013-08-13T10:08:27  <ThomasWaldmann> oh, oops
  18 2013-08-13T10:09:36  <ThomasWaldmann> ThomasAH: could you run ./pytest from the toplevel dir?
  19 2013-08-13T10:10:13  <ThomasAH> ThomasWaldmann: yes ... 1.9.7 or tip?
  20 2013-08-13T10:11:41  <ThomasWaldmann> if you can easily do: tip
  21 2013-08-13T10:11:57  <ThomasWaldmann> (with your old python)
  22 2013-08-13T10:12:29  <ThomasAH> running with 2ce7eb7299a1 now
  23 2013-08-13T10:14:37  <ThomasAH> ThomasWaldmann: ================== 1092 passed, 72 skipped in 137.22 seconds ===================
  24 2013-08-13T10:18:08  <ThomasWaldmann> ThomasAH: pushed a fix for 2.5
  25 2013-08-13T10:18:18  <ThomasWaldmann> (2 places found)
  26 2013-08-13T10:26:28  <ThomasAH> ThomasWaldmann: looks good,   find * -name '*.py'|xargs grep -l '^ *with.*: *$'|xargs grep -L with_statement   only found one other place and that is only a comment
  27 2013-08-13T10:40:33  *** xjjk has quit IRC
  28 2013-08-13T10:41:06  * ThomasWaldmann did a similar search :)
  29 2013-08-13T10:46:33  *** xjjk has joined #moin-dev
  30 2013-08-13T11:44:41  <ThomasWaldmann> ThomasAH: thanks for discovering this, fix will be in 1.9.8
  31 2013-08-13T12:25:06  *** ashutosh1461 has joined #moin-dev
  32 2013-08-13T12:30:40  <ThomasAH> ThomasWaldmann: thanks for accepting bug reports on IRC and fixing the issue :)
  33 2013-08-13T12:36:54  *** dave_largo has joined #moin-dev
  34 2013-08-13T12:40:11  <ashutosh1461> moin
  35 2013-08-13T13:14:54  *** dave_largo has quit IRC
  36 2013-08-13T13:31:30  *** xorAxAx has quit IRC
  37 2013-08-13T13:32:11  *** xorAxAx has joined #moin-dev
  38 2013-08-13T13:35:01  *** xorAxAx has quit IRC
  39 2013-08-13T13:35:40  *** xorAxAx has joined #moin-dev
  40 2013-08-13T15:51:53  *** dave_largo has joined #moin-dev
  41 2013-08-13T16:44:29  *** brunomartin has joined #moin-dev
  42 2013-08-13T17:11:30  *** rciorba has joined #moin-dev
  43 2013-08-13T17:12:57  *** bilal has joined #moin-dev
  44 2013-08-13T17:21:18  *** greg_f has quit IRC
  45 2013-08-13T17:22:46  *** bilal has quit IRC
  46 2013-08-13T17:29:34  *** bilal has joined #moin-dev
  47 2013-08-13T17:45:48  *** bilal has quit IRC
  48 2013-08-13T17:58:54  <ashutosh1461> hi ThomasWaldmann
  49 2013-08-13T18:27:55  <ThomasWaldmann> moin ashutosh1461. if you just tell, you save time.
  50 2013-08-13T18:28:47  <ashutosh1461> ThomasWaldmann, why do want to trash comments/ threaded comments ?
  51 2013-08-13T18:28:56  <ashutosh1461> as i dont have much idea about how the comment system works
  52 2013-08-13T18:29:04  <ThomasWaldmann> please read my comments precisely.
  53 2013-08-13T18:43:44  <ashutosh1461> ThomasWaldmann, cannot get a clear idea.
  54 2013-08-13T18:44:36  <ThomasWaldmann> give urls
  55 2013-08-13T18:45:40  <ashutosh1461> https://codereview.appspot.com/12560043/diff/40001/MoinMoin/items/__init__.py
  56 2013-08-13T18:48:56  <ThomasWaldmann> so, where did i say i want to trash comment items?
  57 2013-08-13T18:51:25  <ashutosh1461> on EP, if an item is without names (AND not intentionally created/kept so, e.g. for threaded comment system, that uses nameless items), we set the TRASH flag to indicate that it is not needed any more.if an item is without names (AND not intentionally created/kept so, e.g. for threaded comment system, that uses nameless items), we set the TRASH flag to indicate that it is not needed any more.
  58 2013-08-13T18:56:57  <ThomasWaldmann> give urls
  59 2013-08-13T18:58:29  <ThomasWaldmann> and comment items ARE intentionally created without names. maybe read the sentence again.
  60 2013-08-13T18:59:50  <ashutosh1461> http://etherpad.osuosl.org/moin-itemid
  61 2013-08-13T19:00:09  <ThomasWaldmann> comments = nameless items that must not get trashed just because they are nameless.
  62 2013-08-13T19:01:00  <ashutosh1461> exactly, so which are nameless items that can be trashed ?
  63 2013-08-13T19:01:10  <ashutosh1461> the items which we are deleting manually ?
  64 2013-08-13T19:01:22  <ThomasWaldmann> dealing with such stuff correctly was the whole point of introducing a separate flag btw and not just using the empty name list to determine whether it is trash or not..
  65 2013-08-13T19:02:38  <ThomasWaldmann> if you remove the last name from an item, then set the trash flag
  66 2013-08-13T19:03:37  * ThomasWaldmann brb
  67 2013-08-13T19:36:19  <ananasova> ThomasWaldmann: is it ok to tweek sendmail function to send also html mails by setting content-type to text/html or better create a different function?
  68 2013-08-13T19:39:21  <ananasova> tweak*
  69 2013-08-13T20:06:32  <ThomasWaldmann> you should try modifying existing code rather than duplicating it.
  70 2013-08-13T20:08:49  <ThomasWaldmann> esp. if the modification is simple and rather a generalization
  71 2013-08-13T20:09:25  <ananasova> alright
  72 2013-08-13T20:44:26  *** bilal has joined #moin-dev
  73 2013-08-13T20:59:45  *** rciorba has left #moin-dev
  74 2013-08-13T21:19:37  *** eSyr has quit IRC
  75 2013-08-13T21:19:47  *** eSyr has joined #moin-dev
  76 2013-08-13T21:20:36  *** dave_largo has quit IRC
  77 2013-08-13T21:24:22  <ashutosh1461> ThomasWaldmann, updated https://codereview.appspot.com/12560043/
  78 2013-08-13T21:33:22  <ThomasWaldmann> ashutosh1461: done
  79 2013-08-13T21:38:12  <ThomasWaldmann> found one more issue
  80 2013-08-13T21:39:24  * ashutosh1461 just found the same issue while testing
  81 2013-08-13T21:40:25  * ashutosh1461 writes a unit test for the same.
  82 2013-08-13T21:47:44  <ThomasWaldmann> also please additionally do some manual testing
  83 2013-08-13T22:13:47  *** bilal has quit IRC
  84 2013-08-13T22:15:50  <ashutosh1461> ok
  85 2013-08-13T22:17:19  <ashutosh1461> gn
  86 2013-08-13T22:17:19  *** ashutosh1461 has quit IRC
  87 2013-08-13T22:25:21  *** brunomartin has quit IRC
  88

MoinMoin: MoinMoinChat/Logs/moin-dev/2013-08-13 (last edited 2013-08-13 05:30:02 by IrcLogImporter)