1 2013-07-28T07:03:36 <xiaq> ThomasWaldmann: https://codereview.appspot.com/11981043 a trivial changeset...
2 2013-07-28T07:52:43 *** WarP|work
3 2013-07-28T08:09:51 *** ashutosh1461
4 2013-07-28T08:16:46 <ashutosh1461> moin
5 2013-07-28T08:39:22 <ananasova> moin
6 2013-07-28T08:48:22 *** ashutosh1461
7 2013-07-28T08:50:40 *** ashutosh1461
8 2013-07-28T09:54:03 <waldi> moin
9 2013-07-28T09:56:54 *** rciorba
10 2013-07-28T09:57:21 <dreimark> moin
11 2013-07-28T09:57:27 <sharky93> moin
12 2013-07-28T09:57:31 <TheSheep> moin
13 2013-07-28T09:57:58 <sharky93> can i go first? the internet is pretty shaky -_-
14 2013-07-28T09:58:40 <sharky93> ThomasWaldmann: ^
15 2013-07-28T09:58:50 <ananasova> mine too. i hope i won't be disappearing
16 2013-07-28T09:58:59 <ThomasWaldmann> moin
17 2013-07-28T09:59:41 <ThomasWaldmann> ok, sharky93 / thesheep first, ananasova / waldi afterwards.
18 2013-07-28T10:00:10 <sharky93> ok
19 2013-07-28T10:00:48 <ThomasWaldmann> ok, let's begin with the meeting.
20 2013-07-28T10:00:57 <sharky93> My week started with pushing the changes for ajax, ngram'ed search after codereview to https://bitbucket.org/sharky93/moin-2.0
21 2013-07-28T10:01:00 <xiaq> moin
22 2013-07-28T10:01:36 <sharky93> Next up was the modify view, changes submitted @ https://bitbucket.org/sharky93/moin-2.0-bootstrap
23 2013-07-28T10:01:48 <sharky93> Fixed around 12 issues @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issues
24 2013-07-28T10:02:08 <sharky93> Finalized a textarea plugin -> for autoresize @ http://www.jacklmoore.com/autosize/
25 2013-07-28T10:02:39 <sharky93> Minor changes pending with the modify wrt #17 @ https://bitbucket.org/sharky93/moin-2.0-bootstrap/issue/17/display-general-meta-and-extra-meta-forms
26 2013-07-28T10:03:49 <sharky93> I've started work with the history view, basic ui is up for review, if there's many issues with that, we'll go for a new design, maybe
27 2013-07-28T10:04:00 <sharky93> BLOCKERS - None
28 2013-07-28T10:04:01 <sharky93> EOF
29 2013-07-28T10:04:16 <TheSheep> sharky93: what are your plans wrt bootstrap v3?
30 2013-07-28T10:06:20 <ThomasWaldmann> https://bitbucket.org/sharky93/moin-2.0-bootstrap/commits/92dacdb1bedaa8e1dc157ad95a13c09fa715e24d sharky93: that needs to be packaged as xstatic package, please open a ticket for that
31 2013-07-28T10:07:15 <sharky93> TheSheep: I think, our current changes are basic and should work with v3.
32 2013-07-28T10:07:36 <ThomasWaldmann> "should" :D
33 2013-07-28T10:08:07 <sharky93> since, the release candidate was made available just yesterday :) i've not checked
34 2013-07-28T10:08:17 <TheSheep> sharky93: I don't think so, as v3 uses completely different class names for the grid
35 2013-07-28T10:08:53 <sharky93> TheSheep: if it's just names we have to change, shouldn't be much issue, right?
36 2013-07-28T10:09:42 <ThomasWaldmann> I'ld suggest doing more views / theme improvements next week, more fixes and switch to v3 after that.
37 2013-07-28T10:09:54 <ThomasWaldmann> next week are midterm evals btw
38 2013-07-28T10:10:37 <TheSheep> sharky93: not just names, but we will get to that
39 2013-07-28T10:10:52 <TheSheep> ThomasWaldmann: sounds like a plan
40 2013-07-28T10:11:27 <ThomasWaldmann> sharky93: do you have anything that is begun, but not yet committed to public repo?
41 2013-07-28T10:12:24 <sharky93> sry, got dc
42 2013-07-28T10:12:25 <ThomasWaldmann> spy_: are you with us?
43 2013-07-28T10:12:35 <ThomasWaldmann> sharky93: do you have anything that is begun, but not yet committed to public repo?
44 2013-07-28T10:13:03 <sharky93> ThomasWaldmann: i dont think so, but i'll check to be sure
45 2013-07-28T10:14:18 * ThomasWaldmann .oO(my android phone just reminded me that gsoc meeting begins at 12:00, at 12:13. wtf?)
46 2013-07-28T10:14:32 <ThomasWaldmann> ok, anything else for sharky93 / TheSheep ?
47 2013-07-28T10:15:53 <ThomasWaldmann> ok, seems like not. thanks sharky93 / TheSheep. ananasova / waldi: you're next.
48 2013-07-28T10:16:05 <ananasova> DONE:
49 2013-07-28T10:16:06 <ananasova> * Diff function for complex datastructures, like meta dicts (cr / commit / push)
50 2013-07-28T10:16:08 <ananasova> * Diff to text function for text representation of datastructures diff (cr / commit / push)
51 2013-07-28T10:16:11 <ananasova> * Change of meta section in template
52 2013-07-28T10:16:34 <ananasova> TODO next week
53 2013-07-28T10:16:34 <ananasova> * Implementing mail notification templates
54 2013-07-28T10:16:34 <ananasova> * Notification messages and sending mails
55 2013-07-28T10:16:34 <ananasova> * Planning on receive_mail func and bounce handling
56 2013-07-28T10:16:34 <ananasova> * Performance testing for determining subscribers (low priority)
57 2013-07-28T10:16:46 <ananasova> BLOCKERS: none
58 2013-07-28T10:18:05 <ThomasWaldmann> ananasova: don't you somehow have the mail notification templates already or how did you produce these emails you sent to waldi and me?
59 2013-07-28T10:19:06 <ananasova> they need some testing with different mail clients and define bugs in those
60 2013-07-28T10:19:40 <ananasova> currenty templates are pure html, just need to translate to jinja
61 2013-07-28T10:20:07 <ThomasWaldmann> ah
62 2013-07-28T10:20:45 <ThomasWaldmann> you'll also need some diff to html for the meta diff
63 2013-07-28T10:20:45 <dreimark> so that will be *.txt files?
64 2013-07-28T10:21:19 <ananasova> dreimark: no, html with a nice fallback for mail clients that don't render html
65 2013-07-28T10:21:47 <ananasova> ThomasWaldmann: i am planning on using the make_text_diff() output and iterating over it in the template
66 2013-07-28T10:22:09 <ananasova> in that way we are not bound to a specific html output and can be more flexible
67 2013-07-28T10:22:54 <waldi> this should be a converter
68 2013-07-28T10:22:58 <ThomasWaldmann> ananasova: we also want html diff on the ui, so some python function that can be used at different places would be nice
69 2013-07-28T10:23:25 <dreimark> as an option, can we have the content of the mail on the server
70 2013-07-28T10:23:33 <dreimark> in the userspace of the user
71 2013-07-28T10:23:39 <dreimark> and only send that there is a change
72 2013-07-28T10:23:58 <dreimark> whithout sending the whole content to an insecure mail system?
73 2013-07-28T10:24:11 <ThomasWaldmann> waldi: why? diff takes 2 revisions as input.
74 2013-07-28T10:24:45 <waldi> ThomasWaldmann: diff takes a diff representation as input and produces html or something else
75 2013-07-28T10:25:18 <ananasova> ThomasWaldmann: why not have a separate template and then import it anywhere you need, in the UI / mails ?
76 2013-07-28T10:25:56 <ThomasWaldmann> waldi: the exisitng data diff doesn't do that
77 2013-07-28T10:28:01 <ThomasWaldmann> ananasova: well, you currently have a diff tuples > text in python, now you want to do tuples > html in jinja2, using what as input?
78 2013-07-28T10:28:55 <ananasova> yes, or txt lines > html in jinja 2
79 2013-07-28T10:30:02 <ThomasWaldmann> that sounds somehow indirect. you'ld need to parse stuff and regenerate html. if you go that route, i'ld rather suggest using always the tuples.
80 2013-07-28T10:31:12 <ThomasWaldmann> ananasova: usual question, anything you've already begin that is not in public repo?
81 2013-07-28T10:31:20 <ThomasWaldmann> begun*
82 2013-07-28T10:31:36 <ananasova> probably tuples are better and easier to define if it's an insert or delete, rather than parsing the strings for +/-
83 2013-07-28T10:31:48 <ananasova> just the templates in progress
84 2013-07-28T10:34:06 <ThomasWaldmann> dreimark: we won't store "mails on the server", but of course we could send links to a view that displays THAT diff
85 2013-07-28T10:35:07 <dreimark> yeah, meant that
86 2013-07-28T10:35:10 <ThomasWaldmann> ananasova: waldi: what do you think? ^^ alternative to getting full mails. via a user profile setting?
87 2013-07-28T10:36:19 <ThomasWaldmann> the view of coure would be the same diff view as we offer anyway
88 2013-07-28T10:36:33 <waldi> not public accessible stuff via link, later encryption support
89 2013-07-28T10:37:06 <ThomasWaldmann> it would obey acls, of course, so it is as public as it is anyway
90 2013-07-28T10:37:43 <ThomasWaldmann> encryption support ++ :)
91 2013-07-28T10:38:25 <ThomasWaldmann> ananasova: you keep some of these ideas on the issue tracker?
92 2013-07-28T10:39:44 <ThomasWaldmann> anything else for ananasova / waldi ?
93 2013-07-28T10:40:10 <ananasova> no, but i can fill in the issue tracker on my bb public repo with todos/bugs/suggestions
94 2013-07-28T10:40:33 <ThomasWaldmann> asingla: ashutosh1461: eSyr: spy_: are you there?
95 2013-07-28T10:41:21 <ThomasWaldmann> ok, thanks to ananasova / waldi . xiaq and eSyr (if there) is next.
96 2013-07-28T10:42:03 <xiaq> LAST: non-DataTables TicketIndex, Chosen packaging & integration
97 2013-07-28T10:42:04 <xiaq> BLOCKER: none
98 2013-07-28T10:42:04 <xiaq> NEXT: DataTables integration
99 2013-07-28T10:42:31 <eSyr> ThomasWaldmann: yes.
100 2013-07-28T10:43:46 <ashutosh1461> ThomasWaldmann, yes
101 2013-07-28T10:46:07 <ThomasWaldmann> xiaq: can you please give me full access to pypi xstatic-Chosen / -DataTables? just in case we need to update that at some time and you are not there (see issues with that we have right now with bootstrap package)
102 2013-07-28T10:48:00 <xiaq> ThomasWaldmann: your pypi id plz?
103 2013-07-28T10:48:24 * xiaq tries ThomasWaldmann and got "user nonexistent"
104 2013-07-28T10:48:44 <ThomasWaldmann> huh, that should work
105 2013-07-28T10:49:20 *** rciorba1
106 2013-07-28T10:49:33 <ThomasWaldmann> Username: ThomasWaldmann - i can login with that
107 2013-07-28T10:50:50 <xiaq> ah, stupid mistake - i put a leading space...
108 2013-07-28T10:51:09 <xiaq> ThomasWaldmann: owner role granted for xstatic-{chosen,datatables}
109 2013-07-28T10:51:14 <ThomasWaldmann> xiaq: it's nice to see a bit more activity than in the weeks before, btw
110 2013-07-28T10:52:00 <xiaq> thanks - i'm still somehow behind though :-|
111 2013-07-28T10:52:06 *** rciorba
112 2013-07-28T10:53:34 <ThomasWaldmann> yeah, not much in the repo yet
113 2013-07-28T10:54:12 <ThomasWaldmann> maybe try to get more stuff there, finishing stuff that you've already begun
114 2013-07-28T10:54:53 <ThomasWaldmann> eSyr: can you have a look at the stuff, midterm starts tomorrow
115 2013-07-28T10:55:23 *** rciorba
116 2013-07-28T10:56:20 *** rciorba2
117 2013-07-28T10:56:31 <ThomasWaldmann> any questions for xiaq/esyr?
118 2013-07-28T10:56:56 <ThomasWaldmann> xiaq: btw, is your EP uptodate?
119 2013-07-28T10:57:28 <xiaq> ThomasWaldmann: not much change to the plan
120 2013-07-28T10:57:35 <eSyr> ThomasWaldmann: yes, sure.
121 2013-07-28T10:58:06 *** rciorba1
122 2013-07-28T10:58:09 <ThomasWaldmann> ok, thanks to xiaq / esyr. ashutosh1461 / me is next.
123 2013-07-28T10:58:33 <ashutosh1461> ok
124 2013-07-28T10:59:26 <ashutosh1461> DONE LAST WEEK :-
125 2013-07-28T10:59:26 <ashutosh1461> Added multiple and composite name support to some views (tags, similar, mychanges, backrefs, wanteds, orphans done).
126 2013-07-28T10:59:26 <ashutosh1461> Fixed the issues at my issue tracker (1, 2, 3, 5, 6, 7).
127 2013-07-28T10:59:26 <ashutosh1461> Progress on namespace-root mapping.
128 2013-07-28T10:59:26 <ashutosh1461> I will Commit / Update cr's for the above by today.
129 2013-07-28T10:59:28 <ashutosh1461> TODO Next week:-
130 2013-07-28T10:59:30 <ashutosh1461> Finish the views.
131 2013-07-28T10:59:32 <ashutosh1461> BLOCKERS :-
132 2013-07-28T10:59:34 <ashutosh1461> None
133 2013-07-28T10:59:54 *** rciorba
134 2013-07-28T11:01:34 <ThomasWaldmann> https://moinmo.in/AshutoshSingla/GSOC-2013-Diary/2013-07-26 that should be more specific
135 2013-07-28T11:03:49 <ashutosh1461> fine
136 2013-07-28T11:03:55 <ThomasWaldmann> and maybe try to recover from lost time last week, there wasn't too much activity
137 2013-07-28T11:05:31 <ashutosh1461> yes surely, i will make it up in the following weeks.
138 2013-07-28T11:05:43 <ashutosh1461> ThomasWaldmann, what should be next after the views are fixed ?
139 2013-07-28T11:06:20 <ThomasWaldmann> there is a lot todo on the etherpad, but it maybe needs some cleanup
140 2013-07-28T11:06:49 <ThomasWaldmann> first do stuff that is still missing for stuff you already begin
141 2013-07-28T11:07:52 <ThomasWaldmann> maybe don't do very big refactoring in the next days, though, rather concentrate on improving the state of your repo code. try it practically.
142 2013-07-28T11:09:21 <ThomasWaldmann> also, get stuff finished/committed to public repo that is still living on some codereview or elsewhere.
143 2013-07-28T11:10:06 <ThomasWaldmann> any questions to ashutosh1461 or me, referring to his project?
144 2013-07-28T11:11:27 <ThomasWaldmann> ashutosh1461: btw, many of these issues are still open on the issue tracker.
145 2013-07-28T11:11:35 <ThomasWaldmann> 12:59 ashutosh1461$ Fixed the issues at my issue tracker (1, 2, 3, 5, 6, 7).
146 2013-07-28T11:11:57 <ashutosh1461> ThomasWaldmann, yes, i will commit the fixes by today.
147 2013-07-28T11:12:57 <ThomasWaldmann> ah, ok
148 2013-07-28T11:14:00 <ThomasWaldmann> ok, looks like no more questions, thanks ashutosh1461. spy_ / dreimark is next.
149 2013-07-28T11:16:48 <dreimark> looks like spy_ is offline
150 2013-07-28T11:18:19 <ThomasWaldmann> spy / spy_ ^^
151 2013-07-28T11:19:54 <ThomasWaldmann> dreimark: according to his calendar (please check), there was a bit more activity from him last week. please review.
152 2013-07-28T11:20:49 <ThomasWaldmann> still not much in the repo, though :|
153 2013-07-28T11:21:18 <dreimark> seen, and already added a comment
154 2013-07-28T11:21:56 <dreimark> but have to do it more detailed, will do today. just reviewed a ton proposals for talks
155 2013-07-28T11:22:14 <ThomasWaldmann> ok, as spy_ missed the meeting, it looks like we are through. I have something related for all mentors:
156 2013-07-28T11:23:29 <ThomasWaldmann> the mentor summit will be at 2013-10-19 + -20 in Mountain View, please think about whether you would like to / have time to participate.
157 2013-07-28T11:23:50 <ThomasWaldmann> Do this ASAP as arranging / booking / planning all the stuff takes time.
158 2013-07-28T11:24:23 <ThomasWaldmann> dreimark: eSyr: TheSheep: waldi: ^^
159 2013-07-28T11:25:16 <ThomasWaldmann> (and it not only takes time, some stuff NEEDS to be done early)
160 2013-07-28T11:25:51 <ThomasWaldmann> if you have questions about mentor summit, just ask
161 2013-07-28T11:26:30 <ThomasWaldmann> ok, guess the official part of the meeting is over, thanks to everybody who made it here.
162 2013-07-28T11:26:33 <TheSheep> ThomasWaldmann: I'm not going for sure, I'm talking at pycon.pl at the same time
163 2013-07-28T11:27:11 <ThomasWaldmann> ok, so you have fun there also :D
164 2013-07-28T11:33:07 <dreimark> ThomasWaldmann: I can't go this year
165 2013-07-28T11:33:38 <dreimark> we have pycon.de
166 2013-07-28T11:34:08 <dreimark> TheSheep: same week ?
167 2013-07-28T11:34:30 <dreimark> next year ep/pycon.de is in july
168 2013-07-28T11:53:59 <ThomasWaldmann> waldi: eSyr: do you already know?
169 2013-07-28T11:54:57 <ThomasWaldmann> i guess we would get 2 invites this year (not 3 as we didn't participate in gci)
170 2013-07-28T11:55:09 <waldi> not really
171 2013-07-28T11:59:37 <ThomasWaldmann> https://moinmo.in/action/info/ReimarBauer/SvgEditor?action=info btw, there seems to be some malfunction, we shouldn't ever see 10.x.x.x there
172 2013-07-28T12:01:47 <TheSheep> dreimark: yeah, 17-20 October
173 2013-07-28T12:06:54 <ThomasWaldmann> omg, who has made that dark-green-on-black top menue of pycon.de?
174 2013-07-28T15:25:06 *** rciorba2
175 2013-07-28T15:58:14 *** WarP|work
176 2013-07-28T16:31:08 *** greg_f
177 2013-07-28T17:26:58 <dreimark> ThomasWaldmann: JuliaZemke
178 2013-07-28T17:27:24 <dreimark> is responsible for the green design
179 2013-07-28T17:28:56 <dreimark> ThomasWaldmann: we had the first course last week, using the usb sticks.
180 2013-07-28T17:34:54 <dreimark> have you seen the pull request https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/178/add-some-explicit-checks-for-the-optional/diff
181 2013-07-28T17:40:11 <ThomasWaldmann> dreimark: with low (30%) brightness, i hardly can read the text
182 2013-07-28T17:40:51 * spy_ added a reminder about the meeting to his android phone, commiting all the changes to his public repo
183 2013-07-28T17:41:39 <ThomasWaldmann> spy_: about android reminders: see my note from the meeting X)
184 2013-07-28T17:52:31 <dreimark> ThomasWaldmann: yes, it is not made for powersaving on displays
185 2013-07-28T17:53:52 <spy_> ThomasWaldmann: hm, thanks
186 2013-07-28T17:56:22 <dreimark> spy_: do you want tell now?
187 2013-07-28T18:03:38 <spy_> dreimark: just a moment, will upload my patches as a separate branch
188 2013-07-28T18:07:27 *** dreimark
189 2013-07-28T18:07:27 *** dreimark
190 2013-07-28T18:07:36 <dreimark> spy_: ok
191 2013-07-28T18:07:38 <spy_> btw, as a general workflow I use MQ patches, but you want to see commited changes. What is the best way to combine these two things?
192 2013-07-28T18:08:28 <spy_> Is it a good practice to create a separate branch/bookmark for each changeset in mercurial?
193 2013-07-28T18:09:02 <ThomasWaldmann> no idea. but the general idea is to get something done and finished and that means: committed.
194 2013-07-28T18:09:43 <ThomasWaldmann> that doesn't mean it needs to be perfect or "final", but in a reasonable state
195 2013-07-28T18:19:15 *** greg_f
196 2013-07-28T18:47:49 <spy_> dreimark: ThomasWaldmann: Quick summary of this week: Pushed a small fix for checking ModifyForm fields. Finished +addcomment view (no tests yet), implemented add comment input form that posts requests to this view. It is displayed on the +show view of a content item under the comments block.
197 2013-07-28T18:48:45 <spy_> future work is to improve the existing stuff, mainly add more tests for it
198 2013-07-28T18:49:27 <spy_> created a new branch in my local repo: https://bitbucket.org/psviderski/moin-2.0/commits/branch/comments
199 2013-07-28T18:53:52 <spy_> also I can give you a remote access to the working instance of it, so it will simplify manual testing and playing with features.
200 2013-07-28T18:55:46 <dreimark> ok
201 2013-07-28T18:55:53 <dreimark> spy_: any blockers?
202 2013-07-28T18:56:45 <spy_> suppose no
203 2013-07-28T18:58:06 <dreimark> :)
204 2013-07-28T19:04:25 <spy_> there was an idea to use ajax requests to optimize the comments listing and to add a new comment. For now I think it it more important to work on backend features such as threaded comments and ACLs. And then will try to reuse the existing views for ajax requests.
205 2013-07-28T19:13:49 <dreimark> yes, make this work first
206 2013-07-28T21:16:09 *** rciorba
207 2013-07-28T21:38:21 *** ashutosh1461
208 2013-07-28T22:40:42 *** rciorba
209