1 2013-07-27T05:20:26 *** rciorba
2 2013-07-27T06:13:17 <ananasova> moin
3 2013-07-27T06:14:12 <ananasova> waldi: there is a reason for inline styling, some mail clients don't recognize style tag (like gmail)
4 2013-07-27T06:14:18 *** rciorba
5 2013-07-27T06:42:37 *** ashutosh1461
6 2013-07-27T07:29:44 <sharky93> moin
7 2013-07-27T07:47:16 <sharky93> TheSheep: ThomasWaldmann something new @ http://twitter.github.io/bootstrap/
8 2013-07-27T08:18:10 <ThomasWaldmann> 3.0rc1 but still AL2
9 2013-07-27T08:21:24 <sharky93> https://github.com/github/choosealicense.com/pull/69
10 2013-07-27T08:22:13 <sharky93> ASF vs FSF #AL2 incompatibility is more of a social issue than a legal one :|
11 2013-07-27T08:22:22 * sharky93 is damn confused
12 2013-07-27T08:24:19 <ThomasWaldmann> sharky93: says who?
13 2013-07-27T08:25:08 <sharky93> ThomasWaldmann: the discussion @ https://github.com/github/choosealicense.com/pull/69
14 2013-07-27T08:29:58 <ThomasWaldmann> nothing new...
15 2013-07-27T08:36:34 <sharky93> ThomasWaldmann: what happens in the scenario that they finally justify AL2 with this :/
16 2013-07-27T08:37:58 * ThomasWaldmann must go, just ignore that for now
17 2013-07-27T10:10:32 <TheSheep> sharky93: it doesn't work like that, copyright lawyers work in terms of legal risk
18 2013-07-27T10:11:52 <TheSheep> sharky93: since copyright infringement is persecuted only at the request of the copyright owner, and the copyright owners all have no problem with us using this code, the legal risk is nil
19 2013-07-27T10:14:10 <TheSheep> furthermore, even if one of the bootstrap contributors actually went crazy and decided, that it's not ok for us to use it, they still wouldn't go to the court with it and risk paying for the case costs if the judge decided that AL2 is after all compatible with GPL2
20 2013-07-27T10:16:25 <TheSheep> finally, if they did risk it, and decided to go to the court, and they would won, they would get damages up to three times the price of the infridged work, which amounts to $0
21 2013-07-27T11:10:18 *** ashutosh1461
22 2013-07-27T11:22:50 *** ashutosh1461
23 2013-07-27T11:39:59 <sharky93> TheSheep: ah, nice insight
24 2013-07-27T13:13:45 *** greg_f
25 2013-07-27T14:15:55 <ananasova> waldi, ThomasWaldmann: please review when free, https://codereview.appspot.com/11967043/
26 2013-07-27T14:23:59 *** greg_f
27 2013-07-27T14:28:02 *** greg_f
28 2013-07-27T17:15:31 <sharky93> TheSheep: what's your take on doing the history view in a similar fashion to github's rendering of commit history?
29 2013-07-27T17:21:15 <sharky93> ThomasWaldmann: ^
30 2013-07-27T17:27:02 <sharky93> it may get a little inconsistent with the current simplistic ui we have
31 2013-07-27T17:29:17 *** ashutosh1461
32 2013-07-27T17:51:57 <TheSheep> sharky93: make a mockup and show it
33 2013-07-27T18:02:55 *** greg_f
34 2013-07-27T18:04:34 <ThomasWaldmann> ananasova: done
35 2013-07-27T18:13:35 <ananasova> ThomasWaldmann: left a comment to tests file https://codereview.appspot.com/11967043/
36 2013-07-27T18:14:56 <ananasova> btw what do you think about the changed meta section in the notification mail? does it look better now?
37 2013-07-27T18:16:25 <ThomasWaldmann> did you fix the stuff pointed out be me and waldi yesterday?
38 2013-07-27T18:22:49 <ananasova> about inline styling: it is best practise to use inline, some mail clients just strip everything between head and body
39 2013-07-27T18:24:45 <ananasova> charset was set utf-8, were there any problems with encoding?
40 2013-07-27T18:24:58 <ThomasWaldmann> ananasova: usually there is nothing between html head and html body,so what do you mean?
41 2013-07-27T18:25:18 <ananasova> and i didn't see your feedback, where did you write it?
42 2013-07-27T18:25:30 <ThomasWaldmann> as a comment
43 2013-07-27T18:26:04 <ananasova> by email?
44 2013-07-27T18:26:53 <ThomasWaldmann> what precisely do you mean? the diff email feedback?
45 2013-07-27T18:27:14 <ananasova> yes
46 2013-07-27T18:27:33 <ThomasWaldmann> that was on irc. "use utf-8" and "don't use inlines styles".
47 2013-07-27T18:27:44 <ThomasWaldmann> -s
48 2013-07-27T18:28:35 <ananasova> saw that one.
49 2013-07-27T18:29:17 <ananasova> and i was trying to explain why i use inline styles.
50 2013-07-27T18:30:06 * ananasova is fixing the tests for the cr
51 2013-07-27T18:43:29 <ThomasWaldmann> ananasova: internal stylesheet is IN the head, not between head and body. is that a problem?
52 2013-07-27T18:46:21 <ananasova> even if we insert an internal stylesheet in the head, it won't be considerend while rendering by the mail client.
53 2013-07-27T18:46:56 <ananasova> and yes, i said it wrong, not between head and body, but inside.
54 2013-07-27T18:47:32 <ThomasWaldmann> waldi: http://kb.mailchimp.com/article/how-to-code-html-emails/ they also recommend inline style
55 2013-07-27T18:48:45 <ThomasWaldmann> waldi: http://www.campaignmonitor.com/css/
56 2013-07-27T18:49:58 <ananasova> and there are plenty of inlining tools for css
57 2013-07-27T18:51:23 <ThomasWaldmann> well, it's a question of style somehow :)
58 2013-07-27T19:01:20 <ThomasWaldmann> spy_: finished changesets need to be in your public repo ASAP
59 2013-07-27T19:06:35 <ThomasWaldmann> (also, everybody is expected to do calendar entries daily, not somehow for multiple days afterwards)
60 2013-07-27T19:18:35 <ananasova> ThomasWaldmann: https://codereview.appspot.com/11967043/ updated the tests
61 2013-07-27T20:05:02 <ananasova> ThomasWaldmann: left a comment here - https://codereview.appspot.com/11967043/patch/9001/10001
62 2013-07-27T21:08:11 <ThomasWaldmann> ananasova: ok
63 2013-07-27T21:40:16 <sharky93> gn
