1 2013-07-20T06:18:58 *** rciorba
2 2013-07-20T08:02:38 <xiaq> ThomasWaldmann: https://codereview.appspot.com/10889044/ updated
3 2013-07-20T08:04:06 <xiaq> i introduced a new "schema" package - i hope to integrate the schema pieces (DisplayField, forms.py, Whoosh schema) together in future, hence the package
4 2013-07-20T08:25:50 *** dav2d
5 2013-07-20T08:30:25 *** xorRaxRax
6 2013-07-20T08:30:26 *** dav1d
7 2013-07-20T08:35:23 *** ronny_
8 2013-07-20T08:36:49 *** xorRaxRax
9 2013-07-20T08:38:03 *** jek
10 2013-07-20T08:46:02 *** ronny
11 2013-07-20T08:46:02 *** jek_
12 2013-07-20T08:47:37 *** ronny_
13 2013-07-20T08:54:47 *** xorRaxRax
14 2013-07-20T09:06:42 *** TheSheep
15 2013-07-20T09:06:42 *** sharky93
16 2013-07-20T09:06:42 *** eSyr-ng
17 2013-07-20T09:06:42 *** sunu
18 2013-07-20T09:06:42 *** dreimark
19 2013-07-20T09:06:42 *** waldi
20 2013-07-20T09:06:42 *** ThomasAH
21 2013-07-20T09:06:43 *** dennda_
22 2013-07-20T09:06:43 *** xjjk
23 2013-07-20T09:06:44 *** SteveMcIntyre
24 2013-07-20T09:06:45 *** sharky93_
25 2013-07-20T09:07:22 *** sharky93
26 2013-07-20T09:07:43 *** xorRaxRax
27 2013-07-20T09:07:43 *** dennda_
28 2013-07-20T09:07:43 *** SteveMcIntyre
29 2013-07-20T09:07:43 *** xjjk
30 2013-07-20T09:07:43 *** ThomasAH
31 2013-07-20T09:07:43 *** waldi
32 2013-07-20T09:07:43 *** dreimark
33 2013-07-20T09:07:43 *** sunu
34 2013-07-20T09:07:43 *** eSyr-ng
35 2013-07-20T09:07:43 *** sharky93
36 2013-07-20T09:07:43 *** TheSheep
37 2013-07-20T09:08:53 *** TheSheep
38 2013-07-20T09:08:53 *** sharky93
39 2013-07-20T09:08:53 *** eSyr-ng
40 2013-07-20T09:08:53 *** sunu
41 2013-07-20T09:08:53 *** dreimark
42 2013-07-20T09:08:53 *** waldi
43 2013-07-20T09:08:54 *** ThomasAH
44 2013-07-20T09:10:33 *** TheSheep
45 2013-07-20T09:10:33 *** sharky93
46 2013-07-20T09:10:33 *** eSyr-ng
47 2013-07-20T09:10:33 *** sunu
48 2013-07-20T09:10:33 *** dreimark
49 2013-07-20T09:10:33 *** waldi
50 2013-07-20T09:10:33 *** ThomasAH
51 2013-07-20T09:11:00 *** xorRaxRax
52 2013-07-20T09:11:41 *** xorRaxRax
53 2013-07-20T10:18:35 <ananasova> moin
54 2013-07-20T10:31:08 <sharky93> moin
55 2013-07-20T10:42:31 <sharky93> TheSheep: to begin with, moinwiki converter test @ http://codereview.appspot.com/11627043 please have a look
56 2013-07-20T10:43:41 <TheSheep> sharky93: I think you will need two tests, one for the input and one for the output
57 2013-07-20T10:43:53 <TheSheep> sharky93: I suppose this looks good
58 2013-07-20T10:44:55 *** dav2d
59 2013-07-20T10:48:09 <sharky93> TheSheep: so one more with the html_out converter, right ?
60 2013-07-20T10:48:58 <TheSheep> yes, and the others
61 2013-07-20T10:49:03 <TheSheep> like rst
62 2013-07-20T10:49:23 <sharky93> TheSheep: there's one trouble there, those test_html_out tests require lxml, but I think we dont want to use it anymore
63 2013-07-20T10:49:37 <TheSheep> why not?
64 2013-07-20T10:50:17 <sharky93> I think i remember some chat with thomas long time back.
65 2013-07-20T10:51:07 <sharky93> I think he mentioned that In the end those tsts have to be converted to not depending on lxml ..
66 2013-07-20T10:52:30 <sharky93> TheSheep: so there's two options as i see, add more test to that tally of tests which have to be converted later on ..? OR do something like converter/_tests/test_image.py ..
67 2013-07-20T10:54:19 <TheSheep> replacing one xml-parsing library with another shouldn't be that hard, I suppose
68 2013-07-20T10:55:04 <TheSheep> I mean, it's not like you would have to rewrite all those tests, so adding some more cases won't hurt
69 2013-07-20T10:55:50 <sharky93> TheSheep: ok, pip install lxml is way :)
70 2013-07-20T11:10:30 <ananasova> http://moinmo.in/GoogleSoc2013/InitialProjectIdeas contains "remove dependency on lxml completely"
71 2013-07-20T11:48:21 <ananasova> waldi: any comment on <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
72 2013-07-20T11:48:24 <ananasova> <html>
73 2013-07-20T11:48:27 <ananasova> <head>
74 2013-07-20T11:48:29 <ananasova> <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
75 2013-07-20T11:48:32 <ananasova> <title>Wiki Notifications</title>
76 2013-07-20T11:48:34 <ananasova> </head>
77 2013-07-20T11:48:37 <ananasova> <body style="-webkit-text-size-adjust:none;margin:0;padding:0;width:100%;">
78 2013-07-20T11:48:39 <ananasova> <div style="font-size:14px;text-align:center;">
79 2013-07-20T11:48:42 <ananasova> <p>Dear Wiki user,</p>
80 2013-07-20T11:48:44 <ananasova> <p style="margin-bottom:0px;">The <strong>"Important content"</strong> page has been changed by <strong>UserName</strong>.</p>
81 2013-07-20T11:48:47 <ananasova> <p style="margin-top:0px;"><a href="http://moinmo.in/ImportantContent/" style="text-decoration:none;color:#3CA7DD;">http://moinmo.in/ImportantContent/?action=diff&rev1=22&rev2=23</a></p>
82 2013-07-20T11:48:51 <ananasova> </div>
83 2013-07-20T11:48:54 <ananasova> <h3 style="margin:0 23px 10px;">Content</h3>
84 2013-07-20T11:48:56 <ananasova> <table border="0" cellpadding="0" cellspacing="0" bgcolor="#F9F9F9" style="margin:0;padding:10px;width:100%;font-size:13px;font-family:monospace;">
85 2013-07-20T11:48:59 <ananasova> <tbody>
86 2013-07-20T11:49:02 <ananasova> <tr>
87 2013-07-20T11:49:04 <ananasova> <td width="15" style="font-family: monospace;"></td>
88 2013-07-20T11:49:07 <ananasova> <td style="font-family: monospace;">Lorem ipsum dolor sit amet, consectetur adipisicing elit. Temporibus, repudiandae, est, delectus, saepe cumque perferendis numquam quia inventore fugit laborum nostrum facilis molestias porro magnam quo reprehenderit eligendi soluta ratione!</td>
89 2013-07-20T11:49:12 <ananasova> </tr>
90 2013-07-20T11:49:14 <ananasova> <tr style="color:#00B000;">
91 2013-07-20T11:49:17 <ananasova> <td width="15" style="font-family: monospace;">+</td>
92 2013-07-20T11:49:19 <ananasova> <td style="font-family: monospace;">That's some</td>
93 2013-07-20T11:49:22 <ananasova> </tr>
94 2013-07-20T11:49:24 <ananasova> <tr style="color:#00B000;">
95 2013-07-20T11:49:27 <ananasova> <td width="15" style="font-family: monospace;">+</td>
96 2013-07-20T11:49:29 <ananasova> <td style="font-family: monospace;">modified content.</td>
97 2013-07-20T11:49:32 <ananasova> </tr>
98 2013-07-20T11:49:34 <ananasova> <tr style="color:#408;">
99 2013-07-20T11:49:37 <ananasova> <td style="font-family: monospace;"></td>
100 2013-07-20T11:49:39 <ananasova> <td style="font-family: monospace;">@@ -1,3 +1,7 @@</td>
101 2013-07-20T11:49:42 <ananasova> </tr>
102 2013-07-20T11:49:44 <ananasova> <tr>
103 2013-07-20T11:49:47 <ananasova> <td style="font-family: monospace;"></td>
104 2013-07-20T11:49:49 <ananasova> <td style="font-family: monospace;">Lorem ipsum dolor sit amet, consectetur adipisicing elit.</td>
105 2013-07-20T11:49:52 <ananasova> </tr>
106 2013-07-20T11:49:55 <ananasova> <tr style="color:#911;">
107 2013-07-20T11:49:57 <ananasova> <td style="font-family: monospace;">-</td>
108 2013-07-20T11:50:00 <ananasova> <td style="font-family: monospace;">And these lines</td>
109 2013-07-20T11:50:02 <ananasova> </tr>
110 2013-07-20T11:50:05 <ananasova> <tr style="color:#911;">
111 2013-07-20T11:50:07 <ananasova> <td style="font-family: monospace;">-</td>
112 2013-07-20T11:50:10 <ananasova> <td style="font-family: monospace;">were deleted.</td>
113 2013-07-20T11:50:12 <ananasova> </tr>
114 2013-07-20T11:50:15 <ananasova> </tbody>
115 2013-07-20T11:50:17 <ananasova> </table>
116 2013-07-20T11:50:20 <ananasova> <h3 style="margin:10px 23px;">Metadata</h3>
117 2013-07-20T11:50:22 <ananasova> <table border="0" cellpadding="0" cellspacing="0" style="margin:0;padding:0;width:100%;font-size:13px;font-family:monospace;border:1px solid #dddddd;border-radius:4px;">
118 2013-07-20T11:50:25 <ananasova> <thead>
119 2013-07-20T11:50:28 <ananasova> <tr style="background-color:#F9F9F9">
120 2013-07-20T11:50:30 <ananasova> <td width="20%" style="font-family: monospace;font-weight:bold;padding:8px;border-right:1px solid #dddddd;border-bottom:1px solid #dddddd;";>Meta</td>
121 2013-07-20T11:50:33 <ananasova> <td width="40%" style="font-family: monospace;font-weight:bold;padding:8px;border-right:1px solid #dddddd;border-bottom:1px solid #dddddd;">Old revision</td>
122 2013-07-20T11:50:36 <ananasova> <td width="40%" style="font-family: monospace;font-weight:bold;padding:8px;border-bottom:1px solid #dddddd;">New revision</td>
123 2013-07-20T11:50:39 <ananasova> </tr>
124 2013-07-20T11:50:42 <ananasova> </thead>
125 2013-07-20T11:50:44 <ananasova> <tbody>
126 2013-07-20T11:50:47 <ananasova> <tr style="background-color: #fff;">
127 2013-07-20T11:50:49 <ananasova> <td width="20%" style="font-family: monospace;padding:8px;border-right:1px solid #dddddd;">"action"</td>
128 2013-07-20T11:50:52 <ananasova> <td width="40%" style="font-family: monospace;color:#911;padding:8px;border-right:1px solid #dddddd;">"RENAME"</td>
129 2013-07-20T11:50:55 <ananasova> <td width="40%" style="font-family: monospace;color:#00B000;padding:8px;">"SAVE"</td>
130 2013-07-20T11:50:58 <ananasova> </tr>
131 2013-07-20T11:51:01 <ananasova> <tr style="background-color:#F9F9F9">
132 2013-07-20T11:51:03 <ananasova> <td width="20%" style="font-family: monospace;padding:8px;border-right:1px solid #dddddd;">"subscriptions"</td>
133 2013-07-20T11:51:06 <ananasova> <td width="40%" style="font-family: monospace;color:#911;padding:8px;border-right:1px solid #dddddd;">[]</td>
134 2013-07-20T11:51:09 <ananasova> <td width="40%" style="font-family: monospace;color:#00B000;padding:8px;">["name::xxx"]</td>
135 2013-07-20T11:51:12 <ananasova> </tr>
136 2013-07-20T11:51:15 <ananasova> <tr style="background-color: #fff;">
137 2013-07-20T11:51:17 <ananasova> <td width="20%" style="font-family: monospace;padding:8px;border-right:1px solid #dddddd;">"comment"</td>
138 2013-07-20T11:51:20 <ananasova> <td width="40%" style="font-family: monospace;color:#911;padding:8px;border-right:1px solid #dddddd;">""</td>
139 2013-07-20T11:51:23 <ananasova> <td width="40%" style="font-family: monospace;color:#00B000;padding:8px;">"Lorem ipsum dolor sit amet, consectetur adipisicing elit. Numquam, omnis, recusandae, facere necessitatibus quisquam iusto illo autem a provident aspernatur rem ipsum dignissimos mollitia ipsam dolorum nulla nam expedita atque."</td>
140 2013-07-20T11:51:28 <ananasova> </tr>
141 2013-07-20T11:51:31 <ananasova> <tr style="background-color:#F9F9F9">
142 2013-07-20T11:51:33 <ananasova> <td width="20%" style="font-family: monospace;padding:8px;border-right:1px solid #dddddd;">"size"</td>
143 2013-07-20T11:51:36 <ananasova> <td width="40%" style="font-family: monospace;color:#911;padding:8px;border-right:1px solid #dddddd;">256</td>
144 2013-07-20T11:51:39 <ananasova> <td width="40%" style="font-family: monospace;color:#00B000;padding:8px;">4</td>
145 2013-07-20T11:51:42 <ananasova> </tr>
146 2013-07-20T11:51:45 <ananasova> </tbody>
147 2013-07-20T11:51:47 <ananasova> </table>
148 2013-07-20T11:51:50 <ananasova> <div class="footer" style="font-size:11px;margin-top:25px;">
149 2013-07-20T11:51:52 <ananasova> <p style="text-align:center;color:#A6A6A6;margin-bottom:0;">You are receiving this because you have subscribed to a wiki page or a wiki category on MoinMoin for change notifications.</p>
150 2013-07-20T11:51:56 <ananasova> <p style="text-align:center;margin-top:0;"><strong><a href="#" style="text-decoration:none;color:#3CA7DD;">Unsubscribe from this page notifications</a></strong></p>
151 2013-07-20T11:51:59 <ananasova> </div>
152 2013-07-20T11:52:02 <ananasova> </body>
153 2013-07-20T11:52:04 <ananasova> ohh, sheesh, i am so sorry
154 2013-07-20T11:52:10 <ananasova> waldi: any comments on https://codereview.appspot.com/11215045/ or should i close the issue?
155 2013-07-20T11:52:13 <ananasova> ThomasWaldmann: left a comment here https://codereview.appspot.com/10693045/ :)
156 2013-07-20T11:52:16 * ananasova is wondering when EP will be up again to see ThomasWaldmann comments
157 2013-07-20T11:53:53 *** ronny
158 2013-07-20T11:54:44 <ThomasWaldmann> ananasova: you are still using 2 columns for old/new metadata
159 2013-07-20T11:56:52 <ananasova> ThomasWaldmann: i didn't see your comments yesterday
160 2013-07-20T11:57:25 <ananasova> today morning ep was down when i tried to reach it
161 2013-07-20T11:58:42 <ananasova> so i have no clue about the comments
162 2013-07-20T11:59:51 <ThomasWaldmann> i told that on #osuosl
163 2013-07-20T12:00:37 <ThomasWaldmann> ananasova: ok, guess you just read them later when it is online again
164 2013-07-20T12:00:44 <ananasova> yep :)
165 2013-07-20T12:09:14 <ThomasWaldmann> replied on CR
166 2013-07-20T12:10:00 *** ronny
167 2013-07-20T12:11:30 <waldi> ananasova: looks okay
168 2013-07-20T12:17:30 <ananasova> also how about the issue with Determining subscribers (https://codereview.appspot.com/10950045/) and checking the regexps in the validator (https://codereview.appspot.com/11403044/)?
169 2013-07-20T12:17:41 <ananasova> waldi, ThomasWaldmann ^
170 2013-07-20T12:34:35 <ThomasWaldmann> ananasova: done
171 2013-07-20T12:35:39 <ThomasWaldmann> ananasova: I'ld suggest you don't touch the interwikiname stuff right now, but fix the minor issues and get all stuff published on your repo, so we can try the code
172 2013-07-20T12:37:12 <ananasova> ok
173 2013-07-20T12:52:30 *** greg_
174 2013-07-20T13:31:19 * ananasova updated the crs and will push the changes a bit later
175 2013-07-20T13:49:19 <ThomasWaldmann> ananasova: replied
176 2013-07-20T14:41:04 <ThomasWaldmann> who wants to test webrtc with me? (includes video/audio chat builtin into firefox 22)
177 2013-07-20T14:41:28 <ThomasWaldmann> (a recent chrome should also work)
178 2013-07-20T15:00:09 *** rciorba
179 2013-07-20T17:36:00 *** ashutosh1461
180 2013-07-20T17:36:08 <ashutosh1461> moin
181 2013-07-20T17:41:44 <ananasova> moin ashutosh1461
182 2013-07-20T17:42:45 <ashutosh1461> ThomasWaldmann, what should be the correct place to define namespace and root mapping ?
183 2013-07-20T17:44:15 <ThomasWaldmann> the namespace mapping is setup in wiki config
184 2013-07-20T17:47:14 <ashutosh1461> ThomasWaldmann, ping me when you need the repo for testing.
185 2013-07-20T17:48:58 <ThomasWaldmann> i need it now
186 2013-07-20T17:49:38 <ThomasWaldmann> (and just to be clear: that should be your normal gsoc repo where you should push your stuff often. daily.)
187 2013-07-20T17:51:00 <ashutosh1461> ThomasWaldmann, ok i am running tests .. should be done within 15 mins.
188 2013-07-20T18:33:57 <sharky93> TheSheep: are we done with the search reviews?
189 2013-07-20T18:34:18 <ashutosh1461> ThomasWaldmann, done https://bitbucket.org/ashu1461/moin-2.0/ along with https://codereview.appspot.com/download/issue11593044_1.diff should work fine.
190 2013-07-20T18:34:56 <ashutosh1461> the cr patch is temporary fix for the converter stuff that is yet to be fixed.
191 2013-07-20T18:52:57 <ThomasWaldmann> please fix it so the repo is in a good state
192 2013-07-20T18:53:33 *** greg_
193 2013-07-20T18:54:12 <ashutosh1461> ThomasWaldmann, these are temporary fixes, so that the tests don't fail so I did not merge them.
194 2013-07-20T18:55:34 <ThomasWaldmann> ok, then do real fix
195 2013-07-20T18:57:44 <ashutosh1461> ThomasWaldmann, these are related to the converter code, so i need to do some more research about what to use.
196 2013-07-20T19:02:47 <ThomasWaldmann> etherpads are back. for all students: did you make your recent offline copy already? it seems to be rather unreliably recently, do it before it is too late.
197 2013-07-20T19:06:10 <ThomasWaldmann> ananasova: ashutosh1461: spy_: xiaq: sharky93: ^^
198 2013-07-20T19:06:56 * ashutosh1461 prefers to use riseup pads instead.
199 2013-07-20T19:15:21 * sharky93 got 13 failures in TestConverter after pip install lxml
200 2013-07-20T19:32:40 <TheSheep> sharky93: yes, I reviewed it
201 2013-07-20T19:32:47 <TheSheep> sharky93: didn't test though
202 2013-07-20T19:32:54 <TheSheep> sharky93: I trust you it works :)
203 2013-07-20T19:34:26 <sharky93> TheSheep: so all three right?, umm
204 2013-07-20T19:34:28 <sharky93> https://codereview.appspot.com/10971043/
205 2013-07-20T19:34:39 <sharky93> https://codereview.appspot.com/10935045/
206 2013-07-20T19:34:45 <sharky93> and https://codereview.appspot.com/10976043/
207 2013-07-20T19:34:48 <sharky93> TheSheep: ^
208 2013-07-20T20:01:29 *** rciorba
209 2013-07-20T20:28:40 <dreimark> moin
210 2013-07-20T20:29:09 <dreimark> ananasova: this will become more hits for your nick on moin-dev
211 2013-07-20T20:37:01 <ashutosh1461> ThomasWaldmann, please review https://codereview.appspot.com/11584044 when free..
212 2013-07-20T20:42:09 <ananasova> dreimark: what do you mean?
213 2013-07-20T20:43:01 <dreimark> ananasova: http://moinmo.in/MoinMoinChat/Logs/moin-dev/2013-07-20#CA-b627766e802002d6f85092ee7899c0d5149b364d_71
214 2013-07-20T20:45:10 <dreimark> counting activity of students on irc ;)
215 2013-07-20T20:48:16 <sharky93> ^ :P
216 2013-07-20T20:48:56 <sharky93> +1 dreimark
217 2013-07-20T20:49:39 <ananasova> dreimark: ohh yes, that was my big epic fail :(
218 2013-07-20T20:52:54 <dreimark> ananasova: btw. do you know about kodos?
219 2013-07-20T20:53:53 <dreimark> if you need to test some regex I think it can be helpful to try there
220 2013-07-20T20:55:00 <ashutosh1461> ThomasWaldmann, would be good if you could test https://codereview.appspot.com/8709049/ this also ..
221 2013-07-20T21:07:46 <ananasova> dreimark: thx, nice tool :)
222 2013-07-20T21:17:05 <ThomasWaldmann> ashutosh1461: what do you mean by "test" for this codereview?
223 2013-07-20T21:18:26 <ThomasWaldmann> http://www.sharefest.me/611da183 can we test whether that works?
224 2013-07-20T21:19:37 <dreimark> did you send this cheese sandwich?
225 2013-07-20T21:19:50 <ThomasWaldmann> yes :)
226 2013-07-20T21:20:34 <dreimark> is there a size limitation for sharing?
227 2013-07-20T21:21:09 <dreimark> e.g. 2TB, currentl looking for some service to share usb stick isos
228 2013-07-20T21:21:17 <ThomasWaldmann> p2p filesharing directly from browser (with a little help from external server)
229 2013-07-20T21:21:22 <ThomasWaldmann> dreimark: try it :)
230 2013-07-20T21:22:39 <sharky93> not supported on Chromium v.23 ..
231 2013-07-20T21:23:03 <ashutosh1461> ThomasWaldmann, patch it and then test. (earlier you said that you would have to patch it to review it.)
232 2013-07-20T21:23:46 <dreimark> doing tom. with the release
233 2013-07-20T21:25:58 <ThomasWaldmann> sharky93: ff22 and a more recent chromium works
234 2013-07-20T21:26:35 <ThomasWaldmann> dreimark: use some quick connection for upload :)
235 2013-07-20T21:27:12 <ThomasWaldmann> dreimark: and you mean 2GB, right?
236 2013-07-20T21:27:22 <dreimark> oh yeah
237 2013-07-20T21:27:29 <dreimark> too much units
238 2013-07-20T22:04:41 <dreimark> gn
239 2013-07-20T23:05:13 *** rciorba
240
