MoinMoin: MoinMoinChat/Logs/moin-dev/2013-07-16

   1 2013-07-16T00:07:00  *** ronny has joined #moin-dev
   2 2013-07-16T00:11:21  *** brunomartin has quit IRC
   3 2013-07-16T01:03:05  *** asingla has quit IRC
   4 2013-07-16T01:03:20  *** asingla has joined #moin-dev
   5 2013-07-16T01:03:39  *** asingla has joined #moin-dev
   6 2013-07-16T05:21:44  <asingla> ThomasWaldmann: updated + replied to your prev comments https://codereview.appspot.com/10869045/
   7 2013-07-16T05:23:22  <xiaq> ThomasWaldmann: updated, plz review! https://codereview.appspot.com/10889044/
   8 2013-07-16T05:23:42  * xiaq struggled a lot with this patchset
   9 2013-07-16T05:25:17  <xiaq> i tried doing a more "comprehensive" like that of Flatland elements and forms - use a wrapper to contain information about a field (flatland.Element), another wrapper to contain the all the desired metadata fields (flatland.Form)
  10 2013-07-16T05:25:45  <xiaq> which ended up being overly complex...
  11 2013-07-16T05:28:27  <xiaq> Flatland lets you to tie the "type" (label, validators and possibly the widget name for a field) and the "value" (metadata key-value pair, like 'summary': 'A ticket!') together using Python's class model
  12 2013-07-16T05:32:42  <xiaq> Flatland comes with a lot of helpers to manipulate *types*, like Element.using and other "class cloners" - duplicating the funtionality is a lot of work
  13 2013-07-16T05:34:00  <xiaq> so i gave up this approach, ending up just a "DisplayField" class that specifies how the field should be displayed and not tied to the values directly
  14 2013-07-16T05:35:51  <xiaq> ThomasWaldmann: so, no __unicode__ or __html__ on fields to get representation suitable for plain text (eg. email) or webpage. one can just implement a plain-text version of display_widgets.html and use those widgets in emails
  15 2013-07-16T06:10:58  *** rciorba has joined #moin-dev
  16 2013-07-16T06:18:36  *** xorRaxRax has quit IRC
  17 2013-07-16T06:19:18  *** xorRaxRax has joined #moin-dev
  18 2013-07-16T06:26:35  *** rciorba has quit IRC
  19 2013-07-16T06:29:14  <xiaq> ThomasWaldmann: also, we should adopt a uniform indentation style for jinja templates, after soc...
  20 2013-07-16T06:30:22  * xiaq backs using 2 spaces and always indent even if a {% jinja2 block %} contains exactly one html <tag>
  21 2013-07-16T06:30:47  <xiaq> (currently there are quite some places where the latter is not indented)
  22 2013-07-16T06:36:00  <xiaq> eSyr: https://codereview.appspot.com/10889044/ plz review too :)
  23 2013-07-16T06:37:59  <eSyr> ok.
  24 2013-07-16T06:48:54  *** rciorba has joined #moin-dev
  25 2013-07-16T09:11:41  *** xiaq has quit IRC
  26 2013-07-16T09:11:50  *** xiaq has joined #moin-dev
  27 2013-07-16T09:12:14  *** xiaq is now known as Guest41000
  28 2013-07-16T09:40:32  *** greg_ has joined #moin-dev
  29 2013-07-16T10:36:51  <sharky93> moin
  30 2013-07-16T10:51:28  <ananasova> moin
  31 2013-07-16T12:41:17  *** brunomartin has joined #moin-dev
  32 2013-07-16T12:44:20  *** Guest41000 is now known as xiaq
  33 2013-07-16T12:59:44  <ananasova> waldi: any other comments on the validator issue - https://codereview.appspot.com/11248043/ ?
  34 2013-07-16T13:00:31  <ananasova> and also this cr with admin emails - https://codereview.appspot.com/11139044/
  35 2013-07-16T13:22:38  *** dave_largo has joined #moin-dev
  36 2013-07-16T14:29:26  <ananasova> waldi: updated the indexer cr, please review - https://codereview.appspot.com/11241043/
  37 2013-07-16T15:58:00  <ThomasWaldmann> asingla: https://codereview.appspot.com/10869045/ you do the first review yourself. tell me how many errors you found.
  38 2013-07-16T17:07:27  *** TheSheep has quit IRC
  39 2013-07-16T17:07:27  *** SteveMcIntyre has quit IRC
  40 2013-07-16T17:07:27  *** sharky93 has quit IRC
  41 2013-07-16T17:07:27  *** eSyr-ng has quit IRC
  42 2013-07-16T17:07:27  *** sunu has quit IRC
  43 2013-07-16T17:07:27  *** dreimark has quit IRC
  44 2013-07-16T17:07:27  *** waldi has quit IRC
  45 2013-07-16T17:07:28  *** ThomasAH has quit IRC
  46 2013-07-16T17:07:30  *** sharky93_ is now known as sharky93
  47 2013-07-16T17:09:56  *** sharky93 is now known as 7JTAABCFJ
  48 2013-07-16T17:10:07  *** TheSheep has joined #moin-dev
  49 2013-07-16T17:10:07  *** SteveMcIntyre has joined #moin-dev
  50 2013-07-16T17:10:07  *** sharky93 has joined #moin-dev
  51 2013-07-16T17:10:07  *** eSyr-ng has joined #moin-dev
  52 2013-07-16T17:10:07  *** sunu has joined #moin-dev
  53 2013-07-16T17:10:07  *** dreimark has joined #moin-dev
  54 2013-07-16T17:10:07  *** waldi has joined #moin-dev
  55 2013-07-16T17:10:07  *** ThomasAH has joined #moin-dev
  56 2013-07-16T17:29:03  *** birkenfeld_ has joined #moin-dev
  57 2013-07-16T17:29:39  <sharky93> re
  58 2013-07-16T17:31:10  *** xiaq_ has joined #moin-dev
  59 2013-07-16T17:32:40  <sharky93> TheSheep: pushed 2 more commits to solve 2 issues @ the bootstrap fork
  60 2013-07-16T17:33:15  <sharky93> TheSheep: did you get a bit free to review the earlier things .. are they ok now ?
  61 2013-07-16T17:34:57  *** greg_ has quit IRC
  62 2013-07-16T17:34:57  *** xiaq has quit IRC
  63 2013-07-16T17:34:57  *** 7JTAABCFJ has quit IRC
  64 2013-07-16T17:34:57  *** birkenfeld has quit IRC
  65 2013-07-16T17:35:08  *** birkenfeld_ is now known as birkenfeld
  66 2013-07-16T17:38:00  <asingla> ThomasWaldmann: self review done found 3 errors, updated https://codereview.appspot.com/10869045/
  67 2013-07-16T17:38:01  *** sharky93_ has joined #moin-dev
  68 2013-07-16T17:51:28  <ananasova> ThomasWaldmann, waldi: wha
  69 2013-07-16T17:52:04  <ananasova> what's the ultimate pep8 style for lists and tuples that should be used?
  70 2013-07-16T17:52:55  <ananasova> because there have appeared some opposite suggestions how to handle them
  71 2013-07-16T18:08:06  <sharky93> TheSheep: pushed one more commit, all 3 minor issues on the bootstrap fork are now fixed, please confirm :)
  72 2013-07-16T18:12:01  <ananasova> for those who are not good at licensing like me :) http://www.tldrlegal.com/
  73 2013-07-16T19:27:05  <ThomasWaldmann> maybe they should add "incompatibility issues"
  74 2013-07-16T19:27:59  <ThomasWaldmann> ananasova: if you start from "[]", the rule for element insertion that is ever true is to add "element, "
  75 2013-07-16T19:28:14  <ThomasWaldmann> don't do that in json, though
  76 2013-07-16T19:30:27  <ThomasWaldmann> the rule is esp. nice if there are long list element, so each is on a separate line, then you only need to add a line to add an element, not change one line and add one because of the comma (if there were no trailing comma at the last elem)
  77 2013-07-16T20:42:39  * sharky93 says gn
  78 2013-07-16T20:43:33  <dreimark> gn sharky93
  79 2013-07-16T20:49:29  <ThomasWaldmann> xiaq_: your diary is still much too empty. https://moinmo.in/CheerXiao/GSOC-2013-Diary
  80 2013-07-16T20:50:22  <ThomasWaldmann> spy_: https://moinmo.in/PavelSviderski/GSOC-2013-Diary not much better for you
  81 2013-07-16T20:53:34  <asingla> ThomasWaldmann: the constructor for Properties class is not called from anywhere yet .. It's there if someone wants to create it's instance in later period.
  82 2013-07-16T20:53:51  <dreimark> at least this weak after vacation in italy the data there should increase
  83 2013-07-16T20:55:07  <asingla> meta is the only argument the class needs.
  84 2013-07-16T20:56:27  <ThomasWaldmann> asingla: using a class that has a __init__ and not calling it is unclean
  85 2013-07-16T21:04:33  *** rciorba1 has joined #moin-dev
  86 2013-07-16T21:05:30  *** dave_largo has quit IRC
  87 2013-07-16T21:18:34  <dreimark> gn
  88 2013-07-16T21:27:11  <asingla> ThomasWaldmann: removed __init__  https://codereview.appspot.com/10869045/ rest is fine ?
  89 2013-07-16T21:42:10  <ThomasWaldmann> asingla: in case you just removed the init method: that means you rather want a mixin class
  90 2013-07-16T21:45:22  *** xjjk has quit IRC
  91 2013-07-16T21:48:13  <asingla> ThomasWaldmann: yes, the Properties class functions as a mixin class.
  92 2013-07-16T21:51:52  *** brunomartin has quit IRC
  93 2013-07-16T21:53:40  <asingla> ThomasWaldmann: so where is the problem ?
  94 2013-07-16T22:00:55  <ThomasWaldmann> if it is a mixin, name it like that?
  95 2013-07-16T22:06:24  <asingla> ThomasWaldmann: BaseProperties would work or PropertiesMixin? :D
  96 2013-07-16T22:24:50  *** rciorba2 has joined #moin-dev
  97 2013-07-16T22:27:05  *** rciorba1 has quit IRC
  98 2013-07-16T22:42:14  *** vpv has quit IRC
  99 2013-07-16T22:42:15  *** TheSheep has quit IRC
 100 2013-07-16T22:42:15  *** SteveMcIntyre has quit IRC
 101 2013-07-16T22:42:15  *** sharky93 has quit IRC
 102 2013-07-16T22:42:15  *** eSyr-ng has quit IRC
 103 2013-07-16T22:42:15  *** sunu has quit IRC
 104 2013-07-16T22:42:15  *** dreimark has quit IRC
 105 2013-07-16T22:42:15  *** waldi has quit IRC
 106 2013-07-16T22:42:15  *** ThomasAH has quit IRC
 107 2013-07-16T22:42:15  *** sharky93_ has quit IRC
 108 2013-07-16T22:42:17  *** rciorba has quit IRC
 109 2013-07-16T22:42:17  *** ronny has quit IRC
 110 2013-07-16T22:42:17  *** jek_ has quit IRC
 111 2013-07-16T22:44:40  *** sharky93_ has joined #moin-dev
 112 2013-07-16T22:44:40  *** ThomasAH has joined #moin-dev
 113 2013-07-16T22:44:40  *** waldi has joined #moin-dev
 114 2013-07-16T22:44:40  *** dreimark has joined #moin-dev
 115 2013-07-16T22:44:40  *** sunu has joined #moin-dev
 116 2013-07-16T22:44:40  *** eSyr-ng has joined #moin-dev
 117 2013-07-16T22:44:40  *** sharky93 has joined #moin-dev
 118 2013-07-16T22:44:40  *** SteveMcIntyre has joined #moin-dev
 119 2013-07-16T22:44:40  *** TheSheep has joined #moin-dev
 120 2013-07-16T22:44:40  *** rciorba has joined #moin-dev
 121 2013-07-16T22:44:40  *** ronny has joined #moin-dev
 122 2013-07-16T22:44:40  *** jek_ has joined #moin-dev
 123 2013-07-16T22:45:23  *** vpv has joined #moin-dev
 124 2013-07-16T22:53:00  *** brunomartin has joined #moin-dev
 125 2013-07-16T23:00:31  *** rciorba2 has quit IRC
 126 2013-07-16T23:06:09  *** brunomartin has quit IRC
 127 2013-07-16T23:29:07  *** xjjk has joined #moin-dev
 128