1 2013-07-07T00:01:35 <ThomasWaldmann> sharky93: i'll package it as xstatic tomorrow, so you can just require it
2 2013-07-07T00:03:25 <ThomasWaldmann> sharky93: check with TheSheep whether we can build upon foobar, modernized or a new-clean-from-scratch theme
3 2013-07-07T00:03:52 <ThomasWaldmann> in the end i'ld prefer only having 1 or 2 builtin themes (not 3 or more)
4 2013-07-07T01:28:52 *** TheSheep
5 2013-07-07T01:28:58 *** TheSheep
6 2013-07-07T06:38:44 *** TheSheep_
7 2013-07-07T06:39:22 *** SteveMcI1tyre
8 2013-07-07T06:43:46 *** TheSheep
9 2013-07-07T06:43:49 *** SteveMcIntyre
10 2013-07-07T06:59:13 *** TheSheep_
11 2013-07-07T06:59:20 *** TheSheep
12 2013-07-07T08:39:49 <sharky93> moin
13 2013-07-07T08:44:18 <TheSheep> ThomasWaldmann: http://p.yusukekamiyamane.com/
14 2013-07-07T08:58:40 <TheSheep> also http://fortawesome.github.io/Font-Awesome/
15 2013-07-07T09:00:23 <TheSheep> sharky93: can you do a pull from main on your fork of the repo?
16 2013-07-07T09:00:36 <TheSheep> sharky93: ThomasWaldmann added bootstrap to it
17 2013-07-07T09:01:29 <sharky93> TheSheep: sure!
18 2013-07-07T09:03:23 <sharky93> done
19 2013-07-07T09:26:41 *** ashutosh1461
20 2013-07-07T09:51:12 <ThomasWaldmann> can someone try devpi on windows platform?
21 2013-07-07T09:51:51 <ReimarBauer> moin
22 2013-07-07T09:55:27 <ThomasWaldmann> moin
23 2013-07-07T09:55:32 <ThomasWaldmann> meeting in 5mins
24 2013-07-07T09:57:13 <ReimarBauer> who all is here ?
25 2013-07-07T09:57:28 <ashutosh1461> present
26 2013-07-07T09:57:35 <ThomasWaldmann> TheSheep, dreimark and ThomasWaldmann sitting together at europython sprint
27 2013-07-07T09:58:15 *** ReimarBauer
28 2013-07-07T09:59:02 <sharky93> nice!
29 2013-07-07T09:59:47 <ThomasWaldmann> sharky93: TheSheep: are you prepared, can you begin?
30 2013-07-07T09:59:50 * xiaq is alive :)
31 2013-07-07T10:00:36 <ananasova> moin
32 2013-07-07T10:00:58 <ThomasWaldmann> ok, welcome to the weekly meeting.
33 2013-07-07T10:01:33 <ThomasWaldmann> waldi: are you there?
34 2013-07-07T10:02:14 <dreimark> spy_: where are you
35 2013-07-07T10:02:48 <ThomasWaldmann> xiaq: can you begin? eSyr are you there?
36 2013-07-07T10:03:35 <xiaq> LAST: preliminary TicketIndex implementation, packaged datatables with XStatic. BLOCKED: cr and pr are pending. also a bit busy last week. NEXT: finish TicketIndex
37 2013-07-07T10:04:04 <ThomasWaldmann> xiaq: did you talk to your mentor?
38 2013-07-07T10:04:55 <xiaq> ThomasWaldmann: ah, not yet
39 2013-07-07T10:05:53 <ThomasWaldmann> cdn is only at microsoft?
40 2013-07-07T10:06:12 <xiaq> yup, they got not other cdn's
41 2013-07-07T10:07:00 <ThomasWaldmann> ok, one can also serve locally if one doesn't like that. I can have a look at some cr/pr after returning to germany, rather busy here on other stuff.
42 2013-07-07T10:07:48 <ThomasWaldmann> btw, i added bootstrap to main repo (using an already existing xstatic package), so if you need something for UI, it might be in there.
43 2013-07-07T10:07:58 <ThomasWaldmann> (so, pull and merge main repo)
44 2013-07-07T10:08:06 <dreimark> and update env
45 2013-07-07T10:08:21 <xiaq> ThomasWaldmann: what about licensing?
46 2013-07-07T10:08:51 <ThomasWaldmann> we decided that it is likely no issue
47 2013-07-07T10:09:22 <ThomasWaldmann> it is a separate package, and practically noone will care anyway
48 2013-07-07T10:10:08 <ThomasWaldmann> also there is some chance that they adopt MIT license, so the slight issue might go away
49 2013-07-07T10:10:20 <xiaq> ah allright. referencing js and css resources is more akin to dynamic linking which gpl doesn't infest :)
50 2013-07-07T10:11:08 <TheSheep> even if it did, it's not gpl that we have problems with, it's apache2
51 2013-07-07T10:11:21 <TheSheep> and they don't infest anything
52 2013-07-07T10:11:47 <xiaq> oh... ok
53 2013-07-07T10:11:54 <dreimark> anything more ?
54 2013-07-07T10:12:31 <ThomasWaldmann> not from me, except that xiaq needs to catch up. but i am positive about that. :)
55 2013-07-07T10:12:41 * dreimark too
56 2013-07-07T10:13:22 <ThomasWaldmann> ok, spy_ next please
57 2013-07-07T10:13:40 <spy_> DONE: Simple listing of comments on the +show view (templates, macroses, unittest)
58 2013-07-07T10:13:46 <spy_> BLOCKERS: none
59 2013-07-07T10:13:56 <spy_> TODO: Implement a form to add a comment on the +show view, get familiar with bootstrap styles.
60 2013-07-07T10:15:50 <dreimark> ok, how far is the discussion with acls?
61 2013-07-07T10:16:03 <dreimark> spy_: ^
62 2013-07-07T10:16:15 <dreimark> s/with/about/
63 2013-07-07T10:16:23 <dreimark> for create, write etc?
64 2013-07-07T10:16:26 <ThomasWaldmann> (maybe we can have some wiki page with tipps/links for bootstrap and how to reuse its stuff instead of homegrown css)
65 2013-07-07T10:16:56 <spy_> sharky93: If I'm not mistaken you have already sent a link on how to use bootstrap+less (some best practice) or maybe not you
66 2013-07-07T10:17:27 <sharky93> spy_: im not too sure :)
67 2013-07-07T10:18:19 <spy_> dreimark: I'll write some notes on etherpad later
68 2013-07-07T10:18:39 <dreimark> ok
69 2013-07-07T10:18:48 <dreimark> anything else?
70 2013-07-07T10:18:54 <spy_> dreimark: we decided to use an acl_function for comments
71 2013-07-07T10:19:24 <dreimark> good :)
72 2013-07-07T10:19:28 <spy_> and an appropriate comments_acl meta property on each item
73 2013-07-07T10:19:54 <ThomasWaldmann> sharky93: ok, you're next
74 2013-07-07T10:20:00 <ThomasWaldmann> thanks spy_
75 2013-07-07T10:20:17 <ThomasWaldmann> (we had some direct discussions here at europython)
76 2013-07-07T10:21:06 <sharky93> this week we worked on the search functionality
77 2013-07-07T10:21:17 <sharky93> for ngrams, highlights, helping user if common words in query @ https://codereview.appspot.com/10971043/
78 2013-07-07T10:21:20 <sharky93> for ajax'ed search, works also with JS disabled. @ https://codereview.appspot.com/10935045/
79 2013-07-07T10:21:30 <sharky93> for suggestions @ https://codereview.appspot.com/10976043/
80 2013-07-07T10:21:40 <sharky93> Demo for simple ajax, @ http://www.youtube.com/watch?v=TE_N8CoEPeE ..
81 2013-07-07T10:21:47 <sharky93> this has been improved much, since i had working on different branches, have not merged the
82 2013-07-07T10:21:50 <sharky93> code for ajax and ngrams.
83 2013-07-07T10:22:07 <sharky93> since it has not been reviewed ..
84 2013-07-07T10:23:10 <ThomasWaldmann> maybe everybody should make sure to add links to all the open codereviews to the calendar entries
85 2013-07-07T10:23:37 <sharky93> this has been improved much, since i had working on different branches, have not merged the
86 2013-07-07T10:23:42 <sharky93> oops
87 2013-07-07T10:24:08 <sharky93> TODO: commit these stuff, and rest needs to be discussed.
88 2013-07-07T10:24:49 <ThomasWaldmann> some more usual way than displaying all the results in the full form (title, highlighted contents, etc) would be to offer all sorts of completions and suggestions in some dropdown sort of list
89 2013-07-07T10:25:21 <ThomasWaldmann> (esp. if the results would get rather long)
90 2013-07-07T10:25:54 <ThomasWaldmann> sharky93: are you familiar with bootstrap already?
91 2013-07-07T10:25:57 <sharky93> ThomasWaldmann: yes, dropdown is an option but since it involves the frontend, i skipped that part
92 2013-07-07T10:26:05 <dreimark> ok
93 2013-07-07T10:26:28 <ThomasWaldmann> waldi: are you there?
94 2013-07-07T10:26:39 <sharky93> ThomasWaldmann: not very much familiar. but i dont think it'll take too much time..
95 2013-07-07T10:26:48 <spy_> TheSheep: bootstrap+less: http://ruby.bvision.com/blog/please-stop-embedding-bootstrap-classes-in-your-html
96 2013-07-07T10:26:58 <ThomasWaldmann> sharky93: do much RTFM :)
97 2013-07-07T10:27:32 <ThomasWaldmann> ashutosh1461: please prepare (are you there?)
98 2013-07-07T10:27:37 <ashutosh1461> yes
99 2013-07-07T10:28:15 <ThomasWaldmann> sharky93: i'ld like a bit more detailled plan for next week
100 2013-07-07T10:28:35 <TheSheep> spy_: thanks!
101 2013-07-07T10:29:32 <ashutosh1461> E LAST WEEK:-
102 2013-07-07T10:29:32 <ashutosh1461> -> Updated cr subitems view :- https://codereview.appspot.com/10707048/
103 2013-07-07T10:29:32 <ashutosh1461> -> Work on validator(name/itemid validation, test added) https://codereview.appspot.com/10842043/
104 2013-07-07T10:29:32 <ashutosh1461> -> Updated existing fqname methods in protecting.py and indexing.py cr https://codereview.appspot.com/10869045/
105 2013-07-07T10:29:32 <ashutosh1461> -> Added support if the field is not unique like for ns1/@tags/name cr https://codereview.appspot.com/10915044/
106 2013-07-07T10:29:36 <ashutosh1461> -> Worked on displaying the links (as per discussion on etherpad with tw) same cr as above.
107 2013-07-07T10:29:38 <ashutosh1461> -> Added validator and fqname support to /+revert view. cr https://codereview.appspot.com/10973043/ (was necessary for the deleted view.)
108 2013-07-07T10:29:41 <ashutosh1461> BLOCKERS:-
109 2013-07-07T10:29:43 <ashutosh1461> DELETED view almost ready but need suggestions imagebin.org/index.php?mode=image&id=263658 (Undelete works, fullname on mouseover)
110 2013-07-07T10:29:46 <ashutosh1461> TODO:-
111 2013-07-07T10:29:48 <ashutosh1461> more planning on what to do next
112 2013-07-07T10:31:14 <ThomasWaldmann> ashutosh1461: when looking at the acl system, i've remembered it is all name based. we need a more generic approach there. iirc you didn't work on that yet, so that might be next week.
113 2013-07-07T10:33:05 <ashutosh1461> ThomasWaldmann, i have updated the acl functions, but there are some doubts, would be clear once cr review is done, yes next week :)
114 2013-07-07T10:33:21 <ThomasWaldmann> so not give name as positional arg, but **meta with key/value pairs
115 2013-07-07T10:34:00 <ashutosh1461> yes i added a function to the compositename class that does the task
116 2013-07-07T10:34:15 <ThomasWaldmann> i also did some review of validators together with jason kirtland here at EP, did some simplifications
117 2013-07-07T10:35:00 <ThomasWaldmann> any more questions to ashutosh1461? ananasova please prepare. waldi: try to be with us more often.
118 2013-07-07T10:35:53 <ashutosh1461> ThomasWaldmann, does this look fine ? imagebin.org/index.php?mode=image&id=263658
119 2013-07-07T10:36:41 <ThomasWaldmann> no. that is like a technical user / dev would do it.
120 2013-07-07T10:36:59 <ThomasWaldmann> but for normal people, the names are more interesting than the uuids.
121 2013-07-07T10:37:48 <ThomasWaldmann> also, why is the first saying @itemid/xxxx and all others just xxxxx?
122 2013-07-07T10:38:10 <ananasova> that's on hover i think
123 2013-07-07T10:38:17 <ashutosh1461> that is on mouse hover
124 2013-07-07T10:39:14 <ashutosh1461> wont the main header look odd if the names list is empty ?
125 2013-07-07T10:40:11 <ThomasWaldmann> it should rarely be empty.
126 2013-07-07T10:40:39 <ThomasWaldmann> (comment items won't have names, but we won't list them there, just the stuff with deleted=True metadata)
127 2013-07-07T10:41:10 <ThomasWaldmann> so you will find names in rev-1
128 2013-07-07T10:41:16 <ashutosh1461> fine then
129 2013-07-07T10:41:45 * dreimark htg, prepare to get to the airport
130 2013-07-07T10:42:10 <dreimark> bbl
131 2013-07-07T10:42:44 <ThomasWaldmann> ashutosh1461: maybe we need a undelete and a show link
132 2013-07-07T10:43:25 <ashutosh1461> show on name click ?
133 2013-07-07T10:45:45 <ThomasWaldmann> the itemid links to the latest rev of the item, not necessarily to the deleted rev
134 2013-07-07T10:46:31 <ThomasWaldmann> maybe like this:
135 2013-07-07T10:46:47 <ThomasWaldmann> <previous names> (most helpful) as title
136 2013-07-07T10:47:28 <ThomasWaldmann> [links to show / undelete of deleted rev] [some more info about deleted rev, same line]
137 2013-07-07T10:49:19 <ThomasWaldmann> ok, thanks ashutosh1461
138 2013-07-07T10:49:26 <ThomasWaldmann> ananasova: you're next :)
139 2013-07-07T10:49:46 <ananasova> DONE:
140 2013-07-07T10:49:46 <ananasova> * Determining subscribers by the subscription_patterns and the pattern validator - https://codereview.appspot.com/10871044/
141 2013-07-07T10:49:49 <ananasova> * Change of user subscription methods and getting rid of old methods and dependencies - https://codereview.appspot.com/10843043/
142 2013-07-07T10:49:52 <ananasova> * Some other old pending crs with updated patches
143 2013-07-07T10:49:57 <ananasova> TODO next week:
144 2013-07-07T10:49:57 <ananasova> * Finish with the following functionality, commit/push
145 2013-07-07T10:49:57 <ananasova> * Signals emitting on item modify, destroy
146 2013-07-07T10:49:57 <ananasova> * Prepare templates for notification mails
147 2013-07-07T10:51:18 <ThomasWaldmann> ananasova: you did collect subscriber's language already, right?
148 2013-07-07T10:51:33 <ananasova> yes
149 2013-07-07T10:51:55 <ananasova> it is in the Subscriber namedtuple
150 2013-07-07T10:52:03 <ThomasWaldmann> because you'll have to use THAT (not the current user's language when sending notifies)
151 2013-07-07T10:52:26 <ananasova> yeah, i remember that
152 2013-07-07T10:52:32 <ThomasWaldmann> (maybe research how to do that with flask-babel / babel)
153 2013-07-07T10:52:48 <ananasova> adding that to TODOs
154 2013-07-07T10:53:09 <ThomasWaldmann> (we already have/had some related code)
155 2013-07-07T10:53:58 <ananasova> i will take a look for sure
156 2013-07-07T10:54:12 <ThomasWaldmann> I'll have a look at your CR later. How was communication with waldi last week?
157 2013-07-07T10:54:59 <ananasova> a bit more verbose than usual. still many crs are pending
158 2013-07-07T10:55:24 <ThomasWaldmann> ok, maybe send him a reminder by email, just with urls TODO
159 2013-07-07T10:55:33 <ananasova> ok
160 2013-07-07T10:56:17 <ThomasWaldmann> any more questions about email related stuff?
161 2013-07-07T10:57:16 <ThomasWaldmann> ok, looks like we are through with the meeting. have fun. :)
162 2013-07-07T10:57:55 * ThomasWaldmann will fly back to germany tomorrow afternoon
163 2013-07-07T10:58:24 <sharky93> is the moin sprint done? :)
164 2013-07-07T11:09:32 <sharky93> TheSheep: ping
165 2013-07-07T11:25:35 <TheSheep> sharky93: pong
166 2013-07-07T11:33:09 <sharky93> TheSheep: how do we begin the work with bootstrap .. and how to go about pushing this weeks work?
167 2013-07-07T11:44:11 <TheSheep> sharky93: I will review your commits tomorrow
168 2013-07-07T11:44:34 <TheSheep> sharky93: as for bootstrap, I will start a new theme and make a pull request to your repository
169 2013-07-07T11:46:29 <sharky93> TheSheep: ok, btw about the search i've not made any commit yet, it's all on codereview.appspot
170 2013-07-07T11:46:55 <TheSheep> that's what I meant
171 2013-07-07T11:47:07 <TheSheep> I have a plane in an hour
172 2013-07-07T11:48:01 <sharky93> hmm ok
173 2013-07-07T11:52:49 <dreimark> re
174 2013-07-07T11:52:59 <dreimark> which one
175 2013-07-07T11:53:23 <dreimark> mine is delayed for 3h
176 2013-07-07T12:00:11 <TheSheep> munich
177 2013-07-07T12:00:39 <TheSheep> LH 9441
178 2013-07-07T12:05:42 *** ashutosh1461
179 2013-07-07T12:08:27 <dreimark> i cant find this on the board
180 2013-07-07T12:09:24 <dreimark> may be it isnt in the timeframe
181 2013-07-07T12:11:44 <TheSheep> yeah
182 2013-07-07T12:12:12 <TheSheep> at least you have internet while waiting :)
183 2013-07-07T12:18:12 <dreimark> and a seat with air condition
184 2013-07-07T12:59:29 <ThomasWaldmann> ananasova: dreimark: eSyr: sharky93: spy_: sunumonster: sunu: xiaq: creators of codereview items need to remember to CLOSE them when they are finished. It is filling up my inbound and sits there until closed (and as I am not the creator of them, I can't close them).
185 2013-07-07T13:00:05 <ThomasWaldmann> closing works using the (X) icon on the UI
186 2013-07-07T13:10:36 <ThomasWaldmann> https://bitbucket.org/thomaswaldmann/moin-2.0/pull-request/151/various-theme-tweaks-for-bootstrap-support/diff
187 2013-07-07T13:10:50 <ThomasWaldmann> can someone with a clue about bootstrap review this again? ^^
188 2013-07-07T13:11:22 <ThomasWaldmann> sharky93: TheSheep: maybe you also want to contact him
189 2013-07-07T13:58:21 <spy_> ThomasWaldmann: eta['new_test_key'] == update_meta['new_test_key'] 358 377 359 378
190 2013-07-07T13:58:27 <spy_> oh
191 2013-07-07T13:58:40 <spy_> ThomasWaldmann: https://codereview.appspot.com/10977044
192 2013-07-07T13:58:55 <spy_> please have a look when you have free time
193 2013-07-07T14:35:43 *** greg_f
194 2013-07-07T14:55:08 *** inducer
195 2013-07-07T14:55:28 <inducer> Hi, I'm Andreas, the guy with the bootstrap patch
196 2013-07-07T14:55:36 <inducer> I was briefly IRC-confused, sorry.
197 2013-07-07T14:55:37 <inducer> :)
198 2013-07-07T14:57:52 <ThomasWaldmann> ah, moin inducer :)
199 2013-07-07T14:59:48 <ThomasWaldmann> sharky93: ^^ TheSheep ^^ (thesheep likely being on a plane now, so expect delayed answer)
200 2013-07-07T15:04:21 <inducer> btw, any chance you guys might switch to git sometime soon?
201 2013-07-07T15:04:47 <inducer> hg is just different enough to cause me grief
202 2013-07-07T15:09:40 <inducer> (i'm just merging my theme tweaks branch)
203 2013-07-07T15:14:43 <inducer> ok, third attempt.
204 2013-07-07T15:22:23 <ananasova> inducer: one more vote for git :D
205 2013-07-07T15:31:00 <ThomasWaldmann> inducer: i like python stuff :)
206 2013-07-07T15:32:56 <ThomasWaldmann> (and git is giving me grief also, so the problem is somehow symetric :D )
207 2013-07-07T15:47:36 * sharky93 closes done codereviews :)
208 2013-07-07T15:47:41 <sharky93> moin inducer :)
209 2013-07-07T15:47:54 <inducer> moin
210 2013-07-07T15:49:45 <sharky93> ThomasWaldmann: the issues i close, will they be deleted automatically after some time?
211 2013-07-07T16:06:44 <inducer> ok, 'theme-tweaks-for-bootstrap' and 'moinboot' in https://bitbucket.org/inducer/moin-2.0/ are up-to-date wrt the latest upstream moin and working for me
212 2013-07-07T16:34:33 *** greg_f
213 2013-07-07T16:58:45 *** sharky93__
214 2013-07-07T17:02:02 <spy_> ThomasWaldmann: updated cr https://codereview.appspot.com/10761044/
215 2013-07-07T17:03:27 *** sharky93_
216 2013-07-07T19:34:36 <ronny> sup
217 2013-07-07T19:34:38 <ThomasWaldmann> re
